[edk2] [Patch] MdePkg: Update comments for DriverSupportedEfiVersion.FirmwareVersion

2015-04-27 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni CC: Liming Gao --- MdePkg/Include/Protocol/DriverSupportedEfiVersion.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Protocol/DriverSupportedEfiVersion.h b/MdePkg/Include/Pr

Re: [edk2] Review the code of modfying the PCD for gcc build

2015-04-27 Thread Wei, David
Hi Tim, This patch is good. Reviewed-by: David Wei Thanks, David | SSG BIOS From: He, Tim Sent: Tuesday, April 28, 2015 2:14 PM To: Guo, Mang; Wei, David; Lu, ShifeiX A; Wu, Mike; He, Tim Cc: edk2-devel@lists.sourceforge.net Subject: Review the code of modfying the PCD for gcc build Hi David

[edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.

2015-04-27 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Reviewed-by: Liming Gao --- MdePkg/Include/Uefi/UefiSpec.h | 42 ++ 1 file changed, 42 insertions(+) diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec

[edk2] Review the code of modfying the PCD for gcc build

2015-04-27 Thread He, Tim
Hi David, Could you please review this path which modified the PCD value as sync the flash layout change for gcc build? [Description] Modified the PCD value due to flash layout change. [HSD link] N/A [Test] Pass gcc build. Yocto boot fine. [SVN Commit Log] Due to flash layout change, modified

Re: [edk2] [PATCH 2/2] efinet: fix lost packets due to active MNP instances

2015-04-27 Thread Michael Chang
On Mon, Apr 27, 2015 at 02:47:16PM +0800, Michael Chang wrote: > On Sun, Apr 26, 2015 at 09:42:52AM +0300, Andrei Borzenkov wrote: > > В Tue, 21 Apr 2015 14:12:54 +0800 > > Michael Chang пишет: > > > > > > > > 3. Even I can add the card open earler before hadling the dhcpv6 > > > packets, it wil

[edk2] [Patch 0/2] MdePkg: Add URI_DEVICE_PATH.

2015-04-27 Thread Ruiyu Ni
The patch adds URI device path node definition and FromText/ToText support it. Ruiyu Ni (2): MdePkg: Add URI_DEVICE_PATH definition. MdePkg: Add ToText/FromText support for URI device path node MdePkg/Include/Protocol/DevicePath.h | 12 ++ MdePkg/Library/UefiDevicePathLi

[edk2] [Patch 2/2] MdePkg: Add ToText/FromText support for URI device path node

2015-04-27 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni CC: Feng Tian --- MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 35 +++- MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 42 +++- 2 files changed, 75 insertions(+), 2 del

[edk2] [Patch 1/2] MdePkg: Add URI_DEVICE_PATH definition.

2015-04-27 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni CC: Feng Tian --- MdePkg/Include/Protocol/DevicePath.h | 12 1 file changed, 12 insertions(+) diff --git a/MdePkg/Include/Protocol/DevicePath.h b/MdePkg/Include/Protocol/DevicePath.h index a27ea5d..9e5

Re: [edk2] [Patch V3 03/16] Nt32Pkg: Use the new PCDs defined in MdePkg and MdeModulePkg.

2015-04-27 Thread Qiu, Shumin
The patch is good to me. Reviewed-by: Qiu Shumin -Shumin -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch V3 03/16] Nt32Pkg: Use the new PCDs defined in MdePkg and MdeModulePkg. Con

[edk2] [EDK2] [Vlv2TbltDevicePkg] [MinnowBoard Max Platform] Review the code of changing address of FV MICROCODE

2015-04-27 Thread Wei, David
It looks good. Thanks. Reviewed-by: David Wei Thanks, David | SSG BIOS From: Guo, Mang Sent: Tuesday, April 28, 2015 9:52 AM To: Wei, David; He, Tim; Lu, ShifeiX A; Guo, Mang; Wu, Mike Subject: Review the code of changing address of FV MICROCODE Hi all, Could you please help review this pack

Re: [edk2] [PATCH 1/3] SecurityPkg: remove unused variables

2015-04-27 Thread Zhang, Chao B
Laszlo: It looks good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, April 27, 2015 7:08 PM To: edk2-devel@lists.sourceforge.net Cc: Zhang, Chao B Subject: Re: [edk2] [PATCH 1/3] Sec

Re: [edk2] [Patch V2 5/10] Add Quark SoC Compatibility: MdeModulePkg : BaseSerialPortLib16550

2015-04-27 Thread Tian, Feng
Good to me Reviewed-by: Feng Tian From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Monday, April 27, 2015 13:55 To: edk2-devel@lists.sourceforge.net; Justen, Jordan L Subject: [edk2] [Patch V2 5/10] Add Quark SoC Compatibility: MdeModulePkg : BaseSerialPortLib16550 Add stride

[edk2] [patch 1/2] MdePkg: Add UFS (Universal Flash Storage) device path definition

2015-04-27 Thread Feng Tian
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian Reviewed-by: Star Zeng --- MdePkg/Include/Ppi/BlockIo.h | 5 +++- MdePkg/Include/Protocol/DevicePath.h | 18 MdePkg/Include/Protocol/DiskInfo.h | 11

[edk2] [patch 0/2] Add UFS (Universal Flash Storage) support

2015-04-27 Thread Feng Tian
The patches add UFS related definitions and implement a UFS stack. Feng Tian (2): MdePkg: Add UFS (Universal Flash Storage) device path definition MdeModulePkg: Add UFS (Universal Flash Storage) Stack MdeModulePkg/Bus/Pci/UfsPciHcDxe/ComponentName.c | 225 +++ MdeModulePkg/Bus/Pci/UfsPciH

Re: [edk2] [PATCH] UEFI2.5 HASH2

2015-04-27 Thread Yao, Jiewen
Good suggestion. I agree both. I will update when I check in. -Original Message- From: Long, Qin [mailto:qin.l...@intel.com] Sent: Tuesday, April 28, 2015 9:52 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH] UEFI2.5 HASH2 The patch looks good to me. Could you add so

Re: [edk2] [PATCH] UEFI2.5 HASH2

2015-04-27 Thread Long, Qin
The patch looks good to me. Could you add some descriptions about EFI_HASH2_PROTOCOL in the Hash2.h? There are only some descriptions about EFI_HASH2_SERVICE_BINDING_PROTOCOL now. In the driver implementation: +#define HASH2_SERVICE_DATA_SIGNATURE SIGNATURE_32 ('H', 's', '2', 'S') I prefer to u

Re: [edk2] [PATCH] UEFI2.5 HASH2

2015-04-27 Thread Yao, Jiewen
Hi Many thanks to Long Qin, who found an error in EFI_HASH2_OUTPUT definition in Hash2.h. Here is new patch. Thank you Yao Jiewen -Original Message- From: Yao, Jiewen Sent: Monday, April 27, 2015 8:38 AM To: Justen, Jordan L; edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [PATCH]

Re: [edk2] [Patch V2 1/10] Add Quark SoC Compatibility: MdePkg : BaseCacheMaintenanceLib

2015-04-27 Thread Kinney, Michael D
Jordan, Thanks for the feedback and the review. I will fix the commit messages. Mike -Original Message- From: Justen, Jordan L Sent: Monday, April 27, 2015 11:38 AM To: Kinney, Michael D; edk2-devel@lists.sourceforge.net Subject: Re: [edk2][Patch V2 1/10] Add Quark SoC Compatibility: M

Re: [edk2] [Patch V2 1/10] Add Quark SoC Compatibility: MdePkg : BaseCacheMaintenanceLib

2015-04-27 Thread Jordan Justen
How about making the first commit message line be a bit more specific? == 01/10 == MdePkg/BaseCacheMaintenanceLib: Support IA32 processors without CLFLUSH == 02/10 == MdePkg/BaseLib: Support IA32 processors without CLFLUSH == 03/10 == MdePkg/BaseLib: Support IA32 processors without CMOVx etc...

Re: [edk2] [Patch 3/4] ShellPkg: Update Shell MemMap command to show PersistentMemory range

2015-04-27 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey -Original Message- From: Liming Gao [mailto:liming@intel.com] Sent: Monday, April 27, 2015 3:58 AM To: edk2-devel@lists.sourceforge.net Cc: liminggaoliming@intel.com Subject: [edk2] [Patch 3/4] ShellPkg: Update Shell MemMap command to show PersistentMem

Re: [edk2] [Patch V2 10/10] Add Quark SoC Compatibility: UefiCpuPkg : DebugAgentLib

2015-04-27 Thread Kinney, Michael D
Jeff, Thanks. I will fix the commit log. Mike From: Fan, Jeff [mailto:jeff@intel.com] Sent: Monday, April 27, 2015 12:32 AM To: edk2-devel@lists.sourceforge.net; Justen, Jordan L Subject: Re: [edk2] [Patch V2 10/10] Add Quark SoC Compatibility: UefiCpuPkg : DebugAgentLib One typo in commi

Re: [edk2] KVM Forum 2015 Call for Participation

2015-04-27 Thread Paolo Bonzini
A friendly reminder that KVM Forum 2015 accepts proposal submissions until next Friday. Thanks on behalf of the KVM Forum 2015 Program Committee. Paolo On 11/03/2015 18:55, Paolo Bonzini wrote: > = > KVM Forum 2015: Call For Partici

[edk2] [PATCH] IntelFpsPkg BaseCacheLib clean up SetPower2

2015-04-27 Thread Yao, Jiewen
Commit message: IntelFpsPkg BaseCacheLib clean up SetPower2. Replace SetPower2 by GetPowerOfTwo64() in base lib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: “Yao, Jiewen” Thank you Yao Jiewen CacheLib.c.patch Description: CacheLib.c.patch -

Re: [edk2] [PATCH 3/3] ArmVirtualizationPkg: enable secure boot for ArmVirtualizationQemu

2015-04-27 Thread Laszlo Ersek
On 04/23/15 14:52, Ard Biesheuvel wrote: > Signed-off-by: Ard Biesheuvel > --- > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualization.dsc.inc | 27 > ++ > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 29 > +++- > ArmPlatformPkg/ArmVirtualizati

Re: [edk2] [PATCH 2/3] ArmPlatformPkg: enable use of authenticated variables in NorFlashDxe

2015-04-27 Thread Laszlo Ersek
On 04/23/15 14:52, Ard Biesheuvel wrote: > The NorFlashDxe uses an explicit 'BEFORE xxx' Depex declaration to > ensure that it is invoked before VariableRuntimeDxe, and uses the > GUID of the latter as 'xxx' explicitly to accomplish that. > > However, when enabling UEFI Secure Boot, this breaks do

Re: [edk2] [PATCH 1/3] SecurityPkg: remove unused variables

2015-04-27 Thread Laszlo Ersek
On 04/23/15 14:52, Ard Biesheuvel wrote: > This removes various unused variables from SecurityPkg whose presence > is causing failed builds. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > SecurityPkg/VariableAuthenticated/RuntimeDxe/AuthServic

[edk2] [Patch 3/4] ShellPkg: Update Shell MemMap command to show PersistentMemory range

2015-04-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com Reviewed-by: Star Zeng Signed-off-by: Liming Gao --- ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ShellPkg/Library/UefiShellDeb

[edk2] [Patch 1/4] MdePkg: Add UEFI2.5 and PI1.4 PersistentMemory definition

2015-04-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com Reviewed-by: Star Zeng Signed-off-by: Liming Gao --- MdePkg/Include/Pi/PiDxeCis.h | 9 +++-- MdePkg/Include/Pi/PiHob.h| 4 +++- MdePkg/Include/Uefi/UefiMultiPhase.h | 7

[edk2] [Patch 4/4] IntelFrameworkModulePkg: Add UEFI2.5 PersistentMemory support in LegacyBios

2015-04-27 Thread Liming Gao
LegacyBiosDxe converts EfiPersistentMemory to E820 EfiAddressRangePersistentMemory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com Reviewed-by: Star Zeng Signed-off-by: Liming Gao --- IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBiosIn

[edk2] [Patch 2/4] MdeModulePkg: Add support for UEFI2.5 and PI1.4 PersistentMemory feature

2015-04-27 Thread Liming Gao
Update DxeCore to collect PersistentMemory resource and report them in EFI memory map. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao liming@intel.com Reviewed-by: Star Zeng Signed-off-by: Liming Gao --- .../MemoryProfileInfo/MemoryProfileInfo.c |

[edk2] [Patch 0/4] Add support for UEFI2.5 and PI1.4 PersistentMemory feature

2015-04-27 Thread Liming Gao
Update DxeCore to collect PersistentMemory resource and report them in EFI memory map. Update Shell MemMap command to show PersistentMemory range. Update LegacyBiosDxe to convert EfiPersistentMemory to E820 EfiAddressRangePersistentMemory. Liming Gao (4): MdePkg: Add UEFI2.5 and PI1.4 Persiste

[edk2] [Patch] MdeModulePkg: PI1.4 DxeCore GetMemoryMap() update

2015-04-27 Thread Liming Gao
PI1.4: Updates DxeCore to add all EfiGcdMemoryTypeReserved memory into UEFI memory map. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Star Zeng --- MdeModulePkg/Core/Dxe/Mem/Page.c | 63 +++- 1 file changed, 30

Re: [edk2] Proposal: can we create a new mailing list (e.g.: edk2-pa...@lists.sourceforge.net) for patch review?

2015-04-27 Thread Laszlo Ersek
On 04/27/15 09:32, Ni, Ruiyu wrote: > Jordan, > Can you point me how to group git patch mails in a single thread in > outlook? > My outlook shows mail in thread-view, I didn't expect that -- it's great though that Outlook can finally do this! > but git patch mails are still in one-by-one style, n

Re: [edk2] [Patch V2 00/15] Add pure UEFI Boot Manager

2015-04-27 Thread Ni, Ruiyu
Laszlo, V3 patches were posted to edk2-devel. Sure I will create additional branch for new version of patch in future. Thanks, Ray -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, April 27, 2015 4:17 PM To: Ni, Ruiyu Cc: edk2-devel list; Ard Biesheuvel Subj

Re: [edk2] [Patch V2 00/15] Add pure UEFI Boot Manager

2015-04-27 Thread Laszlo Ersek
On 04/25/15 03:43, Ni, Ruiyu wrote: > Laszlo, > Thanks for your detailed educations:) > For your suggestion (6), can you check this url > (https://github.com/niruiyu/edk2/compare/master...niruiyu:new_bds)? Is this > what you want me to do? > What I did is to firstly fork a edk2 in my personal git

Re: [edk2] [PATCH] MdePkg: Add header files to support graphics in PEI.

2015-04-27 Thread Wu, Hao A
Got it. I will update the subject and log message when committing. -Original Message- From: Justen, Jordan L Sent: Monday, April 27, 2015 3:22 PM To: edk2-devel@lists.sourceforge.net; Wu, Hao A Subject: Re: [edk2] [PATCH] MdePkg: Add header files to support graphics in PEI. For the subje

Re: [edk2] [Patch V2 10/10] Add Quark SoC Compatibility: UefiCpuPkg : DebugAgentLib

2015-04-27 Thread Fan, Jeff
One typo in commit log: UefiCpuPkg : DebugAgentLib => UefiCpuPkg : CpuExceptionHandlerLib Reviewed-by: Jeff Fan From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Monday, April 27, 2015 1:55 PM To: edk2-devel@lists.sourceforge.net; Justen, Jordan L Subject: [edk2] [Patch V2 10/10

Re: [edk2] Proposal: can we create a new mailing list (e.g.: edk2-pa...@lists.sourceforge.net) for patch review?

2015-04-27 Thread Ni, Ruiyu
Jordan, Can you point me how to group git patch mails in a single thread in outlook? My outlook shows mail in thread-view, but git patch mails are still in one-by-one style, not grouped. Thanks, Ray -Original Message- From: Justen, Jordan L Sent: Monday, April 27, 2015 2:55 PM To: edk2-

Re: [edk2] [PATCH] MdePkg: Add header files to support graphics in PEI.

2015-04-27 Thread Jordan Justen
For the subject, what about this? MdePkg: Add PI 1.4 Graphics HOB and PPI header files In the PPI header file, I wondered about including a DXE phase Protocol include file, but I guess it has been done previously. MdeModulePkg/Include/Ppi/Usb2HostController.h:#include MdeModulePkg/Include/Ppi/U