Thanks, Baranee
I double checked code flow.
When there is transaction error, the Urb->EvtTrb would not be updated and is
NULL (see line 1165 of last revision in EDKII trunk XhciSched.c). Then
XhcCmdTransfer() may return EFI_SUCCESS with EvtTrb == NULL. So I think it may
bring exception at Xhc
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Star Zeng
---
MdeModulePkg/Universal/PCD/Dxe/Service.c | 8 +---
MdeModulePkg/Universal/PCD/Pei/Service.c | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Star Zeng
---
MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCo
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin
Reviewed-by: Star Zeng
---
MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryP
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
ZeroGuid defined in
\Compatibility\PiSmbiosRecordOnDataHubSmbiosRecordThunk is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
gZeroGuid defined in Compatibility/FrameworkHiiOnUefiHiiThunk is
redundent.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
.../FrameworkH
mZeroGuid is defined but not used in IpSecDxe. All the header files in
IpSecDxe which expose mZeroGuid are not included externally as well.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
NetworkPkg/IpSecDxe/Ik
MdeModulePkg has defined gZeroGuid in Include/Guid/ZeroGuid.h, therefore,
the ZeroGuid/gZeroGuid/mZeroGuid/mTrEEZeroGuid defined in current code is
redundent.
Hao Wu (9):
IntelFrameworkModulePkg: Remove gZeroGuid definition in DataHubDxe
MdeModulePkg: Remove gZeroGuid definition in SetupBrowse
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
gZeroGuid defined in DataHubDxe is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
IntelFrameworkModulePkg/Universal/DataHubDxe
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
mTrEEZeroGuid defined in DxeTpm2MeasureBootLib is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
SecurityPkg/Library/DxeTpm2Me
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
gZeroGuid defined in SetupBrowserDxe is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
MdeModulePkg/Universal/SetupBrowserDxe/
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
mZeroGuid defined in DxeTpmMeasureBootLib is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
SecurityPkg/Library/DxeTpmMeasureB
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
mZeroGuid defined in Universal/Variable/RuntimeDxe is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
MdeModulePkg/Universal/Va
MdeModulePkg has defined gZeroGuid in 'Guid/ZeroGuid.h', therefore, the
mZeroGuid defined in VariableAuthenticated/RuntimeDxe is redundant.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
SecurityPkg/VariableAu
Hello Yang and all,
Could you help review this patch? Thank you
[Description]
Fix a bug when checking copyright format
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hess Chen mailto:hesheng.c...@intel.com>
>
Best Regards,
Chen, Hess
Intel China Software Center
Tel: +86
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jaben Carsey
---
UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
b/UefiCpuPkg/U
CHAR16 array mGaugeString[DP_GAUGE_STRING_LENGTH + 1] is pass into
function GetShortPdbFileName(). However, in this function it treats the
size of the input buffer as DXE_PERFORMANCE_STRING_SIZE.
Though DXE_PERFORMANCE_STRING_SIZE is smaller than DP_GAUGE_STRING_LENGTH
now, but this manner might i
Yes, you are right. I forget removing these from AtaBus driver.
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Friday, June 26, 2015 13:16
To: edk2-devel@lists.sourceforge.net; Yao, Jiewen
Subject: Re: [edk2] [patch 0/2] Do TPer Reset for all encrypted drives
Also
The first patch is to use safe string functions in Dp_App.
The second patch is to resolve a buffer size mismatch problem in
DpUtilities.c.
Details are available in the log message in each commit.
Hao Wu (2):
PerformancePkg Dp_App: Use safe string functions
PerformancePkg Dp_App: Resolve buffe
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jaben Carsey
---
PerformancePkg/Dp_App/DpUtilities.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/PerformancePkg/Dp_App/DpUtilities.c
b/PerformancePkg/D
Also need to remove #include from AtaBus.h and
gEfiMemoryOverwriteControlDataGuid from AtaBusDxe.inf?
Others are good to me.
Thanks,
Star
-Original Message-
From: Tian Feng [mailto:feng.t...@intel.com]
Sent: Thursday, June 25, 2015 12:01 PM
To: zeng.s...@intel.com; Yao, Jiewen
Cc: edk2
Jordan,
Simply using PCD to split the code is very straightforward. Another approach is
to introduce a new library class with carefully defined library APIs so that
different platforms can use one common driver plus different instances of
libraries.
After all, abstracting is never a easy work.
S
Changes between PATCH v1:
1. Replace Buf = AllocateZeroPool (size) followed by Strcpy (Buf, Source)
with Buf = AllocateCopyPool (size, Source)
2. Replace unnecessary usage of StrnCpyS/CatS with StrCpyS/CatS
3. The CopyMem() usage in file DevicePathFromText.c for the first patch is
a mistake.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLibPrint.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/IntelFrameworkPkg/Library/Fra
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
MdePkg/Library/UefiLib/Console.c | 6 +++---
MdePkg/Library/UefiLib/UefiLibPrint.c | 8 ++--
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Liming Gao
Reviewed-by: Jaben Carsey
---
MdePkg/Library/UefiDevicePathLib/DevicePathFromText.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Library/UefiDev
Scott,
Thanks your detailed explain and analysis.
Jeff
-Original Message-
From: Scott Duplichan [mailto:sc...@notabs.org]
Sent: Friday, June 26, 2015 12:05 AM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch] SourceLevelDebugPkg/DebugAgent: Add typecast to fix
sign exten
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c | 8
IntelFrameworkModulePkg/Universal/BdsDxe/MemoryTest.c | 6 +++---
2 files changed, 7 insertions(+
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c| 14 +-
.../Library/GenericBdsLib/Performance.c| 10 +-
2 files c
Changes between PATCH v1:
1. Replace Buf = AllocateZeroPool (size) followed by Strcpy (Buf, Source)
with Buf = AllocateCopyPool (size, Source)
2. Replace unnecessary usage of StrnCpyS/CatS with StrCpyS/CatS
3. Correct pointer calculation mistakes in original PATCH 5/8, file
BdsDxe/BootMaint/B
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
.../Universal/FirmwareVolume/UpdateDriverDxe/ParseUpdateProfile.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
a/IntelFrameworkModulePk
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
.../Universal/BdsDxe/BootMaint/BootOption.c| 31 +++---
.../Universal/BdsDxe/BootMaint/FormGuid.h | 16 +++
.../Universal/Bd
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
IntelFrameworkModulePkg/Bus/Isa/IsaFloppyDxe/ComponentName.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/IntelFrameworkModulePkg/Bus/Isa/
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
.../Universal/BdsDxe/BootMngr/BootManager.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/IntelFrameworkModulePkg
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
.../Library/PeiDxeDebugLibReportStatusCode/DebugLib.c| 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
a/IntelFrameworkModulePkg
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
Reviewed-by: Jeff Fan
Reviewed-by: Jaben Carsey
---
.../Universal/BdsDxe/DeviceMngr/DeviceManager.c| 25 +++---
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git
a/IntelFrameworkModule
Please check if there is any error message printed during the build. If build
success, there should be a 8MB image created under
"C:\MyWorkspace\Vlv2TbltDevicePkg\Stitch\".
Thanks,
David | SSG BIOS
From: Ulysses Mckibbens [mailto:zergrusher2...@gmail.com]
Sent: Friday, June 26, 2015 8:17 AM
T
Good point, I am ok to update the package version. About package GUID, I never
saw it has been changed since the package been created, I will leave it as is.
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, June 26, 2015 1:48 AM
To: edk2-devel@lists.s
Ard,
Thanks for your confirmation on ArmVirtQemu(I did not do it as I have no the
environment, the result makes me more confident about the quality of patchset)
and your answer to Laszlo.
Laszlo,
Answer your question below.
> Okay -- so this means that the merged variable driver does not
> *
Hi,
I followed the build instructions for a 0.79 debug build using the make
scripts in following sections 2 and 3 of this document:
http://firmware.intel.com/sites/default/files/MinnowBoard_MAX-Rel_0.79-ReleaseNotes.txt
It creates a 3MB image in the Vlv2TblDevicePkg\Stitch subdirectory. The
flash
Jordan, Ray,
On 06/25/15 19:14, Jordan Justen wrote:
> On 2015-06-24 19:10:01, Ni, Ruiyu wrote:
>> Jordan,
>> I prefer to share the code across multiple platforms as well, if
>> that's possible.
>>
>> In real world, DUET's PciHostBridgeDxe driver does something
>> additionally: it gathers all opti
On 06/25/15 18:19, Yao, Jiewen wrote:
> Hi Ersek
> That is just my thought, and I have no solid time frame at this moment, to be
> honest.
> If you have time to do the cleanup, please just go ahead.
> I appreciate your help on that, and I will be happy to review your code
> change.
Okay, I'll ad
> -Original Message-
> From: Tian, Feng [mailto:feng.t...@intel.com]
> Sent: Wednesday, June 24, 2015 11:02 PM
> To: Anbazhagan, Baraneedharan; Eric Wittmayer;
> edk2-devel@lists.sourceforge.net
> Cc: Tian, Feng
> Subject: RE: [edk2] XHCI question
>
> Hi, Baranee
>
> Which case do you th
Since removing a module is non-backwards compatible change to the package,
shouldn't you change the package GUID (and the version)?
-Jaben
> -Original Message-
> From: Star Zeng [mailto:star.z...@intel.com]
> Sent: Thursday, June 25, 2015 2:46 AM
> To: edk2-devel@lists.sourceforge.net
>
Hi Ersek
That is just my thought, and I have no solid time frame at this moment, to be
honest.
If you have time to do the cleanup, please just go ahead.
I appreciate your help on that, and I will be happy to review your code change.
I am sorry that I did not realize that OVMF has a its own AcpiS3
Jeff Fan [mailto:jeff@intel.com] wrote:
]Sent: Thursday, June 25, 2015 02:59 AM
]To: edk2-devel@lists.sourceforge.net
]Subject: [edk2] [Patch] SourceLevelDebugPkg/DebugAgent: Add typecast to fix
sign extension
]
]OffsetHigh is 16bit value and its type is UINT32 and defined in structure.
]If i
Jiewen,
On 06/25/15 10:35, Yao, Jiewen wrote:
> And in the future, I believe we could remove
> EFI_ACPI_S3_SAVE_PROTOCOL protocol completely. (This is Framework 0.9
> defined API, not PI defined API)
>
> The better design might be:
> 1) AcpiS3Save does not install EFI_ACPI_S3_SAVE_PROTOCOL.
> 2)
On 25 June 2015 at 16:29, Laszlo Ersek wrote:
> On 06/25/15 14:59, Zeng, Star wrote:
>> Ard & Laszlo,
>>
>> Variable store header is initialized by platform dsc, the merged
>> variable driver will AUTOMATICALLY compare EFI_VARIABLE_GUID/
>> EFI_AUTHENTICATED_VARIABLE_GUID against
>> VARIABLE_STORE
On 25 June 2015 at 16:33, Laszlo Ersek wrote:
> On 06/25/15 15:10, Ard Biesheuvel wrote:
>> On 25 June 2015 at 14:16, Laszlo Ersek wrote:
>
>>> Looks good, but you're going to hate me nonetheless. Because, our
>>> exchange has been too quick, and my thoughts about addressing the same
>>> in OvmfP
On 06/25/15 15:10, Ard Biesheuvel wrote:
> On 25 June 2015 at 14:16, Laszlo Ersek wrote:
>> Looks good, but you're going to hate me nonetheless. Because, our
>> exchange has been too quick, and my thoughts about addressing the same
>> in OvmfPkg had not matured enough until I posted my v1 review.
On 06/25/15 14:59, Zeng, Star wrote:
> Ard & Laszlo,
>
> Variable store header is initialized by platform dsc, the merged
> variable driver will AUTOMATICALLY compare EFI_VARIABLE_GUID/
> EFI_AUTHENTICATED_VARIABLE_GUID against
> VARIABLE_STORE_HEADER.Signature to know the format of variable
> (VA
NorFlashDxe.inf and NorFlashAuthenticatedDxe.inf may still need to be there as
NorFlashDxe.inf includes NorFlashVariableDep.c to use gEfiVariableGuid to
initialize variable store header and NorFlashAuthenticatedDxe.inf includes
NorFlashAuthenticatedVariableDep.c to use EfiAuthenticatedVariableGu
On 25 June 2015 at 14:16, Laszlo Ersek wrote:
> On 06/25/15 13:00, Ard Biesheuvel wrote:
>> Currently, the ArmVirtPkg platforms built with the Intel BDS fail
>> to signal the end-of-DXE event 'gEfiEndOfDxeEventGroupGuid' when
>> entering the BDS phase, which results in some loss of functionality,
Ard & Laszlo,
Variable store header is initialized by platform dsc, the merged variable
driver will AUTOMATICALLY compare EFI_VARIABLE_GUID/
EFI_AUTHENTICATED_VARIABLE_GUID against VARIABLE_STORE_HEADER.Signature to know
the format of variable (VARIABLE_HEADER or AUTHENTICATED_VARIABLE_HEADER(I
HI Ard
Sorry for the confusing.
I mean, there is no need to guarantee the order of "1) call AcpiS3->S3Save(),
then 2) signal EndOfDxe". The only order requirement is "EndOfDxe before
SmmReadyToLock"
When I wrote this white paper, I just mean we need this those thing based on
current design in
Looks good. Thanks!
Reviewed-by: Yao, Jiewen
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, June 25, 2015 5:22 PM
To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Yao, Jiewen; Fan, Jeff
Cc: Ard Biesheuvel
Subject: [PATCH] IntelFramewo
On 06/25/15 13:00, Ard Biesheuvel wrote:
> Currently, the ArmVirtPkg platforms built with the Intel BDS fail
> to signal the end-of-DXE event 'gEfiEndOfDxeEventGroupGuid' when
> entering the BDS phase, which results in some loss of functionality,
> i.e., variable reclaim in the VariableDxe drivers,
On 25 June 2015 at 13:15, Laszlo Ersek wrote:
> On 06/25/15 11:46, Star Zeng wrote:
>> For your easy review,
>> the forked code is at g...@github.com:lzeng14/edk2.git branch
>> SeparateAuthVariableService.
>>
>> What to do:
>> 1. Move TpmMeasurementLib LibraryClass from SecurityPkg to MdeModulePk
On 06/24/15 22:58, Carsey, Jaben wrote:
>
>
>> -Original Message-
>> From: Roy Franz [mailto:roy.fr...@linaro.org]
>> Sent: Wednesday, June 24, 2015 12:52 PM
>> To: Kinney, Michael D
>> Cc: edk2-devel@lists.sourceforge.net
>> Subject: Re: [edk2] [PATCH] MdePkg: Describe submission of a pa
On 25 June 2015 at 11:46, Star Zeng wrote:
> For your easy review,
> the forked code is at g...@github.com:lzeng14/edk2.git branch
> SeparateAuthVariableService.
>
Hello Star,
This series looks like an improvement, and thanks for making it
available via GitHub, that is very helpful.
I do have
On 06/25/15 11:46, Star Zeng wrote:
> For your easy review,
> the forked code is at g...@github.com:lzeng14/edk2.git branch
> SeparateAuthVariableService.
>
> What to do:
> 1. Move TpmMeasurementLib LibraryClass from SecurityPkg to MdeModulePkg.
> 2. Implement a NULL TpmMeasurementLib library ins
Currently, the ArmVirtPkg platforms built with the Intel BDS fail
to signal the end-of-DXE event 'gEfiEndOfDxeEventGroupGuid' when
entering the BDS phase, which results in some loss of functionality,
i.e., variable reclaim in the VariableDxe drivers, and the splitting
of the memory regions that is
On 06/25/15 12:34, Laszlo Ersek wrote:
> On 06/25/15 11:22, Ard Biesheuvel wrote:
>> The AcpiS3->S3Save() call needs to occur before the end-of-DXE event
>> is signalled. The end-of-DXE event needs to be signalled prior to
>> invoking any UEFI drivers, applications, or connecting consoles.
>>
>> Th
On 25 June 2015 at 12:32, Laszlo Ersek wrote:
> comments below
>
> On 06/25/15 10:19, Ard Biesheuvel wrote:
>> Currently, the ArmVirtPkg platforms built with the Intel BDS fail
>> to signal the end-of-DXE event 'gEfiEndOfDxeEventGroupGuid' when
>> entering the BDS phase, which results in some loss
On 06/25/15 12:34, Laszlo Ersek wrote:
> (If this patch is deemed correct by the IntelFrameworkModulePkg
> maintainers, then adopting OVMF is the right thing to do.)
Adapting, not adopting.
--
Monitor 25 network devices
On 06/25/15 11:22, Ard Biesheuvel wrote:
> The AcpiS3->S3Save() call needs to occur before the end-of-DXE event
> is signalled. The end-of-DXE event needs to be signalled prior to
> invoking any UEFI drivers, applications, or connecting consoles.
>
> This means the call to S3Save() that occurs in
comments below
On 06/25/15 10:19, Ard Biesheuvel wrote:
> Currently, the ArmVirtPkg platforms built with the Intel BDS fail
> to signal the end-of-DXE event 'gEfiEndOfDxeEventGroupGuid' when
> entering the BDS phase, which results in some loss of functionality,
> i.e., variable reclaim in the Vari
On 25 June 2015 at 12:23, Laszlo Ersek wrote:
> On 06/25/15 10:27, Ard Biesheuvel wrote:
>> On 25 June 2015 at 10:08, Ard Biesheuvel wrote:
>>> On 25 June 2015 at 09:58, Laszlo Ersek wrote:
On 06/25/15 01:31, Yao, Jiewen wrote:
> Hi Ard
> You are right that END_OF_DXE must be signal
On 06/25/15 10:27, Ard Biesheuvel wrote:
> On 25 June 2015 at 10:08, Ard Biesheuvel wrote:
>> On 25 June 2015 at 09:58, Laszlo Ersek wrote:
>>> On 06/25/15 01:31, Yao, Jiewen wrote:
Hi Ard
You are right that END_OF_DXE must be signal in Bds.
My thought is that this event shoul
On 06/25/15 10:44, Ni, Ruiyu wrote:
> Laszlo/Jordan,
> It seems to generalize the code is not very much possible, or at
> least not an easy task. How about we do the things in multiple steps?
> So it won't block your current work.
> 1. Duplicate the PciHostBridgeDxe in OvmfPkg and add these speci
What to do:
1. Implement AuthVariableLib library instance.
Why to do:
1. Share code.
Separate auth variable service from Auth Variable driver in
SecurityPkg to AuthVariableLib. Then the AuthVariableLib could benefit
and be used by different implementation of Auth Variable drivers.
Contributed-und
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Jiewen Yao
Reviewed-by: Liming Gao
---
MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MdeModulePkg/Universal/Pl
with AUTHENTICATED_VARIABLE_HEADER.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
.../EsalVariableDxeSal/AuthService.c | 42 ++--
.../EsalVariableDxeSal/Variable.c | 220 ++---
.../EsalVariable
What to do:
1. Delete VariablePei in SecurityPkg after it merged to VariablePei in
MdeModulePkg.
Why to do:
1. Remove code duplication and reduce maintenance effort.
The code logic of VariablePei in SecurityPkg is same with VariablePei
in MdeModulePkg.
Contributed-under: TianoCore Contribution A
Link AuthVariableLib and DxeTpmMeasurementLib in SecurityPkg
when SECURE_BOOT_ENABLE = TRUE.
Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg
when SECURE_BOOT_ENABLE = FALSE.
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Ze
Link AuthVariableLib and DxeTpmMeasurementLib in SecurityPkg
when SECURE_BOOT_ENABLE = TRUE.
Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg
when SECURE_BOOT_ENABLE = FALSE.
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
Nt32
Link AuthVariableLib and DxeTpmMeasurementLib in SecurityPkg
when SECURE_BOOT_ENABLE = TRUE.
Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg
when SECURE_BOOT_ENABLE = FALSE.
Cc: Jordan Justen
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-b
What to do:
1. Move authenticated variable definition from AuthenticatedVariableFormat.h
to VariableFormat.h with gEfiAuthenticatedVariableGuid and
AUTHENTICATED_VARIABLE_HEADER.
Why to do:
1. Share code.
We are moving forward to separate auth variable service from Auth Variable
driver in Security
What to do:
1. Add AuthVariableLib LibraryClass definitions.
2. Implement a NULL AuthVariableLib library instance.
3. Add VARIABLE_ENTRY_PROPERTY definition to VarCheck.h.
4. Add VARIABLE_ENTRY_CONSISTENCY and variable attribute
combinations definitions to VariableFormat.h.
Why to do:
1. Share cod
Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg.
Remove gVariableAuthenticatedRuntimeDxeFileGuid definition in
ArmPlatformPkg.dec and use gVariableRuntimeDxeFileGuid in
NorFlashAuthenticatedDxe.inf as auth Variable driver in SecurityPkg
and Variable driver in MdeModulePkg have be
Link AuthVariableLib and DxeTpmMeasurementLib in SecurityPkg
when SECURE_BOOT_ENABLE = TRUE.
Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg
when SECURE_BOOT_ENABLE = FALSE.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-
What to do:
1. Move authenticated variable definition from AuthenticatedVariableFormat.h
to VariableFormat.h with gEfiAuthenticatedVariableGuid and
AUTHENTICATED_VARIABLE_HEADER.
Why to do:
1. Share code.
We are moving forward to separate auth variable service from Auth Variable
driver in Security
What to do:
1. Move TpmMeasurementLib LibraryClass from SecurityPkg to MdeModulePkg.
2. Implement a NULL TpmMeasurementLib library instance.
Why to do:
1. Share code.
We are moving forward to separate auth variable service from Auth Variable
driver in SecurityPkg to AuthVariableLib. Then the AuthV
Link AuthVariableLibNull and TpmMeasurementLibNull in MdeModulePkg.
Cc: Jordan Justen
Cc: Andrew Fish
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
EmulatorPkg/EmulatorPkg.dsc | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Emu
What to do:
1. Merge from VariablePei in SecurityPkg to VariablePei in MdeModulePkg.
Why to do:
1. Remove code duplication and reduce maintenance effort.
The code logic of VariablePei in SecurityPkg is same with VariablePei
in MdeModulePkg.
Contributed-under: TianoCore Contribution Agreement 1.0
What to do:
1. Delete VariableInfo in SecurityPkg after it merged to VariableInfo in
MdeModulePkg.
Why to do:
1. Remove code duplication and reduce maintenance effort.
The functionality of VariableInfo in SecurityPkg has covered VariableInfo
in MdeModulePkg.
Contributed-under: TianoCore Contribu
For your easy review,
the forked code is at g...@github.com:lzeng14/edk2.git branch
SeparateAuthVariableService.
What to do:
1. Move TpmMeasurementLib LibraryClass from SecurityPkg to MdeModulePkg.
2. Implement a NULL TpmMeasurementLib library instance in MdeModulePkg.
3. Move authenticated varia
What to do:
1. Merge VariableInfo in SecurityPkg to VariableInfo in MdeModulePkg.
Why to do:
1. Remove code duplication and reduce maintenance effort.
The functionality of VariableInfo in SecurityPkg has covered VariableInfo
in MdeModulePkg.
Contributed-under: TianoCore Contribution Agreement 1.0
What to do:
1. Move TpmMeasurementLib LibraryClass from SecurityPkg to MdeModulePkg.
2. Update DxeTpmMeasurementLib.inf to include MdeModulePkg.dec.
Why to do:
1. Share code.
We are moving forward to separate auth variable service from Auth Variable
driver in SecurityPkg to AuthVariableLib. Then t
Reviewed-by: Star Zeng
-Original Message-
From: Qiu, Shumin
Sent: Thursday, June 25, 2015 3:47 PM
To: edk2-devel@lists.sourceforge.net
Cc: Zeng, Star; Fan, Jeff; Gao, Liming; Ni, Ruiyu; Tian, Feng
Subject: [PATCH 04/13] MdeModulePkg/Library/PeiPerformanceLib: Use safe string
functions t
Reviewed-by: Star Zeng
-Original Message-
From: Qiu, Shumin
Sent: Thursday, June 25, 2015 3:47 PM
To: edk2-devel@lists.sourceforge.net
Cc: Zeng, Star; Fan, Jeff; Gao, Liming; Ni, Ruiyu; Tian, Feng
Subject: [PATCH 13/13] MdeModulePkg/Universal/Variable: Use safe string
functions to refin
The logic is good to me. One minor comment below.
How about save "AsciiStrSize (TokenSpaceName) + AsciiStrSize (PcdName)" to one
local variable, for example:
UINTN NameSize;
...
NameSize = AsciiStrSize (TokenSpaceName) + AsciiStrSize (PcdName);
Thanks,
Star
-Original Message-
From: Qiu
Reviewed-by: Star Zeng
-Original Message-
From: Qiu, Shumin
Sent: Thursday, June 25, 2015 3:47 PM
To: edk2-devel@lists.sourceforge.net
Cc: Zeng, Star; Fan, Jeff; Gao, Liming; Ni, Ruiyu; Tian, Feng
Subject: [PATCH 02/13] MdeModulePkg/Library/DxeCorePerformanceLib: Use safe
string functio
The AcpiS3->S3Save() call needs to occur before the end-of-DXE event
is signalled. The end-of-DXE event needs to be signalled prior to
invoking any UEFI drivers, applications, or connecting consoles.
This means the call to S3Save() that occurs in BdsLibBootViaBootOption()
violates the ordering con
Please use SMM_PERFORMANCE_STRING_SIZE, but not DXE_PERFORMANCE_STRING_SIZE.
Thanks,
Star
-Original Message-
From: Qiu, Shumin
Sent: Thursday, June 25, 2015 3:47 PM
To: edk2-devel@lists.sourceforge.net
Cc: Zeng, Star; Fan, Jeff; Gao, Liming; Ni, Ruiyu; Tian, Feng
Subject: [PATCH 05/13] Md
Reviewed-by: Star Zeng
-Original Message-
From: Qiu, Shumin
Sent: Thursday, June 25, 2015 3:47 PM
To: edk2-devel@lists.sourceforge.net
Cc: Zeng, Star; Fan, Jeff; Gao, Liming; Ni, Ruiyu; Tian, Feng
Subject: [PATCH 12/13] MdeModulePkg/Universal/SmbiosDxe: Use safe string
functions to refi
On 25 June 2015 at 10:51, Yao, Jiewen wrote:
> The dispatch order can be determined by TPL. Event with high TPL runs first.
> But, there is no guaranteed dispatch order if 2 events have same TPL.
>
> Would you please let me know what problem you find?
>
> I cannot see any interaction between S3Sav
The dispatch order can be determined by TPL. Event with high TPL runs first.
But, there is no guaranteed dispatch order if 2 events have same TPL.
Would you please let me know what problem you find?
I cannot see any interaction between S3Save and silicon driver.
Also, I cannot see the problem if
Laszlo/Jordan,
It seems to generalize the code is not very much possible, or at least not an
easy task. How about we do the things in multiple steps? So it won't block your
current work.
1. Duplicate the PciHostBridgeDxe in OvmfPkg and add these special OVMF logic.
2. Review the different version
On 25 June 2015 at 10:35, Yao, Jiewen wrote:
> And in the future, I believe we could remove EFI_ACPI_S3_SAVE_PROTOCOL
> protocol completely. (This is Framework 0.9 defined API, not PI defined API)
>
> The better design might be:
> 1) AcpiS3Save does not install EFI_ACPI_S3_SAVE_PROTOCOL.
> 2) Acp
1 - 100 of 127 matches
Mail list logo
