On 18 August 2015 at 14:30, Haojian Zhuang wrote:
> On Tue, 2015-08-18 at 11:43 +0200, Ard Biesheuvel wrote:
>> On 18 August 2015 at 11:31, Haojian Zhuang wrote:
>> > On Tue, 2015-08-18 at 11:22 +0200, Ard Biesheuvel wrote:
>> >> On 18 August 2015 at 11:04
On 18 August 2015 at 11:31, Haojian Zhuang wrote:
> On Tue, 2015-08-18 at 11:22 +0200, Ard Biesheuvel wrote:
>> On 18 August 2015 at 11:04, Haojian Zhuang wrote:
>> > Support multiple PL061 controllers.
>> >
>> > Contributed-under: TianoCore Contribution Agree
On 18 August 2015 at 11:04, Haojian Zhuang wrote:
> Support multiple PL061 controllers.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Haojian Zhuang
> ---
> ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c| 107
> ++---
> .../Drivers/PL061GpioDx
On 9 August 2015 at 23:20, Narinder Dhillon wrote:
> Hi All,
>
> I am building a UEFI image for ARMv7 Cortex A7 SoC. While debugging, I
> looked at the objdump of my 'dll' files and notice that entry point offset
> is around 0x8000.
>
> Looking at DxeCore.map file I noticed below statement.
> Any
On 16 July 2015 at 00:41, Laszlo Ersek wrote:
> The "MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf" driver is generic, it
> provides EFI_SMBIOS_PROTOCOL.
>
> The "OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf" driver downloads the
> SMBIOS payload from QEMU
ed on TTY terminal patches.
> V3 updates comment for PcdDefaultTerminalType.
> V4 splits the 1st patch.
>
Thanks Heyi
Committed as SVN r18023 ... r18027
Regards,
Ard.
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Jordan Justen
> Cc: Andrew Fish
> Cc: Laszlo Ersek
&
On 16 July 2015 at 04:09, Heyi Guo wrote:
> There were some issues when I ran SCT test against Serial IO Protocol
> on qemu aarch64, and below patches were made after I went through the
> code of TerminalDxe driver and the flow of console devices being
> connected.
>
> V2 is based on TTY terminal
from a XIP binary, since .reloc is now the final section in the
image.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BaseTools/Source/C/GenFw/Elf32Convert.c | 55 -
BaseTools/Source/C/GenFw/Elf64Convert.c | 54
On 13 July 2015 at 21:58, Laszlo Ersek wrote:
> On 07/13/15 21:49, Ard Biesheuvel wrote:
>> This constifies two instances of mStatusString, preventing it from
>> being emitted into the .data section.
>>
>> Ard Biesheuvel (2):
>> MdePkg/BasePrintLi
o include new type. Its
> comment can highlight this type is not defined in UEFI specification.
>
OK, that is also fine,
Thanks,
Ard.
> -----Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, July 14, 2015 6:36 PM
> To: edk2-devel@l
Since PcdDefaultTerminalType may now assume values that are not
defined in MdePkg (i.e., TTYTERM), introduce a new version in
MdeModulePkg instead. Also add TTYTERM as #4.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
EmulatorPkg/EmulatorPkg.dsc
: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdePkg/MdePkg.dec | 9 -
1 file changed, 9 deletions(-)
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index bda6550ed6c6..026a94987bef 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -2007,15 +2007,6
Now that MdeModulePkg defines a TTYTERM terminal type that MdePkg
knows nothing about, we should move PcdDefaultTerminalType to
MdeModulePkg as well, and allow it to assume the value #4 which
corresponds with TTYTERM.
Ard Biesheuvel (2):
MdeModulePkg|EmulatorPkg: add definition for
On 14 July 2015 at 12:18, Ard Biesheuvel wrote:
> On 14 July 2015 at 12:15, Laszlo Ersek wrote:
>> On 07/13/15 13:34, Laszlo Ersek wrote:
>>> On 07/13/15 13:22, Ard Biesheuvel wrote:
>>>> On 13 July 2015 at 13:15, Laszlo Ersek wrote:
>>>>> On
On 14 July 2015 at 12:15, Laszlo Ersek wrote:
> On 07/13/15 13:34, Laszlo Ersek wrote:
>> On 07/13/15 13:22, Ard Biesheuvel wrote:
>>> On 13 July 2015 at 13:15, Laszlo Ersek wrote:
>>>> On 07/13/15 05:24, Heyi Guo wrote:
>>>>> Change defaul
On 14 July 2015 at 10:12, Liu, Yingke D wrote:
> Reviewed-by: Yingke Liu
>
Thanks! Pushed as SVN r17942
--
Ard.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, July 14, 2015 3:52
> To: Liu, Yingke D; edk2-devel@lis
1.0
Signed-off-by: Ard Biesheuvel
---
BaseTools/Source/C/Common/BasePeCoff.c | 33 +++
BaseTools/Source/C/Common/PeCoffLoaderEx.c | 90
2 files changed, 11 insertions(+), 112 deletions(-)
diff --git a/BaseTools/Source/C/Common/BasePeCoff.c
b/BaseTools/Source/C/Common
Change the type of mStatusString[] to reflect that it is a CONST
array of pointers to CONST.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Change the type of mStatusString[] to reflect that it is a CONST
array of pointers to CONST.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdePkg/Library/BasePrintLib/PrintLibInternal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This constifies two instances of mStatusString, preventing it from
being emitted into the .data section.
Ard Biesheuvel (2):
MdePkg/BasePrintLib: make mStatusString array CONST
MdeModulePkg/DxePrintLibPrint2Protocol: make mStatusString array CONST
MdeModulePkg/Library
to put such binaries into a FV image in
a way that they can be executed in place without forcing the header to
be section aligned. I think it is possible, but I am not quite there
yet.
I will try to post an RFC series later today or tomorrow to illustrate
what I am trying to do.
--
Ard.
>&g
On 13 July 2015 at 13:15, Laszlo Ersek wrote:
> On 07/13/15 05:24, Heyi Guo wrote:
>> Change default terminal type to be consistent with default
>> ConIn/ConOut device path, which is now determined by TTY_TERMINAL
>> flag, TTYTERM or VT100.
>>
>> I can't say this is a bug, as we can pass the whole
On 12 July 2015 at 19:34, Long, Qin wrote:
> Ard,
>
> This looks good to me. (And thanks for doing this. I was out of office this
> week, so sorry for late response.)
>
> Reviewed-by: Qin Long
>
Thanks! Committed as SVN r17928
Regards,
Ard.
> -Original Message
On 10 July 2015 at 18:13, Olivier Martin wrote:
>
>
>> -Original Message-----
>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>> Sent: 08 July 2015 18:50
>> To: Olivier Martin
>> Cc: Leif Lindholm; edk2-devel@lists.sourceforge.net; Harry Lieb
same
> coding style issue.
>
Yes. I wonder who wrote it :-)
> Reviewed-By: Olivier Martin
>
> I pushed the patchset in SVN rev17925-17927. Thanks for the contribution :-)
>
Thanks,
Ard.
> -----Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@lina
On 10 July 2015 at 16:14, Matt Fleming wrote:
> On Fri, 10 Jul, at 03:57:52PM, Ard Biesheuvel wrote:
>>
>> Are you sure it is the .reloc section itself? It could well be the
>> target of a relocation fixup that is inside a code region, which
>> cannot be applied
On 10 July 2015 at 15:53, Matt Fleming wrote:
> On Thu, 09 Jul, at 05:58:36PM, Ard Biesheuvel wrote:
>>
>> Sure. In the meantime, I have cooked up a slightly more elaborate
>> series that also fixes the
>> EFI_IMAGE_REL_BASED_LOW/EFI_IMAGE_REL_BASED_HIGH issues (even t
On 10 July 2015 at 10:19, Wang Fan wrote:
> Move null check before set value to address to avoid null address
> dereferenced.
>
Preventing a NULL pointer from being dereferenced is hardly an
optimization, so perhaps you should change the patch description?
> Contributed-under: TianoCore Contrib
On 10 July 2015 at 10:19, Wang Fan wrote:
> Revise some errors which may lead NULL pointer be dereferenced:
> * DnsDhcp.c: Paralist may be used without any initialized
> * DnsHeader and RcvString may be null but be dereferenced
> * HttpDriver.c: revise an if judgment
> * HttpImpl.c: add a judgment
inal Message-----
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, July 10, 2015 2:54 PM
> To: edk2-devel@lists.sourceforge.net; Long, Qin; Dong, Guo; Ye, Ting
> Cc: Justen, Jordan L; Gao, Liming; Ard Biesheuvel
> Subject: [PATCH] CryptoPkg: update OpenSSL d
Upstream OpenSSL version 1.0.2c contained a fatal flaw
[CVE-2015-1793] and is no longer available from the openssl.org
download servers. So upgrade to its replacement, version 1.0.2d.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
CryptoPkg/Library
and the OS..
Perhaps in this particular case, we could get away with it, but I
think it is a pattern that we want to discourage, so it does not
belong in a reference implementation.
--
Ard.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.or
On 9 July 2015 at 16:57, Matt Fleming wrote:
> On Thu, 02 Jul, at 02:31:24PM, Ard Biesheuvel wrote:
>> Hello all,
>>
>> This is a proof of concept patch that fixes the problems that occur when
>> enabling the EFI_PROPERTIES_RUNTIME_MEMORY_PROTEC
On 7 July 2015 at 19:37, Ryan Harkin wrote:
> Hi Ard,
>
> On 7 July 2015 at 13:22, Ard Biesheuvel wrote:
>>
>> On 6 July 2015 at 20:26, Ard Biesheuvel wrote:
>> > This fixes an issue reported by Ryan Harkin where 32-bit ARM platforms
>> > without
>>
On 9 July 2015 at 01:42, Jordan Justen wrote:
> On 2015-07-08 08:58:04, Laszlo Ersek wrote:
>> On 07/08/15 17:02, Ard Biesheuvel wrote:
>> > On 8 July 2015 at 16:59, Olivier Martin wrote:
>> >> For ARM architectures, I only disable this flag for RELEASE build:
>&
On 8 July 2015 at 17:53, Olivier Martin wrote:
> That's a fair comment. I will revert the patch. Sorry for the inconvenience.
>
OK, thanks.
--
Ard.
> -Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: 07 July 2015 22
On 8 July 2015 at 20:01, Andrew Fish wrote:
>
> On Jul 8, 2015, at 10:49 AM, Ard Biesheuvel
> wrote:
>
> On 8 July 2015 at 16:57, Olivier Martin wrote:
>
> When EDK2 is built for the small memory model with AArch64 LLVM,
> some page-relative relocations (R_AARCH64_
On 8 July 2015 at 16:57, Olivier Martin wrote:
> When EDK2 is built for the small memory model with AArch64 LLVM,
> some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its
> R_AARCH64_LDST(16|32|64|128)_ABS_LO12_NC companions) that were not
> supported before by EDK2 BaseTools are now n
Wno-unused-but-set-variable
> RELEASE_GCC49_ARM_CC_FLAGS = DEF(GCC49_ARM_CC_FLAGS)
> -Wno-unused-but-set-variable
> RELEASE_GCC49_AARCH64_CC_FLAGS = DEF(GCC49_AARCH64_CC_FLAGS)
> -Wno-unused-but-set-variable
>
>
> -Original Message-
> From: Ard Biesheuve
On 8 July 2015 at 15:35, Wu, Jiaxin wrote:
> Hi Ard,
> Please help to review and reply the patch, if so, I can submit the patch as
> soon as possible.
>
> Thank you very much!
>
I just tested it and it works.
So please feel free to add
Reviewed-by: Ard Bieshe
ne option.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BaseTools/Conf/tools_def.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/tools_def.template
b/BaseTools/Conf/tools_def.template
index 7edd7590956b..15d8db0423
-- Forwarded message --
From: Ard Biesheuvel
Date: 8 July 2015 at 11:26
Subject: Re: [edk2] [PATCH v4] ShellPkg: Update ping/ifconfig library.
To: "edk2-devel@lists.sourceforge.net"
On 3 July 2015 at 05:39, jiaxinwu wrote:
> Version4 include small update fr
On 3 July 2015 at 05:39, jiaxinwu wrote:
> Version4 include small update from reviewer's comments:
> Change and add some help messages in uni file.
> Revert copyright year in UefiShellNetwork1CommandsLib.c file since there is
> no code change in this file.
>
> This patch update ShellPkg ping/ifco
On 8 July 2015 at 08:24, jiaxinwu wrote:
> Version2 update with a proper commit message.
>
This commit message still does not explain the purpose of this change.
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signe
Hi Olivier,
Your patch 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file
names' has broken the FVP build in a non-trivial way:
This part of the FDF:
"""
!ifdef $(DTB_DIR)
#
# Embed flattened device tree (FDT) images for all known
# variants of this platform
#
FILE RAW = PCD (gArm
On 7 July 2015 at 22:07, Roy Franz wrote:
> On Tue, Jul 7, 2015 at 6:18 AM, Ard Biesheuvel
> wrote:
>> On 7 July 2015 at 01:04, Roy Franz wrote:
>>> Accept the VT220 escape code [3~ as backspace for TtyTerm terminals. This
>>> is
>>> sent by many Linux t
by: Olivier Martin
Reviewed-by: Ard Biesheuvel
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 8893dfa..16d7ea6 100644
> --- a/ArmVirtPkg/ArmVirt.dsc
This fixes the declaration and definition of mSystemMemoryEnd so that it
is correctly annotated as a non-function symbol. Also adds the ASM_PFX
prefix, which is empty on AARCH64 but should be included for correctness.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard
This fixes the declaration and definition of mSystemMemoryEnd so that it
is correctly annotated as a non-function symbol. Also adds the ASM_PFX
prefix, which is empty on AARCH64 but should be included for correctness.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard
On 7 July 2015 at 15:16, Olivier Martin wrote:
> This ensures the .type directive is used to mark them as function symbols
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Olivier Martin
This patch looks fine to me
Reviewed-by: Ard Biesheuvel
*Howe
/* 2 character escape code */
> + TtyEscapeStr[TtyEscapeIndex++] = UnicodeChar;
> + continue;
> +}
> +else {
> + DEBUG ((EFI_D_ERROR, "Unexpected state in escape2\n"));
> +}
> + }
> +
Signed-off-by: Roy Franz
> Contributed-under: TianoCore Contribution Agreement 1.0
Order is wrong ^^^
Other than that
Reviewed-by: Ard Biesheuvel
> ---
> MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
b13e..539463b 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -304,6 +304,9 @@
># Include/Guid/LzmaDecompress.h
>gLzmaCustomDecompressGuid = { 0xEE4E5898, 0x3914, 0x4259, { 0x9D,
> 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }}
> gLzmaF86Cust
e "-D TTY_TERMINAL" build option.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek
> [Roy Franz: minor edits: add TtyTerminal GUID, rename LINUX_TERMINAL to
> TTY_TERMINAL]
> Contributed-under: TianoCore Contribution Agreement 1.0
On 7 July 2015 at 03:27, jiaxinwu wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: jiaxinwu
Reviewed-by: Ard Biesheuvel
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> ArmVirtPkg/ArmVirtQemu.fdf | 1 -
> 2 files changed, 2 deletions(-)
>
>
On 7 July 2015 at 14:46, Ard Biesheuvel wrote:
> On 7 July 2015 at 03:27, jiaxinwu wrote:
>> Those patches are used to remove Ip4ConfigDxe module and related guid
>> definitions from related packages.
>>
>
> Could you please explain *why* you are removing these?
>
On 7 July 2015 at 03:27, jiaxinwu wrote:
> Those patches are used to remove Ip4ConfigDxe module and related guid
> definitions from related packages.
>
Could you please explain *why* you are removing these?
--
Ard.
> jiaxinwu (7):
> MdeModulePkg: Remove Ip4ConfigDxe module and related guid
On 6 July 2015 at 20:26, Ard Biesheuvel wrote:
> This fixes an issue reported by Ryan Harkin where 32-bit ARM platforms without
> PSCI compliant firmware cannot be rebooted or powered off successfully at
> boot time.
>
> This is caused by a change which aimed to prevent system re
On 7 July 2015 at 13:01, Olivier Martin wrote:
> Sorry for that, I have got ArmVirtQemu.dsc in my CI but I have not got yet
> ArmVirtXen.dsc :-/
>
No problem, it was an easy fix.
Thanks,
Ard.
> -Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.
ocal variable VirtImageBase.
>
Yes, that would work. I will change that in the next version.
--
Ard.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, July 6, 2015 3:12 PM
> To: Gao, Liming
> Cc: edk2-devel@lists.sourcefo
Signed-off-by: Ard Biesheuvel
---
This fixes the build for ArmVirtXen, although I would have preferred a
different approach for r17835 in the first place, i.e., a clean interface
rather than a global which is declared as an extern in random places.
--
Ard.
ArmVirtPkg/PrePi/AArch64
revert to the Versatile Express-specific system register
interface (which is only available during boot time) on ARM platforms.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 1 +
1 file changed, 1
.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
b/ArmPlatformPkg/ArmVExpressPkg
, and wiring
it up for 32-bit VExpress platforms.
Ard Biesheuvel (3):
ArmPlatformPkg/ArmVExpressPkg: add ArmPlatformSysConfigLib for runtime
ArmVExpressPkg: use ArmVExpressSysConfigRuntimeLib by default
ArmVExpressPkg: use PSCI for system reset only on AARCH64 platforms
ArmPlatformPkg
1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmVExpressPkg/Library/{ArmVExpressSysConfigLib/ArmVExpressSysConfig.c
=> ArmVExpressSysConfigRuntimeLib/ArmVExpressSysConfigRuntimeLib.c}|
10 ++
ArmPlatformPkg/ArmVExpressPkg/Library/{ArmVExpressSysConfig
-Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, June 29, 2015 12:37 PM
> To: edk2-devel@lists.sourceforge.net; ler...@redhat.com;
> olivier.mar...@arm.com; af...@apple.com; Cohen, Eugene; jiewen@intel.com
> Cc: yingke.d.
Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
index 4d8adcc3e348..1ca9b2de6550 100644
On 6 July 2015 at 18:11, Ryan Harkin wrote:
> The following 3 patches break reboot/shutdown from within UEFI on TC2 and
> probably all 32-bit ARM Ltd platforms:
>
> ee171cc 2015-05-08 ArmVExpressPkg: restrict ArmVExpressSysConfigLib to SEC
> and DXE_DRIVER [Ard Biesheuvel]
Thanks,
Ard.
> -Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, July 03, 2015 5:40 PM
> To: edk2-devel@lists.sourceforge.net; Kinney, Michael D; Yao, Jiewen; Gao,
> Liming; Justen, Jordan L
> Cc: ler...@redhat.com; olivier.mar...@arm.com; Ar
tory and run ls
> command.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo
Reviewed-by: Ard Biesheuvel
> ---
> ShellPkg/Application/Shell/ShellProtocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Shell
On 3 July 2015 at 11:34, Heyi Guo wrote:
> SVN r17742 uses AllocateCopyPool to replace AllocateZeroPool, however
> String can be NULL and this will trigger assert in AllocateCopyPool.
> Error Can be replayed when we use "cd " command under Shell.
>
> Just use a more conservative way to replace uns
the list of supported machines
of the generic version, and use it for AARCH64 as well.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdePkg/Library/BasePeCoffLib/AArch64/PeCoffLoaderEx.c | 127
MdePkg/Library/BasePeCoffLib
Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
b/MdePkg/Library/BasePeCoffLib/BasePeCoff.c
index 33cad23a014e..28c84062d125 100644
--- a/MdePkg
PeCoffLoaderRelocateImageForRuntime
have been updated to account for this, so update the call site as well.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/RuntimeDxe/Runtime.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg
Signed-off-by: Ard Biesheuvel
---
MdePkg/Include/Library/PeCoffLib.h| 28
MdePkg/Library/BasePeCoffLib/Arm/PeCoffLoaderEx.c | 19 ++-
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 35 +++-
MdePkg/Library/BasePeCoffLib
The IPF implementation of PeHotRelocateImageEx () handles relocations
of type EFI_IMAGE_REL_BASED_DIR64. However, since the caller already
handles this type, this is essentially dead code and can be removed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
comparisons that
occur when the other relocation of a pair has been handled already,
keep a per-page record of which 32-bit words have been partially
relocated.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 47
to use the new PeCoffLoaderRelocateImageForRuntime
prototype.
Unfortunately, this series is not bisectable between #5 and #6. Working around
that is non-trivial and probably not worth the hassle.
Ard Biesheuvel (6):
MdePkg/BasePeCoffLib: remove redundant PeCoffLoaderEx.c for AARCH64
MdePkg/Bas
mageBase, apply ConvertPointer () to each relocation target to obtain the
new value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/RuntimeDxe/Runtime.c | 229 +++-
1 file changed, 227 insertions(+), 2 deletions(-)
diff
On 2 July 2015 at 09:29, Jordan Justen wrote:
> On 2015-07-02 00:10:40, Jordan Justen wrote:
>> On 2015-07-01 23:51:19, Ard Biesheuvel wrote:
>> > On 2 July 2015 at 08:38, Ard Biesheuvel wrote:
>> > > Liming, Jordan, Jiewen.
>> > >
>> > >
On 2 July 2015 at 09:21, Gao, Liming wrote:
> Jordan:
> For now, this feature will break older OSes. The platform requires to add
> feature flag to enable/disable it. So, DSC BuildOptions extension is added to
> configure it. In future, if more and more platforms enable it, we could
> figure
On 2 July 2015 at 08:38, Ard Biesheuvel wrote:
> Liming, Jordan, Jiewen.
>
> I appeared to have screwed up something performing the push
>
> Could you please rewind SVN to r17801 ?
>
Apologies for sounding a bit panicky, but it would be useful if those
commits could be removed
t;ld" looks for it in the directories
specified by any preceding -L options. Multiple -T options accumulate.
"""
>> Is this the long term plan?
>>
>> Do Visual Studio based builds do something similar?
>>
>> -Jordan
>>
>>&
GN(0x1) { }
}
8<
so I suppose the X86 version could be stripped down in a similar way.
--
Ard.
>> -Original Message-
>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>> Sent: Thursday, July 02, 2015 1:05 PM
>> To: Justen, Jordan L
>>
rds,
Ard.
>> -Original Message-
>> From: Justen, Jordan L
>> Sent: Thursday, July 2, 2015 6:42 AM
>> To: Liu, Yingke D; Ard Biesheuvel
>> Cc: edk2-devel@lists.sourceforge.net; Gao, Liming
>> Subject: RE: [PATCH] BaseTools: fix a syntax error in 4 KB al
@Olivier: do you have any comments on this patch?
On 29 June 2015 at 23:22, Cohen, Eugene wrote:
> Reviewed-by: Eugene Cohen
>
> Thanks.
>
> -Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, June 29, 2015 12:3
On 30 June 2015 at 06:12, Roy Franz wrote:
> Add a description of how to describe the authorship of a patch that
> is submitted by someone other than the original author.
> Add mention of git format-patch options for generating
> more useful patch names in diffstat.
>
> Contributed-under: TianoCor
On 30 June 2015 at 06:12, Roy Franz wrote:
> Replace the 38 identical Contributions.txt in subdirectories with a single
> copy at the top level.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Roy Franz
I agree that the duplication seems wasteful, but how is this sup
this instead:
> There needs to be a space between the output section name and the colon, i.e.,
as the subject line which looks a little silly imo
Thanks,
Ard.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Tuesday, June 30, 2015 7:00 PM
ssed the review.
>
Yes, that looks fine.
Reviewed-by: Ard Biesheuvel
I would also like to thank you for using the Git setup that Laszlo
suggested. Having diff lines like
@@ -123,6 +124,9 @@ [LibraryClasses.common]
makes life as a reviewer very easy!
Thanks,
Ard.
> -Original Mes
On 30 June 2015 at 11:01, Star Zeng wrote:
> These library classes are now linked with
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
> to optionally support secure variables.
>
> For ArmPlatformPkg, secure boot is not currently enabled,
> so we map these libraries to the NULL
been merged.
>
> Cc: Olivier Martin
> Cc: Leif Lindholm
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng
Reviewed-by: Ard Biesheuvel
As I mentioned before, I will try to merge
NorFlashAuthenticatedDxe.inf again with NorFlashDxe.inf (I only split
This series applies some cleanups to the Properties Table feature
implementation,
and updates it so that it may be used on AArch64 without violating the alignment
restrictions imposed by the architecture (i.e., runtime regions should be 64 KB
aligned)
Ard Biesheuvel (5):
MdeModulePkg: remove
Add STATIC to functions that are only used internally.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 21
1 file changed, 21 insertions(+)
diff --git a/MdeModulePkg/Core/Dxe/Misc
Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
b/MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
index 0232a3ce7d93..01ecca64ab0a
This removes the functions RevertRuntimeMemoryMap () and
DumpMemoryMap () which are not referenced anywhere in the code.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 82
1 file
PCD names should start with 'Pcd' so rename PropertiesTableEnable
to PcdPropertiesTableEnable.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/DxeMain.inf| 2 +-
MdeModulePkg/Core/Dxe/Misc/PropertiesT
Move the definitions of EFI_ACPI_RUNTIME_PAGE_ALLOCATION_ALIGNMENT and
DEFAULT_PAGE_ALLOCATION to DxeMain.h to make them available explicitly
to all parts of DxeCore.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Core/Dxe/DxeMain.h | 25
There needs to be a space between the output section name and the
colon, i.e.,
.text : ALIGN(0x1000)
^
Fix this for all output sections
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BaseTools/Scripts/gcc-4K-align-ld-script | 10
newly introduced
Properties Table feature.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BaseTools/Conf/tools_def.template | 23 +++-
BaseTools/Scripts/gcc-aarch64-64K-align-ld-script | 4 ++
BaseTools/Scripts/gcc-aarch64-ld-s
1 - 100 of 735 matches
Mail list logo
