Re: [edk2] [PATCH V3 3/4] MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default

On 07/16/2015 05:56 PM, Laszlo Ersek wrote: > On 07/16/15 04:09, Heyi Guo wrote: >> This is bug fix for TerminalDxe: NullRemaining should be set to FALSE >> by fault and then be set to TRUE conditionally. >> >> Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH] ArmPlatformPkg/Bds: Use HandleProtocol to get SNP instance

LocateProtocol only gets the 1st SNP instance and this will be wrong in a system with multiple SNP instances installed. Use HandleProtocol instead. Cc: Olivier Martin Cc: Leif Lindholm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmPlatformPkg/Bds

[edk2] [PATCH V4 0/5] Some improvements on serial terminal

PcdDefaultTerminalType. V4 splits the 1st patch. Thanks. Cc: Michael D Kinney Cc: Liming Gao Cc: Jordan Justen Cc: Andrew Fish Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Feng Tian Cc: Ruiyu Ni Heyi Guo (5): MdePkg: Update comment for PcdDefaultTerminalType EmulatorPkg: Update comment for

[edk2] [PATCH V4 5/5] MdeModulePkg/TerminalDxe: Some improvements

: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Reviewed-by: Ruiyu Ni Reviewed-by: Feng Tian --- .../Universal/Console/TerminalDxe/Terminal.c | 27 -- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe

[edk2] [PATCH V4 4/5] MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default

This is bug fix for TerminalDxe: NullRemaining should be set to FALSE by fault and then be set to TRUE conditionally. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Reviewed-by: Ruiyu Ni Reviewed-by: Feng Tian --- MdeModulePkg/Universal/Console

[edk2] [PATCH V4 3/5] ArmVirtPkg: Make terminal type consistent

erial terminal be reconnected with normal connect controller operation. Cc: Laszlo Ersek Cc: Ard Biesheuvel Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Reviewed-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtQemu.dsc | 8 1 file changed, 8 insertions(+)

[edk2] [PATCH V4 1/5] MdePkg: Update comment for PcdDefaultTerminalType

Update comment for PcdDefaultTerminalType, as a new terminal type TTYTERM has been added with type value of 4. The new type is NOT defined in UEFI SPEC v2.5. Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Reviewed-by: Liming

[edk2] [PATCH V4 2/5] EmulatorPkg: Update comment for PcdDefaultTerminalType

Update comment for PcdDefaultTerminalType, as a new terminal type TTYTERM has been added with type value of 4. The new type is NOT defined in UEFI SPEC v2.5. Cc: Jordan Justen Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo Reviewed-by: Jordan

Re: [edk2] [PATCH V3 0/4] Some improvements on serial terminal

Thanks for your helpful info. On 07/16/2015 02:56 PM, Ard Biesheuvel wrote: > On 16 July 2015 at 04:09, Heyi Guo wrote: >> There were some issues when I ran SCT test against Serial IO Protocol >> on qemu aarch64, and below patches were made after I went through the >> code

[edk2] [PATCH V3 2/4] ArmVirtPkg: Make terminal type consistent

erial terminal be reconnected with normal connect controller operation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmVirtPkg/ArmVirtQemu.dsc | 8 1 file changed, 8 insertions(+) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQem

[edk2] [PATCH V3 3/4] MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default

This is bug fix for TerminalDxe: NullRemaining should be set to FALSE by fault and then be set to TRUE conditionally. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 2 +- 1 file changed, 1 insertion

[edk2] [PATCH V3 0/4] Some improvements on serial terminal

PcdDefaultTerminalType. Please help review these patches and provide your comments. Thanks. Heyi Guo (4): MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType ArmVirtPkg: Make terminal type consistent MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default MdeModulePkg/TerminalDxe: Some

[edk2] [PATCH V3 1/4] MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType

Update comment for PcdDefaultTerminalType, as a new terminal type TTYTERM has been added with type value of 4. The new type is NOT defined in UEFI SPEC v2.5. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- EmulatorPkg/EmulatorPkg.dsc | 2 +- MdePkg

[edk2] [PATCH V3 4/4] MdeModulePkg/TerminalDxe: Some improvements

Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- .../Universal/Console/TerminalDxe/Terminal.c | 27 -- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c

Re: [edk2] [PATCH V2 1/3] ArmVirtPkg: Make terminal type consistent

No problem :) Heyi On 07/15/2015 07:20 PM, Laszlo Ersek wrote: > Heyi, > > On 07/13/15 13:22, Ard Biesheuvel wrote: >> On 13 July 2015 at 13:15, Laszlo Ersek wrote: >>> On 07/13/15 05:24, Heyi Guo wrote: >>>> Change default terminal type to be consistent w

[edk2] [PATCH V2 0/3] Some improvements on serial terminal

provide your comments. Thanks. Heyi Guo (3): ArmVirtPkg: Make terminal type consistent MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default MdeModulePkg/TerminalDxe: Some improvements ArmVirtPkg/ArmVirtQemu.dsc | 6 + .../Universal/Console/TerminalDxe

[edk2] [PATCH V2 1/3] ArmVirtPkg: Make terminal type consistent

erial terminal be reconnected with normal connect controller operation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmVirtPkg/ArmVirtQemu.dsc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc

[edk2] [PATCH V2 2/3] MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default

This is bug fix for TerminalDxe: NullRemaining should be set to FALSE by fault and then be set to TRUE conditionally. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 2 +- 1 file changed, 1 insertion

[edk2] [PATCH V2 3/3] MdeModulePkg/TerminalDxe: Some improvements

Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- .../Universal/Console/TerminalDxe/Terminal.c | 27 -- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c

Re: [edk2] [PATCH v2] IntelFrameworkPkg FrameworkUefiLib: Fix ASSERT in CatVSPrint

Hi Hao, Shall we also change code in MdePkg for the same function to keep code style consistent? Thanks. On 07/09/2015 08:53 AM, Hao Wu wrote: > This commit will resolve issue brought by r17740. > > BufferToReturn = AllocateCopyPool(SizeRequired, String); > > The above using of AllocateCopyPool

Re: [edk2] [PATCH 1/3] ArmVirtPkg: Make terminal type consistent

Hi Laszlo, Thanks for your comments. I'll send another version when Roy's patches are committed. On 07/08/2015 02:47 AM, Laszlo Ersek wrote: > comments below > > On 07/07/15 18:56, Heyi Guo wrote: >> Change default terminal type to be VT100, to make it consistent wit

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

onPolicy|0x04 > !endif > > +!if $(TTY_TERMINAL) == TRUE And I don't understand why we use "!if" here and "!ifdef" in dsc file. I should have tested the patch directly, but I couldn't apply the mail patches with "git am" right now

[edk2] [PATCH 0/3] Some improvements on serial terminal

There were some issues when I ran SCT test against Serial IO Protocol on qemu aarch64, and below patches were made after I went through the code of TerminalDxe driver and the flow of console devices being connected. Please help review these patches and provide your comments. Thanks. Heyi Guo (3

[edk2] [PATCH 1/3] ArmVirtPkg: Make terminal type consistent

nnect controller operation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 0671469..0f104f3 100644 --- a/ArmVi

[edk2] [PATCH 3/3] MdeModulePkg: Some improvements on TerminalDxe

Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- .../Universal/Console/TerminalDxe/Terminal.c | 27 -- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c

[edk2] [PATCH 2/3] MdeModulePkg: TerminalDxe: Fix bug of NullRemaining flag

NullRemaining should be set to FALSE by fault and then be set to TRUE conditionally. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [edk2] [PATCH 0/3] Some improvements on serial terminal

Sorry, please ignore this mail. It seems there is something wrong with my system to send several patches at a time... :( On 07/08/2015 12:24 AM, Heyi Guo wrote: > There were some issues when I ran SCT test against Serial IO Protocol > on qemu aarch64, and below patches were made after

[edk2] [PATCH 0/3] Some improvements on serial terminal

There were some issues when I ran SCT test against Serial IO Protocol on qemu aarch64, and below patches were made after I went through the code of TerminalDxe driver and the flow of console devices being connected. Please help review these patches and provide your comments. Thanks. Heyi Guo (3

[edk2] [PATCH 0/3] Some improvements on serial terminal

There were some issues when I ran SCT test against Serial IO Protocol on qemu aarch64, and below patches were made after I went through the code of TerminalDxe driver and the flow of console devices being connected. Please help review these patches and provide your comments. Thanks. Heyi Guo (3

[edk2] [PATCH 0/3] Some improvements on serial terminal

There were some issues when I ran SCT test against Serial IO Protocol on qemu aarch64, and below patches were made after I went through the code of TerminalDxe driver and the flow of console devices being connected. Please help review these patches and provide your comments. Thanks. Heyi Guo (3

Re: [edk2] [PATCH 1/2] MdePkg: Fix bug in CatVSPrint introduced by r17742

es in r17742 and only replace StrCpy with StrCpyS. On 07/03/2015 08:25 PM, Ard Biesheuvel wrote: > On 3 July 2015 at 11:34, Heyi Guo wrote: >> SVN r17742 uses AllocateCopyPool to replace AllocateZeroPool, however >> String can be NULL and this will trigger assert in AllocateCopyP

[edk2] [PATCH 1/2] MdePkg: Fix bug in CatVSPrint introduced by r17742

TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- MdePkg/Library/UefiLib/UefiLibPrint.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MdePkg/Library/UefiLib/UefiLibPrint.c b/MdePkg/Library/UefiLib/UefiLibPrint.c index cc41eb0..604c25b 100644 --- a/MdePkg/Libra

[edk2] [PATCH 0/2] Fix some bugs of replacing unsafe string functions

***S to replace Strn***, because they functions differently when length overflows. Thanks. Heyi Guo (2): MdePkg: Fix bug in CatVSPrint introduced by r17742 ShellPkg: Fix bug introduced by r17730 MdePkg/Library/UefiLib/UefiLibPrint.c | 6 +- ShellPkg/Application/Shell/ShellProtoc

[edk2] [PATCH 2/2] ShellPkg: Fix bug introduced by r17730

Agreement 1.0 Signed-off-by: Heyi Guo --- ShellPkg/Application/Shell/ShellProtocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c index 249e1e1..6a24852 100644 --- a/ShellPkg/Application

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: Add HttpLib to MdeModulePkg.

Hi Siyuan, The include protection macro name in HttpLib.h is not consistent with the file name; is it better to use _HTTP_LIB_H_ instead? +#ifndef _HTTP_H_ +#define _HTTP_H_ On 07/02/2015 05:02 PM, Fu Siyuan wrote: > This patch add the header file and DXE implementation for the HttpLib. > > C

Re: [edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for large alignment

side is ok. Don't worry about that:-) > > Thanks > Feng > > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Monday, June 08, 2015 12:26 > To: edk2-devel@lists.sourceforge.net; Tian, Feng > Cc: Ilias Biris > Subject: Re: [edk2

Re: [edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for large alignment

. > > Thanks > Liming > -----Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Monday, June 08, 2015 9:26 AM > To: Tian, Feng > Cc: edk2-devel@lists.sourceforge.net; Ilias Biris > Subject: Re: [edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for lar

Re: [edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for large alignment

Hi Tian, Do you have any comments on this patch? Thanks! On 06/05/2015 09:57 AM, Heyi Guo wrote: > Hi Ard, > > I got this error when running SCT against QEMU AARCH64 UEFI. I think > it will only happen for aarch64 runtime services allocation, because > only this type of memor

Re: [edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for large alignment

and runtime memory, it just avoid the bug indirectly, as each descriptor would be kept naturally aligned with 64KB. Thanks. On 06/05/2015 12:08 AM, Ard Biesheuvel wrote: > On 4 June 2015 at 17:55, Heyi Guo wrote: >> DescEnd will be clipped for alignment in CoreFindFreePagesI, and it &g

[edk2] [PATCH] MdeModulePkg: Fix bug of AllocatePages for large alignment

descriptor, fulfilling the allocation requirement but failing to run ConvertPages; at last it causes occasional failure of AllocatePages. A simple comparison is added to ensure we would never get a negative number. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo

Re: [edk2] [PATCH 3/3] OvmfPkg: PlatformDxe: Add ConfigHdrMatch check in RouteConfig

check the GUID and NAME field, but I didn't find it implicitly declared in the SPEC. I may discuss the issues with you before sending patches directly, but I thought the code would tell the story clearer and we can discuss based on it. Thanks. Heyi Guo On 06/01/2015 11:13 PM, La

[edk2] [PATCH 0/3] Fix UEFI-SCT test errors for QEMU-AARCH64 UEFI

I'm running UEFI SCT on QEMU-AARCH64 UEFI and found there are some improvements needed to pass SCT conformance test (not real bug, but lack of parameter check or something similar). Please help to review my patches and let me know your comments. Thanks! Heyi Guo (3): OvmfPkg: VirtioBlkDxe

[edk2] [PATCH 2/3] OvmfPkg: PlatformDxe: Add sanity check for HiiConfigAccess

TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- OvmfPkg/PlatformDxe/Platform.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c index 4ec327e..35fabf8 100644 --- a/OvmfPkg/PlatformDxe/Platform.c +++

[edk2] [PATCH 1/3] OvmfPkg: VirtioBlkDxe: Fix SCT test errors

es in media state". 2. Check Buffer to be not NULL, or we will get below error from QEMU and the emulation will exit abnormally: qemu-system-aarch64: virtio: error trying to map MMIO memory Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- OvmfPkg/Vi

[edk2] [PATCH 3/3] OvmfPkg: PlatformDxe: Add ConfigHdrMatch check in RouteConfig

Add HiiIsConfigHdrMatch check in RouteConfig, or the test case in UEFI SCT will fail for Configuration with invalid GUID, because it expects the return value to be NOT FOUND but actually INVALID PARAMETER returned. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo

Re: [edk2] UEFI SCT test failure for HII_CONFIG_ACCESS_PROTOCOL on AARCH64 QEMU UEFI

Thanks Ard :) I'll try with this. On 05/29/2015 10:14 PM, Ard Biesheuvel wrote: > On 29 May 2015 at 13:58, Heyi Guo wrote: >> Hi Laszlo and Ard, >> >> As you two are the new maintainers for ArmVirtPkg, I suppose you are the >> right persons to ask this quest

Re: [edk2] UEFI SCT test failure for HII_CONFIG_ACCESS_PROTOCOL on AARCH64 QEMU UEFI

Thank you so much for your time with such a detailed reply. I need more time to understand all the information :) On 05/29/2015 10:45 PM, Laszlo Ersek wrote: > On 05/29/15 13:58, Heyi Guo wrote: >> Hi Laszlo and Ard, >> >> As you two are the new maintainers for ArmVirtPkg,

[edk2] UEFI SCT test failure for HII_CONFIG_ACCESS_PROTOCOL on AARCH64 QEMU UEFI

Hi Laszlo and Ard, As you two are the new maintainers for ArmVirtPkg, I suppose you are the right persons to ask this question :) I'm running UEFI SCT aganst QEMU aarch64, and I got error for functional test against HII_CONFIG_ACCESS_PROTOCOL installed in PlatformDxe module. The test case is B

Re: [edk2] Potential memory leak for AARCH64 runtime memory allocation

Sorry, I didn't notice the counterpart code in FreePages. Then it should be none issue. Thanks Ard. On 05/26/2015 05:47 PM, Ard Biesheuvel wrote: > On 26 May 2015 at 11:40, Laszlo Ersek wrote: >> Ard, >> >> On 05/25/15 05:27, Heyi Guo wrote: >>> Hi folks, &

Re: [edk2] HII gEfiHiiPackageListProtocolGuid problem with GCC48 (VS2012x86 works)

Hi Bruce, I got the similar issue with arm linux gcc; I googled and found you had posted the question, but I didn't see the final solution. Is there any update for this issue? Thanks. -- One dashboard for servers and a

[edk2] How can I combine HII resource section into a PE/COFF Image?

Hi folks, I want to combine an HII resource section into a PE/COFF image. I've set UEFI_HII_RESOURCE_SECTION = TRUE and specified the uni file and vfr file in module INF, but there seems to be no effect. Could you please help? Thanks Hey

[edk2] Potential memory leak for AARCH64 runtime memory allocation

some way, e.g. using another macro to calculate page number for runtime memory, documented in UEFI spec, etc. Please let me know your comments, thanks! Heyi Guo -- One dashboard for servers and applications across

[edk2] Where can I post a bug or patch for UEFI-sct?

I found it is failed to compile sct-next with the latest edk2 code base, as EFI_SPECIFICATION_VERSION has been updated to 2.5, while EFI_SCT_NAME only supports 2.4B. In MdePkg/Include/Uefi/UefiSpec.h: #define EFI_SYSTEM_TABLE_REVISION EFI_2_50_SYSTEM_TABLE_REVISION #define EFI_SPECIFICATION_VER

[edk2] [PATCH] ArmPkg: Expand AArch64 address width to 48 bits

The VA address space has a maximum address width of 48 bits in AArch64 state; 48 bits address width limit will provide better compatibility than 40 bits for future CPU. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmPkg/Include/Chipset/AArch64Mmu.h | 4

[edk2] [PATCH] Fix Ebl dumpgcd bug with memory type and IO type

e strict equation, it is clearer to use switch-case than if-else. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmPlatformPkg/Library/EblCmdLib/EblCmdLib.c | 31 +--- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/ArmPlatf

[edk2] [PATCH] ArmPkg: fix ArmWriteCntkCtl simple code bug

We need to use msr instruction to write system register. It seems the code was simply copied from ArmReadCntkCtl. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmPkg/Library/ArmLib/AArch64/AArch64ArchTimerSupport.S | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2] How to setup ACPI tables for QEMU aarch64 virt hardware

Hi Shannon, I checked your branch and tested; I found there is a minor bug in QEMU ARM ACPI code that will cause FWTS test failed with ACPI syntaxcheck: 1. syntaxcheck: syntaxcheck;INF 00027| Name (_HID, "ACPI007") // _HID: Hardware ID syntaxcheck;INF |