Re: [edk2] question about x2apic support

2015-08-10 Thread Laszlo Ersek
On 08/10/15 18:13, Brian J. Johnson wrote: On 08/10/2015 03:16 AM, tiger...@zhaoxin.com wrote: Hello, experts: I have a question about x2apic support in UEFI BIOS. Could UEFI BIOS determine switching to xapic or x2apic when handing off to OS loader? Some webpages said: If CPU number

Re: [edk2] [PATCH] CryptoPkg: OpensslLib: reintroduce EFIAPI for ERR_add_error_data()

2015-07-23 Thread Laszlo Ersek
On 07/23/15 14:44, David Woodhouse wrote: On Thu, 2015-07-23 at 14:41 +0200, Laszlo Ersek wrote: Right. So what are the options? 1. Push a patch into OpenSSL upstream that marks ERR_add_error_data() and any other varargs functions with EFIAPI. (Ick, no. I can't imagine them

Re: [edk2] [PATCH] CryptoPkg: OpensslLib: reintroduce EFIAPI for ERR_add_error_data()

2015-07-23 Thread Laszlo Ersek
On 07/23/15 15:13, Andrew Fish wrote: On Jul 23, 2015, at 5:47 AM, Laszlo Ersek ler...@redhat.com wrote: On 07/23/15 14:44, David Woodhouse wrote: On Thu, 2015-07-23 at 14:41 +0200, Laszlo Ersek wrote: Right. So what are the options? 1. Push a patch into OpenSSL upstream that marks

Re: [edk2] [Patch v3] NetworkPkg: Add old IPv4_DEVICE_PATH and IPv6_DEVICE_PATH support

2015-07-23 Thread Laszlo Ersek
On 07/22/15 02:57, Wang Fan wrote: v3: * Update the macro of Ip4 device path node length and Ip6 device path node length. GatewayIpAddress and SubnetMask do not exist in old IPv4_DEVICE_PATH, IPAddressOrigin, PrefixLength and GatewayIPAddress do not exist in old IPv6_DEVICE_PATH. This

Re: [edk2] [PATCH] CryptoPkg: OpensslLib: reintroduce EFIAPI for ERR_add_error_data()

2015-07-23 Thread Laszlo Ersek
On 07/23/15 14:17, David Woodhouse wrote: On Thu, 2015-07-23 at 12:31 +0200, Laszlo Ersek wrote: I'm slightly confused. Why does it *only* matter for varargs functions? I thought that on some platforms, the difference between the ELF ABI and the MS ABI extended to putting arguments

Re: [edk2] [PATCH v2 0/6] OvmfPkg: save S3 state at EndOfDxe

2015-07-23 Thread Laszlo Ersek
On 07/14/15 18:48, Laszlo Ersek wrote: Version 2 of http://thread.gmane.org/gmane.comp.bios.tianocore.devel/16304. Changes relative to v1: - Since I received no feedback for Vlv2TbltDevicePkg, and no answer to my explicit query about interest in Vlv2TbltDevicePkg, I dropped

Re: [edk2] [Patch v3] MdeModulePkg: Add old IPv4_DEVICE_PATH support for new IScsiDxe

2015-07-23 Thread Laszlo Ersek
On 07/22/15 02:57, Wang Fan wrote: v3: * Update the macro of Ip4 device path node length. GatewayIpAddress and SubnetMask do not exist in old IPv4_DEVICE_PATH, this will lead new IScsiDxe to error if IPv4_DEVICE_PATH in system is not updated. Following UEFI2.5 spec of IPv4_DEVICE_PATH do a

Re: [edk2] [PATCH] CryptoPkg: OpensslLib: reintroduce EFIAPI for ERR_add_error_data()

2015-07-23 Thread Laszlo Ersek
On 07/23/15 01:06, David Woodhouse wrote: On Thu, 2015-07-23 at 00:44 +0200, Laszlo Ersek wrote: I guess it should work at the moment (and -UNO_BUILTIN_VA_FUNCS would be easy enough to add under [BuildOptions] in CryptoPkg/Library/OpensslLib/OpensslLib.inf). But, as soon as a genuinely

Re: [edk2] [PATCH] CryptoPkg: OpensslLib: reintroduce EFIAPI for ERR_add_error_data()

2015-07-23 Thread Laszlo Ersek
On 07/23/15 12:31, Laszlo Ersek wrote: On 07/23/15 01:06, David Woodhouse wrote: Well, why don't we just add -mabi=ms to the compiler flags? Then EFIAPI in the source code could be a no-op, right? Yes, I think EFIAPI would be a no-op then. I don't know why we don't set -mabi=ms globally

Re: [edk2] [PATCH] CryptoPkg: OpensslLib: reintroduce EFIAPI for ERR_add_error_data()

2015-07-22 Thread Laszlo Ersek
On 07/22/15 23:07, David Woodhouse wrote: On Tue, 2015-06-23 at 09:54 -0400, Peter Jones wrote: On Tue, Jun 23, 2015 at 03:34:25PM +0200, Laszlo Ersek wrote: Git commit f93f78ea70 (SVN r17633), with subject CryptoPkg: Update openssl patch file from 0.9.8zf to 1.0.2c, replaced the file

Re: [edk2] [PATCH V3 1/4] MdePkg|EmulatorPkg: Update comment for PcdDefaultTerminalType

2015-07-16 Thread Laszlo Ersek
On 07/16/15 06:45, Jordan Justen wrote: Can you just split this into two patches? I think we should keep patches confined to updating a single module unless there is a technical reason to touch separate packages in a single patch. Or, I suppose if you are making the *exact* same change to

Re: [edk2] [PATCH V3 2/4] ArmVirtPkg: Make terminal type consistent

2015-07-16 Thread Laszlo Ersek
TTY_TERMINAL is not TRUE. + ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1 !endif gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 Reviewed-by: Laszlo Ersek ler...@redhat.com

Re: [edk2] Farewell - last days at ARM Ltd

2015-07-16 Thread Laszlo Ersek
Hi Olivier, On 07/16/15 01:41, Olivier Martin wrote: For people who does not know me I have been the EDK2 maintainer of the ARM Packages for the last 4 years. I took over the excellent work Andrew Fish and Eugene Cohen started few years before. This week was my last week at ARM - my last

Re: [edk2] [PATCH V3 3/4] MdeModulePkg/TerminalDxe: Set NullRemaining to FALSE by default

2015-07-16 Thread Laszlo Ersek
On 07/16/15 04:09, Heyi Guo wrote: This is bug fix for TerminalDxe: NullRemaining should be set to FALSE by fault and then be set to TRUE conditionally. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo heyi@linaro.org ---

Re: [edk2] [PATCH V4 0/5] Some improvements on serial terminal

2015-07-16 Thread Laszlo Ersek
. Cc: Michael D Kinney michael.d.kin...@intel.com Cc: Liming Gao liming@intel.com Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Andrew Fish af...@apple.com Cc: Laszlo Ersek ler...@redhat.com Cc: Ard Biesheuvel ard.biesheu...@linaro.org Cc: Feng Tian feng.t...@intel.com Cc: Ruiyu

Re: [edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

2015-07-16 Thread Laszlo Ersek
works on both x86 and ARM, while some other code (which happens to be Xen code) only works on x86. The patch just separates the x86-only code out. Thanks! Laszlo On Thu, Jul 16, 2015 at 12:41:18AM +0200, Laszlo Ersek wrote: The Xen code in SmbiosPlatformDxe is centered on the informational HOB

Re: [edk2] upload two drivers

2015-07-15 Thread Laszlo Ersek
On 07/14/15 23:49, Andrew Fish wrote: On Jul 14, 2015, at 2:21 PM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/14/15 20:31, S.Vieira wrote: Hi everyone. It's possible to do upload of two drives just in ONE .efi I am wanting to do upload

Re: [edk2] MTRR setup in OVMF [was: PATCH v3 01/10 KVM: MMU: fix decoding cache type from MTRR]

2015-07-15 Thread Laszlo Ersek
On 07/15/15 00:37, Jordan Justen wrote: On 2015-07-14 14:29:11, Laszlo Ersek wrote: On 07/14/15 23:15, Paolo Bonzini wrote: The long delay that Alex reported (for the case when all guest memory was set to UC up-front) is due to the fact that the SEC phase of OVMF decompresses an approximately

Re: [edk2] [PATCH 2/2] MdePkg: remove PcdDefaultTerminalType

2015-07-15 Thread Laszlo Ersek
On 07/15/15 10:59, Ard Biesheuvel wrote: On 15 July 2015 at 08:26, Gao, Liming liming@intel.com wrote: Ard: From compatible view, I don't prefer to make this change. The driver in other EDKII package may use this PCD. After this change, they will build break. I suggest to keep this

Re: [edk2] [PATCH V2 1/3] ArmVirtPkg: Make terminal type consistent

2015-07-15 Thread Laszlo Ersek
Heyi, On 07/13/15 13:22, Ard Biesheuvel wrote: On 13 July 2015 at 13:15, Laszlo Ersek ler...@redhat.com wrote: On 07/13/15 05:24, Heyi Guo wrote: Change default terminal type to be consistent with default ConIn/ConOut device path, which is now determined by TTY_TERMINAL flag, TTYTERM

Re: [edk2] MTRR setup in OVMF [was: PATCH v3 01/10 KVM: MMU: fix decoding cache type from MTRR]

2015-07-15 Thread Laszlo Ersek
On 07/15/15 21:30, Xiao Guangrong wrote: Hi, I have posted the pachset to make OVMF happy and have CCed you guys, could you please check it if it works for you? Sorry, I can't check it; I don't have an environment that exposes the issue in the first place. Perhaps Alex can check it, or

[edk2] [PATCH 6/6] ArmVirtPkg/ArmVirtQemu: support SMBIOS

2015-07-15 Thread Laszlo Ersek
Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- ArmVirtPkg/ArmVirtQemu.dsc | 6 ++ ArmVirtPkg/ArmVirtQemu.fdf | 6 ++ 2 files changed, 12 insertions(+) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index f5dd8a3..9570cc2 100644 --- a/ArmVirtPkg

[edk2] [PATCH 5/6] ArmVirtPkg: QemuFwCfgToPcdDxe: set SMBIOS entry point version dynamically

2015-07-15 Thread Laszlo Ersek
. Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf | 4 ++ ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.c | 40 ArmVirtPkg

[edk2] [PATCH 3/6] MdeModulePkg: SmbiosDxe: ARM and AARCH64 are VALID_ARCHITECTURES

2015-07-15 Thread Laszlo Ersek
: Star Zeng star.z...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf

[edk2] [PATCH 4/6] ArmVirtPkg: add QemuFwCfgToPcdDxe

2015-07-15 Thread Laszlo Ersek
. Actual fw_cfg files and PCDs shall be accessed in future patches. Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- ArmVirtPkg/QemuFwCfgToPcdDxe/QemuFwCfgToPcd.inf | 42

[edk2] [PATCH 2/6] OvmfPkg: SmbiosPlatformDxe: restrict current Xen code to IA32/X64

2015-07-15 Thread Laszlo Ersek
Justen jordan.l.jus...@intel.com Cc: Wei Liu wei.l...@citrix.com Cc: Gabriel Somlo so...@cmu.edu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 12 OvmfPkg/SmbiosPlatformDxe

Re: [edk2] upload two drivers

2015-07-15 Thread Laszlo Ersek
On 07/15/15 15:40, Andrew Fish wrote: On Jul 15, 2015, at 2:55 AM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: On 07/14/15 23:49, Andrew Fish wrote: On Jul 14, 2015, at 2:21 PM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com mailto:ler...@redhat.com wrote

Re: [edk2] [PATCH V2 1/3] ArmVirtPkg: Make terminal type consistent

2015-07-14 Thread Laszlo Ersek
On 07/14/15 12:27, Ard Biesheuvel wrote: On 14 July 2015 at 12:18, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 14 July 2015 at 12:15, Laszlo Ersek ler...@redhat.com wrote: On 07/13/15 13:34, Laszlo Ersek wrote: On 07/13/15 13:22, Ard Biesheuvel wrote: On 13 July 2015 at 13:15, Laszlo

Re: [edk2] [PATCH V2 1/3] ArmVirtPkg: Make terminal type consistent

2015-07-14 Thread Laszlo Ersek
On 07/13/15 13:34, Laszlo Ersek wrote: On 07/13/15 13:22, Ard Biesheuvel wrote: On 13 July 2015 at 13:15, Laszlo Ersek ler...@redhat.com wrote: On 07/13/15 05:24, Heyi Guo wrote: Change default terminal type to be consistent with default ConIn/ConOut device path, which is now determined

Re: [edk2] [PATCH 1/2] MdeModulePkg|EmulatorPkg: add definition for PcdDefaultTerminalType

2015-07-14 Thread Laszlo Ersek
the idea behind it. In any case, 0x006e is used in the same section just a little bit higher. So this looks good to me. Reviewed-by: Laszlo Ersek ler...@redhat.com -- Don't Limit Your Business. Reach for the Cloud

Re: [edk2] [PATCH v3 23/23] OvmfPkg: QemuBootOrderLib: recognize extra PCI root buses

2015-07-14 Thread Laszlo Ersek
On 07/14/15 01:18, Jordan Justen wrote: Reviewed-by: Jordan Justen jordan.l.jus...@intel.com Greatly appreciated! I committed the series to SVN as r17943 through r17965, inclusive. Now back to the end-of-dxe series... :) Thanks! Laszlo On 2015-07-07 08:09:25, Laszlo Ersek wrote: The OFW

[edk2] [PATCH v2 4/6] IntelFrameworkModulePkg/GenericBdsLib: remove AcpiS3-S3Save() call

2015-07-14 Thread Laszlo Ersek
in BdsLibBootViaBootOption() violates the ordering constraints, and should be removed. Since it is the responsibility of the platform BDS to signal the end-of-DXE event, it should also perform the AcpiS3-S3Save() call at an appropriate time. Commit message update from Laszlo Ersek ler...@redhat.com

[edk2] [PATCH v2 1/6] OvmfPkg: AcpiS3SaveDxe: prepare for End-of-Dxe callback

2015-07-14 Thread Laszlo Ersek
that we actually don't even have any use for that parameter. This patch ports the identical change from IntelFrameworkModulePkg to OvmfPkg. Cc: Jordan Justen jordan.l.jus...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com Reviewed

[edk2] [PATCH v2 3/6] OvmfPkg: PlatformBdsLib: signal End-of-Dxe event group

2015-07-14 Thread Laszlo Ersek
...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- Notes: v2: - split End-of-Dxe signalling into standalone patch [Jordan] OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf | 3 ++ OvmfPkg/Library/PlatformBdsLib/BdsPlatform.h

[edk2] [PATCH v2 6/6] OvmfPkg: AcpiS3SaveDxe: drop EFI_ACPI_S3_SAVE_PROTOCOL

2015-07-14 Thread Laszlo Ersek
At this point, nothing in the OVMF build calls EFI_ACPI_S3_SAVE_PROTOCOL member functions; simplify the code by dropping this protocol interface. Cc: Jordan Justen jordan.l.jus...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com

[edk2] [PATCH v2 2/6] OvmfPkg: AcpiS3SaveDxe: call S3Ready() at End-of-Dxe

2015-07-14 Thread Laszlo Ersek
: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Jordan Justen jordan.l.jus...@intel.com --- Notes: v2: - unchanged OvmfPkg/AcpiS3SaveDxe/AcpiS3SaveDxe.inf | 1 + OvmfPkg/AcpiS3SaveDxe/AcpiS3Save.c | 46 2 files

[edk2] [PATCH v2 0/6] OvmfPkg: save S3 state at EndOfDxe

2015-07-14 Thread Laszlo Ersek
-S3Save() call Laszlo Ersek (5): OvmfPkg: AcpiS3SaveDxe: prepare for End-of-Dxe callback OvmfPkg: AcpiS3SaveDxe: call S3Ready() at End-of-Dxe OvmfPkg: PlatformBdsLib: signal End-of-Dxe event group OvmfPkg: install DxeSmmReadyToLock in PlatformBdsLib OvmfPkg: AcpiS3SaveDxe: drop

[edk2] [PATCH v2 5/6] OvmfPkg: install DxeSmmReadyToLock in PlatformBdsLib

2015-07-14 Thread Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com --- Notes: v2: - move SaveS3BootScript() function definition and call from OvmfPkg/AcpiS3SaveDxe to OvmfPkg/Library/PlatformBdsLib in a separate patch [Jordan] OvmfPkg

[edk2] MTRR setup in OVMF [was: PATCH v3 01/10 KVM: MMU: fix decoding cache type from MTRR]

2015-07-14 Thread Laszlo Ersek
Cross-posting to edk2-devel. Original sub-thread starts here: http://thread.gmane.org/gmane.linux.kernel/1952205/focus=1994315 On 07/13/15 17:15, Xiao Guangrong wrote: On 07/13/2015 11:13 PM, Paolo Bonzini wrote: On 13/07/2015 16:45, Xiao Guangrong wrote: +/* MTRR is completely

Re: [edk2] MTRR setup in OVMF [was: PATCH v3 01/10 KVM: MMU: fix decoding cache type from MTRR]

2015-07-14 Thread Laszlo Ersek
On 07/14/15 23:15, Paolo Bonzini wrote: The long delay that Alex reported (for the case when all guest memory was set to UC up-front) is due to the fact that the SEC phase of OVMF decompresses an approximately 1712 KB sized, LZMA-compressed blob, to approx. 896 KB worth of PEI drivers and 8192

Re: [edk2] upload two drivers

2015-07-14 Thread Laszlo Ersek
On 07/14/15 20:31, S.Vieira wrote: Hi everyone. It's possible to do upload of two drives just in ONE .efi I am wanting to do upload of the AtaAtapiPassThruDxe and AtaBusDxe only in ONE file. I think it should be possible to install any number of driver binding protocol instances in a

Re: [edk2] BUG in properties table feature implementation

2015-07-14 Thread Laszlo Ersek
On 06/29/15 20:10, Ard Biesheuvel wrote: On 29 June 2015 at 17:12, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 29 June 2015 at 17:09, Matt Fleming m...@codeblueprint.co.uk wrote: On Mon, 29 Jun, at 03:06:32PM, Laszlo Ersek wrote: In any case, for OVMF, I think we'll need a small patch

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-13 Thread Laszlo Ersek
On 07/12/15 08:24, B Cran wrote: On Jul 11, 2015, at 11:42 PM, Jordan Justen jordan.l.jus...@intel.com wrote: It could be that the move to git will make it more feasible to have a testing branch that could allow all patches to first be tested against all toolchains. But, personally I'm

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-13 Thread Laszlo Ersek
:09, Scott Duplichan wrote: ] Bruce Cran [mailto:br...@cran.org.uk] wrote: ] ] ]Sent: Wednesday, July 08, 2015 05:12 PM ] ]To: edk2-devel@lists.sourceforge.net ] ]Subject: Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables ] ] ] ]On Wed, Jul 08, 2015 at 10:43:38PM +0200, Laszlo

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-13 Thread Laszlo Ersek
On 07/12/15 04:53, Bruce Cran wrote: On Wed, Jul 08, 2015 at 09:02:10PM +0200, Laszlo Ersek wrote: My lack of faith is based on experience :) We've been complaining about this for ages on the list. I think it is safe to assume that the primary participant that has legal access to all

Re: [edk2] [PATCH V2 1/3] ArmVirtPkg: Make terminal type consistent

2015-07-13 Thread Laszlo Ersek
. + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1 !endif gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3 Reviewed-by: Laszlo Ersek ler...@redhat.com -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you

Re: [edk2] [PATCH V2 1/3] ArmVirtPkg: Make terminal type consistent

2015-07-13 Thread Laszlo Ersek
On 07/13/15 13:22, Ard Biesheuvel wrote: On 13 July 2015 at 13:15, Laszlo Ersek ler...@redhat.com wrote: On 07/13/15 05:24, Heyi Guo wrote: Change default terminal type to be consistent with default ConIn/ConOut device path, which is now determined by TTY_TERMINAL flag, TTYTERM or VT100. I

Re: [edk2] [PATCH 8/8] ArmVirtPkg/ArmVirtQemu.dsc: Remove Linux specific boot path

2015-07-13 Thread Laszlo Ersek
On 07/13/15 18:36, Olivier Martin wrote: PcdDefaultBootType has been removed when the embedded Linux Loader has been removed from BdsLib. The boot arguments (defined by PcdDefaultBootArgument) are now always targetting EFI applications. Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 0/2] MdePkg|MdeModulePkg: constify mStatusString

2015-07-13 Thread Laszlo Ersek
CONST MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c | 2 +- MdePkg/Library/BasePrintLib/PrintLibInternal.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Laszlo Ersek ler...@redhat.com

Re: [edk2] [PATCH] Avoid variable set but not used warning from GCC.

2015-07-10 Thread Laszlo Ersek
); if (AsciiStrCmp (Name, FName) == 0) { Reviewed-by: Laszlo Ersek ler...@redhat.com I committed the patch (with a slight update to the subject) to SVN as r17920. Thank you. Laszlo -- Don't Limit Your Business

Re: [edk2] [PATCH] Avoid variable set but not used warning from GCC.

2015-07-10 Thread Laszlo Ersek
. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Bill Paul wp...@windriver.com You should add Cc's here (package owners are in Maintainers.txt): Cc: Jordan Justen jordan.l.jus...@intel.com Cc: Laszlo Ersek ler...@redhat.com Agree, but ultimately both of us noticed the patch

Re: [edk2] [PATCH] CryptoPkg: update OpenSSL dependency to version 1.0.2d

2015-07-10 Thread Laszlo Ersek
-by: Laszlo Ersek ler...@redhat.com -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus on growing your business

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
On 07/10/15 10:40, Wu, Jiaxin wrote: Yes, edk2-devel will strip it. You can check version2 for those series patches, I had added someone with cc tag to the commit message, but it haven't actually cc to those people. Yes, you did! I *did* get a personal copy of the v2 patches from you! (And

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
sorted out once we move to the new mailing list. Thank you! Laszlo Thanks again. Jiaxin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, July 10, 2015 7:29 PM To: Wu, Jiaxin Cc: Justen, Jordan L; edk2-devel@lists.sourceforge.net; af...@apple.com

Re: [edk2] [PATCH] OvmfPkg/VirtioLib: Ensure VirtioFlush() is not blocked

2015-07-10 Thread Laszlo Ersek
: http://people.redhat.com/~lersek/arm_case566785_queuepfn_repro/ The model team at ARM fixed the bug for the next release. It was a positive experience for me. Thanks! Laszlo -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: 09 July 2015 18:30 To: Olivier Martin

Re: [edk2] [PATCH v3 3/7] EmulatorPkg: Remove Ip4ConfigDxe module from EmulatorPkg

2015-07-10 Thread Laszlo Ersek
On 07/10/15 18:36, Jordan Justen wrote: On 2015-07-10 04:29:11, Laszlo Ersek wrote: On 07/10/15 10:40, Wu, Jiaxin wrote: Yes, edk2-devel will strip it. You can check version2 for those series patches, I had added someone with cc tag to the commit message, but it haven't actually cc to those

Re: [edk2] [PATCH] BaseTools: aarch64: add -fno-asynchronous-unwind-tables to gcc cflags

2015-07-09 Thread Laszlo Ersek
archive, but I'm attaching it. Thanks Laszlo ---BeginMessage--- I can confirm that this patch fixes my problem. The machine is a native AArch64 server, with Fedora GCC 4.8.3. Thanks, -Wei On 03/04/2015 03:13 AM, Laszlo Ersek wrote: On 02/06/15 14:52, Leif Lindholm wrote: Some toolchains, at least

Re: [edk2] [PATCH] OvmfPkg/VirtioLib: Ensure VirtioFlush() is not blocked

2015-07-09 Thread Laszlo Ersek
On 07/09/15 18:47, Olivier Martin wrote: .. in case the platform does not received the used buffer from the device, VirtioFlush() returns EFI_TIMEOUT. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Olivier Martin olivier.mar...@arm.com ---

Re: [edk2] [Patch] OvmfPkg: Fix GCC49 build hang in PeiCore

2015-07-09 Thread Laszlo Ersek
On 07/09/15 09:13, Ruiyu Ni wrote: PeiCore hang when loads a PEIM whose section alignment requirement is 0x40 but the actual base address is 0x20 aligned. Thank you very much for tracking this down! However, can you please describe the analysis (that you must have certainly done to identify

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

2015-07-09 Thread Laszlo Ersek
On 07/09/15 08:45, Paolo Bonzini wrote: On 08/07/2015 23:03, Laszlo Ersek wrote: On 07/08/15 22:36, Ryan Harkin wrote: I have an alias in my ~/.gitconfig file: [alias] amm=am --ignore-whitespace --ignore-space-change Then I use git amm to apply patches and that seems to work most

Re: [edk2] [PATCH v3 2/7] ArmVirtPkg: Remove Ip4ConfigDxe module from ArmVirtPkg

2015-07-09 Thread Laszlo Ersek
/Tcp4Dxe/Tcp4Dxe.inf Reviewed-by: Laszlo Ersek ler...@redhat.com -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs

Re: [edk2] [Patch V2] OvmfPkg: Fix GCC49 build hang in PeiCore

2015-07-09 Thread Laszlo Ersek
rules spell out Align=whatever). Superb work! Reviewed-by: Laszlo Ersek ler...@redhat.com I'm going to commit your patch right away (I'll just rewrap the commit message to 74 characters first). Thank you! Laszlo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

2015-07-09 Thread Laszlo Ersek
specification Laszlo Ersek (1): Add PCD for selecting terminal type at build time Roy Franz (4): Add TtyTerm terminal type to TerminalDxe Treat ASCII 0x7F as backspace for TtyTerm terminals Accept VT220 DEL and function keys for TTY terminal type add TTY_TERMINAL build option

Re: [edk2] [PATCH v3 5/7] OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg

2015-07-09 Thread Laszlo Ersek
/Ip6Dxe.inf Reviewed-by: Laszlo Ersek ler...@redhat.com -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload your IT needs and focus

Re: [edk2] [PATCH v3 7/7] MdeModulePkg: Remove Ip4ConfigDxe and related guid definition

2015-07-09 Thread Laszlo Ersek
delete mode 100644 MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.c delete mode 100644 MdeModulePkg/Universal/Network/Ip4ConfigDxe/NicIp4Variable.h Reviewed-by: Laszlo Ersek ler...@redhat.com -- Don't

Re: [edk2] [Patch V2] OvmfPkg: Fix GCC49 build hang in PeiCore

2015-07-09 Thread Laszlo Ersek
Committed as SVN r17902. Thanks! Laszlo On 07/09/15 10:06, Ruiyu Ni wrote: PeiCore hang when loads a PEIM whose section alignment requirement is 0x40 but the actual base address is 0x20 aligned. The issue is caused by the following facts, in order: 1. GCC49 requires the section alignment of

Re: [edk2] [Patch] BaseTools: Fix BinWrappers LzmaF86Compress Script

2015-07-09 Thread Laszlo Ersek
=--f86 break; fi done Reviewed-by: Laszlo Ersek ler...@redhat.com -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need to offload

Re: [edk2] Source code for network devices?

2015-07-09 Thread Laszlo Ersek
On 07/09/15 19:46, Ralph Campbell wrote: I was searching the edk2 code for network device drivers but I could only find 3: EmbeddedPkg/Drivers/Lan9118Dxe/* OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/* OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/* Does anyone know of other examples? (1)

Re: [edk2] [PATCH v3 21/23] OvmfPkg: PciHostBridgeDxe: shorten search for extra root buses

2015-07-08 Thread Laszlo Ersek
On 07/08/15 02:38, Jordan Justen wrote: On 2015-07-07 08:09:23, Laszlo Ersek wrote: QEMU provides an fw_cfg file called etc/extra-pci-roots, containing a How long were the extra roots in qemu without the fw_cfg entry? Not at all. Please see QEMU commit 2118196bb. That patch, adding

Re: [edk2] [Patch 3/7] OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg.

2015-07-08 Thread Laszlo Ersek
-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 7, 2015 8:56 PM To: Wu, Jiaxin Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 3/7] OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg. On 07/07/15 03:27, jiaxinwu wrote: Contributed

Re: [edk2] [PATCH v2 5/7] ArmVirtPkg: Remove Ip4ConfigDxe module from ArmVirtPkg.

2015-07-08 Thread Laszlo Ersek
. (Please don't forget to customize PackageName in the subject line as appropriate.) Thanks Laszlo Cc: Laszlo Ersek ler...@redhat.com Cc: Ard Biesheuvel ard.biesheu...@linaro.org Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: jiaxinwu jiaxin...@intel.com

Re: [edk2] OVMF for Xeon

2015-07-08 Thread Laszlo Ersek
On 07/08/15 12:27, tiger...@zhaoxin.com wrote: Hi, Laszlo: I have a question about OVMF package. 1. Qemu could emulate Xeon CPU, so OVMF firmware could run with Xeon in Qemu? Yes, why not. We have a few AsmCpuid() calls in OvmfPkg (and probably many more in modules that OvmfPkg pulls in),

Re: [edk2] [patch] MdemodulePkg: fix the problem that data type conversion may loss data

2015-07-08 Thread Laszlo Ersek
On 07/08/15 11:29, Zhang Lubo wrote: Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo lubo.zh...@intel.com --- MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Support.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [edk2] [PATCH] MdePkg: Refine INF file for SmmMemLib.

2015-07-08 Thread Laszlo Ersek
On 07/08/15 09:53, Qiu Shumin wrote: Add [Depex] section and update protocol usage. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin shumin@intel.com CC: Liming Gao liming@intel.com CC: Yao, Jiewen jiewen@intel.com ---

Re: [edk2] [PATCH v2 0/7] Remove Ip4ConfigDxe module and related guid definitions from related packages.

2015-07-08 Thread Laszlo Ersek
On 07/08/15 09:21, Wu, Jiaxin wrote: For question1: I have really add the commit message in v2 patches(highlight below). Did I misunderstand? You added a description to the cover letter (email 0/7), but whatever you write there will never reach the repo commit log, because the 0/7 email (the

Re: [edk2] I don't understand EmulatorPkg

2015-07-08 Thread Laszlo Ersek
On 07/08/15 01:17, Shubha Ramani wrote: [...] Here's a polite request: - please stop posting HTML mail - if you are forced at gunpoint to post HTML mail, please, for the sake of all subscribers, stop posting with 24px sized and/or x-large fonts. It looks extremely unprofessional and is a

Re: [edk2] [PATCH v2 1/7] MdeModulePkg: Remove Ip4ConfigDxe module and related guid definition from MdeModulePkg.

2015-07-08 Thread Laszlo Ersek
comments below On 07/08/15 08:24, jiaxinwu wrote: Version2 update with a proper commit message. Cc: Feng Tian feng.t...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: jiaxinwu jiaxin...@intel.com --- MdeModulePkg/Include/Guid/Ip4ConfigHii.h |

Re: [edk2] [PATCH v3 20/23] OvmfPkg: PciHostBridgeDxe: look for all root buses

2015-07-08 Thread Laszlo Ersek
On 07/08/15 02:32, Jordan Justen wrote: On 2015-07-07 08:09:22, Laszlo Ersek wrote: In this patch we assume that root bus number 0 is always there (same as before), and scan the rest of the extra root buses, up to and including 255. When an extra root bus is found, we install the PCI root

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

2015-07-08 Thread Laszlo Ersek
On 07/08/15 04:46, Heyi Guo wrote: Hi Roy, I have one question; please see my comments below. Indeed: On 07/08/2015 08:44 AM, Roy Franz wrote: From: Laszlo Ersek ler...@redhat.com Add a fixed pointer PCD to allow build-time selection of VT100 or TTY terminal type. The default

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
RELEASE_GCC49_*_CC_FLAGS at most. ... Actually, we already have -Wno-unused-but-set-variable in a bunch of places in BaseTools/Conf/tools_def.template, so I'd rather propose the attached patch. Thanks Laszlo From 418cc4a23d3c7c6cd6bb130bbbd670a99e6d544e Mon Sep 17 00:00:00 2001 From: Laszlo Ersek

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
On 07/08/15 17:02, Ard Biesheuvel wrote: On 8 July 2015 at 16:59, Olivier Martin olivier.mar...@arm.com wrote: For ARM architectures, I only disable this flag for RELEASE build: OK, I hadn't noticed that. This means my patch would be only for the convenience of the Intel engineers (and my

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
On 07/08/15 17:28, Scott Duplichan wrote: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: ]Sent: Wednesday, July 08, 2015 08:24 AM ]To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; olivier.mar...@arm.com; leif.lindh...@linaro.org; ]jordan.l.jus...@intel.com ]Subject:

Re: [edk2] [Patch 3/7] OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg.

2015-07-08 Thread Laszlo Ersek
- Thanks for everyone's great comments. Best Regards! Jiaxin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, July 8, 2015 6:33 PM To: Wu, Jiaxin Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch 3/7] OvmfPkg: Remove

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

2015-07-08 Thread Laszlo Ersek
On 07/08/15 22:36, Ryan Harkin wrote: I have an alias in my ~/.gitconfig file: [alias] amm=am --ignore-whitespace --ignore-space-change Then I use git amm to apply patches and that seems to work most of the time. But I suspect your method is doing something smarter and more

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
On 07/08/15 21:26, Andrew Fish wrote: On Jul 8, 2015, at 12:02 PM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: It should be noted that once in a while I run into this sort of thing in VxWorks as well, only it's often the other way around. We typically have DEBUG

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
On 07/09/15 01:42, Jordan Justen wrote: On 2015-07-08 08:58:04, Laszlo Ersek wrote: On 07/08/15 17:02, Ard Biesheuvel wrote: On 8 July 2015 at 16:59, Olivier Martin olivier.mar...@arm.com wrote: For ARM architectures, I only disable this flag for RELEASE build: OK, I hadn't noticed

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

2015-07-08 Thread Laszlo Ersek
- nothing linux specific in patchset * remove changes to Mde module, as changes not part of UEFI specification Laszlo Ersek (1): Add PCD for selecting terminal type at build time Roy Franz (4): Add TtyTerm terminal type to TerminalDxe Treat ASCII 0x7F as backspace for TtyTerm terminals

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
On 07/08/15 22:53, Andrew Fish wrote: On Jul 8, 2015, at 1:43 PM, Laszlo Ersek ler...@redhat.com mailto:ler...@redhat.com wrote: https://svn.code.sf.net/p/edk2/code/trunk/edk2/MdePkg/Include/Library/DebugLib.h #if !defined(MDEPKG_NDEBUG) #define ASSERT(Expression)\ do

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
, Laszlo Ersek wrote: ] ] I think it would make a difference if -flto *actually* worked, but from ] a quick google search, I think it either doesn't work with gcc-4.8 at ] all, *or* the edk2 build system would have to use FLTO-aware binutils ] and linker wrappers (or parameters). I have no clue how

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

2015-07-08 Thread Laszlo Ersek
On 07/08/15 20:15, Bill Paul wrote: Of all the gin joints in all the towns in all the world, Laszlo Ersek had to walk into mine at 09:17:08 on Wednesday 08 July 2015 and say: In the above pattern, ASSERT_EFI_ERROR() is not necessarily used for error handling. You are absolutely right

Re: [edk2] [PATCH V4 5/5] add TTY_TERMINAL build option for ARM BDS

2015-07-08 Thread Laszlo Ersek
, but I won't risk you throwing a keyboard at me, should we ever meet in person, so I won't insist ;) Reviewed-by: Laszlo Ersek ler...@redhat.com -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions

Re: [edk2] [PATCH v2 02/24] PcAtChipsetPkg: remove PciHostBridgeDxe

2015-07-07 Thread Laszlo Ersek
On 07/07/15 02:52, Jordan Justen wrote: On 2015-07-06 15:10:45, Laszlo Ersek wrote: On 06/28/15 01:36, Jordan Justen wrote: On 2015-06-25 21:26:20, Ni, Ruiyu wrote: Jordan, Simply using PCD to split the code is very straightforward. Another approach is to introduce a new library class

Re: [edk2] [PATCH 1/3] ArmVirtPkg: Make terminal type consistent

2015-07-07 Thread Laszlo Ersek
comments below On 07/07/15 18:56, Heyi Guo wrote: Change default terminal type to be VT100, to make it consistent with default ConIn/ConOut device path. I can't say this is a bug, as we can pass the whole console device path to ConnectController, and TerminalDxe driver will pick up the

Re: [edk2] [PATCH 1/3] ArmVirtPkg: Make terminal type consistent

2015-07-07 Thread Laszlo Ersek
On 07/07/15 22:16, Roy Franz wrote: On Tue, Jul 7, 2015 at 11:47 AM, Laszlo Ersek ler...@redhat.com wrote: comments below On 07/07/15 18:56, Heyi Guo wrote: Change default terminal type to be VT100, to make it consistent with default ConIn/ConOut device path. I can't say this is a bug

Re: [edk2] [PATCH V2 3/4] Accept VT220 DEL and function keys for TTY terminal type

2015-07-07 Thread Laszlo Ersek
On 07/07/15 22:25, Ard Biesheuvel wrote: On 7 July 2015 at 22:07, Roy Franz roy.fr...@linaro.org wrote: On Tue, Jul 7, 2015 at 6:18 AM, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 7 July 2015 at 01:04, Roy Franz roy.fr...@linaro.org wrote: Accept the VT220 escape code [3~ as backspace

[edk2] [PATCH v3 03/23] PcAtChipsetPkg/PciHostBridgeDxe/PciHostBridge.h: rewrap comments to 79 columns

2015-07-07 Thread Laszlo Ersek
Cc: Ruiyu Ni ruiyu...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com Regression-tested-by: Gabriel Somlo so...@cmu.edu Reviewed-by: Ruiyu Ni ruiyu...@intel.com --- Notes: v3: - rewrap the driver under PcAtChipsetPkg

[edk2] [PATCH v3 01/23] PcAtChipsetPkg: PciHostBridgeDxe: rewrap IoFifo source files to 79 columns

2015-07-07 Thread Laszlo Ersek
Cc: Ruiyu Ni ruiyu...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com Regression-tested-by: Gabriel Somlo so...@cmu.edu Reviewed-by: Ruiyu Ni ruiyu...@intel.com --- Notes: v3: - rewrap the driver under PcAtChipsetPkg

[edk2] [PATCH v3 04/23] PcAtChipsetPkg/PciHostBridgeDxe/PciHostBridge.h: strip trailing ws from code

2015-07-07 Thread Laszlo Ersek
Cc: Ruiyu Ni ruiyu...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com Regression-tested-by: Gabriel Somlo so...@cmu.edu Reviewed-by: Ruiyu Ni ruiyu...@intel.com --- Notes: v3: - rewrap the driver under PcAtChipsetPkg

[edk2] [PATCH v3 07/23] PcAtChipsetPkg/PciHostBridgeDxe/PciRootBridgeIo.c: rewrap leading comments

2015-07-07 Thread Laszlo Ersek
Cc: Ruiyu Ni ruiyu...@intel.com Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek ler...@redhat.com Regression-tested-by: Gabriel Somlo so...@cmu.edu Reviewed-by: Ruiyu Ni ruiyu...@intel.com --- Notes: v3: - rewrap the driver under PcAtChipsetPkg

[edk2] [PATCH v3 00/23] OvmfPkg: support extra PCI root buses

2015-07-07 Thread Laszlo Ersek
...@cmu.edu Laszlo Ersek (23): PcAtChipsetPkg: PciHostBridgeDxe: rewrap IoFifo source files to 79 columns PcAtChipsetPkg: PciHostBridgeDxe: rewrap INF file to 79 columns PcAtChipsetPkg/PciHostBridgeDxe/PciHostBridge.h: rewrap comments to 79 columns PcAtChipsetPkg/PciHostBridgeDxe

  1   2   3   4   5   6   7   8   9   10   >