Can you update to latest version? The check-in attached fixed the issue.
From: Tony [mailto:tony...@hotmail.com]
Sent: Thursday, July 16, 2015 1:49 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] FW: edk2 build problems
Hi there, I get the error below whe
text console.
Thanks,
Ray
> -Original Message-
> From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
> Sent: Thursday, July 16, 2015 10:42 AM
> To: Carsey, Jaben; Gao, Liming; edk2-devel@lists.sourceforge.net
> Subject: Re: [edk2] [Patch] MdeModulePkg: Correct PcdConOutColum
Jaben,
Partially right. When row and col is 0, core will try to use the native
resolution of that monitor. Native resolution concept only applies to LCD/TFT
monitor, not legacy CRT monitor. It may have maximum col, or maximum row, or
both.
> -Original Message-
> From: Carsey, Jaben [mai
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Heyi Guo [mailto:heyi@linaro.org]
> Sent: Wednesday, July 8, 2015 12:57 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH 2/3] MdeModulePkg: TerminalDxe: Fix bug of
> NullRemaining flag
>
> NullRemaining should be s
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Heyi Guo [mailto:heyi@linaro.org]
> Sent: Wednesday, July 8, 2015 12:57 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH 3/3] MdeModulePkg: Some improvements on
> TerminalDxe
>
> 1. Get default terminal type from PC
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, July 9, 2015 3:25 PM
> To: edk2-devel@lists.sourceforge.net; Ni, Ruiyu
> Subject: [PATCH v3 4/7] Nt32Pkg: Remove Ip4ConfigDxe module from
> Nt32Pkg
>
> Version3 continue to upd
t in QEMU 1.6.2
>
> On 07/07/15 08:47, Ni, Ruiyu wrote:
> > Hi,
> >
> > I found OVMF built from the latest source tree cannot boot in QEMU 1.6.2
> > (Ubuntu14.04.1).
> >
> > Is it related to the changes made to OvmfPkg?
>
> I can't tell offhand
Jordan,
Sure. I will submit patch to delete it if no one is using it. In fact, one of
my colleagues disagreed to remove this driver since he is using it in his
project.:)
Thanks,
Ray
> -Original Message-
> From: Justen, Jordan L
> Sent: Wednesday, July 8, 2015 7:51 AM
> T
Laszlo,
Sure. If there is no functionality change and just re-formatting, I accept.
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, July 7, 2015 7:12 PM
> To: Ni, Ruiyu
> Cc: Justen, Jordan L; edk2-devel@lists.
Hi,
I found OVMF built from the latest source tree cannot boot in QEMU 1.6.2
(Ubuntu14.04.1).
Is it related to the changes made to OvmfPkg?
Boot log as following:
--
SecCoreStartupWithStack(0xFFFCC000, 0x818000)
Register PPI Notify: DCD0BE23-9586-40F4-B643-06522CED4EDE
Install PPI:
But maybe in one step, maybe in
several steps.
Thanks,
Ray
> -Original Message-
> From: Justen, Jordan L
> Sent: Tuesday, July 7, 2015 8:53 AM
> To: Laszlo Ersek; Ni, Ruiyu
> Cc: edk2-devel@lists.sourceforge.net; Kinney, Michael D; Gerd Hoffmann
> Subject: Re: [edk2]
Martin,
Please go ahead to check in the patch first. I will send new patch for review
later when I have bandwidth to look into this further.
Reviewed-by: Ruiyu Ni
Thanks,
Ray
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Monday, July 6, 2015 10:12 PM
To: Ni, Ruiyu; edk2-devel
Fix comments as below:
PcRtc: Fix PcRtcInit() to use correct value for RegisterB
> -Original Message-
> From: Ni, Ruiyu
> Sent: Monday, July 6, 2015 2:39 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Ni, Ruiyu; Tian, Feng
> Subject: [Patch] PcRtc: Fix PcRtcI
I think they are saying A.dsc includes B.dsc, which nestly includes C.dsc.
I vote Andrew’s solution to provide the correct line number. It’s not a complex
problem for tool to resolve.
From: Gao, Liming [mailto:liming@intel.com]
Sent: Wednesday, July 1, 2015 10:34 AM
To: edk2-devel@lists.sourc
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Liming Gao [mailto:liming@intel.com]
> Sent: Tuesday, June 30, 2015 2:12 PM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [Patch 0/3] Update driver to handle LoadFile device path
>
> UEFI Spec HTTP Boot Device Path, after
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Qiu, Shumin
> Sent: Thursday, June 25, 2015 3:47 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Zeng, Star; Fan, Jeff; Gao, Liming; Ni, Ruiyu; Tian, Feng
> Subject: [PATCH 09/13] MdeModulePkg/Universal/FvSimpleFileSys
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Qiu, Shumin
> Sent: Thursday, June 25, 2015 3:47 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Zeng, Star; Fan, Jeff; Gao, Liming; Ni, Ruiyu; Tian, Feng
> Subject: [PATCH 06/13] MdeModulePkg/Library/UefiBootMana
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Zeng, Star
> Sent: Friday, June 26, 2015 4:38 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Ni, Ruiyu
> Subject: [PATCH V2 15/24] Nt32Pkg: Use the merged Variable driver.
>
> Cc: Ruiyu Ni
> Contributed-un
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Star Zeng [mailto:star.z...@intel.com]
> Sent: Friday, June 26, 2015 4:38 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Ni, Ruiyu
> Subject: [edk2] [PATCH V2 08/24] Nt32Pkg: Link AuthVariableLib for
> following m
gt; From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Friday, June 26, 2015 3:07 AM
> To: Justen, Jordan L; Ni, Ruiyu
> Cc: edk2-devel@lists.sourceforge.net; Kinney, Michael D
> Subject: Re: [edk2] [PATCH v2 02/24] PcAtChipsetPkg: remove
> PciHostBridgeDxe
>
> Jordan, Ray,
Thursday, June 25, 2015 4:24 PM
> To: Ni, Ruiyu
> Cc: Justen, Jordan L; edk2-devel@lists.sourceforge.net; Kinney, Michael D
> Subject: Re: [edk2] [PATCH v2 02/24] PcAtChipsetPkg: remove
> PciHostBridgeDxe
>
> On 06/25/15 04:10, Ni, Ruiyu wrote:
> > Jordan,
> > I prefer
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Fan, Jeff
> Sent: Thursday, June 25, 2015 3:59 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Ni, Ruiyu
> Subject: [Patch] SourceLevelDebugPkg/DebugAgent: Add typecast to fix sign
> extension
>
> OffsetHigh
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Liming Gao [mailto:liming@intel.com]
> Sent: Thursday, May 21, 2015 8:59 AM
> To: edk2-devel@lists.sourceforge.net
> Subject: [edk2] [PATCH v2] Edk2: Update Edk2Setup.bat
>
> Fix the issue when configure X64 NT32, replace NT32_X64 by
,
Ray
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, June 11, 2015 11:17 PM
> To: Ni, Ruiyu
> Cc: edk2-devel@lists.sourceforge.net; Gerd Hoffmann (GMail address)
> Subject: Re: [edk2] [Patch] PcAtChipsetPkg/PcRtc: Fix a Y2K bug
>
> On 0
Depending on whether the low-layer produces BlockIo2 protocol, the Fat driver
doesn't always produce REVISION_2 for FileHandle/DirHandle.
So either we can check both the REVISION_1 and REVISION_2, or we can remove
this check because the rubbish data can happen to be REVISION_1 or REVISION_2
but
Please also add /Gy- which can let WinDbg recognize the calling stack correctly.
From: Tian, Feng
Sent: Wednesday, June 10, 2015 9:40 AM
To: Saiprasad Chavali; 'edk2-devel@lists.sourceforge.net'; Ni, Ruiyu
Cc: Tian, Feng
Subject: RE: [edk2] Question about WinDbg Support--
Conclusi
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Fan, Jeff
> Sent: Tuesday, June 9, 2015 10:21 AM
> To: edk2-devel@lists.sourceforge.net
> Cc: Ni, Ruiyu
> Subject: [Patch] SourceLevelDebugPkg/DxeDebugAgent: Initialize Local APIC
> Timer
>
> Now Debug Ag
Reviewed-by: Ruiyu Ni
> -Original Message-
> From: Fan, Jeff
> Sent: Friday, June 5, 2015 4:27 PM
> To: edk2-devel@lists.sourceforge.net
> Cc: Ni, Ruiyu
> Subject: [Patch] SourceLevelDebugPkg/DebugAgent: Disable Debug Timer as
> early
>
> InitializeApicTim
Better to update comments to "Update to follow EDKII coding style."
Reviewed-by: Ruiyu Ni
From: Qiu, Shumin
Sent: Friday, June 5, 2015 10:56 AM
To: edk2-devel@lists.sourceforge.net
Cc: Ni, Ruiyu
Subject: [PATCH] MdeModulePkg: Refine the format o
Reviewed-by: Ruiyu Ni
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Wednesday, May 27, 2015 11:35 PM
To: Tian, Feng
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdeModulePkg/PciBusDxe: Removed unused variable
assignment
Contributed-under:
adding debug agent to default console list may not help you to get debugger
work.
Can you update the SourceLevelDebugPkg to latest and try again?
Thanks,
Ray
From: Kan Qiu [mailto:kan...@osbase.com]
Sent: Tuesday, May 26, 2015 3:56 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net
Subject: Re:
Kan,
It seems you have enabled the UDK Debugger in DUET. Any findings you can share
with me?
Thanks,
Ray
From: Kan Qiu [mailto:kan...@osbase.com]
Sent: Thursday, May 21, 2015 4:27 PM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] Debug UEFI driver using EDKII
Thanks Ray
Make sure you boot your HP system to DUET. DUET contains a typical EDKII BIOS
setup UI which should be quite different from your HP’s BIOS setup UI.
In DUET’s setup UI, enters to Boot Maintainance Manager->Console Option.
Make sure you check the device path like
“VenHw(865A5A9B-B85D-474C-8455-65D
only want to keep one, which is the most useful? I would like to keep
CHAR16/CHAR8 (input/pattern) at least.
4. Agreed.
From: Ni, Ruiyu [ruiyu...@intel.com]
Sent: Friday, May 22, 2015 01:15
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [
Reviewed-by: Ruiyu Ni
-Original Message-
From: Jeff Fan [mailto:jeff@intel.com]
Sent: Friday, May 22, 2015 2:11 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch v2 0/2] Initialize Local APIC Timer in SMM entry
Now Debug Agent library uses Local APIC Timer to implement
4. how about Regex instead of RegEx? C# uses Regex name.
-Original Message-
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Friday, May 22, 2015 1:29 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] MdeModulePkg: Regular expression protocol
Doman,
1. If RegExCompile
Doman,
1. If RegExCompile() returns ABORTED, is the HANDLE valid or not? Because of
ABORTED, it makes more sense to let HANDLE to not be created. But then
RegExErrorMessage(HANDLE) cannot be called.
2. Why do you use CHAR8 instead of CHAR16 for captured string? Even your
library implementation
Qiu,
You need to make sure the flow control setting between HOST and TARGET are the
same. In your case, you need to change the
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl to TRUE.
From: Kan Qiu [mailto:kan...@osbase.com]
Sent: Thursday, May 21, 2015 2:11 AM
To: Ni, Ruiyu
Cc
Reviewed-by: Ruiyu Ni
From: Tian, Feng
Sent: Wednesday, May 20, 2015 9:26 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Tian, Feng
Subject: RE: [patch] FatPkg: Add RecoveryBlockIo2Ppi support
Thanks, Ray
I update the patch according to your comment. Please review again
Thanks
Feng
PEI_FAT_PRIVATE_DATA. It means
an array for PPIs notify.
Thanks,
Ray
From: Tian, Feng
Sent: Monday, May 18, 2015 1:06 PM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Tian, Feng
Subject: [patch] FatPkg: Add RecoveryBlockIo2Ppi support
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by
this
out to free serial port for debugging
!endif
!ifndef $(SOURCE_DEBUG_ENABLE)
INF IntelFrameworkModulePkg/Bus/Isa/IsaSerialDxe/IsaSerialDxe.inf
!endif
From: Ni, Ruiyu mailto:ruiyu.ni@in...>> - 2015-05-18 02:21:33
Attachments: Message as
HTML<https://sourceforge.net/p/edk2/mail
Jeff,
The updated patch keeps the Handle parameter following your offline suggestion.
Please have a check.
Thanks,
Ray
-Original Message-
From: Ni, Ruiyu
Sent: Monday, May 18, 2015 11:39 AM
To: edk2-devel@lists.sourceforge.net
Cc: Ni, Ruiyu; Fan, Jeff
Subject: [Patch
If it
doesn't, I will not check in it.
Thanks,
Ray
-Original Message-
From: Ma, Maurice
Sent: Saturday, May 16, 2015 12:49 AM
To: Justen, Jordan L; Ni, Ruiyu; Agyeman, Prince
Cc: reza.jel...@tuhh.de; Zeng, Star; ler...@redhat.com;
edk2-devel@lists.sourceforge.net
Subject: RE: [edk2
Please give a list of detailed steps about what you did to try UDK Debugger.
From: Kan Qiu [mailto:kan...@osbase.com]
Sent: Sunday, May 17, 2015 1:43 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] Debug UEFI driver using EDKII
Hi I'm new to EDKII. I need to write a UEFI driver and I'm ha
No concerns now:)
Remember to change the function header when you check in.
Reviewed-by: Ruiyu Ni
-Original Message-
From: Fan, Jeff
Sent: Friday, May 15, 2015 10:09 AM
To: Ni, Ruiyu; edk2-devel@lists.sourceforge.net
Subject: RE: [Patch 1/2] SourceLevelDebugPkg/DxeDebugAgent
om: Ma, Maurice
Sent: Saturday, May 9, 2015 6:33 AM
To: Justen, Jordan L; Agyeman, Prince
Cc: reza.jel...@tuhh.de; Zeng, Star; Ni, Ruiyu; ler...@redhat.com;
edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] [PATCH] CorebootPayloadPkg: Replace PciHostBridge driver
with PciRootBridgeNoEnumerat
hanks,
Ray
-Original Message-
From: Fan, Jeff
Sent: Thursday, May 14, 2015 4:42 PM
To: edk2-devel@lists.sourceforge.net
Cc: Ni, Ruiyu
Subject: [Patch 1/2] SourceLevelDebugPkg/DxeDebugAgent: Initialize Local APIC
Timer early
Now Debug Agent library uses Local APIC Timer to implement tim
It lists all boot options referenced by BootOrder variable.
We will create a feature equivalent UI/Firmware Setup later.
-Original Message-
From: Justen, Jordan L
Sent: Monday, May 11, 2015 2:07 PM
To: Ni, Ruiyu; edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] [Patch] Nt32Pkg
OK.
I will commit the patch using the NOTES provide by Felix.
Thanks,
Ray
-Original Message-
From: Kinney, Michael D
Sent: Saturday, May 9, 2015 12:06 AM
To: Felix Poludov; Ni, Ruiyu; edk2-devel@lists.sourceforge.net; Andrew Fish;
Kinney, Michael D
Subject: RE: [edk2] [Patch] MdePkg
up.
Sure I will provide a V2 patch to separate the library and DSC/FDF change, with
subject prefix fixed.
Thanks,
Ray
-Original Message-
From: Justen, Jordan L
Sent: Saturday, May 9, 2015 3:38 AM
To: edk2-devel@lists.sourceforge.net; Ni, Ruiyu
Subject: Re: [edk2] [Patch] Nt32Pkg: Enable
Poludov; edk2-devel@lists.sourceforge.net; Andrew Fish; Ni, Ruiyu;
Kinney, Michael D
Subject: RE: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.
Felix,
I agree with your points and agree that the C structure definition from UEFI
2.5 should be added to UefiSpec.h.
I would like to see the
Reviewed-by: Ruyu Ni
-Original Message-
From: Liming Gao [mailto:liming@intel.com]
Sent: Tuesday, May 5, 2015 2:14 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch] MdeModulePkg: Update FirmwarePerformanceDataTableDxe
for LegacyBoot
Change the code to listen EFI_SW_DX
Signed-off-by: Ruiyu Ni
Reviewed-by: Eric Dong
dxe_runtime.patch
Description: dxe_runtime.patch
--
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with
Martin,
I agree that your patch works. Just wanted to figure out a better patch. But I
haven't got chance to do the investigation yet.
Thanks,
Ray
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, May 5, 2015 10:46 PM
To: edk2-devel@lists.sourceforge.net; Ni, Ruiyu
Cc: R
@lists.sourceforge.net
Cc: Kinney, Michael D; Ni, Ruiyu
Subject: Re: [edk2] [Patch] MdePkg: Add EFI_LOAD_OPTION definition.
> On May 1, 2015, at 10:40 AM, Kinney, Michael D
> wrote:
>
> Ray,
>
> The idea of adding EFI_LOAD_OPTION structure to MdePkg .h files has been
> considered bef
Laszlo,
V3 patches were posted to edk2-devel. Sure I will create additional branch for
new version of patch in future.
Thanks,
Ray
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Monday, April 27, 2015 4:17 PM
To: Ni, Ruiyu
Cc: edk2-devel list; Ard Biesheuvel
-devel@lists.sourceforge.net; Ni, Ruiyu
Subject: Re: [edk2] Proposal: can we create a new mailing list (e.g.:
edk2-pa...@lists.sourceforge.net) for patch review?
On 2015-04-26 20:05:30, Ni, Ruiyu wrote:
>All,
>
>Now since more and more people (mostly from IntelJ ) are send
All,
Now since more and more people (mostly from Intel:) ) are sending patch reviews
to edk2-devel mailing list, it brings lots of mails.
How about we create a new mailing list like edk2-patch?
Regards,
Ray
--
One dashbo
Reviewed-by: Ruiyu Ni
From: Qiu, Shumin
Sent: Monday, April 27, 2015 9:33 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net
Subject: FW: [edk2] [Patch] ShellPkg: Refine the logic about allocating memory
for variable name and data.
Hi Ruiyu,
Could you help to review this patch?
-Shumin
machine. Then commit all my patches to that and push to
github.
Thanks,
Ray
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, April 22, 2015 4:42 PM
To: Ni, Ruiyu
Cc: edk2-devel list; Ard Biesheuvel
Subject: Re: [edk2] [Patch V2 00/15] Add pure UEFI Boot
I tried to set [format]/thread=true but the mails sent from TortoiseGit looks
badly formatted. Seems TortoiseGit have a bug on this.
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, April 21, 2015 8:20 PM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net
Martin,
Please check the attached patch. Can it solve your issue?
Thanks,
Ray
From: Tian, Feng [mailto:feng.t...@intel.com]
Sent: Thursday, April 2, 2015 9:37 AM
To: Olivier Martin
Cc: Ronald Cron; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fix media p
Reviewed-by: Ruiyu Ni
From: Qiu, Shumin [mailto:shumin@intel.com]
Sent: Monday, February 9, 2015 9:47 AM
To: Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [Patch]NT32Pkg: Bind NT32 process to a single core to avoid
NT32 crash issue in some multi-core processors.
Hi Eri
Jordan,
PciEnumeratorLight() in original code always runs in gFullEnumeration = FALSE
when PcdPciDisableBusEnumeration = TRUE.
But PciEnumeratorLight() in your code runs in gFullEnumeration=TRUE when
PcdPciDisableBusEnumeration = TRUE for the first root bridge. When
gFullEnumeration=TRUE, some h
script.
Thanks,
Ray
From: B Cran [mailto:bruce.c...@gmail.com]
Sent: Monday, February 16, 2015 1:38 PM
To: Ni, Ruiyu
Subject: Re: UEFI Source Level Debugging with GCC and Linux
Thanks! I got the debugger tool installed on my openSUSE system and it almost
works -- I'll wait for the new release
riday, February 13, 2015 5:03 AM
To: edk2-devel@lists.sourceforge.net; Ni, Ruiyu; wei.l...@citrix.com
Cc: xen-de...@lists.xen.org
Subject: Re: [edk2] [PATCH] MdeModulePkg: mark completion of PCI enumeration in
PciEnumeratorLight
On 2015-02-11 17:23:26, Ni, Ruiyu wrote:
> Wei,
> No you can
Wei,
No you cannot install gEfiPciEnumerationCompleteProtocolGuid in
PciEnumeratorLight().
For a real platform, PCI BUS is fully enumerated in PciEnumerator() and later
if reconnect happens, it's light enumerated in PciEnumeratorLight(). The
protocol should only be installed once in PeiEnumerato
Thanks.
Reviewed-by: Ruiyu Ni ruiyu...@intel.com<mailto:ruiyu...@intel.com>
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Wednesday, January 7, 2015 12:02 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fixed El
volume descriptor
+ VolDescriptorOffset += SIZE_2KB;
+}
--->
for (VolDescriptorOffset = SIZE_32KB; ; VolDescriptorOffset += SIZE_2KB) {
...
}
Thanks,
Ray
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Monday, December 22, 2014 11:21 PM
To: Ni, Ruiyu
Cc: edk2-de
Sushil,
Just boot to that file: efi\boot\bootia32.efi.
Thanks,
Ray
From: Sushil Kumar Deka [mailto:sushil.d...@csr.com]
Sent: Wednesday, December 10, 2014 1:46 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] USB host controller on NT32Pkg
Hi Andrew,
Thanks for the info.
I am planning
Olivier,
Any comments?
Thanks,
Ray
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Monday, November 17, 2014 11:07 AM
To: Olivier Martin
Cc: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH] MdeModulePkg/PartitionDxe: Fixed El Torito support
when the medium is not a CDROM
Olivier
Update the patch to use OVMF style.
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: Friday, November 21, 2014 1:59 PM
To: Dong, Eric
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] Change NT32 and DUET platform to use UefiShell instead of EDK
Shell
Eric,
Please check the attached patch
Eric,
Please check the attached patch.
It changes NT32 DSC file to use UefiShell by default and use EDK Shell if "-D
USE_OLD_SHELL" is supplied in build command line.
It changes DUET batch file to use UefiShell by default.
Regards,
Ray
new_shell_nt32_duet.patch
Description: new_shell_nt32_duet
Olivier,
I have several comments regarding your patch:
1.if (((2048 % Media->BlockSize) != 0) && (Media->BlockSize > 2048)) {
return EFI_NOT_FOUND;
}
The above check cannot catch the case when Media->BlockSize is 13. So I am
wondering maybe "&&" should be "||". Please confirm.
2
Reviewed-by: Ruiyu Ni
From: Qiu, Shumin [mailto:shumin@intel.com]
Sent: Tuesday, September 23, 2014 2:08 PM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [Patch] ShellPkg: Refine code style to avoid potential
NullPointer dereference.
Update the patch to use ASSE
Hi Olivier, Jaben,
The check in r15180 caused the shell always return EFI_ABORTED no matter what
exit-code user specifies for "exit" command. It's a critical bug for shell user
who does different things upon different exit-codes.
The issue is because the error status was returned in the ExitData.
fy the Shell
specification.
Maybe something like:
‘EFI_SUCCESS The shell manages to start the command’
Thanks,
Olivier
From: Ni, Ruiyu [mailto:ruiyu...@intel.com]
Sent: 12 September 2014 08:58
To: Olivier Martin; 'Phillips, Chris J (BCS CFE)
(chr...@hp.com<mailto:chr...@hp.com>)
Hi Oliver,
Why did you check in the patch to put the exit-code in ExitData? In my opinion,
unless Shell spec defines that the exit-code can be got from the ExitData,
putting the exit-code in ExitData and always returning EFI_ABORTED doesn't make
sense to the caller.
>From the current wording in
Checked into r92. Sorry for the delay.
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Tuesday, September 09, 2014 11:52 PM
To: Ni, Ruiyu; Justen, Jordan L; Gao, Liming
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH] FatPkg: Enable stack protection
Any update on this one
Jaben,
Do you agree to rename PathCleanUpDirectories to PathNormalize?
Thanks,
Ray
-Original Message-
From: Olivier Martin [mailto:olivier.mar...@arm.com]
Sent: Wednesday, September 03, 2014 11:27 PM
To: edk2-devel@lists.sourceforge.net; Ni, Ruiyu; Tian, Feng
Cc: Ronald Cron; Carsey
Checked in @15895
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Saturday, August 23, 2014 7:09 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdePkg: Add PMC/PMCSR definitions
Dear MdePkg maintainers,
Please find the attached patch that adds some PCI Po
Check in @15894.
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Saturday, August 23, 2014 7:13 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdePkg: Update EFI_DRIVER_HEALTH_HII_MESSAGE definition
from UEFI 2.4
Dear MdePkg maintainers,
Please find the a
Reviewed-by: Ruiyu Ni
From: Dong, Eric [mailto:eric.d...@intel.com]
Sent: Tuesday, August 19, 2014 5:20 PM
To: Sergey Isakov
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] IntelFrameworkModulePkg/SourceLevelDebugPkg : Fix
comment typos
Hi Sergey,
Please help to review this patch
I think maybe PathCleanUpDirectories is not a good name to describe this API's
behavior. It's a API to normalize the file path but do nothing to the directory
content. Would "PathNormalize" be better?
-Original Message-
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Friday, A
Sava,
I agree if EbdaAddress is above the 1MB_END, we can safely use the memory from
1MB_START to 1MB_END.
But I don’t understand why we still use the same memory region when EbdaAddress
<0x9A000.
Thanks,
Ray
From: A. Sava [mailto:asava@gmail.com]
Sent: Sunday, June 08, 2014 9:18 AM
To: ed
Could you please run "lm" in WinDbg to check whether the SMM driver is in the
list?
Thanks,
Ray
From: owen [mailto:pengxianb...@byosoft.com.cn]
Sent: Friday, June 20, 2014 10:40 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] cannot load smm drivers symbol when enable source level debug
Williamson,
Thanks for fixing this issue. The patch was committed @ r15567.
Thanks,
Ray
-Original Message-
From: Alex Williamson [mailto:alex.william...@redhat.com]
Sent: Thursday, June 19, 2014 12:59 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH] MdeModulePkg: PciBusDxe
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Tuesday, April 29, 2014 12:49 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Patch to enhance the output around GOP protocol
Ray,
Can you review this?
The STR_GOP_DUMP_MAIN string in the UNI is the change
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Thursday, January 16, 2014 5:59 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Return the failure
Ray,
Can you review please?
ShellPkg: Return the failure
This change returns the error code when they
Still no luck to reproduce it in OVMF.
-Original Message-
From: Ni, Ruiyu
Sent: Wednesday, January 15, 2014 9:52 AM
To: Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [edk2] assertion failure in Shell when scrolling back
I cannot reproduce it in NT32 as well. I will try
I cannot reproduce it in NT32 as well. I will try OVMF and let you know.
-Original Message-
From: Carsey, Jaben
Sent: Tuesday, January 14, 2014 3:02 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: RE: [edk2] assertion failure in Shell when scrolling back
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Saturday, January 11, 2014 1:10 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Fix command line parsing for script files (%1, %1, etc...)
Ray,
Can you verify this please?
ShellPkg: Fix command line
Reviewed-by: Ruiyu Ni
From: Bjorge, Erik C
Sent: Saturday, January 11, 2014 6:27 AM
To: Carsey, Jaben; Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: ShellPkg: add the last PCIe extended capability decodings
Reviewed-by: Erik Bjorge
mailto:erik.c.bjo...@intel.com>>
From:
Reviewed-by: Ruiyu Ni
From: Bjorge, Erik C
Sent: Saturday, January 11, 2014 6:16 AM
To: Carsey, Jaben; Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: MdePkg: add missing #defines for decoding PCIe 2.1 extended
capability structures
Reviewed-by: Erik Bjorge
mailto:erik.c.bjo
The patch looks good to me.
Reviewed-by: Ruiyu Ni mailto:ruiyu...@intel.com>>
From: Carsey, Jaben
Sent: Friday, January 10, 2014 6:16 AM
To: edk2-devel@lists.sourceforge.net; Ni, Ruiyu
Cc: Carsey, Jaben
Subject: ShellPkg: remove potential memory leak with new apps on old shell
Ray,
C
The patch looks good to me.
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Friday, January 10, 2014 6:15 AM
To: edk2-devel@lists.sourceforge.net; Ni, Ruiyu
Cc: Carsey, Jaben
Subject: ShellPkg: remove double free operation
Ray,
Can you review this?
ShellPkg: remove double free operation
The patch is good.
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Thursday, January 09, 2014 3:25 AM
To: Ni, Ruiyu
Cc: 'edk2-devel@lists.sourceforge.net'; Carsey, Jaben
Subject: ShellPkg: remove memory leak in file handle list
Ray,
Can you verify this please?
ShellPkg: remove memo
The patch is good for some NSH script files which contain lots of lines of
comments though it only filters out only the lines whose very first char is '#'.
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Thursday, January 09, 2014 3:30 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourc
The patch is good.
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Thursday, January 09, 2014 3:32 AM
To: Ni, Ruiyu
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Remove memory leak from file list usage
Ray,
Can you verify this please?
ShellPkg: Remove memory leak
Jaben,
You change looks good.
Reviewed-by: Ruiyu Ni
From: Carsey, Jaben
Sent: Thursday, January 09, 2014 1:31 AM
To: Ni, Ruiyu
Cc: 'edk2-devel@lists.sourceforge.net'; Carsey, Jaben
Subject: ShellPkg: Add more output to PCI command
Ray,
Can you verify this please?
ShellPkg: Add more
1 - 100 of 145 matches
Mail list logo
