Re: [edk2] Print(L"0x%.16x", Value) not working as expected

2014-10-17 Thread Nikolai Saoukh
IMHO, correct usage is Print (L"0x%.16lx", Value); // lower case L On Fri, Oct 17, 2014 at 2:22 PM, wrote: > Hi, > > I tried to print a UINT64 value as follows and hoped to get output > ā€œ0x1122334455667788ā€: > > { > > UINT64 Value = 0x1122334455667788; > > Print(Lā€œ0x%.16xā€, Value); > > } >

Re: [edk2] BaseTools: Add MINGW tool chain

2014-10-03 Thread Nikolai Saoukh
I was under impression that mingw-win64 can be used for X64 AND IA32 builds. On Fri, Oct 3, 2014 at 9:19 AM, Scott Duplichan wrote: > Here is a work in progress patch for those building X64 or IA32 targets > from Windows. It allows building with gcc instead of a Microsoft compiler. > Building has

[edk2] [Patch] MdeModulePkg: Magic number 0x1999999999999999ULL does not fit UINTN in IA32 world

2014-09-14 Thread Nikolai Saoukh
Well, subject says all. Review and commit, please Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh Stall.c.patch Description: Binary data -- Want excitement? Manually upgrade your

[edk2] [Patch] DuetPkg: Inapropriate format specifiers for PrintString() produce bizzare results

2014-09-12 Thread Nikolai Saoukh
Both printed fields are 64 bit long for IA32 too. It is better to print them as such. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh DxeInit.c.patch Description: Binary data

[edk2] MdePkg/Include/Base.h: #if __APPLE__ or #ifdef __APPLE__

2014-09-12 Thread Nikolai Saoukh
Is it correct that if __APPLE__ defined, it always non zero (true)? -- Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable.

[edk2] [Patch] UefiCpuPkg: IA32: error: invalid instruction mnemonic 'retf' too

2014-09-12 Thread Nikolai Saoukh
.S assembler files *must* be AT&T syntax ones. So Intel syntax mnemonic is not good. Patch attached. Please review & commit. Missed that in previous submission. Sorry ;-( Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh 32ExceptionHandlerAsm

Re: [edk2] [Patch] BaseTools: Backslash (\) is not valid filename separator in unix universe

2014-09-11 Thread Nikolai Saoukh
On Fri, Sep 12, 2014 at 9:45 AM, Jordan Justen wrote: > On Thu, Sep 11, 2014 at 10:17 PM, Nikolai Saoukh wrote: > > Probably no one use debug stuff nowadays ;-) > > You didn't intend for this line to be in the commit message, right? > Affirmative, Sir! ;-) > > I

[edk2] [Patch] BaseTools: Backslash (\) is not valid filename separator in unix universe

2014-09-11 Thread Nikolai Saoukh
Probably no one use debug stuff nowadays ;-) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh tools_def.template.patch Description: Binary data -- Want excitement? Manually upgrade

[edk2] [Patch] UefiCpuPkg: error: invalid instruction mnemonic 'retf'

2014-09-11 Thread Nikolai Saoukh
Well, I assume .S assembler files *must* be AT&T syntax ones. So Intel syntax mnemonic is not good. Discovered by clang integrated assembler. Patch attached. Please review & commit. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikola

Re: [edk2] Error: constatnt 256 does not fit UINT8

2014-09-09 Thread Nikolai Saoukh
LGTM (Looks Good To me) Signed-off-by: Nikolai Saoukh On Tue, Sep 9, 2014 at 8:43 AM, Tian, Feng wrote: > Thanks, Nikolai > > Please help review this patch. > > Best Regards > Feng > > -Original Message- > From: Nikolai Saoukh [mailto:n...@otdel-1.org] &g

Re: [edk2] Error: constatnt 256 does not fit UINT8

2014-09-08 Thread Nikolai Saoukh
5:11 AM, Tian, Feng wrote: > Hi, Nikolai > > Could I know which tool chain and build option you are using? > > And here is a patch, could you help me have a verification? > > Thanks > Feng > > -Original Message- > From: Nikolai Saoukh [mailto:n...@otdel-1.

[edk2] Error: constatnt 256 does not fit UINT8

2014-09-07 Thread Nikolai Saoukh
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c:111:31: error: comparison of constant 256 with expression of type 'UINT8' (aka 'unsigned char') is always true [-Werror,-Wtautological-constant-out-of-range-compare] ASSERT (IfDesc->ActiveIndex < USB_MAX_INTERFACE_SETTING); ~~~

Re: [edk2] PcAtChipsetPkg: RTC: Modification of "read only" bit VRT considered harmful

2013-02-08 Thread Nikolai Saoukh
> May I ask why you sent your changes from a different address than your > Signed-off-by? I was I was registered to edk2-devel list with another my email address. If it makes difference for the procedure, I will sign my submissions with that address. --

[edk2] PcAtChipsetPkg: RTC: Modification of "read only" bit VRT considered harmful

2013-02-02 Thread Nikolai Saoukh
w enough and failure the check for validity. ASSERT triggered. Attached patch tries to fix the problem. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh PcRtc.c.patch Description: Binary data ---

[edk2] DuetPkg: Wrong format specifiers for debug output

2013-02-02 Thread Nikolai Saoukh
DuetPkg: Wrong format specifiers for debug output Wrong format specifiers produce bizzare output in debug message. Attached patch fix it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh DxeInit.c.patch Description: Binary data

[edk2] MdePkg: pushaw/popaw mnemonics unknown for clang integrated assembler

2013-02-02 Thread Nikolai Saoukh
MdePkg: pushaw/popaw mnemonics unknown for clang integrated assembler clang integrated assembler does not know pushaw/popaw mnemonics. Attached patch change these to format accepted by gas and clang. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh

[edk2] MdePkg: Missing width suffix in .S assembler file

2013-02-02 Thread Nikolai Saoukh
MdePkg: Missing width suffix in .S assembler file Attached patch fixes missing width suffix Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh miswid.patch Description: Binary data

[edk2] MdePkg: Inappropriate intel syntax directives in .S assembler files

2013-02-02 Thread Nikolai Saoukh
MdePkg: Inappropriate intel syntax directives in .S assembler files Attached patch removes intel syntax directives from .S (gnu as) files. These files are AT&T syntax ones. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh intsyn.patch Description: Bi

[edk2] BaseTools: Backslash (\) is not appropriate in unix filenames

2013-02-02 Thread Nikolai Saoukh
BaseTools: Backslash (\) is not appropriate in unix filenames Attached patch fixes inappropriate use of backslash (\) in unix file name Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Nikolai Saoukh tools_def.patch Description: Binary data

[edk2] [patch] pushaw/popaw mnemonics unknown to clang integrated assembler

2013-01-30 Thread Nikolai Saoukh
With the patch file accepted by gas and clang integrated assembler pushaw.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for

[edk2] [patch] missing width suffix in assembly mnemonics

2013-01-30 Thread Nikolai Saoukh
Also discovered with clang integrated assembler miswid.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://

[edk2] [patch] invalid hex number in assembler file

2013-01-30 Thread Nikolai Saoukh
Discovered by clang integrated assembler invhex.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.ne

[edk2] [patch] Intel syntax directives inside assembler file with AT&T syntax

2013-01-30 Thread Nikolai Saoukh
clang integrated assembler does not like the mixture of Intel and AT&T syntax. intsyn.patch Description: Binary data -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynami

Re: [edk2] tautological-constant-out-of-range-compare

2013-01-19 Thread Nikolai Saoukh
t; > > > What tool-chain and build option are you using? Are you changing > tools_def.txt in Conf directory? > > Could you paste the entire command line of building this .c file to us? > > > > Thanks > > Feng > > > > From: Nikolai Saoukh [mailto:n...

Re: [edk2] tautological-constant-out-of-range-compare

2013-01-16 Thread Nikolai Saoukh
> Could you paste the entire command line of building this .c file to us?*** > * > > ** ** > > Thanks**** > > Feng > > ** ** > > *From:* Nikolai Saoukh [mailto:n...@otdel-1.org] > *Sent:* Tuesday, January 15, 2013 22:27 > > *To:* edk2-devel@lists.sour

[edk2] [trivial patch] Backslash is not appropriate in file names at *nix environment?

2013-01-16 Thread Nikolai Saoukh
Backslash is not appropriate in file names at *nix environment? --- BaseTools/Conf/tools_def.template.orig 2013-01-16 12:44:01.0 +0400 +++ BaseTools/Conf/tools_def.template 2013-01-16 12:44:31.0 +0400 @@ -2536,3 +2536,3 @@ *_*_*_SYMRENAME_FLAGS = Symbol renaming n

[edk2] tautological-constant-out-of-range-compare

2013-01-15 Thread Nikolai Saoukh
This particular case was discussed already /tiano/edk2/MdeModulePkg/Core/Dxe/Mem/Pool.c:188:49: error: comparison of constant 2147483647 with expression of type 'EFI_MEMORY_TYPE' is always true [-Werror,-Wtautological-constant-out-of-range-compare] if ((PoolType >= EfiMaxMemoryType && PoolType <

Re: [edk2] out-of-range-compare

2013-01-15 Thread Nikolai Saoukh
Yes, it was discovered while compiling for IA32. Yes, explicit type case fixed the problem. On Tue, Jan 15, 2013 at 6:02 PM, Gao, Liming wrote: > /tiano/edk2/MdeModulePkg/Core/Dxe/Misc/Stall.c -- Master SQL Server Develo

[edk2] out-of-range-compare

2013-01-14 Thread Nikolai Saoukh
/tiano/edk2/MdeModulePkg/Core/Dxe/Misc/Stall.c:70:20: error: comparison of constant 1844674407370955161 with expression of type 'UINTN' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (Microseconds > 0x1999ULL) { ^

Re: [edk2] clang compilation error

2013-01-11 Thread Nikolai Saoukh
ANSI C integer promotion rules make INT32 or UINT32 > interchangeable > when passed as an argument to a function. > > The issue is that some compilers treat enums as signed and others as > unsigned. The EDK II implementation attempts to be compatible with both > types of

Re: [edk2] clang compilation error

2013-01-11 Thread Nikolai Saoukh
Well, what is wrong with UINT32 as type for EFI_MEMORY_TYPE? Why EFI_MEMORY_TYPE should be signed? On Fri, Jan 11, 2013 at 9:00 PM, Kinney, Michael D wrote: > Sergey, > > > > The comparison against 0x7fff is required due to a UEFI Spec > requirement. UEFI Specification 2.3.1 Section 6.2 Allo

Re: [edk2] Can't Trim Efildr Down

2012-10-18 Thread Nikolai Saoukh
Looks like your CPU lacks SSE2? On Thu, Oct 18, 2012 at 7:45 PM, Shao Miller wrote: > Good day to all. > > I am working from commit "Add manual configured gateway address back > after system reset" by Ye Ting. > > I've been trying to build a DUET boot floppy for use with both real > hardware and

[edk2] Proper way to submit bug/feature issues?

2012-10-18 Thread Nikolai Saoukh
web page of tianocore.org points to Trac server at sourceforge.net. Is anybody watching it? -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: h

Re: [edk2] www.tianocore.org gone?

2012-10-08 Thread Nikolai Saoukh
> Link to where www.tianocore.org is normally relayed to: > http://sourceforge.net/apps/mediawiki/tianocore/ The evidence of the problem so far ; <<>> DiG 9.6.-ESV-R7-P3 <<>> www.tianocore.org. any @8.8.8.8 ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id

[edk2] www.tianocore.org gone?

2012-10-08 Thread Nikolai Saoukh
DNS servers points to nowhere -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java,