[edk2] [PATCH] ShellPkg: Fix the wrong value got from 'for' command.

In 'For.c' return error status instead of a wrong number when fail to convert a string to UINT64. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey Reviewed-by: Qiu Shumin --- ShellPkg/Library/UefiShellLevel1CommandsLib/For.c | 53

Re: [edk2] [patch] MdePkg/UefiDevicePathLib:Fix link error due to missing RamDisk GUIDs

Reviewed-by: Qiu Shumin -Original Message- From: Tian, Feng Sent: Thursday, July 09, 2015 11:39 AM To: Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net; Tian, Feng Subject: [patch] MdePkg/UefiDevicePathLib:Fix link error due to missing RamDisk GUIDs

[edk2] [PATCH] MdePkg: Refine INF file for SmmMemLib.

Add [Depex] section and update protocol usage. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin CC: Liming Gao CC: "Yao, Jiewen" --- MdePkg/Library/SmmMemLib/SmmMemLib.inf | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MdeP

Re: [edk2] [PATCH] Fix typo of 'determines' in ShellPkg

Reviewed-by: Qiu Shumin -Original Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Tuesday, July 07, 2015 10:20 AM To: Carsey, Jaben; Qiu, Shumin; edk2-devel@lists.sourceforge.net Cc: Bruce Cran Subject: [PATCH] Fix typo of 'determines' in ShellPkg Contrib

[edk2] [PATCH 0/2] Refine the function comments.

Qiu Shumin (2): SecurityPkg: Refine the function comments. CryptoPkg: Refine the function comments. CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c| 2 +- .../BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c | 2 +- SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe

[edk2] [PATCH 1/2] SecurityPkg: Refine the function comments.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin CC: Long, Qin --- SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c b/SecurityPkg/Pkcs7Verify

[edk2] [PATCH 2/2] CryptoPkg: Refine the function comments.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin CC: Long, Qin --- CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c| 2 +- .../Library/BaseCryptLibRuntimeCryptProtocol/Pk/CryptPkcs7VerifyNull.c | 2 +- 2 files changed, 2 insertions(+), 2

[edk2] [PATCH] MdeModulePkg: Refine code to use Strn**S safe functions instead of Str**S ones in some cases.

Safe string functions may ASSERT when the source length is larger than the MaxDest. This patch use Strn**S to indicate the copy length. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin CC: Star Zeng --- MdeModulePkg/Application/MemoryProfileInfo

[edk2] [PATCH] ShellPkg: Refine code to use Strn**S safe functions instead of Str**S ones in some cases.

Safe string functions may ASSERT when the source length is larger than the MaxDest. This patch use Strn**S to indicate the copy length. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin CC: Ruiyu Ni CC: Heyi Guo CC: Shah, Tapan --- ShellPkg/Application/Shell

[edk2] [PATCH] MdeModulePkg: Use StrnCpyS instead of StrCpyS to indicate the copy length from the source.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Hao Wu CC: Liming Gao --- MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 4 ++-- MdeModulePkg/Library/UefiBootManagerLib/BmPerformance.c| 2 +- 2 files changed, 3

Re: [edk2] [PATCH v2] ShellPkg: Remove UefiHandleParsingLib and Ip4Config Protocol dependency.

Reviewed-by: Qiu Shumin -Original Message- From: jiaxinwu [mailto:jiaxin...@intel.com] Sent: Monday, July 06, 2015 1:12 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH v2] ShellPkg: Remove UefiHandleParsingLib and Ip4Config Protocol dependency. Contributed-under

Re: [edk2] [PATCH 1/2] MdePkg: Fix bug in CatVSPrint introduced by r17742

Reviewed-by: Qiu Shumin -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Friday, July 03, 2015 5:35 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH 1/2] MdePkg: Fix bug in CatVSPrint introduced by r17742 SVN r17742 uses AllocateCopyPool to replace

Re: [edk2] [PATCH 2/2] ShellPkg: Fix bug introduced by r17730

Reviewed-by: Qiu Shumin -Original Message- From: Heyi Guo [mailto:heyi@linaro.org] Sent: Friday, July 03, 2015 5:35 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [PATCH 2/2] ShellPkg: Fix bug introduced by r17730 CurrentFilePattern is only part of FilePattern and will

Re: [edk2] [patch] MdeModulePkg:Modify the incorrect DestStr length in safe string functions

Reviewed-by: Qiu Shumin -Original Message- From: Bi, Dandan Sent: Thursday, July 02, 2015 6:24 PM To: Gao, Liming; Dong, Eric; Qiu, Shumin; edk2-devel@lists.sourceforge.net Subject: [patch] MdeModulePkg:Modify the incorrect DestStr length in safe string functions Contributed-under

[edk2] [PATCH] MdeModulePkg: Refine code to make it more readable.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Jiewen Yao --- MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c| 2 +- .../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c | 2 ++ 2 files changed, 3

Re: [edk2] [Patch] ShellPkg: fix string to number conversion with "0 "

Hi Jaben, The patch looks good to me. I think the comments for InternalShellStrHexToUint64 should also be updated. The 'UINTN' in line 3731 and line 3808 should be 'UINT64'. Reviewed-by: Qiu Shumin mailto:shumin@intel.com>> From: Carsey, Jaben Sent: Wednesday

[edk2] [PATCH] ShellPkg: Refine the code logic of StrnCatGrow.

In order to indicate the catena length use StrnCatS instead of StrCatS to generate Destination string, and update the DestMax of Destination string. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Library/UefiShellLib/UefiShellLib.c | 5 +++-- 1

[edk2] [PATCH] ShellPkg: Refine code to avoid potential buffer overflow.

This commit refine the catenae length to avoid potential buffer overflow. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks, Shumin FileHandleWrappers.c.patch Description: FileHandleWrappers.c

[edk2] [PATCH v3 11/13] MdeModulePkg/Universal/PlatformDriOverrideDxe: Use safe string functions to refine code.

Difference with previous patch: Use one local variable to cache buffer size, then use it in the below reference. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Liming Gao --- .../PlatformDriOverrideDxe/PlatDriOverrideDxe.c | 21

[edk2] [PATCH] ShellPkg: Refine the code logic of mv.c.

When doing the mv we should check whether source is 'above' dest on file path tree. This patch make the check logic more precise. Signed-off-by: Qiu Shumin Reviewed-by: Jaben Carsey --- ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c | 10 ++ 1 file changed, 6 insert

[edk2] [PATCH v3 1/1] ShellPkg: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Jaben Carsey Reviewed-by: Star Zeng --- ShellPkg/Application/Shell/FileHandleWrappers.c| 16 --- ShellPkg/Application/Shell/Shell.c | 50 +++--- ShellPkg

[edk2] [PATCH v3 0/1] ShellPkg: Use safe string functions to refine code.

DXE_PERFORMANCE_STRING_SIZE is smaller than DP_GAUGE_STRING_LENGTH now, but this manner might introduce a potential risk of buffer overflow. Qiu Shumin (1): ShellPkg: Use safe string functions to refine code. ShellPkg/Application/Shell/FileHandleWrappers.c| 16 --- ShellPkg/Application/Shell/Shell.c

[edk2] [PATCH v2 10/13] MdeModulePkg/Universal/PCD: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Star Zeng --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 8 +--- MdeModulePkg/Universal/PCD/Pei/Service.c | 8 +--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg

[edk2] [PATCH v2 05/13] MdeModulePkg/Library/SmmCorePerformanceLib: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Star Zeng --- MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/SmmCorePerformanceLib

[edk2] [PATCH v2 01/13] MdeModulePkg/Application/MemoryProfileInfo: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Star Zeng --- MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Application/MemoryProfileInfo

[edk2] [PATCH 12/13] MdeModulePkg/Universal/SmbiosDxe: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c

[edk2] [PATCH 02/13] MdeModulePkg/Library/DxeCorePerformanceLib: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c

[edk2] [PATCH 04/13] MdeModulePkg/Library/PeiPerformanceLib: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.c b/MdeModulePkg

[edk2] [PATCH 05/13] MdeModulePkg/Library/SmmCorePerformanceLib: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePerformanceLib.c b

[edk2] [PATCH 03/13] MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/DebugLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/DebugLib.c b/MdeModulePkg

[edk2] [PATCH 09/13] MdeModulePkg/Universal/FvSimpleFileSystemDxe: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c

[edk2] [PATCH 08/13] MdeModulePkg/Universal/CapsuleRuntimeDxe: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleService.c b/MdeModulePkg

[edk2] [PATCH 11/13] MdeModulePkg/Universal/PlatformDriOverrideDxe: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../Universal/PlatformDriOverrideDxe/PlatDriOverrideDxe.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideDxe.c

[edk2] [PATCH 10/13] MdeModulePkg/Universal/PCD: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Universal/PCD/Dxe/Service.c | 4 ++-- MdeModulePkg/Universal/PCD/Pei/Service.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Universal/PCD/Dxe/Service.c b

[edk2] [PATCH 07/13] MdeModulePkg/Universal/CapsulePei: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Universal/CapsulePei/UefiCapsule.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/CapsulePei/UefiCapsule.c b/MdeModulePkg/Universal/CapsulePei

[edk2] [PATCH 06/13] MdeModulePkg/Library/UefiBootManagerLib: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 24 ++ .../Library/UefiBootManagerLib/BmPerformance.c | 20 ++ 2 files changed, 28 insertions(+), 16 deletions

[edk2] [PATCH 00/13] MdeModulePkg: Use safe string functions to refine code.

Qiu Shumin (13): MdeModulePkg/Application/MemoryProfileInfo: Use safe string functions to refine code. MdeModulePkg/Library/DxeCorePerformanceLib: Use safe string functions to refine code. MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode: Use safe string functions to refine

[edk2] [PATCH 01/13] MdeModulePkg/Application/MemoryProfileInfo: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.c b

[edk2] [PATCH 13/13] MdeModulePkg/Universal/Variable: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariable.c | 6 +++--- MdeModulePkg/Universal/Variable/RuntimeDxe/VarCheck.c | 2 +- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6

[edk2] [PATCH v2 ] ShellPkg: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Jaben Carsey --- ShellPkg/Application/Shell/FileHandleWrappers.c| 16 --- ShellPkg/Application/Shell/Shell.c | 50 +++--- ShellPkg/Application/Shell

[edk2] [PATCH] ShellPkg: Use safe string functions to refine code.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Application/Shell/FileHandleWrappers.c| 16 --- ShellPkg/Application/Shell/Shell.c | 56 -- ShellPkg/Application/Shell/ShellEnvVar.c | 6

[edk2] [PATCH] MdePkg\Library\UefiFileHandleLib: Make FileHandleWriteLine support both ASCII and UNICODE file.

When the file is a UNICODE file (with UNICODE file tag) write UNICODE text. When the file is an ASCII file write ASCII text. If the file size is zero (without the file tag at the beginning) write ASCII text as default. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu

[edk2] [PATCH] ShellPkg\Application\Shell: Refine the code style.

BOOLEAN variable should not use explicit comparisons to TRUE or FALSE. To follow EDKII code style. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Application/Shell/ConsoleLogger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg AcpiTableDxe: Non-Boolean comparisons should use a compare operator.

Reviewed-by: Qiu Shumin -Original Message- From: Zeng, Star Sent: Friday, June 19, 2015 3:56 PM To: edk2-devel@lists.sourceforge.net Cc: Qiu, Shumin Subject: [PATCH] MdeModulePkg AcpiTableDxe: Non-Boolean comparisons should use a compare operator. Cc: Shumin Qiu Contributed-under

[edk2] [PATCH] MdePkg: Refine the cod logic of FileHandleLib.

When the file is empty, make FileHandleReadLine in FileHandleLib return EFI_SUCCESS instead of EFI_BUFFER_TOO_SMALL. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../Library/UefiFileHandleLib/UefiFileHandleLib.c | 41 ++ 1 file

[edk2] [PATCH] MdePkg: Refine the comments for FileHandleLib.

Make the function comments of FileHandleLib consistent with instance implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Include/Library/FileHandleLib.h | 17 -- MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c

[edk2] [PATCH 0/2] Enhance the comments for MemoryAllocationLib of SMM instance

Per PI spec all allocation of SMRAM should use EfiRuntimeServicesCode or EfiRuntimeServicesData. So SMM instance use EfiRuntimeServicesCode as the default memory allocation type instead of EfiBootServicesData. This patch clarify this usage in comments. Qiu Shumin (2): MdePkg: Enhance the

[edk2] [PATCH 1/2] MdePkg: Enhance the comments for SmmMemoryAllocationLib instance.

Per PI spec all allocation of SMRAM should use EfiRuntimeServicesCode or EfiRuntimeServicesData. So SMM instance use EfiRuntimeServicesCode as the default memory allocation type instead of EfiBootServicesData. This patch clarify this usage in comments. Signed-off-by: Qiu Shumin

[edk2] [PATCH 2/2] MdeModulePkg: Enhance the comments for PiSmmCoreMemoryAllocationLib instance.

Per PI spec all allocation of SMRAM should use EfiRuntimeServicesCode or EfiRuntimeServicesData. So SMM instance use EfiRuntimeServicesCode as the default memory allocation type instead of EfiBootServicesData. This patch clarify this usage in comments. Signed-off-by: Qiu Shumin

[edk2] [PATCH v2 ] MdePkg: Refine the comments for FileHandleIsDirectory.

Make the function comments of FileHandleIsDirectory in FileHandleLib consistent with instance implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Jaben Carsey --- MdePkg/Include/Library/FileHandleLib.h | 11

[edk2] [PATCH] MdePkg: Refine the comments for FileHandleIsDirectory.

Make the function comments of FileHandleIsDirectory in FileHandleLib consistent with instance implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Include/Library/FileHandleLib.h | 4 ++-- MdePkg/Library/UefiFileHandleLib

[edk2] [PATCH 1/2] MdePkg: Make function comments in UefiHandleLib consistent with instance implementation.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Jaben Carsey --- MdePkg/Include/Library/FileHandleLib.h | 4 ++-- MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[edk2] [PATCH 0/2] Refine the code logic of UefiHandleLib and update the function comments.

*** BLURB HERE *** Qiu Shumin (2): MdePkg: Make function comments in UefiHandleLib consistent with instance implementation. MdePkg/Library/UefiFileHandleLib: Do the validation for DirHandle before get file information. MdePkg/Include/Library/FileHandleLib.h | 4

[edk2] [PATCH 2/2] MdePkg/Library/UefiFileHandleLib: Do the validation for DirHandle before get file information.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c b/MdePkg/Library

[edk2] [PATCH] MdePkg: Make the implementation of UefiFileHandleLib instance consistent with comments in header file.

Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c b/MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c index be66c57..7245

[edk2] [PATCH] MdeModulePkg: Add type cast to avoid build failure in GCC.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/PropertiesTableAttributesDxe

[edk2] [PATCH] MdeModulePkg: Refine the comments format for PropertiesTable.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 5 +++-- .../PropertiesTableAttributesDxe/PropertiesTableAttributesDxe.c | 2 +- .../PropertiesTableAttributesDxe

Re: [edk2] build error for Shell.efi

Hi Winddy, This issue is caused by a Non-ASCII char in Parse.c:193. I have sent a patch to fix it. Thanks, Shumin From: winddy [mailto:winddy_zh...@foxmail.com] Sent: Monday, June 08, 2015 8:59 PM To: edk2-devel Subject: [edk2] build error for Shell.efi Hi experts, I find in latest code b

[edk2] [PATCH] ShellPkg\Application\Shell: Clean start row information after the console has been Reset or SetMode.

OriginalStartRow and CurrentStartRow should be initialized after new mode is set. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Signed-off-by: Eric Jin --- ShellPkg/Application/Shell/ConsoleLogger.c | 13 ++--- 1 file changed, 10 insertions(+), 3

[edk2] [PATCH] ShellPkg: Fix the Non-ASCII char and do code refine.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Library/UefiShellLevel2CommandsLib/Parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Parse.c b/ShellPkg/Library

[edk2] [PATCH 0/3] Make DebugLib and PrintLib support %u and %lu formats.

Add %u and %lu support for PrintLib and DebugLib. Qiu Shumin (3): IntelFrameworkModulePkg: Add %u and %lu support for DebugLib. MdeModulePkg: Add %u and %lu support for PrintLib and DebugLib. MdePkg: Add %u and %lu support for PrintLib and DebugLib. IntelFrameworkModulePkg/Library

[edk2] [PATCH 3/3] MdePkg: Add %u and %lu support for PrintLib and DebugLib.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Include/Library/PrintLib.h | 5 - MdePkg/Library/BasePrintLib/PrintLibInternal.c | 26 ++ MdePkg/Library/BasePrintLib/PrintLibInternal.h | 3 ++- 3 files

[edk2] [PATCH 1/3] IntelFrameworkModulePkg: Add %u and %lu support for DebugLib.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../Library/PeiDxeDebugLibReportStatusCode/DebugLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode

[edk2] [PATCH 2/3] MdeModulePkg: Add %u and %lu support for PrintLib and DebugLib.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- .../Library/DxePrintLibPrint2Protocol/PrintLib.c | 26 +++--- .../PeiDxeDebugLibReportStatusCode/DebugLib.c | 2 +- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a

[edk2] [PATCH] MdeModulePkg: Refine the format of INF file.

0001-MdeModulePkg-Refine-the-format-of-INF-file.patch Description: Binary data -- ___ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/list

[edk2] [PATCH] MdePkg: Refine the format of comment in WindowsUxCapsule.h

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Include/IndustryStandard/WindowsUxCapsule.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/IndustryStandard/WindowsUxCapsule.h b/MdePkg/Include/IndustryStandard

Re: [edk2] [PATCH] ShellPkg: Update help output for correct alphabetical rev 2

The patch is good to me. Reviewed-by: Qiu Shumin -Shumin From: Carsey, Jaben Sent: Thursday, May 28, 2015 9:29 AM To: Shah, Tapan; Qiu, Shumin; edk2-devel@lists.sourceforge.net Cc: Carsey, Jaben Subject: [PATCH] ShellPkg: Update help output for correct alphabetical rev 2 Tapan and Shumin

Re: [edk2] [Patch 0/2] Update coding style

The patch is good to me. Reviewed-by: Qiu Shumin -Original Message- From: Zhang, Chao B [mailto:chao.b.zh...@intel.com] Sent: Tuesday, May 19, 2015 10:44 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch 0/2] Update coding style Update coding style & fix potential

Re: [edk2] [PATCH] ShellPkg: Fix buffer overflow issue in 'map' command.

It was found by an actual buffer overflow occurring. -Shumin -Original Message- From: Carsey, Jaben Sent: Friday, May 08, 2015 11:36 PM To: Qiu, Shumin; edk2-devel@lists.sourceforge.net Cc: Yao, Jiewen; Carsey, Jaben Subject: RE: [edk2] [PATCH] ShellPkg: Fix buffer overflow issue in

Re: [edk2] [PATCH] ShellPkg: Fix buffer overflow issue in 'map' command.

; command. Hello The 2nd parameter should be: The maximum number of Destination Unicode char, including terminating null char. Should we use "(StrSize(Specific) + sizeof(CHAR16))/sizeof(CHAR16)" for 2nd parameter? Thank you Yao Jiewen -Original Message----- From: Qiu S

[edk2] [PATCH] ShellPkg: Fix buffer overflow issue in 'map' command.

This patch replace 'StrnCat' with 'StrnCatS' to avoid the buffer overflow in 'map.c'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c | 24 +++ 1 fil

[edk2] [PATCH] MdePkg: Add longer term new CPER memory section definition.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Include/Guid/Cper.h | 83 ++ MdePkg/MdePkg.dec | 3 ++ 2 files changed, 86 insertions(+) diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include

[edk2] [PATCH 2/2] MdePkg: Add bluetooth devicepath handling in device path library.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Yao Jiewen --- .../Library/UefiDevicePathLib/DevicePathFromText.c | 49 +- .../Library/UefiDevicePathLib/DevicePathToText.c | 39 - .../Library/UefiDevicePathLib

[edk2] [PATCH 1/2] MdePkg: Add UEFI2.5 bluetooth protocol/devicepath definition in MdePkg.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin Reviewed-by: Liming Gao Reviewed-by: Yao Jiewen --- MdePkg/Include/IndustryStandard/Bluetooth.h | 47 +++ MdePkg/Include/Protocol/BluetoothConfig.h | 514 MdePkg/Include/Protocol

Re: [edk2] [Patch V3 03/16] Nt32Pkg: Use the new PCDs defined in MdePkg and MdeModulePkg.

The patch is good to me. Reviewed-by: Qiu Shumin -Shumin -Original Message- From: Ni, Ruiyu Sent: Monday, April 27, 2015 10:54 AM To: edk2-devel@lists.sourceforge.net Cc: Ni, Ruiyu; Qiu, Shumin Subject: [Patch V3 03/16] Nt32Pkg: Use the new PCDs defined in MdePkg and MdeModulePkg

[edk2] FW: [Patch] ShellPkg: Refine the logic about allocating memory for variable name and data.

Hi Ruiyu, Could you help to review this patch? -Shumin From: Qiu, Shumin [mailto:shumin@intel.com] Sent: Friday, April 24, 2015 3:40 PM To: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: [edk2] [Patch] ShellPkg: Refine the logic about allocating memory for variable name and data

[edk2] [Patch] ShellPkg: Refine the logic about allocating memory for variable name and data.

Hi Jaben, The run time service 'QueryVariableInfo' is not proper to be used to get the variable name size. This patch refine the logic about allocating memory for variable name and data. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mai

Re: [edk2] [PATCH] ShellPkg: Remove memory leak when printing help and there are dynamic commands installed

The patch is good to me. Reviewed-by: Qiu Shumin mailto:shumin@intel.com>> -Shumin From: Carsey, Jaben Sent: Thursday, April 23, 2015 9:42 AM To: Qiu, Shumin; edk2-devel@lists.sourceforge.net Cc: Carsey, Jaben Subject: [PATCH] ShellPkg: Remove memory leak when printing help and the

Re: [edk2] [PATCH] ShellPkg: add more info to function block.

The patch is good to me. Reviewed-by: Qiu Shumin mailto:shumin@intel.com>> -Shumin From: Carsey, Jaben Sent: Wednesday, April 22, 2015 4:14 AM To: Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: [PATCH] ShellPkg: add more info to function block. Shumin, C

Re: [edk2] [PATCH]IntelFrameworkPkg: Fix typo in LegacyBios.h.

0.98 spec, it should be UmaAddress - 1. UmaAddress Start Address of Upper Memory Area (UMA) to be set as Read/Write. If UmaAddress is a valid address in the shadow RAM, it also indicates that the region from 0xC to (UmaAddress - 1) can be used for Option ROM. Thanks, Hot From: Qiu, Shumin

[edk2] [PATCH]IntelFrameworkPkg: Fix typo in LegacyBios.h.

Hi Jeff, Could you help review the patch? It fixed the typo in LegacyBios.h Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks, Shumin LegacyBios.h.patch Description: LegacyBios.h

[edk2] [Patch] ShellPkg: Remove extra quotes surrounding flag values.

Hi Jaben , Could you help review the patch? It remove the redundant quotes from flag values. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks, Shumin UefiShellLib.c.patch Description: UefiShellLib.c

Re: [edk2] [Patch] ShellPkg: Fix typo in ShellPkg.

n ShellPkg. On 3/13/2015 1:51 AM, Qiu, Shumin wrote: > Could you help review the patch? It fix the typo 'caculate' -> 'calculate'. + Get and calculate the frequency in tick/ms. The result is saved in the globle variable mFrequency Should probably be 'in tick

[edk2] [Patch] ShellPkg: Fix typo 'caculate' in ShellPkg.

Hi Jaben, Could you help review the patch? It fix the typo 'caculate' -> 'calculate'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks, Shumin ShellPkg_calculate_typo.patch Description:

[edk2] [Patch] ShellPkg: Add type cast to avoid build failure in VS2005.

: warning C4244: 'function' : conversion from 'int' to 'const BOOLEAN', possible loss of data " The attached patch add type cast to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>

Re: [edk2] [PATCH] ShellPkg: smbiosview show wrong information for Type 27

Reviewed-by: Shumin Qiu mailto:shumin@intel.com>> -Shumin From: Li, Elvin [mailto:elvin...@intel.com] Sent: Wednesday, March 04, 2015 3:34 PM To: edk2-devel@lists.sourceforge.net Cc: Davis, Brad A Subject: [edk2] [PATCH] ShellPkg: smbiosview show wrong information for Type 27 Hi Shumin/Ruiyu

Re: [edk2] [PATCH] ShellPkg: Parse new SMBIOS 3.0 fields

Reviewed-by: Shumin Qiu mailto:shumin@intel.com>> -Shumin From: Li, Elvin Sent: Monday, March 02, 2015 2:12 PM To: Carsey, Jaben; Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [PATCH] ShellPkg: Parse new SMBIOS 3.0 fields Shumin/Jaben, Could you h

[edk2] [Patch]NT32Pkg: Bind NT32 process to a single core to avoid NT32 crash issue in some multi-core processors.

Hi Erik, Could you help review this patch? In some situations a TPL violation will be reported by NT32 when running on some multi-core Intel processors. This patch bind NT32 process to a single core to avoid crash. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu

Re: [edk2] [PATCH] ShellPkg: cast return value to correct type based on what we passed in

Reviewed-by: Shumin Qiu mailto:joe.peter...@intel.com>> From: Peterson, Joe Sent: Wednesday, February 04, 2015 7:54 AM To: Carsey, Jaben; Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net Subject: RE: [PATCH] ShellPkg: cast return value to correct type based on what we passed in Reviewed-b

[edk2] [Patch]ShellPkg: Fix typos.

Hi Jaben, Could you help review this patch? Comment description should end with period '.' Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks Shumin Shell.patch Descript

Re: [edk2] [PATCH] ShellPkg: Refactor out a now-redundant function

Reviewed-by: Shumin Qiu mailto:joe.peter...@intel.com>> From: Carsey, Jaben Sent: Tuesday, February 03, 2015 5:09 AM To: Peterson, Joe; Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: [PATCH] ShellPkg: Refactor out a now-redundant function Joe and Shumin, Can you

Re: [edk2] [PATCH] ShellPkg: Add quotes around NSH index argument replacement

Reviewed-by: Shumin Qiu mailto:joe.peter...@intel.com>> -Shumin From: Carsey, Jaben Sent: Saturday, January 31, 2015 12:33 AM To: Qiu, Shumin; Peterson, Joe Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: [PATCH] ShellPkg: Add quotes around NSH index argument replacement J

[edk2] [Patch]ShellPkg: Fix typos.

Hi Jaben, Could you help review this patch? It fix some typos in ShellPkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks Shumin ShellPkg_Typo.patch Description: ShellPkg_Typo

Re: [edk2] [Patch 1/1] ShellPkg: Refactor quote and escape search to use new function

Looks good to me. Reviewed-by: Shumin Qiu mailto:shumin@intel.com>> From: Carsey, Jaben Sent: Wednesday, January 28, 2015 7:35 AM To: Shah, Tapan (tapands...@hp.com); Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: [Patch 1/1] ShellPkg: Refactor quote and

Re: [edk2] [Patch 0/1] ShellPkg: Refactor Split search to generic function

Looks good to me. Reviewed-by: Shumin Qiu mailto:shumin@intel.com>> From: Carsey, Jaben Sent: Wednesday, January 28, 2015 7:35 AM To: Qiu, Shumin; Shah, Tapan (tapands...@hp.com) Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: [Patch 0/1] ShellPkg: Refactor Split sea

[edk2] [Patch] ShellPkg: Refine the fomat in INF/DEC files to follow spec.

Hi Jaben, Could you help review the attached patch. It refine the format in INF/DEC files to follow spec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks Shumin ShellPkg_INF_DEC.patch Description: ShellPkg_INF_DEC

Re: [edk2] [Patch] ShellPkg: Check the unrecognized environment variable name before it is removed from command line.

December 30, 2014 8:59 AM To: Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: RE: [edk2] [Patch] ShellPkg: Check the unrecognized environment variable name before it is removed from command line. Does the shell spec clearly indicate what characters can make a valid envi

[edk2] [Patch] ShellPkg: Check the unrecognized environment variable name before it is removed from command line.

*", execute b.nsh, the output is "*" The root cause is Shell treat '%c %' as an unrecognized environment variable, and replace it with a null string (""). The patch add code to check the name of an unrecognized environment variable, if it's a valid C st

[edk2] [Patch] ShellPkg: Add code to handle the split ('|') in a double-quoted string.

tput: 'ls"' is not recognized as an internal or external command, operable program, or script file. The patch add the code to check whether the '|' is in quotes. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@i

[edk2] [Patch] ShellPkg: Code refine. Add error handling code to check pointer and remove redundant 'ASSERT'.

Hi Jaben, Could you help review the patch? This patch adds error handling code to check the pointer returned from HiiGetString and remove redundant "ASSERT". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>>

  1   2   >