Re: [edk2] Identify Uefi version

2015-03-05 Thread Sergey Isakov
Hi, in Shell type ver Enjoy! On 03 марта 2015 г., at 22:41, Wirlino wrote: > > How to identify the uefi version > > > > In my bios said : > > > ASROCK motherboard > > UEFI version: PI1.20 > > > But i think which PI isn't the first (U)EFI > > > So..exist any command to show

Re: [edk2] Use Mouse

2015-02-26 Thread Sergey Isakov
Install a mouse driver, for example edk2/MdeModulePkg/Bus/Usb/UsbMouseDxe Start it. Poll mouse events by the protocol function ->GetState() And write your own actions on each state change. Best wishes. Sergey On 26.02.2015, at 17:28, S. Vieira wrote: > Hi all. > > My single doubt is : > > H

Re: [edk2] Any notifier for memory change

2015-02-18 Thread Sergey Isakov
No, memory change is not event for hardware. It is not interrupt as well. No matter of UEFI or not. On 19.02.2015, at 10:04, wrote: > No Andrew, It is not for debugging. > I wanted to develop some application which should be triggered after change > in memory content. > But to know that memory

Re: [edk2] 64-bit entry point and table in SMBIOS 3.0 implementation

2015-02-05 Thread Sergey Isakov
On 06.02.2015, at 9:02, Li, Elvin wrote: > Hi All, > 1. When PcdSmbios2xCompatibility is set to TRUE, 32-bit > entrypoint/table will be produced following SMBIOS 2.x spec. There are > several options for 64-bit entrypoint/table: Produce/Not Produce, > 4GBBelow/AnyWhereInMemory. It depend

Re: [edk2] Mouse and touchscreen support

2015-02-03 Thread Sergey Isakov
Hi, GetState() is enough. You probably have incompatibility device with driver. Regards. On 03 февр. 2015 г., at 21:39, Denis Alberto Silverio wrote: > Hi guys, > I´m developing an application that may have touchscreen and mouse support. > So, I´m trying to use the SIMPLE_POINTER_PROTOCOL an

Re: [edk2] Do EFI drivers ever stopped?

2015-01-30 Thread Sergey Isakov
Thanks, I understand that a custom driver should react on ExitBootSevice to perform needed action. Good drivers already do this. On 30.01.2015, at 12:07, Laszlo Ersek wrote: > On 01/30/15 09:23, Sergey Isakov wrote: >> Dear sirs, >> >> Sorry for the stupid questi

[edk2] Do EFI drivers ever stopped?

2015-01-30 Thread Sergey Isakov
Dear sirs, Sorry for the stupid question, I am not found an explanation. If an UEFI BIOS loaded additional drivers then how to stop all of them at OS started? I may propose that OnExitBootService do this but DxeMain.c->CoreExitBootServices () does not contain such codes. So user should do this?

Re: [edk2] [PATCH] StdLib, AppPkg: Update for new Library locations

2015-01-14 Thread Sergey Isakov
Sorry, and what about commit 16606 where PathLib was added into UefiShellLib? On 14.01.2015, at 0:33, Mcdaniel, Daryl wrote: > Lee and Jaben, could you please review the attached patches. Thank you. > > StdLib: Move libraries from ShellPkg into MdeModulePkg and MdePkg. > > The following libr

Re: [edk2] CirrusLogic5430 display card

2014-12-19 Thread Sergey Isakov
Why not emulate something more realistic, for example Intel GMA950? On 19 дек. 2014 г., at 17:46, Paolo Bonzini wrote: > > > On 19/12/2014 12:27, tiger...@via-alliance.com wrote: >> Hi, experts: >> >> I found an OptionROM example for CirrusLogic5430 display card in edkii >> source code packag

[edk2] `.data' type changed to PROGBITS

2014-12-19 Thread Sergey Isakov
Hi sirs, What this message means? ld: warning: section `.data' type changed to PROGBITS I see it when compiled by GCC49 as well as by XCODE5 some modules: edk2/DuetPkg/AcpiResetDxe edk2/DuetPkg/PciBusNoEnumerationDxe edk2/MdeModulePkg/Universal/PCD/Dxe I know, it is safe to ignore them b

Re: [edk2] a question about cache mechanism in EnhancedFatDxe

2014-12-18 Thread Sergey Isakov
Hi, I may propose that read data done by 64kb block. So to read first data 63-64 the driver must read 0-64 and then cache 0-63 for other use. The same for tail data. The driver read more then needed and redundant data is cached. The is no full cache mechanism to speedup data and cache size is sma

Re: [edk2] [Patch] ShellPkg: Add ASSERT to check pointer to avoid being dereferenced

2014-12-03 Thread Sergey Isakov
Fully agree with Scott. I replaced many ASSERT occurrence in ShellPkg by conditional Return statement and got the application working as never before. I hope developers will use ASSERT() only as comments and will not use then as check NULL pointers especially for function arguments that can't gua

Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages

2014-11-27 Thread Sergey Isakov
EndingLBA rather than StartingLBA and SizeInLBA. EndingLBA > = StartingLBA + SizeInLBA. So EndingLBA could be > 0x and up to 2T > space. > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Thursday, November 27, 2014 16:16 > To: edk2-devel@lists.source

Re: [edk2] [PATCH] MdeModulePkg : Misc comments and DEBUG messages

2014-11-27 Thread Sergey Isakov
Feng, IndustryStandard assumes UINT32 typedef struct { UINT8 BootIndicator; UINT8 StartHead; UINT8 StartSector; UINT8 StartTrack; UINT8 OSIndicator; UINT8 EndHead; UINT8 EndSector; UINT8 EndTrack; UINT8 StartingLBA[4]; UINT8 SizeInLBA[4]; } MBR_PARTITION_RECORD; Serge

[edk2] [BUG] UefiCpuDxe: duplicate symbol ExitBootServicesCallback

2014-11-26 Thread Sergey Isakov
Hi, duplicate symbol _ExitBootServicesCallback in: CpuDxe.obj and CpuMp.obj. One of them should be excluded or renamed. Wishes, Sergey -- Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Inst

Re: [edk2] Thunk16 or NASM changed?

2014-11-12 Thread Sergey Isakov
Sorry, it is YASM. On 12.11.2014, at 11:30, Sergey Isakov wrote: > Hi sirs, > Is there anybody knows what is changed in Thunk16.nasm or in NASM ? > -- > /X64/Thunk16.iii:137: error: unexpected STRICT after instruction > /X64/Thunk16.iii:244: warning: `ds' segment re

[edk2] Thunk16 or NASM changed?

2014-11-12 Thread Sergey Isakov
Hi sirs, Is there anybody knows what is changed in Thunk16.nasm or in NASM ? -- /X64/Thunk16.iii:137: error: unexpected STRICT after instruction /X64/Thunk16.iii:244: warning: `ds' segment register ignored in 64-bit mode /X64/Thunk16.iii:246: warning: `es' segment register ignored in 64-bit

Re: [edk2] NASM and Xcode issues

2014-11-11 Thread Sergey Isakov
What about switching to YASM? http://yasm.tortall.net --- Yasm is a complete rewrite of the NASM assembler under the “new” BSD License (some portions are under other licenses, see COPYINGfor details). Yasm currently supports the x86 and AMD64 instruction sets, accepts NASM and GAS assembler synt

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-11 Thread Sergey Isakov
ared here > --strip-unneeded -R .eh_frame > d:\uefi\buildtest-016\edk2\Build\ArmPlatform\RELEASE_GCC49\AARCH64\ArmPlatformPkg\Bds\Bds\DEBUG\ArmPlatformBds.dll > GLOBAL_REMOVE_IF_UNREFERENCED const UINT16 > _gPcd_FixedAtBuild_PcdFdtDevicePath[1] = {0 }; > > Thanks, > S

[edk2] [BUG] ShellPkg: FreePool of NULL pointer

2014-11-10 Thread Sergey Isakov
Dear sir, See, please, ShellPkg/Application/Shell/FileHandleWrappers.c: 561 if (FoundFileList != NULL && !IsListEmpty(&FoundFileList->Link)) { TabLinePos = (EFI_SHELL_FILE_INFO*)GetFirstNode(&FoundFileList->Link); InTabScrolling = TRUE; } else {

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-08 Thread Sergey Isakov
pe, TokenCName, Array)) AutoGenH.Append('#define %s %s_gPcd_FixedAtBuild_%s\n' %(GetModeName, Type, TokenCName)) AutoGenH.Append('//#define %s ASSERT(FALSE) // It is not allowed to set value for a FIXED_AT_BUILD PCD\n' % SetModeName) ——— Now LTO works fine. On 08 нояб.

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-08 Thread Sergey Isakov
, 0x21, 0x55, 0x16, 0x52, 0x85, 0x4E, 0x37 }|VOID*|0x4004 ——— Really these are GUIDs and must be initialized other way, not here. Sergey On 08 нояб. 2014 г., at 10:50, Sergey Isakov wrote: > > On 08 нояб. 2014 г., at 0:08, Scott Duplichan wrote: > >> >> AutoGen.h:50

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-07 Thread Sergey Isakov
On 08 нояб. 2014 г., at 0:08, Scott Duplichan wrote: > > AutoGen.h:50:20: warning: > type of '_gPcd_FixedAtBuild_PcdShellFile' does not match original declaration > extern const VOID* _gPcd_FixedAtBuild_PcdShellFile[]; > > AutoGen.c:277:43: note: previously declared here > GLOBAL_REMOVE_IF_UNR

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-07 Thread Sergey Isakov
nt variables > don't work in the inf file. Maybe having gcc in the path before building > would allow use of just gcc-ar in the inf file. > > Another way to solve the problem is to continue to use ar, but add the > --plugin argument to tell ar where to find the pl

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-07 Thread Sergey Isakov
ith GCC49 LTO. > > Unzip the archive and run build.bat. All 3 shell builds should complete. > > I deleted the build directory and other temps to reduce archive size. > Compilers and all other required build tools are included. > > Thanks, > Scott > > From:

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-07 Thread Sergey Isakov
ese: > * Convert GCC49 to LTO only > * Wait for GCC50 to enable LTO > * Add GCC49LTO I think it may be like conditional compilation ./build.sh -D WITH_LTO By default no. > > -Jordan > >> From: Sergey Isakov [mailto:isakov...@bk.ru] >> Sent: Friday, November 07, 2014 07:06

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-07 Thread Sergey Isakov
of the 4 changes needed is not detailed enough for easy > application. Instead, apply this patch: > http://sourceforge.net/projects/edk2developertoolsforwindows/files/Patches/Link%20Time%20Optimization/ > > Thanks, > Scott > > From: Sergey Isakov [mailto:isakov...@bk.ru

Re: [edk2] Status of gcc link time optimization for EDK2 use

2014-11-07 Thread Sergey Isakov
It is very interesting and I hope someone can apply this to EDK2. I failed. I created gcc-4.9.2 for linux-gnu target with --enable-plugin. And binutils with --enable-plugins. Success. But option -flto brakes building. This advice - 2) Use gcc to launch the ld instead of invoking ld direct

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Sergey Isakov
On 06.11.2014, at 11:26, Jordan Justen wrote: > Is NASM just plain incompatible with XCODE? I see no problems. It is compatible with key *_XCODE5_X64_NASM_FLAGS = -f macho64--

Re: [edk2] Win32 Compress and UEFI Decompress Question

2014-11-05 Thread Sergey Isakov
See DuetPkg. It uses LzmaCompress —— @echo Compressing DxeMain.efi ... @%BASETOOLS_DIR%\LzmaCompress -e -o %BUILD_DIR%\FV\DxeMain.z %BUILD_DIR%\%PROCESSOR%\DxeCore.efi —— and UefiDecompressLib —— UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf —— It is working….

Re: [edk2] [PATCH v2 0/7] OVMF: Adding support for Qemu Q35 machine type

2014-10-24 Thread Sergey Isakov
Mac OS X always run in APIC mode. Correct me if I'n wrong. On 24.10.2014, at 13:51, Paolo Bonzini wrote: > On 10/24/2014 05:33 AM, Gabriel L. Somlo wrote: >> This patch removes hard-coded assumptions about the presence of a PIIX4 >> chipset, and dynamically probes for the presence of either PIIX4

Re: [edk2] [PATCH v2 0/7] OVMF: Adding support for Qemu Q35 machine type

2014-10-24 Thread Sergey Isakov
Mac OS X always run in APIC mode. Correct me if I'n wrong. On 24.10.2014, at 13:51, Paolo Bonzini wrote: > On 10/24/2014 05:33 AM, Gabriel L. Somlo wrote: >> This patch removes hard-coded assumptions about the presence of a PIIX4 >> chipset, and dynamically probes for the presence of either PIIX4

Re: [edk2] Print(L"0x%.16x", Value) not working as expected

2014-10-17 Thread Sergey Isakov
You are right this is a bug but the library was deprecated. New one edk2/MdePkg/Library/BasePrintLib has no such bug. On 17.10.2014, at 14:22, wrote: > Hi, > I tried to print a UINT64 value as follows and hoped to get output > “0x1122334455667788”: > { > UINT64 Value = 0x1122334455667788; >

Re: [edk2] BaseTools: Add MINGW tool chain

2014-10-15 Thread Sergey Isakov
Thanks, NASM is properly works with GCC49 and with XCLANG and with XCODE. I hope BaseLib will always be created with it. On 16 окт. 2014 г., at 7:36, Scott Duplichan wrote: > Sergey Isakov [mailto:isakov...@bk.ru] wrote: > > ]Sorry??? > > Hello Sergey, > > Are you

Re: [edk2] BaseTools: Add MINGW tool chain

2014-10-15 Thread Sergey Isakov
Sorry??? On 15.10.2014, at 10:47, Scott Duplichan wrote: > === > --- MdePkg/Library/BaseLib/BaseLib.inf(revision 16195) > +++ MdePkg/Library/BaseLib/BaseLib.inf(working copy) > @@ -252,7 +252,7 @@ > Ia32/DisableCach

Re: [edk2] BaseTools: Enable gcc -Wunused-but-set-variable for IA32 and X64 builds

2014-10-13 Thread Sergey Isakov
I expected too much errors with variable Status like this ——— edk2/MdeModulePkg/Library/DxeCoreMemoryAllocationLib/MemoryAllocationLib.c:148:15: error: variable 'Status' set but not used [-Werror=unused-but-set-variable] —— Sergey On 14 окт. 2014 г., at 7:08, Gao, Liming wrote: > Scott: > I

[edk2] ShellPkg: dmpstore issue

2014-10-09 Thread Sergey Isakov
Dear sirs, I encounter an undefined behavior of dmpstore command. GUID of variables looks like random. Tracing the problem I found that the procedure - SHELL_STATUS EFIAPI CascadeProcessVariables ( IN CONST CHAR16 *NameOPTIONAL, IN CONST EFI_GUID*GuidOPTIONAL,

[edk2] CoreLoadImage output bug?

2014-10-08 Thread Sergey Isakov
Dear sirs, In the module /MdeModulePkg/Core/Dxe/Image/Image.c I see the procedure -- EFI_STATUS EFIAPI CoreLoadImage ( IN BOOLEANBootPolicy, IN EFI_HANDLE ParentImageHandle, IN EFI_DEVICE_PATH_PROTOCOL *FilePath, IN VOID *Sour

[edk2] Action opcode should not have TextTwo part

2014-10-03 Thread Sergey Isakov
Hi sirs, What is means this warning: VfrCompile... Bm.i(110): WARNING: 0x0002 : Action opcode should not have TextTwo part Same in FrontPageVfr.i(40), FE.i(106) (112, 147, 153) I see no correlation between these digits (line numbers?) with real lines. BaseTools and Vfr sources are most rece

Re: [edk2] Error in ApciS3Save compiled by clang

2014-09-30 Thread Sergey Isakov
30.09.2014, at 16:34, Andrew Fish wrote: > > On Sep 30, 2014, at 5:13 AM, Sergey Isakov wrote: > >> Hi sirs, >> New problem >> >> Building ... >> /Users/sergey/src/edk2/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf >> [X64] >

[edk2] Error in ApciS3Save compiled by clang

2014-09-30 Thread Sergey Isakov
Hi sirs, New problem Building ... /Users/sergey/src/edk2/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf [X64] /Users/sergey/src/edk2/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c:216:33: error: second argument to 'va_arg' is of promotable type 'UINT16' (aka

Re: [edk2] LzmaCustomDecompressLib is not working

2014-09-26 Thread Sergey Isakov
Anyway the code is already modified with statements like #ifndef EFIAPI On 12 сент. 2014 г., at 9:18, Gao, Liming wrote: > Sergey: > LzmaDec.c is LZMA code. Have you other solution without modify LZMA code? > > Thanks > Liming > From: Sergey Isakov [mailto:isakov...@bk.ru]

Re: [edk2] LzmaCustomDecompressLib is not working

2014-09-11 Thread Sergey Isakov
maProps)); return SZ_OK; } --- Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sergey Isakov On 10.09.2014, at 18:01, Sergey Isakov wrote: > Hi all, > I encounter a problem that LzmaCustomDecompressLib is not working if compiled > by Clang into IA32. But it works

Re: [edk2] VolumeLabel is never NULL

2014-09-11 Thread Sergey Isakov
he second issue is not an issue, because the type of VolumeLabel is UINT16 * > not array, it just use the same name as the member in > EFI_FILE_SYSTEM_VOLUME_LABEL structure. > > > BTW, which tool do you use to detect this issue? > > Thanks, > Eric > From: Serg

[edk2] VolumeLabel is never NULL

2014-09-11 Thread Sergey Isakov
Hi, In the module edk2/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/BootOption.c:373 I got a warning said that the comparison is always FALSE - if (FileContext->Info->VolumeLabel == NULL) { VolumeLabel = L"NULL VOLUME LABEL"; } else { - because the

[edk2] LzmaCustomDecompressLib is not working

2014-09-10 Thread Sergey Isakov
Hi all, I encounter a problem that LzmaCustomDecompressLib is not working if compiled by Clang into IA32. But it works fine with GCC49. The sources are very complex and I see no significant constructions that may be differ from gcc to clang. Can anybody point me what to look? The version is 4.65

Re: [edk2] svn problem

2014-09-05 Thread Sergey Isakov
I made full edk2 checkout and now it is OK. I have svn 1.7.10 But removing only BaseLib and svn up was not help. On 05 сент. 2014 г., at 21:36, Jordan Justen wrote: > On Fri, Sep 5, 2014 at 9:46 AM, Sergey Isakov wrote: >> Hi sirs, >> what is it? >> ——— >> Skipped

[edk2] svn problem

2014-09-05 Thread Sergey Isakov
Hi sirs, what is it? ——— Skipped 'MdePkg/Library/BaseLib/X64/Thunk16.nasm' -- Node remains in conflict Skipped 'MdePkg/Library/BaseLib/Ia32/Thunk16.nasm' -- Node remains in conflict Fetching external item into 'BaseTools/Bin/Win32': External at revision 23. At revision 16063. ——— Sergey-

Re: [edk2] Xcode 5 and Ovmf.

2014-09-05 Thread Sergey Isakov
Resolved! It was an argument -DNO_BUILTIN_VA_FUNCS that must be excluded from Clang compilation. Sorry for disturbing! On 05.09.2014, at 12:44, Sergey Isakov wrote: > I made disassembler of the program and found the follow: > This routine > -- > UINTN > EFIAPI > A

Re: [edk2] Xcode 5 and Ovmf.

2014-09-05 Thread Sergey Isakov
at addr 1a74 while it should contain the second argument. I may propose that Clang see only one argument and doesn't bother about second. What should we change to make c-sources to be compatible with Clang? Sergey On 04.09.2014, at 22:17, Sergey Isakov wrote: > Hi Andrew, > One mor

Re: [edk2] Xcode 5 and Ovmf.

2014-09-04 Thread Sergey Isakov
e Sergey On 01 сент. 2014 г., at 21:43, Sergey Isakov wrote: > Hi, > QvmfPkg compiled by XCODE5 to RELEASE works with Qemu 2.1.0 ! > Great! > Sergey > > > On 01 сент. 2014 г., at 11:09, Sergey Isakov wrote: > >> Hi Andrew, >> your patches are good. I test

Re: [edk2] [PATCH] MdePkg BaseLib NASM Thunk16: Initialize _16GdtrBase to 0

2014-09-03 Thread Sergey Isakov
Hi sirs, In commit 16024 you forget to set ASM_PFX(InternalAsmThunk16) in two places Sergey On 01.09.2014, at 16:28, Sergey Isakov wrote: > > On 01.09.2014, at 14:58, Paolo Bonzini wrote: > >> Il 31/08/2014 20:23, Sergey Isakov ha scritto: >>> Clang assembler does

Re: [edk2] Xcode 5 and Ovmf.

2014-09-01 Thread Sergey Isakov
Hi, QvmfPkg compiled by XCODE5 to RELEASE works with Qemu 2.1.0 ! Great! Sergey On 01 сент. 2014 г., at 11:09, Sergey Isakov wrote: > Hi Andrew, > your patches are good. I tested CpuExceptionHandler.lib and Thunk16.nasm in > Ovmf+Qemu2.0 compiled by GCC49. Works fine! > But with X

Re: [edk2] [PATCH] MdePkg BaseLib NASM Thunk16: Initialize _16GdtrBase to 0

2014-09-01 Thread Sergey Isakov
On 01.09.2014, at 14:58, Paolo Bonzini wrote: > Il 31/08/2014 20:23, Sergey Isakov ha scritto: >> Clang assembler doesn’t support 16 bit codes. > > (please don't top-post) > > Does Apple not ship gas anymore and replaces it with clang's integrated > assemb

Re: [edk2] Xcode 5 and Ovmf.

2014-09-01 Thread Sergey Isakov
Hi Andrew, your patches are good. I tested CpuExceptionHandler.lib and Thunk16.nasm in Ovmf+Qemu2.0 compiled by GCC49. Works fine! But with XCLANG (Xcode 4.4.1) I got an error -- qemu: fatal: Trying to execute code outside RAM or ROM at 0x000a RAX= RBX=fffc

Re: [edk2] [PATCH] MdePkg BaseLib NASM Thunk16: Initialize _16GdtrBase to 0

2014-08-31 Thread Sergey Isakov
Clang assembler doesn’t support 16 bit codes. On 31 авг. 2014 г., at 20:16, Paolo Bonzini wrote: > Il 30/08/2014 08:47, Jordan Justen ha scritto: >> All, >> >> Sergey reported that XCLANG was able to build and link with my latest >> version. (Apparently he still has issues booting OVMF, but I d

Re: [edk2] Xcode 5 and Ovmf.

2014-08-31 Thread Sergey Isakov
Hi, Take into account that MTOC is also extra tool not shipped with XCODE nor with BaseTools. Sergey On 30 авг. 2014 г., at 18:54, Andrew Fish wrote: > > On Aug 29, 2014, at 10:42 PM, Jordan Justen wrote: > >> On Fri, Aug 29, 2014 at 4:53 PM, Andrew Fish wrote: >>> With these 3 patches you

Re: [edk2] Xcode 5 and Ovmf.

2014-08-29 Thread Sergey Isakov
There is download for MacOSX. Tested in 10.9.4 and 10.7.5 http://www.nasm.us/pub/nasm/releasebuilds/2.11.05/macosx/ On 30 авг. 2014 г., at 9:42, Jordan Justen wrote: > On Fri, Aug 29, 2014 at 4:53 PM, Andrew Fish wrote: >> With these 3 patches you can boot the EFI shell X64 Ovmf on Mac OS X usi

Re: [edk2] Xcode 5 and Ovmf.

2014-08-29 Thread Sergey Isakov
Thank you, Andrew I am busy now and can test only next week. On 30 авг. 2014 г., at 3:53, Andrew Fish wrote: > With these 3 patches you can boot the EFI shell X64 Ovmf on Mac OS X using > Xcode 5. > [edk2] [OvmfPkg][Review] Use XCODE5 toolchain for current and future OS X > versions > [edk2] [

Re: [edk2] [UefiCpuPkg][CpuExceptionHandlerLib] Make self modifying code work with Xcode

2014-08-29 Thread Sergey Isakov
Hi Andrew, I have one doubt. Should there be a LEA command? Register RAX will contain address not value. Sergey On 30 авг. 2014 г., at 3:34, Andrew Fish wrote: > DoReturn: > pushq %rax > -movabsq ASM_PFX(mDoFarReturnFlag), %rax > +movqASM_PFX(mDoFarReturnFlag)(%rip), %rax >

[edk2] Typos in comments in GenericBdsLib

2014-08-29 Thread Sergey Isakov
Hi sirs, I think the typos should be corrected IntelFrameworkModulePkg/Library/GenericBdsLib: BdsBoot.c:54 Deletete the Boot Option from EFI Variable. The Boot Order Arrray BdsConnect.c:300 the correspoinding controllers if have. And at the same time, make BdsConsole.c:179 // No any availa

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-28 Thread Sergey Isakov
.quad ASM_PFX(CommonInterruptEntry) jmp *%rax It looks like more codes should be revised. And I vote to rewrite this part to nasm too. On 28 авг. 2014 г., at 21:10, Sergey Isakov wrote: > I understand. The value of 16GdtrBase is patched by C-codes in proced

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-28 Thread Sergey Isakov
I understand. The value of 16GdtrBase is patched by C-codes in procedure AsmPrepareThunk16() So we may set ——— >> _16GdtrBase: >> DQ 0 > - On 28 авг. 2014 г., at 15:48, Andrew Fish wrote: > > On Aug 28, 2014, at 4:30 AM, Sergey Isakov wrote: > >

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-28 Thread Sergey Isakov
Hm, looks like the value remains zero forever. And this works. On 28 авг. 2014 г., at 15:48, Andrew Fish wrote: > > On Aug 28, 2014, at 4:30 AM, Sergey Isakov wrote: > >> But what can you do with absolute addressing to _NullSeg? >> --- >> _EntryPoint: >

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-28 Thread Sergey Isakov
Aug 28, 2014, at 12:15 AM, Sergey Isakov wrote: > >>> >>> >>> Actually I just noticed you are getting an illegal text-relocation error. >>> This is usually caused by an absolute relocation, and clang wants it to be >>> IP relative. Basically Xcod

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-28 Thread Sergey Isakov
ecx, [ecx + (_BackFromUserCode - ASM_PFX(m16Start))] mov ax, cx stosd ; [edi] <- return address of user code add eax, _ToUserCode.RealAddrEnd - _BackFromUserCode On 28.08.2014, at 13:47, Sergey Isakov wrote: > I checked only for X64 but I thin

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-28 Thread Sergey Isakov
; > Thanks > Liming > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Thursday, August 28, 2014 3:16 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for > non-MSVC > > Comments below > &

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-28 Thread Sergey Isakov
Comments below On 28.08.2014, at 7:54, Andrew Fish wrote: > > On Aug 27, 2014, at 8:43 PM, Sergey Isakov wrote: > >> Jordan, >> There was no issue with gcc49 toolchain in x86_64. >> I made an attempt to use nasm with XCLANG toolset but failed on ld: >> I see

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
Is it possible to include new family? --- Ia32/Thunk16.s| CLANG Ia32/Thunk16.nasm | GCC --- On 28.08.2014, at 8:27, Andrew Fish wrote: > > On Aug 27, 2014, at 8:51 PM, Jordan Justen wrote: > >> On Wed, Aug 27, 2014 at 8:43 PM, Sergey Isakov wrote: >>&g

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
le to C) in assembly. Some > versions set it to '', and some version have it set to ‘_' > > #define ASM_PFX(name) _CONCATENATE (__USER_LABEL_PREFIX__, name) > > So you can have a bug that passes on one version and fails on another. > > Thanks, > > A

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
g 27, 2014 at 1:08 PM, Sergey Isakov wrote: >> And one new question. Why _16GdtrBase with underscore while m16Start without >> it? > > Does replacing m16Start with ASM_PFX(m16Start) help? > > It looks like I didn't convert this up properly. The

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
; On Wed, Aug 27, 2014 at 5:18 AM, Sergey Isakov wrote: >> Hi sirs, >> I tested Thunk16.nasm too. For x86_64 there is no issue. >> For ia32 compilation disasm shows not good codes >> - >> : >> 0: 00 00 add%al,(%eax) &g

Re: [edk2] [PATCH 0/8] NASM: Object files; Thunk16; Require for non-MSVC

2014-08-27 Thread Sergey Isakov
Hi sirs, I tested Thunk16.nasm too. For x86_64 there is no issue. For ia32 compilation disasm shows not good codes - : 0: 00 00 add%al,(%eax) 2: 00 00 add%al,(%eax) ... 0006 <_BackFromUserCode>: 6: 16

Re: [edk2] build ovmf failure

2014-08-25 Thread Sergey Isakov
Did you update Conf/build_rules.txt to use nasm? On 25.08.2014, at 14:29, chen.fan.f...@cn.fujitsu.com wrote: > Hi, > > I always built OVMF successfully, but today I pull the newest edk2 code > to build OVMF then showing building failure: > >

Re: [edk2] [PATCH] BaseTools: Revert r15816 and r15831 to fix !if in .fdf

2014-08-19 Thread Sergey Isakov
I confirm, it works. Thank you! -- !if ($(ARCH) == X64) -- On 20.08.2014, at 8:50, Liu, Yingke D wrote: > Hi Jordan, > > The issue has been root caused. Before retiring top level makefile, the > GenFds command was executed by make fds, but after the change, we call GenFds > command dir

Re: [edk2] [PATCH 1/8] BaseTools/tools_def: Add NASM_FLAGS

2014-08-19 Thread Sergey Isakov
Thanks! I will test. May be add check for minimum NASM version? On 20 авг. 2014 г., at 3:57, Jordan Justen wrote: > Note: Only tested with the GCC49 toolchain so far. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jordan Justen > --- > BaseTools/Conf/tools_def.tem

Re: [edk2] [Patch][Basetools]Fix a build failure in Linux

2014-08-19 Thread Sergey Isakov
Because if statement is always FALSE. On 19 авг. 2014 г., at 19:49, Olivier Martin wrote: > I confirm this error too. It looks the recent BaseTools requires a ‘!else’ to > interpret the file correctly ... > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: 19 August

Re: [edk2] [Patch][Basetools]Fix a build failure in Linux

2014-08-19 Thread Sergey Isakov
.08.2014, at 13:14, Gao, Liming wrote: > Could you show the error message? > > > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Tuesday, August 19, 2014 5:05 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [Patch][Basetools]Fix a build failure

Re: [edk2] [PATCH] IntelFrameworkModulePkg/SourceLevelDebugPkg : Fix comment typos

2014-08-19 Thread Sergey Isakov
:19, Dong, Eric wrote: > Hi Sergey, > > Please help to review this patch which fix the typo about word “hanlde”, also > fix another three one in SourceLevelDebugPkg. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong > > Th

Re: [edk2] [Patch][Basetools]Fix a build failure in Linux

2014-08-19 Thread Sergey Isakov
For example message make: *** No rule to make target `fds'. Stop. On 19.08.2014, at 13:05, Sergey Isakov wrote: > No, > revision 15831 is still not working in OSX. > > On 19.08.2014, at 12:07, Gao, Liming wrote: > >> Hess: >> The patch is good. >>

Re: [edk2] [Patch][Basetools]Fix a build failure in Linux

2014-08-19 Thread Sergey Isakov
No, revision 15831 is still not working in OSX. On 19.08.2014, at 12:07, Gao, Liming wrote: > Hess: > The patch is good. > Reviewed-by: Gao, Liming > > From: Chen, Hesheng [mailto:hesheng.c...@intel.com] > Sent: Tuesday, August 19, 2014 2:44 PM > To: edk2-devel@lists.sourceforge.net > Subje

Re: [edk2] [PATCH] UefiCpuPkg/ArchExceptionHandler.c: Fix comment typos

2014-08-18 Thread Sergey Isakov
Hi, I also find the word “hanlde” in the edk2/IntelFrameworkModulePkg/Library/GenericBdsLib/ Please also fix On 08 июля 2014 г., at 13:17, chen.fan.f...@cn.fujitsu.com wrote: > On Tue, 2014-07-08 at 07:30 +, Fan, Jeff wrote: >> Hi, Chen >> >> Thanks your fix. >> >> I will help to check-in

[edk2] Redundant codes in MdeModulePkg PartitionDxe

2014-08-18 Thread Sergey Isakov
Contribution Agreement 1.0 Signed-off-by: Sergey Isakov -- ___ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel

[edk2] Wrong build.py rev 15816

2014-08-18 Thread Sergey Isakov
Hi sirs, Commit 15816 contains broken build.py. I can compile after reverting the file to revision 15809. Please consider. Sergey -- ___ edk2-devel mailing list edk2-devel@list

Re: [edk2] Redundant Base tools

2014-08-01 Thread Sergey Isakov
that option and let us know if that works. > > Thanks, > > Mike > > -Original Message- > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Thursday, July 31, 2014 6:19 AM > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] Redundant Base tools >

[edk2] Redundant Base tools

2014-07-31 Thread Sergey Isakov
Hi sirs, Is there any config to NOT fetch Win32 binaries as I don't want to spend my space and time and internet traffic? -- Fetching external item into 'BaseTools/Bin/Win32' ABaseTools/Bin/Win32/VfrCompile.exe ... -- Wishes, Sergey

Re: [edk2] UEFI Graphic Components

2014-07-30 Thread Sergey Isakov
Hi, Toolkit no, sample yes. http://refit.sourceforge.net Sergey On 30.07.2014, at 15:18, Rafael Machado wrote: > Hi Everyone > > Quick question. > I've already searched on the internet but didn't get any result. > Does any of you know if is there any kind of graphic toolkit with components >

Re: [edk2] GOP issue

2014-07-29 Thread Sergey Isakov
Hi, It is not a hardware issue. It is a problem of driver that provided GOP. The driver should be able to set any graphics mode that supported both by monitor and by VideoCard. If not supported then the driver have not to report existence of such modes. Best, Sergey. On 29 июля 2014 г., at 23:3

Re: [edk2] UEFI mouse/touchscreen in Hyper-V

2014-07-24 Thread Sergey Isakov
So I don't think I can use > UsbMouseDxe and I guess Microsoft hasn't made a custom driver for pointer > input. > > > On Thu, Jul 24, 2014 at 12:50 AM, Sergey Isakov wrote: > Hi, > I don't know what is Hyper-V but if you have no SimplePointerProtocol then &g

Re: [edk2] UEFI mouse/touchscreen in Hyper-V

2014-07-23 Thread Sergey Isakov
Hi, I don't know what is Hyper-V but if you have no SimplePointerProtocol then you have to install it by loading additional Dxe driver like edk2/MdeModulePkg/Bus/Usb/UsbMouseDxe Hope it helps, Sergey On 24.07.2014, at 9:06, Thomas Rognon wrote: > Does anyone know how to capture pointer input in

Re: [edk2] [BUG] Wrong usage sizeof(SIZE)

2014-07-17 Thread Sergey Isakov
Reviewed-by: Jeff Fan > > Thanks! > Jeff > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Wednesday, July 16, 2014 2:50 AM > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] [BUG] Wrong usage sizeof(SIZE) > > Dear sirs, > > File edk2/OptionRomPkg/Ci

Re: [edk2] Resource leak at CoreSectionExtraction

2014-07-16 Thread Sergey Isakov
> > Thanks > Feng > > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Wednesday, July 16, 2014 14:52 > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] Resource leak at CoreSectionExtraction > > Dear sirs, > > Next report. File

[edk2] Resource leak at CoreSectionExtraction

2014-07-15 Thread Sergey Isakov
Dear sirs, Next report. File edk2/MdeModulePkg/Core/Dxe/SectionExtraction/CoreSectionExtraction.c: line 1007. Resource leak: CurrentChildNode - Status = CreateChildNode (SourceStream, 0, &CurrentChildNode); if (EFI_ERROR (Status)) { return Status; } - because the proc

[edk2] [BUG] Wrong usage sizeof(SIZE)

2014-07-15 Thread Sergey Isakov
Dear sirs, File edk2/OptionRomPkg/CirrusLogic5430Dxe/Edid.c line:143 ——— *EdidDataBlock = AllocateCopyPool ( sizeof (EDID_BLOCK_SIZE), ValidEdid ); —— There must be EDID_BLOCK_SIZE not sizeof(). Summary: Suspicious usage of 'sizeof

[edk2] Resource leak in BdsBoot.c

2014-07-15 Thread Sergey Isakov
Dear sirs, File edk2/IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c Procedure BdsRefreshBbsTableForBoot() Local array DeviceType is AllocatePooled at line 1587 but never FreePooled. Sergey-- Want fast and easy ac

Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()

2014-07-11 Thread Sergey Isakov
Hi Star, Comments inline Regards, Sergey > Hi Sergey, > > My comments added below. > > Thanks, > Star > From: Sergey Isakov [mailto:isakov...@bk.ru] > Sent: Friday, July 11, 2014 7:05 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk

[edk2] break statement missing in switch statement

2014-07-11 Thread Sergey Isakov
Hi, Look, please, edk2/EmbeddedPkg/Library/EfiFileLib/EfiFileLib.c, line 1503+ switch (File->Type) { case EfiOpenMemoryBuffer: if ((File->CurrentPosition + *BufferSize) > File->MaxPosition) { return EFI_END_OF_FILE; } CopyMem (File->Buffer + File->CurrentPosition, Bu

Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr()

2014-07-11 Thread Sergey Isakov
s, > Star > From: Tian, Feng [mailto:feng.t...@intel.com] > Sent: Monday, July 07, 2014 1:36 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [BUG] Wrong StrLen usage in UnicodeStrToAsciiStr() > > Hi, Isakov > > Thanks for raising this issue. We will w

[edk2] [BUG] Possible array out of bounds

2014-07-11 Thread Sergey Isakov
Hi, I checked EDK2 sources with cppcheck program and found this mistake edk2/IntelFrameworkModulePkg/Universal/BdsDxe/BootMaint/UpdatePage.c:line582 -- for (OptionIndex = 0; (OptionOrder[OptionIndex] != 0 && OptionIndex < MAX_MENU_NUMBER); OptionIndex++) { -- Warning said --- The variab

Re: [edk2] [RFC] Proposal to retire edk2-buildtools sub-project

2014-07-10 Thread Sergey Isakov
On 11 июля 2014 г., at 3:11, Kinney, Michael D wrote: > Delete Win32 binaries from EDK II It is my dream! Thank you!-- Open source business process management suite built on Java and Eclipse Turn processes into busines

  1   2   3   >