Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-22 Thread Jordan Justen
On Thu, May 22, 2014 at 7:03 AM, David Woodhouse wrote: > On Thu, 2014-05-22 at 09:08 +0200, Gerd Hoffmann wrote: >> >> David, I vaguely remember you had some plans/ideas on the fat issue. >> So, if you have some spare cycles for ovmf atm I'd suggest to look into >> that before fixing s3 with csm

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-22 Thread Laszlo Ersek
On 05/21/14 14:19, David Woodhouse wrote: > On Tue, 2014-05-13 at 04:54 +0200, Laszlo Ersek wrote: >> >> But, second, we've known for quite some time that windows server 2008 r2 >> works well with the SeaBIOS CSM and a few edk2 patches (thanks again to >> David Woodhouse and Kevin O'Connor). >> >>

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-22 Thread David Woodhouse
On Thu, 2014-05-22 at 09:08 +0200, Gerd Hoffmann wrote: > > David, I vaguely remember you had some plans/ideas on the fat issue. > So, if you have some spare cycles for ovmf atm I'd suggest to look into > that before fixing s3 with csm present. This is annoying. It should be so simple to reimplem

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-22 Thread Laszlo Ersek
On 05/22/14 03:46, Jordan Justen wrote: > On Wed, May 21, 2014 at 5:19 AM, David Woodhouse wrote: >> On Tue, 2014-05-13 at 04:54 +0200, Laszlo Ersek wrote: >>> (Without enabling the CSM in an OVMF build, the option to legacy-boot is >>> lost of course as well, but I expressly don't desire that opt

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-22 Thread Gerd Hoffmann
Hi, > > Which is why I spent the time to enable CSM in the first place, of > > course. Not to mention the fact that having OVMF+CSM as a default > > firmware will serve to accelerate adoption of UEFI in virtual machines, > > and that gives people a *really* easy playground to get involved in EDK

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-21 Thread Jordan Justen
On Wed, May 21, 2014 at 5:19 AM, David Woodhouse wrote: > On Tue, 2014-05-13 at 04:54 +0200, Laszlo Ersek wrote: >> (Without enabling the CSM in an OVMF build, the option to legacy-boot is >> lost of course as well, but I expressly don't desire that option. Just >> boot legacy OSes with pure SeaBI

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-21 Thread Laszlo Ersek
On 05/21/14 14:19, David Woodhouse wrote: > On Tue, 2014-05-13 at 04:54 +0200, Laszlo Ersek wrote: >> - The specific (possibly accidental, fixable) problem is that using the >> SeaBIOS CSM plus the CSM infrastructure in edk2 breaks OVMF's S3 resume. >> I had not set out to track this down because

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-21 Thread Gerd Hoffmann
Hi, > Or were you really intending the tools to give the user an explicit > choice of legacy vs. UEFI rather than depending on the OS? That would > kind of suck too. Microsoft does exactly that. Latest hyper-v has "generation 1" (== bios) and "generation 2" (== efi) virtual machines. There ar

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-21 Thread David Woodhouse
On Tue, 2014-05-13 at 04:54 +0200, Laszlo Ersek wrote: > > But, second, we've known for quite some time that windows server 2008 r2 > works well with the SeaBIOS CSM and a few edk2 patches (thanks again to > David Woodhouse and Kevin O'Connor). > > There are two problems with the CSM, one specifi

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Laszlo Ersek
On 05/13/14 01:22, Jordan Justen wrote: > On Mon, May 12, 2014 at 2:35 PM, Laszlo Ersek wrote: >> On 05/12/14 22:49, Jordan Justen wrote: >>> On Mon, May 12, 2014 at 10:41 AM, Laszlo Ersek wrote: On 05/12/14 18:03, Jordan Justen wrote: > On Mon, May 12, 2014 at 6:18 AM, Laszlo Ersek >>>

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Laszlo Ersek
On 05/12/14 22:27, Mike Maslenkin wrote: > I just wanted to point that since it is documented behavior may be a > strict requirement for CSM is enough to run W7, W2K8R2, instead of > having a bunch of code requiring a special compilation with NASM. But > anyway, idea with shim is great. Ah, OK, I

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Jordan Justen
On Mon, May 12, 2014 at 2:35 PM, Laszlo Ersek wrote: > On 05/12/14 22:49, Jordan Justen wrote: >> On Mon, May 12, 2014 at 10:41 AM, Laszlo Ersek wrote: >>> On 05/12/14 18:03, Jordan Justen wrote: On Mon, May 12, 2014 at 6:18 AM, Laszlo Ersek wrote: > Additionally, there's another (

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Laszlo Ersek
On 05/12/14 22:49, Jordan Justen wrote: > On Mon, May 12, 2014 at 10:41 AM, Laszlo Ersek wrote: >> On 05/12/14 18:03, Jordan Justen wrote: >>> On Mon, May 12, 2014 at 6:18 AM, Laszlo Ersek >>> wrote: Additionally, there's another (similarly downstream only) patch OvmfPkg: Don't b

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Jordan Justen
On Mon, May 12, 2014 at 10:41 AM, Laszlo Ersek wrote: > On 05/12/14 18:03, Jordan Justen wrote: >> On Mon, May 12, 2014 at 6:18 AM, Laszlo Ersek >> wrote: >>> Additionally, there's another (similarly downstream only) patch >>> >>> OvmfPkg: Don't build in QemuVideoDxe when we have CSM >>> >>> Di

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Mike Maslenkin
> > On 05/12/14 18:21, Mike Maslenkin wrote: > > > >> > + Segment0 = 0; > + Segment0Pages = 1; > + Status = gBS->AllocatePages (AllocateAddress, EfiReservedMemoryType, > + Segment0Pages, &Segment0); > + if (EFI_ERROR (Status)) { > +goto

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Scott Duplichan
Mike Maslenkin [mailto:miha...@parallels.com] wrote: [...] ]1. I'm curious why do you call w2k8 driver buggy. ]According to this document ]http://technet.microsoft.com/en-us/library/hh824898.aspx While I can't speak for Laszlo, it is worth noting that the INT10 requirement was not added to that

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Laszlo Ersek
On 05/12/14 18:21, Mike Maslenkin wrote: > >> + Segment0 = 0; + Segment0Pages = 1; + Status = gBS->AllocatePages (AllocateAddress, EfiReservedMemoryType, + Segment0Pages, &Segment0); + if (EFI_ERROR (Status)) { +goto RestorePam1; +

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Laszlo Ersek
On 05/12/14 18:03, Jordan Justen wrote: > On Mon, May 12, 2014 at 6:18 AM, Laszlo Ersek > wrote: >> Additionally, there's another (similarly downstream only) patch >> >> OvmfPkg: Don't build in QemuVideoDxe when we have CSM >> >> Did you include the presence of this patch in your question? > > N

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Mike Maslenkin
> > >> + Segment0 = 0; > >> + Segment0Pages = 1; > >> + Status = gBS->AllocatePages (AllocateAddress, EfiReservedMemoryType, > >> + Segment0Pages, &Segment0); > >> + if (EFI_ERROR (Status)) { > >> +goto RestorePam1; > >> + } > > > > If CSM is enabled, we will fail

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Jordan Justen
On Mon, May 12, 2014 at 6:18 AM, Laszlo Ersek wrote: > Additionally, there's another (similarly downstream only) patch > > OvmfPkg: Don't build in QemuVideoDxe when we have CSM > > Did you include the presence of this patch in your question? No. I want to remove this patch from being needed, an

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-12 Thread Laszlo Ersek
On 05/10/14 00:49, Jordan Justen wrote: > On Thu, May 8, 2014 at 10:45 AM, Laszlo Ersek wrote: >> The Windows 2008 R2 SP1 UEFI guest's default video driver is buggy -- it >> dereferences the real mode Int10h vector, loads the pointed-to handler >> code, and executes what it thinks to be VGA BIOS s

Re: [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2014-05-09 Thread Jordan Justen
On Thu, May 8, 2014 at 10:45 AM, Laszlo Ersek wrote: > The Windows 2008 R2 SP1 UEFI guest's default video driver is buggy -- it > dereferences the real mode Int10h vector, loads the pointed-to handler > code, and executes what it thinks to be VGA BIOS services in an internal > real-mode emulator.