Re: [edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Andrew Fish
On Jun 21, 2013, at 2:02 PM, Tom Rini wrote: >> Another solution would be to introduce an environment variable (eg: >> EDK_BUILD_PATH) set by edksetup.(sh|bat) with a default value equal to >> $(WORKSPACE) that can be overwritten. > > I suspect this would work for everyones use cases. > This

Re: [edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Olivier Martin
H 1/9] ArmPlatformPkg/ArmVExpressPkg: Add > support for EDK2_OUT_DIR build parameter > > > > On Jun 21, 2013, at 10:36 AM, Ryan Harkin > wrote: > > > On 21 June 2013 17:12, Andrew Fish wrote: > >> > >> On Jun 21, 2013, at 4:23 AM, Ryan Harkin

Re: [edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Andrew Fish
On Jun 21, 2013, at 10:36 AM, Ryan Harkin wrote: > On 21 June 2013 17:12, Andrew Fish wrote: >> >> On Jun 21, 2013, at 4:23 AM, Ryan Harkin wrote: >> >>> On 21 June 2013 11:15, Olivier Martin wrote: I am not convinced by this patch. The use case you gave is the automated build sy

Re: [edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Ryan Harkin
On 21 June 2013 17:12, Andrew Fish wrote: > > On Jun 21, 2013, at 4:23 AM, Ryan Harkin wrote: > >> On 21 June 2013 11:15, Olivier Martin wrote: >>> I am not convinced by this patch. >>> The use case you gave is the automated build system. Nothing prevent you to >>> do a move the folder around af

Re: [edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Andrew Fish
On Jun 21, 2013, at 4:23 AM, Ryan Harkin wrote: > On 21 June 2013 11:15, Olivier Martin wrote: >> I am not convinced by this patch. >> The use case you gave is the automated build system. Nothing prevent you to >> do a move the folder around after building it. > > That's not quite suitable for

Re: [edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Ryan Harkin
On 21 June 2013 11:15, Olivier Martin wrote: > I am not convinced by this patch. > The use case you gave is the automated build system. Nothing prevent you to > do a move the folder around after building it. That's not quite suitable for our CI builds, but I see your point. > Instead of changin

Re: [edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Olivier Martin
I am not convinced by this patch. The use case you gave is the automated build system. Nothing prevent you to do a move the folder around after building it. Instead of changing all the DSC files of EDK2, I would prefer to see a patch that changes the 'build' command to allow to overwrite the Build

[edk2] [PATCH 1/9] ArmPlatformPkg/ArmVExpressPkg: Add support for EDK2_OUT_DIR build parameter

2013-06-21 Thread Ryan Harkin
Add support to the build config to allow the user to specify a custom output directory to the build. This is particularly useful for automated build systems. Eg. build -a ARM -p ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc -t ARMLINUXGCC \ -D EDK2_ARMVE_STANDALONE=1 \