Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-11-27 Thread Olivier Martin
: edk2-devel@lists.sourceforge.net; Olivier Martin; Drew Jones; msal...@redhat.com; Paolo Bonzini; Kevin Wolf Subject: Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol On Thu, Nov 21, 2013 at 9:17 AM, Laszlo Ersek ler...@redhat.com wrote: Jordan

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-11-27 Thread Laszlo Ersek
On 11/27/13 12:48, Olivier Martin wrote: Laszlo go ahead for the v5 to make the change you would like to see. I have really appreciated the amount of time you have spent on reviewing the patchset. Making your own changes would save you some of your time. Thank you very much! I'll seek to send

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-11-08 Thread Jordan Justen
On Wed, Oct 30, 2013 at 5:51 PM, Laszlo Ersek ler...@redhat.com wrote: On 10/31/13 00:26, Jordan Justen wrote: Jordan, could you please explain the problem again? This protocol interface doesn't seem to follow the conventions of the other io protocols. In addition, the alignment issue seems

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-30 Thread Laszlo Ersek
On 10/29/13 18:16, Jordan Justen wrote: On Mon, Oct 28, 2013 at 10:36 PM, Olivier Martin olivier.mar...@arm.com wrote: Unfortunately, the caller (the VirtIo Block driver) does not know if the access is unaligned. Did you or Laszlo say that the virtio spec specifically says that all I/O

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-30 Thread Jordan Justen
On Wed, Oct 30, 2013 at 3:41 AM, Laszlo Ersek ler...@redhat.com wrote: On 10/29/13 18:16, Jordan Justen wrote: On Mon, Oct 28, 2013 at 10:36 PM, Olivier Martin olivier.mar...@arm.com wrote: Unfortunately, the caller (the VirtIo Block driver) does not know if the access is unaligned. Did

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-30 Thread Laszlo Ersek
On 10/31/13 00:26, Jordan Justen wrote: Jordan, could you please explain the problem again? This protocol interface doesn't seem to follow the conventions of the other io protocols. In addition, the alignment issue seems unresolved to me. I just don't want any code outside of EDK II to

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-29 Thread Jordan Justen
22:57 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol On Wed, Oct 16, 2013 at 10:29 AM, Olivier Martin olivier.mar...@arm.com wrote: Not changed: - Endianness: All the architectures

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-28 Thread Laszlo Ersek
On 10/16/13 19:29, Olivier Martin wrote: Changelog from v3: -- - Fixed 'write size' in VIRTIO_DEVICE_WRITE comment - Made all the functions of the protocol return EFI_STATUS - Removed 'VIRTIO_GET_GUEST_FEATURES GetGuestFeatures' - Added a note about the fact

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-28 Thread Olivier Martin
To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol On Wed, Oct 16, 2013 at 10:29 AM, Olivier Martin olivier.mar...@arm.com wrote: Not changed: - Endianness: All the architectures supported

Re: [edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-23 Thread Jordan Justen
On Wed, Oct 16, 2013 at 10:29 AM, Olivier Martin olivier.mar...@arm.com wrote: Not changed: - Endianness: All the architectures supported by the UEFI spec are in 'little endian' mode. - Keep the PCI 64bit read/write break down into two 32bit accesses: The VirtiIo BlockIo

[edk2] [PATCH v4 00/11] OvmfPkg: Introduce and use the new VIRTIO_DEVICE_PROTOCOL protocol

2013-10-16 Thread Olivier Martin
Changelog from v3: -- - Fixed 'write size' in VIRTIO_DEVICE_WRITE comment - Made all the functions of the protocol return EFI_STATUS - Removed 'VIRTIO_GET_GUEST_FEATURES GetGuestFeatures' - Added a note about the fact VIRTIO_SET_QUEUE_ALIGN is a NOP - Fixed