Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-13 Thread Laszlo Ersek
On 11/13/14 00:22, Andrew Fish wrote: > >> On Nov 12, 2014, at 2:26 PM, Jordan Justen wrote: >> Too bad the DebugAgent isn't actually useful for all the trouble it >> causes. :) > > 1st question what is wrong with the DebugAgent? Why is int not useful? There's nothing wrong with it, it's just t

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Andrew Fish
> On Nov 12, 2014, at 7:00 PM, Jordan Justen wrote: > > On 2014-11-12 18:16:59, Andrew Fish wrote: >>> On Nov 12, 2014, at 5:49 PM, Jordan Justen >> > wrote: >>> On 2014-11-12 16:22:59, Andrew Fish wrote: I assumed there would be a Python script to convert

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Jordan Justen
On 2014-11-12 18:16:59, Andrew Fish wrote: > > On Nov 12, 2014, at 5:49 PM, Jordan Justen > > wrote: > > On 2014-11-12 16:22:59, Andrew Fish wrote: > >> I assumed there would be a Python script to convert to WinDBG to > >> gdb-remote. > > > > Hmm. That sounds horrible. Luckily, *I think* it actu

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Andrew Fish
> On Nov 12, 2014, at 5:49 PM, Jordan Justen wrote: > > On 2014-11-12 16:22:59, Andrew Fish wrote: >> >>On Nov 12, 2014, at 4:08 PM, Jordan Justen >>wrote: >> >>On 2014-11-12 15:22:18, Andrew Fish wrote: >>On Nov 12, 2014, at 2:26 PM, Jordan Justen < >>jord

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Jordan Justen
On 2014-11-12 16:22:59, Andrew Fish wrote: > > On Nov 12, 2014, at 4:08 PM, Jordan Justen > wrote: > > On 2014-11-12 15:22:18, Andrew Fish wrote: > On Nov 12, 2014, at 2:26 PM, Jordan Justen < > jordan.l.jus...@intel.com> wrote: > Too bad the Debug

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Fan, Jeff
: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Thursday, November 13, 2014 7:41 AM To: Gabriel Somlo; Laszlo Ersek; edk2-devel@lists.sourceforge.net Cc: pbonz...@redhat.com; gso...@gmail.com Subject: Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Andrew Fish
> On Nov 12, 2014, at 4:08 PM, Jordan Justen wrote: > > On 2014-11-12 15:22:18, Andrew Fish wrote: >>> On Nov 12, 2014, at 2:26 PM, Jordan Justen >> > wrote: >>> Too bad the DebugAgent isn't actually useful for all the trouble it >>> causes. :) >> >> 1st questi

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Jordan Justen
On 2014-11-12 15:22:18, Andrew Fish wrote: > > On Nov 12, 2014, at 2:26 PM, Jordan Justen > > wrote: > > Too bad the DebugAgent isn't actually useful for all the trouble it > > causes. :) > > 1st question what is wrong with the DebugAgent? Why is int not > useful? Last time I looked at it you h

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Jordan Justen
On 2014-11-12 15:12:25, Gabriel Somlo wrote: > On Wednesday, November 12, 2014 5:26 PM, Jordan Justen wrote: > >On 2014-11-12 03:23:04, Laszlo Ersek wrote: > >> SEC always runs, but whether or not SEC depends on TimerLib is > >> conditional on -D SOURCE_DEBUG_ENABLE. If it is absent, then the debug

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Andrew Fish
> On Nov 12, 2014, at 2:26 PM, Jordan Justen wrote: > Too bad the DebugAgent isn't actually useful for all the trouble it > causes. :) 1st question what is wrong with the DebugAgent? Why is int not useful? 2nd question why are you using the DebugAgent, when you could just use the QEMU built in

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Andrew Fish
> On Nov 12, 2014, at 3:12 PM, Gabriel Somlo wrote: > > On Wednesday, November 12, 2014 5:26 PM, Jordan Justen wrote: >> On 2014-11-12 03:23:04, Laszlo Ersek wrote: >>> SEC always runs, but whether or not SEC depends on TimerLib is >>> conditional on -D SOURCE_DEBUG_ENABLE. If it is absent, then

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Gabriel Somlo
On Wednesday, November 12, 2014 5:26 PM, Jordan Justen wrote: >On 2014-11-12 03:23:04, Laszlo Ersek wrote: >> SEC always runs, but whether or not SEC depends on TimerLib is >> conditional on -D SOURCE_DEBUG_ENABLE. If it is absent, then the debug >> agent is not pulled in (*), and then SEC doesn't

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Jordan Justen
On 2014-11-12 03:23:04, Laszlo Ersek wrote: > On 11/11/14 22:34, Gabriel Somlo wrote: > > On Sun, Nov 09, 2014 at 10:13:54AM -0800, Jordan Justen wrote: > >> On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: > >>> Since in OVMF both PEI_CORE and PEIM run from RAM, and thus may > >>> utilize global va

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global

2014-11-12 Thread Laszlo Ersek
On 11/12/14 14:30, Gabriel Somlo wrote: > On Wed, 12 Nov 2014 12:23:04 +0100, Laszlo Ersek wrote: >> On 11/11/14 22:34, Gabriel Somlo wrote: >>> On Sun, Nov 09, 2014 at 10:13:54AM -0800, Jordan Justen wrote: On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: > + // > + // Check to see

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global

2014-11-12 Thread Gabriel Somlo
On Wed, 12 Nov 2014 12:23:04 +0100, Laszlo Ersek wrote: > On 11/11/14 22:34, Gabriel Somlo wrote: > > On Sun, Nov 09, 2014 at 10:13:54AM -0800, Jordan Justen wrote: > >> On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: > >>> + // > >>> + // Check to see if the Power Management Base Address is alr

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-12 Thread Laszlo Ersek
On 11/11/14 22:34, Gabriel Somlo wrote: > On Sun, Nov 09, 2014 at 10:13:54AM -0800, Jordan Justen wrote: >> On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: >>> Since in OVMF both PEI_CORE and PEIM run from RAM, and thus may >>> utilize global variables, use the "Base" AcpiTimerLib instance >>> (ins

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-11 Thread Gabriel Somlo
On Sun, Nov 09, 2014 at 10:13:54AM -0800, Jordan Justen wrote: > On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: > > Since in OVMF both PEI_CORE and PEIM run from RAM, and thus may > > utilize global variables, use the "Base" AcpiTimerLib instance > > (instead of BaseRom) to take advantage of the i

Re: [edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-09 Thread Jordan Justen
On 2014-11-08 14:02:00, Gabriel L. Somlo wrote: > Since in OVMF both PEI_CORE and PEIM run from RAM, and thus may > utilize global variables, use the "Base" AcpiTimerLib instance > (instead of BaseRom) to take advantage of the improved efficiency > of storing the timer register IO address in a glob

[edk2] [PATCH v5 6/9] OvmfPkg: AcpiTimerLib: Use global variable during PEI_CORE and PEIM

2014-11-08 Thread Gabriel L. Somlo
Since in OVMF both PEI_CORE and PEIM run from RAM, and thus may utilize global variables, use the "Base" AcpiTimerLib instance (instead of BaseRom) to take advantage of the improved efficiency of storing the timer register IO address in a global variable. This leaves only SEC using the BaseRomAcpi