On Fri, Nov 14, 2014 at 03:25:51PM +0100, Laszlo Ersek wrote:
> On 11/14/14 15:12, Paolo Bonzini wrote:
> >
> >
> > On 14/11/2014 14:40, Laszlo Ersek wrote:
> >> Now where is my thought process wrong? You might want to add an assert
> >> somewhere.
>
> I don't think your thought
On 11/14/14 15:12, Paolo Bonzini wrote:
>
>
> On 14/11/2014 14:40, Laszlo Ersek wrote:
>> Now where is my thought process wrong? You might want to add an assert
>> somewhere.
I don't think your thought process is wrong. I think I'm being exactly
as right (or as wrong) as Se
On 14/11/2014 14:40, Laszlo Ersek wrote:
>>> >> Now where is my thought process wrong? You might want to add an assert
>>> >> somewhere.
>> >
>> > I don't think your thought process is wrong. I think I'm being exactly
>> > as right (or as wrong) as SeaBIOS under all cases, which is what I was
>>
On 11/14/14 14:31, Gabriel Somlo wrote:
> On Fri, Nov 14, 2014 at 10:26:55AM +0100, Laszlo Ersek wrote:
>> One question.
>>
>> On 11/14/14 04:01, Gabriel L. Somlo wrote:
>>> +
>>> + Status = EFI_SUCCESS;
>>> +
>>> + if (PciHdr->Device.InterruptPin != 0) {
>>
>> so here InterruptPin >= 1
>
> Same
On Fri, Nov 14, 2014 at 10:26:55AM +0100, Laszlo Ersek wrote:
> One question.
>
> On 11/14/14 04:01, Gabriel L. Somlo wrote:
> > +
> > + Status = EFI_SUCCESS;
> > +
> > + if (PciHdr->Device.InterruptPin != 0) {
>
> so here InterruptPin >= 1
Same as in SeaBIOS pci_bios_init_device() under "/* m
One question.
On 11/14/14 04:01, Gabriel L. Somlo wrote:
> Remove hard-coded list of PCI devices for which the Interrupt Line
> register is initialized. Instead, provide a "visitor" function to
> initialize the register only for present and applicable PCI devices.
>
> At this time, we match the b
On Do, 2014-11-13 at 22:01 -0500, Gabriel L. Somlo wrote:
> New in version 7: correctly handle Q35 case with more than 24 slots
> on the root bus.
>
> SeaBIOS traverses the device path starting at the leaf and climbing
> toward the root, so the last "slot" value in mch_pci_slot_get_irq()
> is that
Remove hard-coded list of PCI devices for which the Interrupt Line
register is initialized. Instead, provide a "visitor" function to
initialize the register only for present and applicable PCI devices.
At this time, we match the behavior of SeaBIOS (file src/fw/pciinit.c,
functions *_pci_slot_get_
