Reviewed-by: Tapan Shah mailto:tapands...@hp.com>>
From: Carsey, Jaben [mailto:jaben.car...@intel.com]
Sent: Tuesday, June 30, 2015 4:35 PM
To: Qiu, Shumin; Shah, Tapan
Cc: edk2-devel@lists.sourceforge.net; El-Haj-Mahmoud, Samer; Carsey, Jaben
Subject: RE: [Patch] ShellPkg: fix string to number co
Hi Jaben,
The patch looks good to me.
I think the comments for InternalShellStrHexToUint64 should also be updated.
The 'UINTN' in line 3731 and line 3808 should be 'UINT64'.
Reviewed-by: Qiu Shumin mailto:shumin@intel.com>>
From: Carsey, Jaben
Sent: Wednesday, July 01, 2015 5:35 AM
To: Qiu
I ran some more tests and found that I wanted one more line of code in the
patch. Please check this one instead.
From: Carsey, Jaben
Sent: Tuesday, June 30, 2015 1:54 PM
To: Qiu, Shumin; Shah, Tapan (tapands...@hp.com)
Cc: edk2-devel@lists.sourceforge.net; El-Haj-Mahmoud, Samer
(samer.el-haj-ma
Shumin / Tapan,
Can you review this?
This makes stopping at spaces work with only zero as the value. I also
attached a NSH file that can be used to verify the results. Before this the
loops from 0 to 3 would only execute once as the zero was converted as 3.
ShellPkg: fix string to number con
