Re: [PATCH 1/2 v2] Don't overflow in __libdw_in_section

2017-12-14 Thread Ulf Hermann
On 12/14/2017 02:43 PM, Mark Wielaard wrote: > (Meta, I have some trouble applying this with git am, it thinks the > patch is malformed. But I can apply by hand of course.) Oh, sorry for that. It's probably the leading spaces again. I keep messing up my mail setup on windows ... > The transforma

Re: [PATCH 2/2 v2] Generalize cu_sec_idx

2017-12-14 Thread Ulf Hermann
On 12/14/2017 02:51 PM, Mark Wielaard wrote: > This is clever and indeed cu_sec_idx () is not generic enough. > But this is also somewhat inefficient. I am working on DWARF5 support > and there a CU can come from even more different sections (or file). So > I am changing Dwarf_CU to have an explici

Re: [PATCH 2/2 v2] Generalize cu_sec_idx

2017-12-14 Thread Mark Wielaard
On Fri, 2017-12-08 at 16:06 +0100, Ulf Hermann wrote: > Apparently CUs can appear in other sections than IDX_debug_info and > IDX_types. Rather than relying on the indirect indication provided by > type_offset we compare the addresses directly to figure out which section > a given CU belongs to. T

Re: [PATCH 1/2 v2] Don't overflow in __libdw_in_section

2017-12-14 Thread Mark Wielaard
Hi Ulf, (Meta, I have some trouble applying this with git am, it thinks the patch is malformed. But I can apply by hand of course.) On Fri, 2017-12-08 at 16:05 +0100, Ulf Hermann wrote: > > +2017-05-09  Ulf Hermann   > + > + * libdwP.h: Fix check for the upper border of the range in  > __lib