indentation still stands.
--
Sébastien Miquel
be a bit fragile, and in particular it assumes that the
rest of the block has this =block-content-ind=, which might not be the
case. One could possibly at least check that the first line of the
block does have this much indentation. If it doesn't, just do
whatever.
--
Sébastien Miquel
Ihor Radchenko writes:
We should probably reserve the workaround to Emacs 28 and older and
eventually remove it when Org drops Emacs 28 support.
Ok.
I tested using Emacs 28 and 27 and your patch is passing all the tests.
Thanks.
--
Sébastien Miquel
From
of `indent-rigidly`.
The issues above do not seem too bad. They are uncommon, and an
indent-region call should fix the indentation.
--
Sébastien Miquel
Ihor Radchenko writes:
Sebastien, it looks like one of the tests is failing on the older Emacs:
https://builds.sr.ht/~bzg/job/1020247
Does this specify anywhere what version of emacs it is using ?
Most likely, because `current-column' did not take into account 'display
property until
Ihor Radchenko writes:
May you now rebase the patch onto the latest main, add a Link: to this
discussion to the commit message, and apply the attached extra comments?
Here it is. Thanks for helping with this.
--
Sébastien MiquelFrom 7906d7b7fa2d376e95156ab7177494f2cececaff Mon Sep 17
Ihor Radchenko writes:
For the second scenario, no special treatment of current line is needed.
For the first scenario, why do we need to do it all the way in
`org-src--contents-for-write-back'? Why not directly in
`org-indent-line'?
Ah, yes, that is much better.
--
Sébastien MiquelFrom
g N using blank lines as well ?
1. It isn't consistent with the previous behaviour.
2. If I mistakenly add a space to an empty line in a src block, an
edit-special round trip will add indentation to every line.
Is there any benefit ?
--
Sébastien Miquel
Ihor Radchenko writes:
+ ;; Trim contents: `org-src--contents-for-write-back' may have
+ ;; added indentation at the beginning, which we remove.
May you also mention that we remove the indentation to avoid adding
spaces to latex fragments in the middle of a paragraph?
On
Ihor Radchenko writes:
But why do we need to avoid indenting empty lines?
In the following link, Greg Minshal argues for preserving empty lines:
https://list.orgmode.org/725763.1632663...@apollo2.minshall.org/T/
(CCing the mailing list)
--
Sébastien Miquel
Hi Ihor,
Thank you for the feedback.
Ihor Radchenko writes:
+ ;; Apply WRITE-BACK function on edit buffer contents.
+ (goto-char (point-min))
+ (when (functionp write-back) (save-excursion (funcall write-back)))
(set-marker marker nil
`save-excursion' is no longer
Ihor Radchenko writes:
This is not a problem. We can just apply appropriate 'display property
in `org-src-font-lock-fontify-block', manually replacing the tab with
appropriate number of spaces (as in the origin buffer).
Ok, that works, thanks.
Here are two patches, the first that removes the
ose more serious
issues, which had gone unnoticed so far.
--
Sébastien Miquel
Sébastien Miquel writes:
Should we use native buffer's value of =indent-tabs-mode= to set
=use-tabs?= ? I think this trivial change should work.
It doesn't seem quite that easy. If we want to add 4 columns to a tab
indented line (and tab width is 8), we can either call =indent-to= to
indent
a couple
of spaces in front of a tab indented piece of code, we can break
vertical alignment in the org buffer, which I think is pretty bad.
Should we use native buffer's value of =indent-tabs-mode= to set
=use-tabs?= ? I think this trivial change should work.
--
Sébastien Miquel
esn't seem to conflict for other org elements.
--
Sébastien Miquel
s newlines as whitespace, same with " ".
When I say significant, I don't mean for compilation. When editing an
array of equations for example, one might want to keep one equation
per line in the buffer.
--
Sébastien Miquel
w line (the "current" line is the one
from which the native edit was called).
--
Sébastien Miquel
Hi Ihor, wolf,
Ihor Radchenko writes:
Confirmed.
This is caused by `org-src--contents-for-write-back' not adjusting
blank line indentation in some cases.
I don't think that's the issue. In fact, applying your diff didn't
seem to solve the issue on my end.
Generally, if you edit the given
posal you originally described does not
bring any more flexibility beyond what can be done through short
advices, or indeed the `:filter-` functions. I'm not sure this
dedicated syntax is preferable to advices.
--
Sébastien Miquel
of feature names, and not require any
variable tied to the feature.
--
Sébastien Miquel
be described in the manual.
Having the user create a whole new option in order to toggle a
`chikenize` package seems a bit unwieldy, however.
--
Sébastien Miquel
to me how it ties with your syntax.
--
Sébastien Miquel
= argument, aren't they ? This seems very useful.
--
Sébastien Miquel
`transcoder-conditions`.
--
Sébastien Miquel
nd
concatenating some strings with its =content= argument.
--
Sébastien Miquel
round
Does that make sense? Do you have a better suggestion?
I think special blocks are a good fit for this purpose.
--
Sébastien Miquel
required some effort I did
not try it.
--
Sébastien Miquel
alised org-fill-element already acted natively.
Your patch looks and tests good to me.
--
Sébastien Miquel
-paragraph-act-natively variable.
--
Sébastien Miquel
eadability of this single exercice. The first three lines each
contain information that is important to me when I browse the file (as
opposed to information that's only relevant for org export).
The only line that contains no content information is the #+end_exercice
line, which is only here for the org parser.
--
Sébastien Miquel
Ihor Radchenko writes:
> Sébastien Miquel writes:
>
>> Ihor Radchenko writes:
>> > They do not. Tags are only considered inside headlines. Trying
to allow
>> > tags outside headlines will require major changes across the
whole Org
>> > codebase
tr_latex. That's a lot of wasted real estate.
--
Sébastien Miquel
:hard:
…
#+END_exercice
Does anyone think this is useful and might warrant adding support for ?
--
Sébastien Miquel
Hi Ihor,
I've implemented this proposal in the patch attached.
Does it look good to you ?
--
Sébastien MiquelFrom b1b783dc80821b07937ac4211ec28df8726fff1c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Sat, 13 Aug 2022 20:49:27 +0200
Subject: [PATCH] New babel syntax
Hi,
Ihor Radchenko writes:
> Let me know if you see any potential issues with the proposed change.
Thanks for looking into this. I think the change looks right, though I
am no great user of org-babel and its header arguments.
Regards,
--
Sébastien Miquel
Hi,
Renato Ferreira writes:
> Go to start of list, `org-mark-element`, then `org-fill-paragraph`.
The first item does not get filled.
This should be fixed on main. If not, please say so.
I'm removing this from updates.orgmode.org:
Canceled.
--
Sébastien Miquel
>> - three
>> four
>>
>> 4. mark all with "C-x h"
>> 5. type "M-q" to fill
>>
>> Actual:
>>
>> - one
>> two
>>
>> - three four
>>
>> Expected:
>>
>> - one two
>>
>> - three four
This is fixed on main.
Marking it as resolved on updates.orgmode.org:
Fixed.
--
Sébastien Miquel
you have any example of use in mind, beyond my original one ?
Regards,
--
Sébastien Miquel
Marking this as resolved on updates.orgmode.org, 2nd try.
|Fixed.|
--
Sébastien Miquel
Marking this as resolved on updates.orgmode.org.
|Fixed.|
--
Sébastien Miquel
Marking this as resolved on updates.orgmode.org.
Applied.
--
Sébastien Miquel
Applied, as 4e4250061.
Took a little while :P
--
Sébastien Miquel
Ihor Radchenko writes:
Thanks for the clarification! Now, your patch makes much more sense. Can
you update the commit message explaining the above shortly and linking
to this thread?
See attached.
Thanks,
--
Sébastien Miquel
From 72742cab341f66525e0acb0b92de65fb6d24c27f Mon Sep 17 00:00:00
used to generate images for preview,
and in some cases by ob-latex to compile a document from a LaTeX src
block.
Regards,
--
Sébastien Miquel
Hi,
The attached patch puts DEFAULT-PACKAGES before PACKAGES in
org-format-latex-header, as per org-latex-packages-alist's and
org-latex-classes' documentations.
Regards,
--
Sébastien Miquel
From 983e35f19371e3ea85ed28bd46f36ea5a52a3950 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3
merge access to the repository.
Regards,
--
Sébastien Miquel
,
--
Sébastien Miquel
From 2c9b72731247620dea2aed96a0a83385472e29cc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Wed, 8 Jun 2022 13:11:12 +0200
Subject: [PATCH] org.el (org-latex-preview): With an active region, act on it
* lisp/org.el (org-latex-preview): With an active
://list.orgmode.org/041ca43d-2efb-db1e-76ab-7c15af088...@posteo.eu/
where I submitted a different patch that fixes this issue (I think) and
a couple of others.
Regards,
--
Sébastien Miquel
ure the effect.
I am not sure what you are referring to here. Can you elaborate?
Lines 2892-2893 of (my) ob-core.el, in org-babel-expand-noweb-references:
;; Evaluation can potentially modify the buffer
;; and invalidate the cache: reset it.
Regards,
--
Sébastien Miquel
I've provided two possible
implementations in this thread, that I can rebase.
Regards,
--
Sébastien Miquel
, but not worked into ox-html yet. If you
could check it out on the engrave-faces-latex side and check it’s behaving
sanely, that would be helpful.
I've tried it, and mathescape works, thanks !
--
Sébastien Miquel
.
Regards,
--
Sébastien Miquel
nly the :noweb-prefix part. If applied, we can mark
this thread resolved.
Thanks,
--
Sébastien Miquel
From 3fc3c3557b27026e2cfdb2a1973921c1baf3758a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Mon, 6 Sep 2021 18:45:42 +0200
Subject: [PATCH] ob-core.el: Add `:noweb-pre
;. The
change would be much more complex than what I propose, for maybe
little benefit.
[...]
This sounds a bit confusing. I would also add an example where it is
useful to set :noweb-prefix to no.
I've added such an example in the revised patch attached.
Thanks for the feedback.
Regards,
--
S
ource code. By disabling native compilation I meant as
a compile flag, if you've built emacs from source. I cannot find an
easy way to prevent native compilation of a single package/function.
--
Sébastien Miquel
version of org-mode.
Alternatively, disabling native-comp should also fix this.
Regards,
--
Sébastien Miquel
.
This is the expected behaviour (except for the file name), and what I
get when I run C-c C-e C-s l o.
What I receive is something like this:
[...]
The whole first level of this outline is pointless.
Looking at the code, I don't understand how you can get this outcome.
Regards,
--
Sébastien Miquel
ing a snippet).
Thank you for bringing this up,
Regards,
--
Sébastien Miquel
can make an educated guess. It is quite likely that this change
will fix more documents than it breaks. Hardly a disaster.
Regards,
--
Sébastien Miquel
the specification
accordingly. The change is local and minor.
Regards,
--
Sébastien Miquel
speedup.
Perhaps the frequency of the second
: (< (random 1000) (* 1000 org-element--cache-self-verify-frequency))
call in ~org-element--cache-verify-element~ should be decreased.
Regards,
--
Sébastien Miquel
=c0369a798470763f8f3c69cf2079c3a194635feb
Regards,
--
Sébastien Miquel
of $'s in
table formulas, or for currency, AFAICT.
Regards,
--
Sébastien Miquel
From b023fff129a5cc3b1f12b9f170f2e018dc34d237 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Sun, 23 Jan 2022 13:28:03 +0100
Subject: [PATCH] =?UTF-8?q?org-element:=20Support=20$=E2=80=A6
-for-a-latex-beginner
[2]: https://ctan.tetaneutral.net/info/lshort/english/lshort.pdf
--
Sébastien Miquel
this by modifying the fontification regexps).
Regards,
--
Sébastien Miquel
tangle to
#+BEGIN_SRC emacs-lisp
(setq latex-header "\\usepackage{…}
\\usepackage{…}")
#+END_SRC
I've left undocumented the possibility of setting =:noweb-trans= to
another function. I wonder if anyone can think of some other use.
Regards,
--
Sébastien Miquel
From 66f271225767d07e12bcc73a1ddb
, It should get applied.
I'll probably do so eventually, or you could, if you feel so inclined.
Perhaps one difficulty is to deal with the case where the org-babel
call errors out, say if there's no mode to edit the src code in.
--
Sébastien Miquel
,
--
Sébastien Miquel
lement)
(skip-chars-backward " \t\n")
(line-beginning-position
(progn
(org-babel-do-in-edit-buffer (fill-paragraph))
nil) t)))
(advice-add 'org-fill-paragraph :before-while
#'my-org-fill-paragraph-natively-maybe)
Regards,
--
Sébastien Miquel
:
- one
two
- three four
Expected:
- one two
- three four
Note that this issue is fixed by the patch proposed at
https://list.orgmode.org/041ca43d-2efb-db1e-76ab-7c15af088...@posteo.eu/
Regards,
--
Sébastien Miquel
gets
listed at https://updates.orgmode.org/ and not forgotten. A maintainer
will reply eventually, but it might take up to a few months.
Regards,
--
Sébastien Miquel
adjust= property is provided for the
images to be sized properly. Are the arguments =--no-fonts= and
=--exact-bbox= necessary ?
If there are no drawbacks, perhaps this behaviour should be the
default. Otherwise, it should at least be easier to toggle.
Can something similar be done with =dvipng= ?
Regards,
--
Sébastien Miquel
by
default, although I'll wait for a second opinion on this.
Regards,
--
Sébastien Miquel
behaviour by
setting ~org-src-native-defun-movements~ to nil.
Regards,
--
Sébastien Miquel
From 51675d8bbea54db7daf3dcc88a77ccad5174854f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Fri, 27 Aug 2021 21:41:29 +0200
Subject: [PATCH] org-src.el: add option `org-src-native
elsewhere in the thread,
this lambda is to be treated as data, and written to a file to be
executed by the external emacs instance. It should always have been
quoted (naming it happens to work also).
Regards,
--
Sébastien Miquel
containing a list such as the
one below doesn't fill the first item
- long line
- long line
- long line
+ Calling =fill-paragraph= on a region containing a list such as the
one below doesn't fill the list
- long line
- long line
- short line
Regards,
--
Sébastien Miquel
From
Hi,
Timothy writes:
Pushed .
Sorry for the late reply, but isn't there a =message= call leftover from
debugging ?
Regards,
--
Sébastien Miquel
this may be wrong.
Regards,
--
Sébastien Miquel
to be passed to
the external emacs process.
Attached is a patch that applies the same fix where affected.
Regards,
--
Sébastien Miquel
From 35ae093113d9a04a99b55f0747848b373a7463f3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Mon, 29 Nov 2021 09:54:33 +0100
Subject: [PATCH
from
the same point.
Regards,
#+LATEX_CLASS: my-class
* Head1
* Head2
--
Sébastien Miquel
Hi,
The variable display-line-numbers-width is nil by default.
Regards,
--
Sébastien Miquel
From 2e306750caff0474aa9a6443c7d7eb68e3aca83b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Sat, 23 Oct 2021 13:28:59 +0200
Subject: [PATCH] org.el (org-display-inline-image
).
Regards,
--
Sébastien Miquel
From b80124aa6edbd3b6992817dd8c37253705c82ae3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Mon, 30 Aug 2021 23:18:41 +0200
Subject: [PATCH] org-src.el: Fix special editing of LaTeX fragments
* lisp/org-macs.el (org-do-remove-indentation
.
Regards,
--
Sébastien Miquel
fragment inside an org list such as
$$abc
def$$
Thanks for reporting and confirming.
Regards,
--
Sébastien Miquel
>From 5c3254d42e3d359021d41dae9a0549244e6fddff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Mon, 30 Aug 2021 23:18:41 +0200
Subject: [PATCH] org-src
Sébastien Miquel writes:
Here's a patch that fixes this bug by calling `dvipng' with the `-bg
Transparent' argument only when no background color is set.
Setting X-Woof-Bug and X-Woof-Patch, as this doesn't show on
https://updates.orgmode.org/
--
Sébastien Miquel
l file and
start
=emacs=. Perhaps you need to make sure that ~org-latex-export-to-pdf~ is
native compiled.
Regards,
--
Sébastien Miquel
but I don't know if it's the right
thing to do.
Regards,
--
Sébastien Miquel
, such as `(when nil "filename")'.
Regards,
--
Sébastien Miquel
sized blocks, the delay can still be noticeable and
ought
to be fixed. Attached is a patch that seems to resolve this issue. I haven't
noticed any drawbacks so far.
Regards,
--
Sébastien Miquel
>From d843bdc5887a6e50a57e349128ebbe032086dc17 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bast
in this
case. I've
thought about it some more, and came up with a solution.
Here's a new patch that's smarter about indenting the current line, and
resolves
this remaining issue.
Regards,
--
Sébastien Miquel
>From 8c31e6b732a45c0ddbbf0a0db7a2cb4ef3af0414 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S
, here's a patch that cleans up blank lines, except the current
one. It
preserves the fix for the original issue.
Can you try it out ?
Regards,
--
Sébastien Miquel
>From 405c2be7487c564e72a9f01a940f96dc19ff16ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Wed, 23
these arguments, I have no opinion on the matter.
Regards,
--
Sébastien Miquel
the change was to fix some (electric) indentation issues when
editing a src block directly.
As I write in the linked thread, setting `org-src--preserve-indentation'
should
revert this behaviour.
Regards,
--
Sébastien Miquel
and apply this patch to
master ?
Regards,
--
Sébastien Miquel
lds a
significant speedup, and was enough to make things bearable in my cases.
You can
also try to simplify the latex regexp.
If you try these, I'd be interested to hear how much of an improvement
theymake.
Regards,
--
Sébastien Miquel
.
Makes sense to me.
I also wonder if there's any reason for the `org-block' face not to
apply to "greater" blocks.
--
Sébastien Miquel
Sébastien Miquel writes:
There's already an `org-latex-and-relatex` regexp
I meant the `org-latex-and-related` face.
--
Sébastien Miquel
change the
minimal version to 27.1.
Thank you for the report.
Regards,
--
Sébastien Miquel
X-Woof-Bug: confirmed
>From 8ebdbc5eca92de4429d3994a3663d8aa3b9877fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?=
Date: Tue, 1 Jun 2021 08:56:48 +0200
Subject: [PATCH] org-src.el: Use
)` instead of
`'(native)`. The org-block face won't be applied anymore.
Regards,
--
Sébastien Miquel
1 - 100 of 159 matches
Mail list logo