Eric Schulte writes:
This test (test-ob/catches-all-references) is from commit c21692506d8,
which doesn't have anything to do with newlines (judging from the commit
message).
To me the more natural behavior is to include the newline in the
expansion. Maybe we have discussed this before on
Skip Collins skip.coll...@gmail.com writes:
It's been a week and this test still fails.
Fixed.
Would it make sense to automatically enforce passing all tests before
git accepts a change?
I for one would strongly oppose this change. This would only make it
take longer and thus make it
Eric Schulte writes:
Fixed.
The test was trying to ascertain that an inline babel codeblock didn't
force a newline at the end. You've just made it test that there is a
trailing newline introduced by the inline babel call, which is clearly
against its intent. You could have marked it as a known
On Fri, Dec 6, 2013 at 2:05 PM, Eric Schulte schulte.e...@gmail.com wrote:
Skip Collins skip.coll...@gmail.com writes:
Would it make sense to automatically enforce passing all tests before
git accepts a change?
I for one would strongly oppose this change. This would only make it
take longer
Hi Skip,
Skip Collins skip.coll...@gmail.com writes:
Designating something as an expected failure seems to be a good way to
track minor issues that need eventually to be resolved. As a user, I
frequently update with make up2 just to avoid getting bitten by stupid
errors that might sneak into
Skip Collins skip.coll...@gmail.com writes:
On Fri, Dec 6, 2013 at 2:05 PM, Eric Schulte schulte.e...@gmail.com wrote:
Skip Collins skip.coll...@gmail.com writes:
Would it make sense to automatically enforce passing all tests before
git accepts a change?
I for one would strongly oppose this
Achim Gratz strom...@nexgo.de writes:
Eric Schulte writes:
Fixed.
The test was trying to ascertain that an inline babel codeblock didn't
force a newline at the end.
What makes this code block inline?
You've just made it test that there is a trailing newline introduced
by the inline babel
It's been a week and this test still fails.
Would it make sense to automatically enforce passing all tests before
git accepts a change?
On Wed, Nov 27, 2013 at 2:58 AM, Achim Gratz strom...@nexgo.de wrote:
Hi Eric,
this change seems to introduce additional line breaks in the following
test:
Hi Eric,
this change seems to introduce additional line breaks in the following
test:
--8---cut here---start-8---
Test test-ob/catches-all-references condition:
(ert-test-failed
((should
(string=
(org-babel-execute-src-block)
A
