Re: [O] [PATCH] Add check for assignment to hline relative references in table formulas.

2013-11-08 Thread Michael Brand
Hi Achim On Thu, Nov 7, 2013 at 8:37 PM, Achim Gratz wrote: > I've fixed the failing test since it wasn't checking hline expressions > and hence should not have relied on undocumented behaviour in the first > place. I agree that testing of "LHS hline ref range" and testing of something else (in

Re: [O] [PATCH] Add check for assignment to hline relative references in table formulas.

2013-11-07 Thread Bastien
Achim Gratz writes: > Achim Gratz writes: >> Besides, that change breaks test-org-table/compare, which for whatever >> reason uses just such a LHS construct. > > I've fixed the failing test since it wasn't checking hline expressions > and hence should not have relied on undocumented behaviour in

Re: [O] [PATCH] Add check for assignment to hline relative references in table formulas.

2013-11-07 Thread Achim Gratz
Achim Gratz writes: > Besides, that change breaks test-org-table/compare, which for whatever > reason uses just such a LHS construct. I've fixed the failing test since it wasn't checking hline expressions and hence should not have relied on undocumented behaviour in the first place. Regards, Ach

Re: [O] [PATCH] Add check for assignment to hline relative references in table formulas.

2013-11-05 Thread Bastien
Hi, Achim Gratz writes: > Bastien writes: >>> * org-table.el (org-table-recalculate): Generate user error if >>> an hline relative reference is use on the LHS of a formula. >> >> Applied, thanks! > > Rick is listed as a contributor, so the TINYCHANGE marker is wrong. Yes, I realized that. > Be

Re: [O] [PATCH] Add check for assignment to hline relative references in table formulas.

2013-11-05 Thread Achim Gratz
Bastien writes: >> * org-table.el (org-table-recalculate): Generate user error if >> an hline relative reference is use on the LHS of a formula. > > Applied, thanks! Rick is listed as a contributor, so the TINYCHANGE marker is wrong. Besides, that change breaks test-org-table/compare, which for w

Re: [O] [PATCH] Add check for assignment to hline relative references in table formulas.

2013-11-05 Thread Bastien
Hi Rick, Rick Frankel writes: > * org-table.el (org-table-recalculate): Generate user error if > an hline relative reference is use on the LHS of a formula. Applied, thanks! -- Bastien

[O] [PATCH] Add check for assignment to hline relative references in table formulas.

2013-09-25 Thread Rick Frankel
* org-table.el (org-table-recalculate): Generate user error if an hline relative reference is use on the LHS of a formula. --- lisp/org-table.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/org-table.el b/lisp/org-table.el index 246cf8d..a3197d3 100644 --- a/lisp/org-table.el +++ b/li