Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Rasmus, Rasmus wrote: >"Optionally download an up-to-date KOMA letter exporter" > Is this something we want to encourage people to do? We probably shouldn't. The problem is that the tutorial depends on a version that has not yet been released. Once Org-mode 8.1 arrives the best thing to d

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Tom, Thomas S. Dye wrote: > One small nit to pick, according to my dictionary "meta data" -> > "metadata". Thanks, I've changed this. Cheers, Viktor > > All the best, > Tom

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Suvayu, Suvayu Ali wrote: > The convention is to put all documentation about the new exporters under > Worg.git/exporters. Take a look here: > > Thanks. I've also added an entry to the index file. Cheers, Viktor > > Hope this helps, > > -- > Suvay

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Viktor, Viktor Rosenfeld writes: > Hi Alan, > > I just wanted to let you know that the tutorial is now online. I haven't > linked to it from the org-tutorials page yet, in case you want to take a > look. You can find it at > http://orgmode.org/worg/org-tutorials/koma-letter-export.html This i

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Aloha Viktor, Nice work! I've been trying to find time to experiment with ox-koma-letter. Your tutorial will help. One small nit to pick, according to my dictionary "meta data" -> "metadata". All the best, Tom Viktor Rosenfeld writes: > Hi Alan, > > I just wanted to let you know that the tut

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Viktor, I'm chiming in very late here. On Sun, May 05, 2013 at 03:35:51PM +0200, Viktor Rosenfeld wrote: > > In any case, you can find the tutorial at > ./org-tutorials/koma-letter-export.org The convention is to put all documentation about the new exporters under Worg.git/exporters. Take a

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor Rosenfeld writes: > Hi Alan, > > I just wanted to let you know that the tutorial is now online. I > haven't > linked to it from the org-tutorials page yet, in case you want to take > a > look. You can find it at > http://orgmode.org/worg/org-tutorials/koma-letter-export.html First: thanks

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, I just wanted to let you know that the tutorial is now online. I haven't linked to it from the org-tutorials page yet, in case you want to take a look. You can find it at http://orgmode.org/worg/org-tutorials/koma-letter-export.html Cheers, Viktor Alan Schmitt wrote: > Viktor Rosenfeld

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor Rosenfeld writes: > Hi Alan, > > I've pushed a draft tutorial to Worg, but it's not published yet. Do you > know if there is a delay or if I have to do anything else? I saw the > publishing process output after my push which ended with the following: > >remote: Publishing file /home/ema

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor Rosenfeld writes: >> I have a question about this: is there some special magic that makes the >> string "nil" to be parsed as `nil' and not as the string? > > I assume there must be. If I specify `foldmarks:nil' the if-statement in > line 294 evaluates it as false: > > #+BEGIN_SRC emacs-lis

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, Alan Schmitt wrote: > Hi Victor, > > Viktor Rosenfeld writes: > > > Hi Rasmus and Alan, > > > > I've changed the code so the value for foldmarks is passed through to > > KOMA-Script. It's a bit ugly insofar as one has to specify > > foldmarks:true to use the default values instead of o

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Victor, Viktor Rosenfeld writes: > Hi Rasmus and Alan, > > I've changed the code so the value for foldmarks is passed through to > KOMA-Script. It's a bit ugly insofar as one has to specify > foldmarks:true to use the default values instead of other options, such > as backaddress:t. However, s

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor Rosenfeld writes: > Hi Alan, > > I've removed the defaults from OPENING and CLOSING. See the attached > patch. Thanks, I've applied it. To magit/emacs users: is there a way to apply a patch (with signoff) directly from emacs (I guess with magit)? I typically go to a shell to do so ... Al

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, I've pushed a draft tutorial to Worg, but it's not published yet. Do you know if there is a delay or if I have to do anything else? I saw the publishing process output after my push which ended with the following: remote: Publishing file /home/emacs/git/worg/sitemap.org using `org-

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Rasmus, Rasmus wrote: > Viktor, > > >> >> In a similar spirit to subject is firsthead. First head is displayed > >> >> by default in scrlttr2 as far as I recall, which is annoying. > >> > > >> > Is firsthead something that you change on a letter-by-letter basis? Or > >> > do you configure it

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Rasmus and Alan, I've changed the code so the value for foldmarks is passed through to KOMA-Script. It's a bit ugly insofar as one has to specify foldmarks:true to use the default values instead of other options, such as backaddress:t. However, subject also uses a string already. See the attac

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, I've removed the defaults from OPENING and CLOSING. See the attached patch. Cheers, Viktor Alan Schmitt wrote: > Viktor Rosenfeld writes: > > > Rasmus also suggested setting the default opening and closing to nil > > because we should not assume that everybody speaks English. Maybe, e

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor, >> >> In a similar spirit to subject is firsthead. First head is displayed >> >> by default in scrlttr2 as far as I recall, which is annoying. >> > >> > Is firsthead something that you change on a letter-by-letter basis? Or >> > do you configure it once for your letters and never change

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor Rosenfeld writes: >> Yeah, I guess it's true. Still, since foldmarks depends on which >> envelopes you have at hand it might make sense to have it accept a >> string. In lisp-terms a string is still t. On the other hand the >> current approach is consistent with your approach above so t

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Viktor, Viktor Rosenfeld writes: > I can't reproduce your error. The date KOMA variable is automatically > set by the \date LaTeX command which can be verified by the snipplet > below. Out of curiosity, what TeX version are you using? I use TeX Live > 2012 which includes scrlttr2 2012/07/29 v3

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, Alan Schmitt wrote: > I've applied the patch. I propose a further tiny improvement: > , > | --- a/contrib/lisp/ox-koma-letter.el > | +++ b/contrib/lisp/ox-koma-letter.el > | @@ -273,7 +273,7 @@ holding export options." > |(when email (format "\\setkomavar{fromemail}{%s}\n" em

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor Rosenfeld writes: > Rasmus also suggested setting the default opening and closing to nil > because we should not assume that everybody speaks English. Maybe, every > variable should default to nil. Yes, I think it's a good idea. I often have lines that set the opening and closing to '~' to

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, Alan Schmitt wrote: > I'm still thinking that the default signature should be nil (so that the > option can be picked up from the LCO), but it's a minor nitpick. Rasmus also suggested setting the default opening and closing to nil because we should not assume that everybody speaks Engli

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi again, I've applied the patch. I propose a further tiny improvement: , | --- a/contrib/lisp/ox-koma-letter.el | +++ b/contrib/lisp/ox-koma-letter.el | @@ -273,7 +273,7 @@ holding export options." |(when email (format "\\setkomavar{fromemail}{%s}\n" email)) |(when signature (

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Viktor, Viktor Rosenfeld writes: > Wow, this is great! I didn't know that you can modify the commit history > so easily. I have attached four patches to this mail which correspond to > the four points in my earlier email. They have to be applied > consecutively. Great, thanks. > I can't repr

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Rasmus, Rasmus wrote: > >> In a similar spirit to subject is firsthead. First head is displayed > >> by default in scrlttr2 as far as I recall, which is annoying. > > > > Is firsthead something that you change on a letter-by-letter basis? Or > > do you configure it once for your letters and n

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, Alan Schmitt wrote: > Or you could do a git rebase interactive to merge all the commits > together. Wow, this is great! I didn't know that you can modify the commit history so easily. I have attached four patches to this mail which correspond to the four points in my earlier email. They

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Viktor, Rasmus writes: > Ask Bastien or perhaps Carsten now for write access (you need to > provide your public key). I can look through it when uploaded. Please send me your public key (in private) and I'll add you to Worg. Best, -- Bastien

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor, >> In a similar spirit to subject is firsthead. First head is displayed >> by default in scrlttr2 as far as I recall, which is annoying. > > Is firsthead something that you change on a letter-by-letter basis? Or > do you configure it once for your letters and never change it? In the > la

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor Rosenfeld writes: > Hi Alan, > > Alan Schmitt wrote: > >> A couple notes about the patch: >> - Could you create it using "git format-patch"? This way we'll have >> more metadata in the commit. > > I actually did that first and liked it more because then the patch was > split into more logic

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Rasmus, Rasmus wrote: > > * Setting of KOMA options > > > > The presence of the sender's phone and email, the letter's place and > > subject, as well as foldmarks and the backaddress are > > configurable. Consider: > > > > #+OPTIONS: subject:titled place:nil phone:t email:t foldmarks:nil > >

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, Alan Schmitt wrote: > A couple notes about the patch: > - Could you create it using "git format-patch"? This way we'll have > more metadata in the commit. I actually did that first and liked it more because then the patch was split into more logical blocks (nine patches in total). Howev

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi Alan, Alan Schmitt wrote: > > Also, I could not find an ox-koma-letter tutorial on Worg. I would be > > willing to create such a tutorial, maybe next weekend. Can anybody edit > > the contents on Worg or do I need special priviledges? > > You need to ask for write access. Will do. > I star

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Viktor, Looks nice! > Also, I could not find an ox-koma-letter tutorial on Worg. I would be > willing to create such a tutorial, maybe next weekend. Can anybody edit > the contents on Worg or do I need special priviledges? Ask Bastien or perhaps Carsten now for write access (you need to provide

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Nicolas Goaziou writes: > Hello, > > Alan Schmitt writes: > >> I'm not sure about the procedure to apply this patch, however. Should I >> do it myself? > > You're the file maintainer, aren't you? :) ;-) A couple notes about the patch: - Could you create it using "git format-patch"? This way we'

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hello, Alan Schmitt writes: > I'm not sure about the procedure to apply this patch, however. Should I > do it myself? You're the file maintainer, aren't you? :) Regards, -- Nicolas Goaziou

Re: [O] [PATCH] Improve configurability of ox-koma-letter

Hi, Viktor Rosenfeld writes: > Hi, > > I've hacked the ox-koma-letter exporter to make it more configurable. > See the Changelog of the attached patch, hopefully I've followed the > Changelog guidelines propertly. This looks very nice, thanks a lot. I'm not sure about the procedure to apply thi

[O] [PATCH] Improve configurability of ox-koma-letter

Hi, I've hacked the ox-koma-letter exporter to make it more configurable. See the Changelog of the attached patch, hopefully I've followed the Changelog guidelines propertly. Also, I could not find an ox-koma-letter tutorial on Worg. I would be willing to create such a tutorial, maybe next weeken