Re: [O] [Patch] Few small fixes to html header

2014-04-16 Thread Bastien
Hi Marcin and Rick, Marcin Antczak writes: >> Another good question. Bastien- Do you think it makes sense to do a >> whitespace cleanup only commit of ox-html to master? > > +1 from me. The practice I've seen on Emacs is to not do whitespace commits, but the cleanup whitespace when there is ano

Re: [O] [Patch] Few small fixes to html header

2014-03-28 Thread Marcin Antczak
Rick Frankel writes: > On 2014-03-28 11:16, Marcin Antczak wrote: >> Rick Frankel writes: >> >> On 2014-03-27 15:57, Marcin Antczak wrote: >> I've attached patch below, but I'm affraid that there is something >> wrong >> with indentation. >> I'm not sure if there is problem with my settings or ju

Re: [O] [Patch] Few small fixes to html header

2014-03-28 Thread Rick Frankel
On 2014-03-28 11:16, Marcin Antczak wrote: Rick Frankel writes: On 2014-03-27 15:57, Marcin Antczak wrote: I've attached patch below, but I'm affraid that there is something wrong with indentation. I'm not sure if there is problem with my settings or just entire ox-html.el is indented badly. Un

Re: [O] [Patch] Few small fixes to html header

2014-03-28 Thread Rick Frankel
On 2014-03-27 15:57, Marcin Antczak wrote: I've attached patch below, but I'm affraid that there is something wrong with indentation. I'm not sure if there is problem with my settings or just entire ox-html.el is indented badly. Unfortunately, ox-html is indented with a combination of tabs and

Re: [O] [Patch] Few small fixes to html header

2014-03-28 Thread Marcin Antczak
Rick Frankel writes: > On 2014-03-27 15:57, Marcin Antczak wrote: >> I've attached patch below, but I'm affraid that there is something >> wrong >> with indentation. >> I'm not sure if there is problem with my settings or just entire >> ox-html.el is indented badly. > > Unfortunately, ox-html is

Re: [O] [Patch] Few small fixes to html header

2014-03-28 Thread Marcin Antczak
Rainer M Krug writes: > Marcin Antczak writes: > [...] Is your response intentionally empty or am I missing something? Marcin

Re: [O] [Patch] Few small fixes to html header

2014-03-28 Thread Rainer M Krug
Marcin Antczak writes: > I've attached patch below, but I'm affraid that there is something wrong > with indentation. > I'm not sure if there is problem with my settings or just entire > ox-html.el is indented badly. > > I've been trying to indent file with the default parameters. > I started Ema

[O] [Patch] Few small fixes to html header

2014-03-27 Thread Marcin Antczak
I've attached patch below, but I'm affraid that there is something wrong with indentation. I'm not sure if there is problem with my settings or just entire ox-html.el is indented badly. I've been trying to indent file with the default parameters. I started Emacs with -Q parameter and as I can see