Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-22 Thread Viktor Rosenfeld
Hi Rasmus, Rasmus wrote: Viktor Rosenfeld listuse...@gmail.com writes: Or 5, keep the change from SENDER to AUTHOR but revert the default values to `org-koma-letter-*' variables. (Right now the AUTHOR and EMAIL lines could be removed because they duplicate the derived latex backend.)

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-21 Thread Rasmus
Alan Schmitt alan.schm...@polytechnique.org writes: It seems there are some semantic bugs in ox-koma-letter.el in that new variables are introduces for SENDER (as opposed to AUTHOR) and a separate email variable as well. This seems like a semantic bug IMO. This patch fixes these issues if

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-21 Thread Alan Schmitt
Rasmus writes: Alan Schmitt alan.schm...@polytechnique.org writes: It seems there are some semantic bugs in ox-koma-letter.el in that new variables are introduces for SENDER (as opposed to AUTHOR) and a separate email variable as well. This seems like a semantic bug IMO. This patch fixes

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-21 Thread Rasmus
Alan Schmitt alan.schm...@polytechnique.org writes: OK, sounds good, I've applied it. Thanks. Let's wait with the rest till Vicktor's had a chance to look over it. –Rasmus -- Summon the Mothership!

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-21 Thread Viktor Rosenfeld
Hi, Rasmus wrote: Alan Schmitt alan.schm...@polytechnique.org writes: OK, sounds good, I've applied it. Actually, this patch does break LCO files. Now, if you don't set AUTHOR or EMAIL in the letter the default options from the LaTeX exporter always overwrite the settings defined in LCO

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-21 Thread Rasmus
Viktor Rosenfeld listuse...@gmail.com writes: Actually, this patch does break LCO files. Now, if you don't set AUTHOR or EMAIL in the letter the default options from the LaTeX exporter always overwrite the settings defined in LCO files. This one is tough. . . One could #+INCLUDE an org-file

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-21 Thread Viktor Rosenfeld
Hi, Rasmus wrote: Viktor Rosenfeld listuse...@gmail.com writes: Actually, this patch does break LCO files. Now, if you don't set AUTHOR or EMAIL in the letter the default options from the LaTeX exporter always overwrite the settings defined in LCO files. This one is tough. . . One

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-21 Thread Rasmus
Viktor Rosenfeld listuse...@gmail.com writes: Or 5, keep the change from SENDER to AUTHOR but revert the default values to `org-koma-letter-*' variables. (Right now the AUTHOR and EMAIL lines could be removed because they duplicate the derived latex backend.) I once had a teacher who talked

Re: [O] [patch] ox-koma-letter.el: clean-up/semantic bug [4/4]

2013-05-19 Thread Rasmus
It seems there are some semantic bugs in ox-koma-letter.el in that new variables are introduces for SENDER (as opposed to AUTHOR) and a separate email variable as well. This seems like a semantic bug IMO. This patch fixes these issues if they in fact are issues. –Rasmus -- And let me remind