Re: [O] Have SRC_BLOCK :padline accept numbers

2017-04-18 Thread Nicolas Goaziou
Hello, Daniel P Gomez writes: > I've amended the commit including the changes you've mentioned. > I did not change the following, though: > > (numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines) > > because that changed the behaviour of org-babel-tangle. Having a > stri

Re: [O] Have SRC_BLOCK :padline accept numbers

2017-03-30 Thread Nicolas Goaziou
Hello, Daniel P Gomez writes: > I've amended the commit including the changes you've mentioned. Thank you. > I did not change the following, though: > > (numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines) > > because that changed the behaviour of org-babel-tangle. Ha

Re: [O] Have SRC_BLOCK :padline accept numbers

2017-03-29 Thread Daniel P Gomez
Dear Nicolas, Thanks for the constructive feedback. I've amended the commit including the changes you've mentioned. I did not change the following, though: (numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines) because that changed the behaviour of org-babel-tangle. Havi

Re: [O] Have SRC_BLOCK :padline accept numbers

2017-03-29 Thread Nicolas Goaziou
Hello, Daniel P Gomez writes: > I've written a small patch (attached here), following the contribution > guidelines on the org-mode website. The "patched" repository can be found > here: https://github.com/dangom/org-mode/tree/feature_padline Thank you. > Please let me know if there is anythin

[O] Have SRC_BLOCK :padline accept numbers

2017-03-28 Thread Daniel P Gomez
A use case is tangling python source code snippets containing class definitions. ( http://emacs.stackexchange.com/questions/31738/org-mode-babel-ensure-two-empty-lines-between-tangled-code-blocks-for-python ) Per PEP8, the use of blank lines stipulates: "Surround top-level function and class defi