Re: [O] Why not push?

2015-08-05 Thread Bastien Guerry
Nicolas Goaziou writes: > It's a first step. It would be nice to get rid of `org-split-string' > altogether in the long run. We may make `org-split-string' an obsolete > alias for `split-string', and update code base accordingly. Agreed. I was unclear, I meant: why not using split-string instea

Re: [O] Why not push?

2015-08-04 Thread Nicolas Goaziou
Hello, Bastien Guerry writes: > I pushed a tiny clean up here. Next question is: why not using > > (split-string STRING SEPARATORS t) > > ? It's a first step. It would be nice to get rid of `org-split-string' altogether in the long run. We may make `org-split-string' an obsolete alias for `spl

Re: [O] Why not push?

2015-08-04 Thread Bastien Guerry
Hi Marcin, Marcin Borkowski writes: > I don't want to be nitpicking, but I'm just curious. I'm looking at the > function `org-split-string'. It uses (two times) the following > construction: > > (setq list (cons (something) list)) > > Is there any particular reason for not using `push' there?

Re: [O] Why not push?

2015-02-16 Thread Sebastien Vauban
Hi Marcin, Marcin Borkowski wrote: > I don't want to be nitpicking, but I'm just curious. I'm looking at the > function `org-split-string'. It uses (two times) the following > construction: > > (setq list (cons (something) list)) > > Is there any particular reason for not using `push' there? II

Re: [O] Why not push?

2015-02-15 Thread Marcin Borkowski
On 2015-02-15, at 12:35, Rasmus wrote: > Marcin Borkowski writes: > >> Hi there, >> >> I don't want to be nitpicking, but I'm just curious. I'm looking at the >> function `org-split-string'. It uses (two times) the following >> construction: >> >> (setq list (cons (something) list)) >> >> Is

Re: [O] Why not push?

2015-02-15 Thread Marcin Borkowski
On 2015-02-15, at 13:26, Eric Abrahamsen wrote: > Ah well, maybe we'll trick someone else into it :) ;-) > My own personal project is to spend a bit of every day working on the > emacs packages that make my computing life possible: Org, Gnus, and > BBDB. I'd prefer to spend most of it on Org,

Re: [O] Why not push?

2015-02-15 Thread Marcin Borkowski
On 2015-02-15, at 22:22, Yuri Niyazov wrote: > On Sun, Feb 15, 2015 at 2:38 AM, Nicolas Goaziou > wrote: >> No. Good luck with refactoring "org.el". ;) > > Could you clarify what you think are the biggest issues with > refactoring org.el ? IMHO, the biggest and most useful thing would be to d

Re: [O] Why not push?

2015-02-15 Thread Nicolas Goaziou
Yuri Niyazov writes: > Could you clarify what you think are the biggest issues with > refactoring org.el ? Its size. Regards,

Re: [O] Why not push?

2015-02-15 Thread Yuri Niyazov
On Sun, Feb 15, 2015 at 2:38 AM, Nicolas Goaziou wrote: > No. Good luck with refactoring "org.el". ;) Could you clarify what you think are the biggest issues with refactoring org.el ?

Re: [O] Why not push?

2015-02-15 Thread Eric Abrahamsen
Marcin Borkowski writes: > On 2015-02-15, at 11:42, Eric Abrahamsen wrote: > >> Nicolas Goaziou writes: >> >>> Hello, >>> >>> Marcin Borkowski writes: >>> I don't want to be nitpicking, but I'm just curious. I'm looking at the function `org-split-string'. It uses (two times) the fo

Re: [O] Why not push?

2015-02-15 Thread Rasmus
Marcin Borkowski writes: > Hi there, > > I don't want to be nitpicking, but I'm just curious. I'm looking at the > function `org-split-string'. It uses (two times) the following > construction: > > (setq list (cons (something) list)) > > Is there any particular reason for not using `push' there

Re: [O] Why not push?

2015-02-15 Thread Marcin Borkowski
On 2015-02-15, at 11:42, Eric Abrahamsen wrote: > Nicolas Goaziou writes: > >> Hello, >> >> Marcin Borkowski writes: >> >>> I don't want to be nitpicking, but I'm just curious. I'm looking at the >>> function `org-split-string'. It uses (two times) the following >>> construction: >>> >>> (se

Re: [O] Why not push?

2015-02-15 Thread Eric Abrahamsen
Nicolas Goaziou writes: > Hello, > > Marcin Borkowski writes: > >> I don't want to be nitpicking, but I'm just curious. I'm looking at the >> function `org-split-string'. It uses (two times) the following >> construction: >> >> (setq list (cons (something) list)) >> >> Is there any particular

Re: [O] Why not push?

2015-02-15 Thread Nicolas Goaziou
Hello, Marcin Borkowski writes: > I don't want to be nitpicking, but I'm just curious. I'm looking at the > function `org-split-string'. It uses (two times) the following > construction: > > (setq list (cons (something) list)) > > Is there any particular reason for not using `push' there? No.

[O] Why not push?

2015-02-15 Thread Marcin Borkowski
Hi there, I don't want to be nitpicking, but I'm just curious. I'm looking at the function `org-split-string'. It uses (two times) the following construction: (setq list (cons (something) list)) Is there any particular reason for not using `push' there? Best, -- Marcin Borkowski http://octd