Re: [O] commit 7719734dd7 org-compat.el: New compatibility function `org-random'

2012-09-11 Thread Achim Gratz
Bastien writes: >> Do you mind if I revert that commit and implement the change? > > Absolutely not, on the contrary. Done. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Q+, Q and microQ: http://Synth.Stromeko

Re: [O] commit 7719734dd7 org-compat.el: New compatibility function `org-random'

2012-09-11 Thread Bastien
Achim Gratz writes: > Bastien writes: >> Do you mean this should be (random) instead of (random t) in those >> versions? Why? If so, we can simply get rid of the compatibility >> macro and use (random). > > Do you mind if I revert that commit and implement the change? Absolutely not, on the co

Re: [O] commit 7719734dd7 org-compat.el: New compatibility function `org-random'

2012-09-11 Thread Achim Gratz
Bastien writes: > Do you mean this should be (random) instead of (random t) in those > versions? Why? If so, we can simply get rid of the compatibility > macro and use (random). Do you mind if I revert that commit and implement the change? Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron

Re: [O] commit 7719734dd7 org-compat.el: New compatibility function `org-random'

2012-09-06 Thread Nick Dokos
Bastien wrote: > Achim Gratz writes: > > > Sorry, but that macro doesn't call `random´ appropriately at all. > > The real problem is (random t) in previous versions of org-id.el. > > Do you mean this should be (random) instead of (random t) in those > versions? Why? If so, we can simply g

Re: [O] commit 7719734dd7 org-compat.el: New compatibility function `org-random'

2012-09-06 Thread Achim Gratz
Bastien writes: > The real problem is (random t) in previous versions of org-id.el. Yes. > Do you mean this should be (random) instead of (random t) in those > versions? Why? If so, we can simply get rid of the compatibility > macro and use (random). That would be the correct thing to do. >>

Re: [O] commit 7719734dd7 org-compat.el: New compatibility function `org-random'

2012-09-06 Thread Bastien
Achim Gratz writes: > Sorry, but that macro doesn't call `random´ appropriately at all. The real problem is (random t) in previous versions of org-id.el. Do you mean this should be (random) instead of (random t) in those versions? Why? If so, we can simply get rid of the compatibility macro

[O] commit 7719734dd7 org-compat.el: New compatibility function `org-random'

2012-09-06 Thread Achim Gratz
Sorry, but that macro doesn't call `random´ appropriately at all. No package should ever use `(random t)´ at all and especially not repeatedly. Please make org-random an alias to random. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User