Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.

Karthik Chikmagalur writes: > LRA, thanks for the fix. > > Ihor, `org-persist--find-index' is singularly confusing. I've been over > it with edebug a few times and still can't figure out what it's doing, > because `container' means different things at different points in the > function because o

Re: [PATCH] Async sessions: Fix prompt removal regression in ob-R

-override', which could be used > to override `comint-prompt-regexp' for the purpose of filtering. I > attach a patch with this solution. Maybe we can simply override `comint-prompt-regexp' as we do in ob-shell? The default regexp seems to be too permissive. -- Ihor Radchenko

Re: [PATCH] lisp/org-colview.el: Fix for adding appointments to effort sum

The previous patch contained unmatched parentheses. Sincere apologies. I am attaching a corrected patch. Best, Anand From 7dd9ee45b1ed02de7921efa5c6c2a1c993a1c6ac Mon Sep 17 00:00:00 2001 From: Anand Deopurkar Date: Mon, 30 Sep 2024 10:13:59 +1000 Subject: [PATCH] lisp/org-colview.el: Bug

[BUG][PATCH] org-babel: Shared list structure causes spurious changes in user options [9.8-pre (release_9.7.10-127-g07dd3b @ /usr/local/share/emacs/site-lisp/org/)]

se of shared list structure, the modification gets propagated to the user variables. Emacs : GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-08-09 Package: Org mode version 9.8-pre (release_9.7.10-127-g07dd3b @/usr/local/share/emacs/site-lisp

Re: [PATCH] fix org-babel-view-src-block-info

Ihor Radchenko writes: > I changed the commit message a little, clarifying the purpose of the > patch (rather than generic "fix"), adding a proper changelog entry (see > https://orgmode.org/worg/org-contribute.html#commit-messages), quoting > symbols as `symbols', and

[PATCH] lisp/org-colview.el: Fix for adding appointments to effort sum

From 0b6fbd5bc1326163e16351cee6ee26e7ecf8 Mon Sep 17 00:00:00 2001 From: Anand Deopurkar Date: Mon, 23 Sep 2024 22:58:48 +1000 Subject: [PATCH] lisp/org-colview.el: Bug fix for add-appointments-to-effort-sum * org-colview.el (org-columns--collect-values): Accept an additional optional

Re: [PATCH] fix org-babel-view-src-block-info

Rodrigo Morales writes: >> Note that we had another patch from Rodrigo Morales in 2021: >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e0535fa2d8215ba9a9f96058807648df72e2d99d >> Is it yours? (it is under different email) > > Yes, it was me. I used t

Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.

LRA, thanks for the fix. Ihor, `org-persist--find-index' is singularly confusing. I've been over it with edebug a few times and still can't figure out what it's doing, because `container' means different things at different points in the function because of the macro `org-persist-collection-let'.

Re: [PATCH v6] Inline image display as part of a new org-link-preview system

w and only remove in following releases. It turns out `org-link-preview-overlays' is now required again, since the overlay property `org-image-overlay' is only placed after the preview is done, so we can't use it to collect overlays anymore. >>> And please fix the compiler

[PATCH] Async sessions: Fix prompt removal regression in ob-R

egexp). However, I don't see a good way to let-bind this around `org-babel-comint-async-filter'. The best solution I could think of was to define a new buffer-local variable, `org-babel-comint-prompt-regexp-override', which could be used to override `comint-prompt-regexp

Re: [PATCH] put `org-attach-after-change-hook` at the end of org-attach

"Christopher M. Miles" writes: > Subject: [PATCH] org-attach.el: put org-attach-after-change-hook at the end > > lisp/org-attach.el (org-attach-attach): Put org-attach-after-change-hook > at the end to make sure user can access attach link in org-store-links. I have no p

Re: [PATCH] Texinfo: Check for math support without warnings and quietly (was: Improve Texinfo math checking)

Rudolf Adamkovič writes: > Subject: [PATCH] ox-texinfo: Check for math support without warnings and > quietly > > * lisp/ox-texinfo.el (org-texinfo-supports-math-p): Two > improvements: (1) Fix the incorrect `.info' extension used for the > temporary `.texi' fil

Re: [PATCH] Add repeat-map for navigation commands

Visuwesh writes: >> 1. You can link to "9.11 Repeating a Command" section of Emacs manual > > Can you please tell how to link to an Info node? I see two different > style of linking to another manual in Introduction/Activation and I'm > confused. I do not know how ox-texinfo works. [[info:emac

Re: [PATCH] Add repeat-map for navigation commands

n ~repeat-mode~ is turned on, certain navigation can be repeated. >> +These include the headline navigation commands, ~org-next-link~ and >> +~org-previous-link~, and ~org-next-block~ and ~org-previous-block~. > > Example and a link to Emacs manual would also be good here. > And we probably need to mention `org-navigation-repeat-map' to let users > know what to customize if they prefer alternative bindings. Thanks, will do this in a future patch. Hopefully, by this week.

Re: [PATCH] Add repeat-map for navigation commands

Visuwesh writes: > Please find attached. I tried my best to write the manual entry but it > still reads awkward. Thanks! > * lisp/org-keys.el (org-up-heading): Add new alias for > outline-up-heading. Please quote Elisp symbols as `outline-up-heading'. > +** Repeating commands > +:PROPERTIES:

Re: [PATCH] fix org-babel-view-src-block-info

2001 > From: Rodrigo Morales > Date: Sat, 21 Sep 2024 19:04:55 -0500 > Subject: [PATCH] lisp/ob-core.el: fix org-babel-view-src-block-info Thanks! Applied, onto bugfix. I changed the commit message a little, clarifying the purpose of the patch (rather than generic "fix"), add

Re: [PATCH] Fix ox-icalendar export of diary timestamps

Jack Kamm writes: > Ihor Radchenko writes: > >> I agree that it makes sense. >> However, it is technically a breaking change. >> May you please add a news entry as well? > > Thanks, I've updated the patch with a news entry now. Thanks! Applied, onto main

Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.

l...@phdk.org writes: > And it is *with* the attachment. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a8790ed09e I also added you to the contributor list. https://git.sr.ht/~bzg/worg/commit/466cfcf2 P.S. We really need tests for org-persist. -- I

[PATCH] fix org-babel-view-src-block-info

2024 19:04:55 -0500 Subject: [PATCH] lisp/ob-core.el: fix org-babel-view-src-block-info MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the previous version, when the user interactively calls org-babel-view-src-block-info and the point is on a code bloc

Re: [PATCH] Fix ox-icalendar export of diary timestamps

Ihor Radchenko writes: > I agree that it makes sense. > However, it is technically a breaking change. > May you please add a news entry as well? Thanks, I've updated the patch with a news entry now. >From 5c40741664402a5984803dc3de452ea949885887 Mon Sep 17 00:00:00 2001 From

Re: [PATCH v5] Inline image display as part of a new org-link-preview system

on. But we cannot remove it. We can only deprecate it as of now and only remove in following releases. >> And please fix the compiler warnings. > > As of this patch, I don't see any flymake errors with the > `elisp-flymake-byte-compile' backend. Is this not sufficient? > By

Re: [PATCH] Fix ox-icalendar export of diary timestamps

s not reached, in part because > `org-export--skip-p' always skips timestamps with type `diary'. > > The attached patch fixes this by including diary timestamps when the > export option `:with-timestamps' is `active'. I think it's reasonable > to consider diar

Re: [PATCH v5] Inline image display as part of a new org-link-preview system

Next version of patch attached. > 1. I run preview on the whole buffer > 2. M-x list-timers shows the timer, and it is ugly: > * 10.0s - #f(compiled-function () # > > [...] > > 10+ sec] >- So, no closures please. Use normal named functions D

Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments.

And it is *with* the attachment. Kind regards, LRA Sep 18, 2024, 02:26 by l...@phdk.org: > Hello org-mode mailing list > > Long time, first time. This is just a tiny patch fixing a regression > in org-persist--find-index that was missed in the 95f77669e0 bugfix. It > affects

Re: [PATCH v4] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >> It means that you are scheduling every single preview batch to fire at >> the same time. I think that the timers here should run sequentially - >> (1) fire the first batch without delay; (2) wait org-link-preview-delay >> and fire the next batch; (3) ... > > Done, a

Re: [PATCH] Texinfo: Check for math support without warnings and quietly (was: Improve Texinfo math checking)

A friendly ping. :) Rudolf Adamkovič writes: > Oops, I found a bug in the patch. > > Now fixed. > > Rudy > From a99cb0ecafb6a0a1d4ef841dd20be5fa2da43cff Mon Sep 17 00:00:00 2001 > From: Rudolf Adamkovic > Date: Tue, 27 Aug 2024 11:10:56 +0200 > Subject: [PATCH]

Re: [PATCH] ox-texinfo: Support links in headings

Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> I tried to run make test and your new test fails: [...] > > Yup, `4829bacff', which you merged in the meantime, broke the test, as > it changed how `@ref's are generated. > >> May you please fix

Re: [PATCH] Add repeat-map for navigation commands

isuwesh Date: Mon, 9 Sep 2024 19:46:47 +0530 Subject: [PATCH] Add repeat-mode keymap for navigation commands * lisp/org-keys.el (org-up-heading): Add new alias for outline-up-heading. (org-mode-map): Remap outline-up-heading to the new alias. (org-navigation-repeat-map, org-link-navigation-repea

Re: [PATCH]: suggest the xcolor package everywhere in the ox-latex.el DOCSTRINGs

Great! On Sun, 15 Sept 2024 at 16:12, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > > > attached is a really small patch to suggest the use of the xcolor package > > everywhere in ox-latex.el > > > > Rationale: > > 1. read through [1] &g

Re: [PATCH v4] Inline image display as part of a new org-link-preview system

Latest iteration of patch attached. > In theory, we might not need to clear image cache as long as we call > `image-flush' in `org-link-preview-clear'. Removed (clear-image-cache) when refreshing since we run (image-flush) unconditionally in org-link-preview-file. > My hesita

Re: [PATCH] ox-texinfo: Support links in headings

Ihor Radchenko writes: > I tried to run make test and your new test fails: [...] Yup, `4829bacff', which you merged in the meantime, broke the test, as it changed how `@ref's are generated. > May you please fix this and also rebase the patch onto the latest main? Rebas

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

>>> Image cache is cleared _only_ with REFRESH argument. >>> I think that makes sense, right? >> >> Yes. But `org-link-preview-region' is always called with the REFRESH >> argument set to `t' though. > > Sure. What's a problem with that? Why flush Emacs' entire image cache to preview images in on

Re: [PATCH]: suggest the xcolor package everywhere in the ox-latex.el DOCSTRINGs

Pedro Andres Aranda Gutierrez writes: > attached is a really small patch to suggest the use of the xcolor package > everywhere in ox-latex.el > > Rationale: > 1. read through [1] > 2. Some "more modern" (i.e. > 2016) packages clash with color and require > x

Re: [PATCH v3] Re: [FR] Automatically display images in resutls of evaluation

stardiviner writes: > I updated the patch. Thanks! > + > +(add-hook 'org-babel-after-execute-hook 'org-toggle-inline-image-in-results) Please note that `org-babel-after-execute-hook' is not necessarily evaluated with point at the src block being executed. > +(defun

Re: [PATCH] Add repeat-map for navigation commands

Visuwesh writes: > BTW, should we add C-n and friends to org-navigation-repeat-map or just > have n, p, etc.? I personally find C-n in the repeat-map disruptive > since I usually want to move the cursor after jumping to a specific > heading, in which case C-n not being next-line is annoying. +1

Re: [PATCH] Add repeat-map for navigation commands

Karthik Chikmagalur writes: > Do you think it makes sense to add repeat-maps for other next/previous > commands in Org, such as org-next-link and org-previous-link? I've been > using this for a while (they don't use defvar-keymap as I wrote them a > while ago): > > (defvar org-link-navigation-re

Re: [PATCH] ox-texinfo: Support links in headings

future. Thanks! I tried to run make test and your new test fails: Test test-ox-texinfo/headings-with-links condition: (search-failed "^@chapter Heading 2 (@ref{Heading 1})$") May you please fix this and also rebase the patch onto the latest main? -- Ihor Radchenko // yantar92, Org

Re: [PATCH] ox-texinfo: Support numeric values of `toc' in `#+OPTIONS'

Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> Should be relative level, I think. > > I am a bit lost here, on both why and how. :) See `org-export-collect-headlines' and how it uses `org-export-get-relative-level' to determine whether a given heading is too deeply nested to be included

Re: [PATCH] ox-texinfo: Fix automatic @ref titles

Rudolf Adamkovič writes: > * lisp/ox-texinfo.el (org-texinfo--@ref): Fix an incorrect assumption > that Texinfo uses node names for automatic link text. It does not. > Instead, it uses the corresponding section title. For example, if a > node is named `a' its section is named `A', the Org link

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >> Image cache is cleared _only_ with REFRESH argument. >> I think that makes sense, right? > > Yes. But `org-link-preview-region' is always called with the REFRESH > argument set to `t' though. Sure. What's a problem with that? In theory, we might not need to clear

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >> So, I thought that you are probably the best person to design such >> things :) > > Unfortunately I don't think I'm good at designing flexible async APIs, > at least in Emacs. (The LaTeX preview system is being tuned for > speed/lag-free performance, not flexibilit

[PATCH] Fix ox-icalendar export of diary timestamps

lways skips timestamps with type `diary'. The attached patch fixes this by including diary timestamps when the export option `:with-timestamps' is `active'. I think it's reasonable to consider diary timestamps as a type of active timestamp during export, since they are include

[PATCH]: suggest the xcolor package everywhere in the ox-latex.el DOCSTRINGs

Hi attached is a really small patch to suggest the use of the xcolor package everywhere in ox-latex.el Rationale: 1. read through [1] 2. Some "more modern" (i.e. > 2016) packages clash with color and require xcolor. Best, /PA [1] https://tex.stackexchange.com/questions/89763/wh

Re: [PATCH] ox-texinfo: Support numeric values of `toc' in `#+OPTIONS'

Ihor Radchenko writes: > Should be relative level, I think. I am a bit lost here, on both why and how. :) Rudy -- "'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if it were so, it would be; but as it isn't, it ain't. That's logic.'" --- Lewis Carroll, Through the Lookin

[PATCH] ox-texinfo: Fix automatic @ref titles

* lisp/ox-texinfo.el (org-texinfo--@ref): Fix an incorrect assumption that Texinfo uses node names for automatic link text. It does not. Instead, it uses the corresponding section title. For example, if a node is named `a' its section is named `A', the Org link to the node `a' written as `[[...][

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

chunking and running the >> preview-funcs on an idle-timer seems like overengineering to me, but I >> defer to your experience here. I'll update the patch soon. > > Implementing async is not mandatory. > Here, I am simply taking into account _your_ experience with LaTeX

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

Latest iteration of patch attached. >>>> +BEG and END define the considered part. They default to the >>>> +buffer boundaries with possible narrowing." >>>> + (interactive "P") >>>> + (when (display-graphic-p) >>&g

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >>> since the previews are place asynchronously. It always reports "no >>> images to display inline". Should I remove this messaging, or find a >>> way to run this from the final async chunk? The code gets a little >>> convoluted when I do the latter. >> >> I am a b

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

>> Another problem: this top level chunk no longer works >> >> [...] >> >> since the previews are place asynchronously. It always reports "no >> images to display inline". Should I remove this messaging, or find a >> way to run this from the final async chunk? The code gets a little >> convolute

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: > Another problem: this top level chunk no longer works > > (when interactive? > (let ((new (org-link-preview--get-overlays beg end))) > (message > (if new >(format "[%s] %d images displayed inline %s" >scope (length new) >

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

ay by itself. > > Yes, this is what I suggested. Even chunking and running the > preview-funcs on an idle-timer seems like overengineering to me, but I > defer to your experience here. I'll update the patch soon. Implementing async is not mandatory. Here, I am simply taking into

Re: [PATCH] Add repeat-map for navigation commands

[திங்கள் செப்டம்பர் 09, 2024] Ihor Radchenko wrote: >> ... I've attached a patch which >> adds a repeat-map to org-keys.el but this pointed out that org-mode >> lacks a org-up-heading command so I've resorted to using >> outline-up-heading. > > It is not

Re: [PATCH] Add repeat-map for navigation commands

>> From 8b980efcd9497e395f4d82a1304267ae4426b00d Mon Sep 17 00:00:00 2001 >> From: Visuwesh >> Date: Mon, 9 Sep 2024 19:46:47 +0530 >> Subject: [PATCH] Add repeat-mode keymap for navigation commands >> >> * org-keys.el (org-navigation-repeat-map): Add repeat-m

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

>> ... >> Do you mean something like this? >> >> (while (re-search-forward org-link-any-re end t) >> ;; Make overlay ov here >> ;; Find path, link and preview-func here >> >> (push (list ov preview-func path link) previews-remaining)) >> >> (dolist (preview-data-chunk (seq-partition previews-

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

gt; managing the passed overlay by itself. Yes, this is what I suggested. Even chunking and running the preview-funcs on an idle-timer seems like overengineering to me, but I defer to your experience here. I'll update the patch soon. Karthik

Re: [PATCH] ox-texinfo: Support numeric values of `toc' in `#+OPTIONS'

Rudolf Adamkovič writes: >> Also, what about `org-export-collect-headlines'. It also ignores >> numeric value of :with-toc. > > Fixed. Thank you for letting me know! I am exporting only to HTML, > where Org-generated top-level menus do not appear. So, I missed it. > > P.S. I also fixed the inc

Re: [PATCH] Add repeat-map for navigation commands

Visuwesh writes: > Sorry for the month long delay. I was busy with uni stuff so could not > find the time to invest into this properly. No problem. > ... I've attached a patch which > adds a repeat-map to org-keys.el but this pointed out that org-mode > lacks a org-up-hea

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >>> Do you mean something like this? >>> >>> (while (re-search-forward org-link-any-re end t) >>> ;; Make overlay ov here >>> ;; Find path, link and preview-func here >>> >>> (push (list ov preview-func path link) previews-remaining)) >>> >>> (dolist (preview-dat

[PATCH] Add repeat-map for navigation commands

nvest into this properly. I've attached a patch which adds a repeat-map to org-keys.el but this pointed out that org-mode lacks a org-up-heading command so I've resorted to using outline-up-heading. >From 8b980efcd9497e395f4d82a1304267ae4426b00d Mon Sep 17 00:00:00 2001 From: Visuwesh

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

>> Do you mean something like this? >> >> (while (re-search-forward org-link-any-re end t) >> ;; Make overlay ov here >> ;; Find path, link and preview-func here >> >> (push (list ov preview-func path link) previews-remaining)) >> >> (dolist (preview-data-chunk (seq-partition previews-remaini

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >> I mostly meant calling preview-func asynchronously, while idle, spaced >> out, spending not longer than a fraction of second to call several >> preview-funcs. >> Spacing might then be controlled by the users. > ... > Do you mean something like this? > > (while (re-s

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

>> I'm not sure how to solve this problem. Here's what I'm picturing -- >> note that this doesn't actually avoid the process sentinel pile-up: >> >> The preview provider should return its callback function to Org so Org >> can run it at its convenience. >> >> Org runs (funcall #'preview-func ov pa

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

align link)) >>> + (image (org--create-inline-image file width))) >> >> I am wondering why you left these functions in org.el. Why not moving >> them here? > > They seemed out of place in ol.el, so my plan was the following: > 1. This patch: Implemen

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

Ihor Radchenko writes: >>> From a feasibility perspective, I suspect it might be better for you (or >>> someone else who's signed the FSF copyright assignment paperwork) to >>> take on the work of applying changes that are similar in spirit to the >>> p

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

Suhail Singh writes: >> From a feasibility perspective, I suspect it might be better for you (or >> someone else who's signed the FSF copyright assignment paperwork) to >> take on the work of applying changes that are similar in spirit to the >> patch. > >

Re: [Pre-PATCH] Overhaul of the LaTeX preview system

Super! ;) 2024年9月4日(水) 9:18 Karthik Chikmagalur : > Jun, thank you for the detailed explanation and fix. > > > * Cause > > This is because org-latex-preview: > > 1. Runs dvisvgm in the same directory as the .org file, and > > 2. Tells dvisvgm to report the output SVG file names as relative paths

Re: [Pre-PATCH] Overhaul of the LaTeX preview system

Jun, thank you for the detailed explanation and fix. > * Cause > This is because org-latex-preview: > 1. Runs dvisvgm in the same directory as the .org file, and > 2. Tells dvisvgm to report the output SVG file names as relative paths > using ?svgfile, but > 3. Then expands those file names under

Re: [Pre-PATCH] Overhaul of the LaTeX preview system

Yaroslav, I had a similar issue. The problem there was that the relative path ../../../../var/folders/3m/9xzpnkks773bfdwzqlvr421rgn/T/org-tex-BYOo4y-1.svg was being expanded in the wrong directory. Can you see if the problem reproduces with the attached patch? (You could also just

Re: [PATCH] ox-texinfo: Support numeric values of `toc' in `#+OPTIONS'

Ihor Radchenko writes: > AFAIU, it is a bugfix. Right? > > If it is, the patch name is rather confusing. I can never tell! Fixed. > Also, what about `org-export-collect-headlines'. It also ignores > numeric value of :with-toc. Fixed. Thank you for letting me know! I

Re: [Pre-PATCH] Overhaul of the LaTeX preview system

>> Sorry for delay. >> >> 1. pdflatex >> 2. processing page 1: output written to >> ../../../../var/folders/3m/9xzpnkks773bfdwzqlvr421rgn/T/org-tex-BYOo4y-1.svg >> 3. nil > > Karthik, any thoughts? > It will be useful to know if that svg exists at that path. I've had reports from ot

Re: [Pre-PATCH] Overhaul of the LaTeX preview system

Yaroslav Drachov writes: > Sorry for delay. > > 1. pdflatex > 2. processing page 1: output written to > ../../../../var/folders/3m/9xzpnkks773bfdwzqlvr421rgn/T/org-tex-BYOo4y-1.svg > 3. nil Karthik, any thoughts? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more abou

Re: [PATCH v3] Inline image display as part of a new org-link-preview system

New patch version attached. Not all your points were addressed, please check my comments below. >> Subject: [PATCH] org-link: Move inline image display to org-link > > The patch does a lot more than merely "moving" things around. Please, > name it accordingly. Maybe

Re: [PATCH] Testing: Add tests for `org-tags-sort-function'

I've attached an updated patch. This one has a test where we actually don't sort tags by using the `ignore' function. Ihor Radchenko writes: >> +;; Sorting doesn't care about `org-tag-alist'. This is only >> +;; here for late

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

>> contribute a bit more ;)) >> >> Now, back to your original patch. >> May you please factor out adding attributes into a separate function, so >> that we avoid duplicating the code? And please announce the change in >> the news - people aware of the current behav

[PATCH] put `org-attach-after-change-hook` at the end of org-attach

lisp/org-attach.el (org-attach-attach): Put org-attach-after-change-hook at the end to make sure user can access attach link in org-store-links. From f21ef819ab6670f1ed64a731d5d7b5fb29119f33 Mon Sep 17 00:00:00 2001 From: stardiviner Date: Thu, 29 Aug 2024 11:31:53 +0800 Subject: [PATCH] org

Re: [PATCH] ox-texinfo: Support numeric values of `toc' in `#+OPTIONS'

c' value in export `#+OPTIONS'. > * testing/lisp/test-ox-texinfo.el > (test-ox-texinfo/headings-and-table-of-contents): Add a test. AFAIU, it is a bugfix. Right? If it is, the patch name is rather confusing. Also, what about `org-export-collect-headlines'. It also ignores numeric

Re: [PATCH] lisp/org.el: Add ability to sort tags by hierarchy

t we already have. So I was waiting for a response to > my other patch (linked below) adding that test before continuing with > this thread. I replied in that thread. We can come back to the patch herein after finalizing the other patch. -- Ihor Radchenko // yantar92, Org mode contributor

Re: [PATCH] lisp/org.el: Fix removing timestamp overlays

Joseph Turner writes: > Subject: [PATCH] lisp/org.el: Fix removing timestamp overlays Thanks, although I believe that we can fix things even better. (If I understand the problem you are trying to solve correctly; just in case, please explain what you are trying to solve ;]) > (whe

Re: Patch: hiding emphasis markers

Tommy Phillips writes: > Here is a small suggested patch for the way org hides emphasis markers. > It’s my first time doing this so hopefully I’m submitting it correctly. Duplicate of https://list.orgmode.org/orgmode/caameppfgscw+davgx82-b6qz3w-wig1ta6mpoztn1tcjt4p...@mail.gmail.com/ Ca

Re: Patch: hiding org emphasis markers

Ihor Radchenko writes: > Ihor Radchenko writes: > >> You may instead introduce a new allowed value for >> `org-hide-emphasis-markers' to hide markers for non-nil entries in >> `org-emphasis-alist'. Maybe even allow the value to be an explicit list >> of the markers to be hidden '("*" "_" ...). >

Re: [PATCH] Testing: Add tests for `org-tags-sort-function'

Morgan Smith writes: > diff --git a/testing/lisp/test-org-agenda.el b/testing/lisp/test-org-agenda.el > index 778f91e8e..c1092df3b 100644 > --- a/testing/lisp/test-org-agenda.el > +++ b/testing/lisp/test-org-agenda.el Thanks for the patch! > +;; Sorting doesn't

Re: [PATCH v2] Inline image display as part of a new org-link-preview system

w the link, the previewer must update the overlay ov as > needed, for example by placing an image as its `display' property. > It should not modify the buffer contents. >- The previewer must return a non-nil value to indicate preview > success. If the preview

Re: [PATCH] Texinfo: Check for math support without warnings and quietly (was: Improve Texinfo math checking)

Oops, I found a bug in the patch. Now fixed. Rudy >From a99cb0ecafb6a0a1d4ef841dd20be5fa2da43cff Mon Sep 17 00:00:00 2001 From: Rudolf Adamkovic Date: Tue, 27 Aug 2024 11:10:56 +0200 Subject: [PATCH] ox-texinfo: Check for math support without warnings and quietly * lisp/ox-texinfo.el (

Re: [PATCH v2] Inline image display as part of a new org-link-preview system

v2 of the patch is attached. I incorporated most of your suggested changes including in the commit message, except for a couple that I talk about below. First, here's an updated description of the proposed API: 1. You can register a previewer with each type of Org link in the followin

Re: [PATCH v3] Improvements to Texinfo exporter (was: [PATCH] Re: Texinfo: Custom navigation and links in headings)

Rudolf Adamkovič writes: > I will rebase those onto `main' and > > submit them separately, > > one per thread, to > > make code review easier. And done. The two patches, now rebased on `main' are submitted via `git send-email`, are now waiting for review:

[PATCH] ox-texinfo: Support links in headings

From: Rudolf Adamkovic * etc/ORG-NEWS (Texinfo exporter now supports links in headings): Announce the new feature. * lisp/ox-texinfo.el: (org-texinfo--format-entries, org-texinfo--get-node, org-texinfo--sanitize-title-reference, org-texinfo--sanitize-title): A 2-step change: (1) Rename `--sanitiz

[PATCH] ox-texinfo: Support numeric values of `toc' in `#+OPTIONS'

From: Rudolf Adamkovic * etc/ORG-NEWS (Texinfo exporter now supports numeric =toc= values in =#+OPTIONS:=): Announce the new feature. * lisp/ox.el (org-export-excluded-from-toc-p): Return nil for all headlines that are above the `toc' value in export `#+OPTIONS'. * testing/lisp/test-ox-texinfo.el

Re: [PATCH v1] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >> We may simply pass the link object to :preview function. > > If we pass the link object instead of the overlay, it will be the > preview function's job to create overlays as needed. This overlay > should have special properties (like `org-image-overlay') for previe

Re: [PATCH v1] Inline image display as part of a new org-link-preview system

Thanks Ihor. Before I send the next iteration of the patch, I'd like your input on some decisions marked with "Q:" below. >> Not yet handled or final: >> >> - Link abbreviations: I'm using org-link-any-re to find links, and this >> appears to be ha

Re: [PATCH] Fix the use of a deprecated function in the manual

Rudolf Adamkovič writes: > See the attached patch. > > Rudy > From 9455024b32a94171e70c7ef364a0ae0aad3658ec Mon Sep 17 00:00:00 2001 > From: Rudolf Adamkovic > Date: Tue, 27 Aug 2024 13:50:18 +0200 > Subject: [PATCH] doc/org-manual.org: Update a deprecated function Thanks!

Re: [PATCH v1] Inline image display as part of a new org-link-preview system

Karthik Chikmagalur writes: >> Spin out will be easier when for my rebase :) > > Please find attached the draft of a patch implementing a general > link-preview system. Thanks! > Not yet handled or final: > > - Link abbreviations: I'm using org-link-any-re to fin

Re: [PATCH v3] Improvements to Texinfo exporter (was: [PATCH] Re: Texinfo: Custom navigation and links in headings)

Rudolf Adamkovič writes: > I found I do not need alternative navigation, as I can simulate > "alternative up" with links in parent Org headings. > > [Texinfo renders that just fine in HTML.] > > The other two patches are bug fixes, to > > - support links in headings > (including those expor

Re: [PATCH] Re: Summation of effort estimates in columnview dblock

Ihor Radchenko writes: > [...] > I'd start from a simplified description of what is happening, followed > by the example, and then formal definition. > > Otherwise, reading from top to button is still difficult. > [...] Here is another take: instead of the lengthy explanations I had offered prev

Re: [PATCH v3] Improvements to Texinfo exporter (was: [PATCH] Re: Texinfo: Custom navigation and links in headings)

de review easier. P.S. This thread is orthogonal to [PATCH] Texinfo: Check for math support without warnings and quietly https://list.orgmode.org/m2r0aaxqaa@adamkovic.org/T/ which is waiting for review. Rudy -- "Be especially critical of any statement following the word 'obviousl

Re: [PATCH] lisp/org.el: Add ability to sort tags by hierarchy

o demonstrate the changes I wanted to make by also submitting a test. However, I thought it prudent to first test what we already have. So I was waiting for a response to my other patch (linked below) adding that test before continuing with this thread. I didn't make my intentions clear

Re: [PATCH] lisp/org.el: Add ability to sort tags by hierarchy

Ihor Radchenko writes: > ... may you please elaborate what kind of sorting > order does your function imply? ... It has been over a month. Have you had a chance to look into my questions? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at .

[PATCH] Fix the use of a deprecated function in the manual

See the attached patch. Rudy >From 9455024b32a94171e70c7ef364a0ae0aad3658ec Mon Sep 17 00:00:00 2001 From: Rudolf Adamkovic Date: Tue, 27 Aug 2024 13:50:18 +0200 Subject: [PATCH] doc/org-manual.org: Update a deprecated function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cont

[PATCH] Texinfo: Check for math support without warnings and quietly (was: Improve Texinfo math checking)

Rudolf Adamkovič writes: > The attached patch ... Oops, I again forgot to prefix the subject with "[PATCH]". Fixed now. Rudy -- "If you're thinking without writing, you only think you're thinking." --- Leslie Lamport Rudolf Adamkovič [he/him] http://adamkovic.org

Re: [PATCH] Re: Summation of effort estimates in columnview dblock

Ihor Radchenko writes: > [...] >> +When using summary types for non-special properties like the >> +=Time_Estimate= column in the example, the collection of data for the >> ... >> +The following example illustrates how special, > > I'd start from a simplified description of what is happening, fol

Re: [PATCH] lisp/org.el: Fix removing timestamp overlays

Joseph Turner writes: > Thank you! Cheers! -Joseph > > [2. text/x-diff; 0001-lisp-org.el-Fix-removing-timestamp-overlays.patch]... Woops! The 'display text property may be symbol or list - here's a better patch. Thanks, Joseph >From 9351b3c8f960ac6d2fba3c2de0c46e84

  1   2   3   4   5   6   7   8   9   10   >