[PATCH] Fix erroneous tangling of blocks

2021-07-01 Thread Jacopo De Simoi
Dear All, Please find attached a patch (against master) which takes care of the following issue. Assume I have a block like this #+begin_src sh :tangle no This should not be tangled #+end_src Then the block is correctly ignored when tangling the whole file, but erroneously tangled (to a file

Re: [PATCH] Fix erroneous tangling of blocks

2021-07-01 Thread Timothy
HI Jacopo, I've just taken a look at your patch and it looks good :) glad to see you've also followed the commit message format. I hope this gets merged soon. -- Timothy p.s. Just a little note for the future: it's good if you have full sentences in the description of the changes. Jacopo De S

Re: [PATCH] Fix erroneous tangling of blocks

2021-07-01 Thread Nicolas Goaziou
Hello, Timothy writes: > I've just taken a look at your patch and it looks good :) glad to see > you've also followed the commit message format. I hope this gets merged > soon. Applied. Thanks for the patch, and thanks for the review. Regards, -- Nicolas Goaziou