Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-02-07 Thread Ihor Radchenko
Bastien Guerry writes: > Ihor Radchenko writes: > >> No response from Bastien. > > Yes, sorry for that. In general, don't wait for my answer unless you > really needed it: you've got pre-approval as co-maintainer, I don't > want my current lack of availability to be a blocker. No blocker here.

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-02-07 Thread Bastien Guerry
Hi Ihor, Ihor Radchenko writes: > No response from Bastien. Yes, sorry for that. In general, don't wait for my answer unless you really needed it: you've got pre-approval as co-maintainer, I don't want my current lack of availability to be a blocker. Thanks, -- Bastien Guerry

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-02-07 Thread Ihor Radchenko
Ihor Radchenko writes: > Right. This is because after 72c3f5e8e refactoring, > `org-agenda-skip-scheduled-if-deadline-is-shown' is only respected when > the deadline is actually shown. > > However, judging from the discussion of the original feature request >

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-17 Thread Ihor Radchenko
Morgan Smith writes: > Maybe we could create some data-structure that represents an agenda and > allow the user to manipulate that directly. I'm not really a fan of > having a ton of variables controlling the agenda. Although I imagine I > might gain some respect for it if I tried to implement

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-16 Thread Morgan Smith
Ihor Radchenko writes: > Morgan Smith writes: > >> Ihor Radchenko writes: >> >>> But then `org-agenda-skip-scheduled-if-deadline-is-shown' does not look >>> like the right place for this customization. It would make more sense to >>> have a dedicated custom variable for this. WDYT? >>> .. >> I

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-16 Thread Ihor Radchenko
Morgan Smith writes: > Ihor Radchenko writes: > >> But then `org-agenda-skip-scheduled-if-deadline-is-shown' does not look >> like the right place for this customization. It would make more sense to >> have a dedicated custom variable for this. WDYT? >> .. > I can't quite remember at this point

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-16 Thread Morgan Smith
Ihor Radchenko writes: > But then `org-agenda-skip-scheduled-if-deadline-is-shown' does not look > like the right place for this customization. It would make more sense to > have a dedicated custom variable for this. WDYT? > > I am adding Bastien to the loop - he authored the original feature >

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-04 Thread Ihor Radchenko
[CCing Bastien] Morgan Smith writes: >> I think that you misunderstand the purpose of 'repeated-after-deadline >> value. Let me provide an example: >> >> 'repeated-after-deadline allows this task >> >> * Do me every day before March, 16th (included) >> SCHEDULED: <2013-03-12 mar.

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-03 Thread Morgan Smith
Ihor Radchenko writes: > Morgan Smith writes: > >>> May you please provide a detailed reproducer demonstrating the bug you >>> are trying to fix? Such reproducer could be a basis of a new test. >> >> See a detailed reproducer attached to this mail. It has a task defined >> as this: >> >> *

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-03 Thread Ihor Radchenko
Morgan Smith writes: >> May you please provide a detailed reproducer demonstrating the bug you >> are trying to fix? Such reproducer could be a basis of a new test. > > See a detailed reproducer attached to this mail. It has a task defined > as this: > > * TODO task > SCHEDULED: <2017-03-06 Mon

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2024-01-02 Thread Morgan Smith
Ihor Radchenko writes: > Morgan Smith writes: > >> lisp/org-agenda.el (org-agenda-get-scheduled): Consolidate deadline >> fetching code. Don't check if deadline is shown when >> 'org-agenda-skip-scheduled-if-deadline-is-shown' has a value of >> 'repeated-after-deadline'. >> >> Currently when

Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2023-12-31 Thread Ihor Radchenko
Morgan Smith writes: > lisp/org-agenda.el (org-agenda-get-scheduled): Consolidate deadline > fetching code. Don't check if deadline is shown when > 'org-agenda-skip-scheduled-if-deadline-is-shown' has a value of > 'repeated-after-deadline'. > > Currently when

[PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug

2023-12-30 Thread Morgan Smith
lisp/org-agenda.el (org-agenda-get-scheduled): Consolidate deadline fetching code. Don't check if deadline is shown when 'org-agenda-skip-scheduled-if-deadline-is-shown' has a value of 'repeated-after-deadline'. Currently when 'org-agenda-skip-scheduled-if-deadline-is-shown' has a value of