Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-08 Thread Nick Dokos
Kyle Meyer writes: > Nick Dokos writes: > >> Here's the amended patch: it includes the fixes from Kyle's review, the >> modification >> he suggested that adds the plain property for each _ALL property to the list >> and a few test cases to the test/org-buffer-property-keys test. > > Thank you

Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-08 Thread Nick Dokos
Kyle Meyer writes: > Nick Dokos writes: > >> Here's the amended patch: it includes the fixes from Kyle's review, the >> modification >> he suggested that adds the plain property for each _ALL property to the list >> and a few test cases to the test/org-buffer-property-keys test. > > Thank you

Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-07 Thread Kyle Meyer
Nick Dokos writes: > Here's the amended patch: it includes the fixes from Kyle's review, the > modification > he suggested that adds the plain property for each _ALL property to the list > and a few test cases to the test/org-buffer-property-keys test. Thank you for the updates. Applied

Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-07 Thread Nick Dokos
->8--- >From 60b9ababe42c91ec6fcd2c53f6923d75daa12454 Mon Sep 17 00:00:00 2001 From: Nick Dokos Date: Mon, 6 Jul 2020 21:49:41 -0400 Subject: [PATCH] org: add property names from #+PROPERTY keywords to completion list * lisp/org.el (org-buffer-property-keys): Enhance the completion list with prope

Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-07 Thread Nick Dokos
Kyle Meyer writes: > ,,, > I think this patch is a clear improvement as is, but in the context of > completion (and the stack exchange post you link to), isn't the handling > around *_ALL keywords still a bit off? It seems a caller would want to > complete without the _ALL; to use the example

Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-07 Thread Nick Dokos
o populate the completion list. > > Thanks for the patch. > >> org: add property names from #+PROPERTY keywords to completion list >> >> * lisp/org.el (org-buffer-property-keys): ehhance the completion list > > Typo: enhance. And as a convention nit, it should b

Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-06 Thread Kyle Meyer
Nick Dokos writes: > Here's a patch to enhance the property name completion list with names from > #+PROPERTY keyword lines: at the moment, only property names found in property > drawers are used to populate the completion list. Thanks for the patch. > org: add property names fro

Re: [PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-06 Thread Nick Dokos
Adding a simple test to the previous patch: --8<---cut here---start->8--- >From cae6b5596f69968003c053f53cb45ffb4139a5ad Mon Sep 17 00:00:00 2001 From: Nick Dokos Date: Mon, 6 Jul 2020 21:07:01 -0400 Subject: [PATCH] org: add property names from #

[PATCH] org: add property names from #+PROPERTY keywords to completion list

2020-07-06 Thread Nick Dokos
Here's a patch to enhance the property name completion list with names from #+PROPERTY keyword lines: at the moment, only property names found in property drawers are used to populate the completion list. Keith Pinson posted the question on Emacs SE: