Re: [PATCH] update ob-scheme to latest changes in geiser package

2022-05-08 Thread Ihor Radchenko
Tim Van den Langenbergh writes: > I have updated the patch and enclosed it, feel free to drop a line if you > notice anything else obviously missing. Thanks! Applied onto main as 06d08e6f3. Best, Ihor

Re: [PATCH] update ob-scheme to latest changes in geiser package

2022-05-07 Thread Tim Van den Langenbergh
Ihor Radchenko writes: > > Thanks! Since Felipe has no objections, your patch should be good to apply. > > Could you kindly add the geiser version info as a comment inside code? > Commit message is an unlikely place to be checked regularly and be > noticed as geiser is updated in future. > > Com

Re: [PATCH] update ob-scheme to latest changes in geiser package

2022-04-27 Thread Ihor Radchenko
Tim Van den Langenbergh writes: > I have taken the liberty of reformatting the patch you created for ob-scheme. > You can find it enclosed. Thanks! Since Felipe has no objections, your patch should be good to apply. > If it is fine with you and the org-mode maintainers it can be applied as-is,

Re: [PATCH] update ob-scheme to latest changes in geiser package

2022-04-26 Thread Felipe Lema
I'm Ok with this patch. Haven't tested it myself, but looks good otherwise (probably Tim has been using it for quite a while now) Felipe On 2022-04-23 09:29, Tim Van den Langenbergh wrote: Felipe, I have taken the liberty of reformatting the patch you created for ob-scheme. You can find i

Re: [PATCH] update ob-scheme to latest changes in geiser package

2022-04-23 Thread Tim Van den Langenbergh
Felipe, I have taken the liberty of reformatting the patch you created for ob-scheme. You can find it enclosed. If it is fine with you and the org-mode maintainers it can be applied as-is, particularly since it is a tiny change. I have also added some additional information to the commit message,

Re: [PATCH] update ob-scheme to latest changes in geiser package

2022-02-06 Thread Ihor Radchenko
The patch appears to solve the real issue others already experience. See https://list.orgmode.org/20220205221049.ymkzevpc2ivlxwbc@bob-mtu/T/#t Dear Felipe, Could you kindly update the patch as requested by Max? Best, Ihor

Re: [PATCH] update ob-scheme to latest changes in geiser package

2021-12-30 Thread Max Nikulin
On 31/12/2021 02:01, Felipe Lema wrote: On Thursday, 30 December 2021 22:50:20 +07 Max Nikulin wrote: I would consider testing if `geiser-eval-region/wait' is bound and fallback to `geiser-eval-region' otherwise. I've wrapped an `if` to fallback to previous API before this breaking change in

Re: [PATCH] update ob-scheme to latest changes in geiser package

2021-12-30 Thread Felipe Lema
On Thursday, 30 December 2021 22:50:20 +07 Max Nikulin wrote: > On Wednesday, 29 December 2021 22.53.18 -03 Felipe Lema wrote: > > On Wednesday, 29 December 2021 15.03.47 -03 Felipe Lema wrote: > > > Sup, y'all > > > > > > The geiser package had a recent update in which `geiser-eval-region` > > >

Re: [PATCH] update ob-scheme to latest changes in geiser package

2021-12-30 Thread Max Nikulin
On 30/12/2021 08:53, Felipe Lema wrote: On Wednesday, 29 December 2021 15.03.47 -03 Felipe Lema wrote: The geiser package had a recent update in which `geiser-eval-region` behaves like an async function and does not return evaluation result. In exchange, the newly introduced `geiser-eval-regi

Re: [PATCH] update ob-scheme to latest changes in geiser package

2021-12-29 Thread Felipe Lema
On Wednesday, 29 December 2021 15.03.47 -03 Felipe Lema wrote: > Sup, y'all > > The geiser package had a recent update in which `geiser-eval-region` behaves > like an async function and does not return evaluation result. In exchange, > the newly introduced `geiser-eval-region/wait` does that now

[PATCH] update ob-scheme to latest changes in geiser package

2021-12-29 Thread Felipe Lema
Sup, y'all The geiser package had a recent update in which `geiser-eval-region` behaves like an async function and does not return evaluation result. In exchange, the newly introduced `geiser-eval-region/wait` does that now. I've attached a patch to update ob-scheme.el to reflect these changes.