Re: [patch] Fix inner smart quotes in French

2023-08-24 Thread Bastien Guerry
Ihor Radchenko writes: > Agree. We can factor out the language names into a separate constant and > then use that constant as a source of "canonical" language names in > :type definitions of defcustom. Then, we can turn all the other > dictionary variables into defcustoms. Yes, sounds good! --

Re: [patch] Fix inner smart quotes in French

2023-08-23 Thread Ihor Radchenko
Bastien Guerry writes: > From the same quick look, I believe `org-export-dictionary' contains > more entries than other variables--we could use languages names from > this variable. > > WDYT? Agree. We can factor out the language names into a separate constant and then use that constant as a

Re: [patch] Fix inner smart quotes in French

2023-08-22 Thread Bastien Guerry
Ihor Radchenko writes: > Bastien Guerry writes: > > Are you referring to `org-export-smart-quotes-alist'? It is a defconst. Ah, indeed. I'd say using a defcustom here would be useful. >>> >>> Is changing defconst to defcustom ok for bugfix? >> >> Nope, it's more an "evolution"

Re: [patch] Fix inner smart quotes in French

2023-08-15 Thread Ihor Radchenko
Bastien Guerry writes: Are you referring to `org-export-smart-quotes-alist'? It is a defconst. >>> >>> Ah, indeed. I'd say using a defcustom here would be useful. >> >> Is changing defconst to defcustom ok for bugfix? > > Nope, it's more an "evolution" than a bugfix. Ok. I changed it to

Re: [patch] Fix inner smart quotes in French

2023-08-14 Thread Bastien Guerry
Ihor Radchenko writes: > Bastien Guerry writes: > >>> Are you referring to `org-export-smart-quotes-alist'? It is a defconst. >> >> Ah, indeed. I'd say using a defcustom here would be useful. > > Is changing defconst to defcustom ok for bugfix? Nope, it's more an "evolution" than a bugfix.

Re: [patch] Fix inner smart quotes in French

2023-08-13 Thread Ihor Radchenko
Bastien Guerry writes: >> Are you referring to `org-export-smart-quotes-alist'? It is a defconst. > > Ah, indeed. I'd say using a defcustom here would be useful. Is changing defconst to defcustom ok for bugfix? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [patch] Fix inner smart quotes in French

2023-08-13 Thread Bastien Guerry
Ihor Radchenko writes: >> It's difficult to say what's more common but since we cannot expect >> the « « inner » » style to be correctly implemented in, say, HTML, and >> since, even in LaTeX, babel-french defaults to the « “inner” » style, >> I suggest we stick to the « “inner” » style (this is

Re: [patch] Fix inner smart quotes in French

2023-08-13 Thread Ihor Radchenko
Bastien Guerry writes: >> What I >> don't know is why babel-french defaults to the « “inner” » style. Is it >> the most used currently in France? If the « « inner » » style is more >> canonical, I don't mind having my patch 'fix' reverted. > > It's difficult to say what's more common but since

Re: [patch] Fix inner smart quotes in French

2023-08-13 Thread Bastien Guerry
Hi Juan, Juan Manuel Macías writes: > In any case (apart from LaTeX), it is clear that I was wrong when I said > that the inner quotes that my patch 'corrects' were 'incorrect'. Indeed, and thanks for the discussion, interesting. > What I > don't know is why babel-french defaults to the «

Re: [patch] Fix inner smart quotes in French

2023-08-10 Thread Juan Manuel Macías
Bastien writes: > Yes, this is also what the French national printing press ("Imprimerie > nationale"), which is quite authoritative in this matter, recommends. > > Note that the Full recommendation of the Imprimerie nationale is to > repeat second-level quotation marks at the beginning and of

Re: [patch] Fix inner smart quotes in French

2023-08-10 Thread Max Nikulin
On 10/08/2023 21:49, Bastien wrote: So I'd rather use this: Then X reported : « This is what Y said : ”Here is a quotation with a paragraph spaning over several lines, with each line starting with a quotation mark until the end of the quotation."» WDYT? I do not mind since I see

Re: [patch] Fix inner smart quotes in French

2023-08-10 Thread Bastien
Max Nikulin writes: > On 04/08/2023 18:09, Bastien wrote: >> Juan Manuel Macías writes: >> >>> In the meantime, I'm submitting this patch with a fix for second-level >>> French `smart quotes': the correct quotes should be “” (without spaces, >>> as in Spanish or Greek) (please, some francophone

Re: [patch] Fix inner smart quotes in French

2023-08-10 Thread Max Nikulin
On 04/08/2023 18:09, Bastien wrote: Juan Manuel Macías writes: In the meantime, I'm submitting this patch with a fix for second-level French `smart quotes': the correct quotes should be “” (without spaces, as in Spanish or Greek) (please, some francophone correct me, if I'm wrong...).

Re: [patch] Fix inner smart quotes in French

2023-08-05 Thread Ihor Radchenko
Juan Manuel Macías writes: >> And it looks like at least on of the test conditions is not trivial to >> fix without knowing French. May you or somebody familiar with French >> punctuation take a look? > > I'm afraid I'm not very familiar with the syntax and usage of tests, so > I have to study

Re: [patch] Fix inner smart quotes in French

2023-08-05 Thread Juan Manuel Macías
Hi, Ihor, Ihor Radchenko writes: > Welcome back :) thanks! :-) >> In the meantime, I'm submitting this patch with a fix for second-level >> French `smart quotes': the correct quotes should be “” (without spaces, >> as in Spanish or Greek) (please, some francophone correct me, if I'm >>

Re: [patch] Fix inner smart quotes in French

2023-08-05 Thread Ihor Radchenko
Juan Manuel Macías writes: > These last months I have been disconnected from the list for family > reasons. Now, trying to catch up with the news on the list and pending > things that I left here :-). Welcome back :) > In the meantime, I'm submitting this patch with a fix for second-level >

Re: [patch] Fix inner smart quotes in French

2023-08-04 Thread Bastien
Hi Juan, Juan Manuel Macías writes: > In the meantime, I'm submitting this patch with a fix for second-level > French `smart quotes': the correct quotes should be “” (without spaces, > as in Spanish or Greek) (please, some francophone correct me, if I'm > wrong...). Applied, thanks! --

[patch] Fix inner smart quotes in French

2023-08-04 Thread Juan Manuel Macías
Hi, These last months I have been disconnected from the list for family reasons. Now, trying to catch up with the news on the list and pending things that I left here :-). In the meantime, I'm submitting this patch with a fix for second-level French `smart quotes': the correct quotes should be