Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

Christian Köstlin writes: > Subject: [PATCH 2/2] testing/lisp/test-ob-C.el: Add test for dub support in > ob-C.el Canceled, due to no response. See https://list.orgmode.org/orgmode/CAG741+bUT_Yt3PdLuVpMNH7vo-bb3n1iiynf2Cime1LW=21...@mail.gmail.com/ -- Ihor Radchenko // yantar92, Org mode

Re: [PATCH] Please add support for dlangs packagemanager to ob-C.el - v3

Ihor Radchenko writes: >> After adding unit-tests (following in another patchset) I found a bug in my >> last patch. >> Sorry for the noise. > > Sorry for the very late reply. > > If you are still interested, may you please document the new header > argument in etc/ORG_NEWS and update >

Re: [PATCH] Please add support for dlangs packagemanager to ob-C.el - v3

Christian Köstlin writes: > After adding unit-tests (following in another patchset) I found a bug in my > last patch. > Sorry for the noise. Sorry for the very late reply. If you are still interested, may you please document the new header argument in etc/ORG_NEWS and update

Re: Please add support for dlangs packagemanager to ob-C.el

tbanelwebmin writes: > Your TINYCHANGE fits into the 15 lines limit. I will review it. > > As Bastien said, we follow as much as we can a predefined format for commit > messages: > https://orgmode.org/worg/org-contribute.html#commit-messages > > You may also look at past commit messages, for

Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

tbanelwebmin writes: > For unit-testing Dlang, we could mock the «dub» command (compiler+packager). > For instance, we could replace it > by the «cat» Linux command, just while running the unit-test. > > But the «cat» command introduces a new dependency on Linux. Is there a > portable

Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

For unit-testing Dlang, we could mock the «dub» command (compiler+packager). For instance, we could replace it by the «cat» Linux command, just while running the unit-test. But the «cat» command introduces a new dependency on Linux. Is there a portable

Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

Christian Köstlin writes: >> If the programming language is using its own package manager, is it any >> different? Or do you refer to something else? >> > Most of the packages that a programming language like rust/crates, > ruby/rubygems > or dlang/dub-packages provide will probably never

Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

Max Nikulin writes: > I am unsure concerning general policy related to org-babel test, so the > following is rather discussion than a direct request to change the test. > > Is there a way to avoid dependency on remote resources? My concern is > test results affected by network issues. In

Re: [PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

On 02/10/2022 05:05, Christian Köstlin wrote: Aforementioned unit-test. +(ert-deftest ob-D/dub-basics () + (if (executable-find "dub") (org-test-at-id + "81E17302-BE76-4E2A-93CA-0A7E121CB7C2" (org-babel-next-src-block 1) + (should (equal "abc, bac, cab, acb, bca,

[PATCH] Unit-test for Please add support for dlangs packagemanager to ob-C.el

Aforementioned unit-test. Kind regards, Christian 0002-testing-lisp-test-ob-C.el-Add-test-for-dub-support-i.patch Description: Binary data

[PATCH] Please add support for dlangs packagemanager to ob-C.el - v3

After adding unit-tests (following in another patchset) I found a bug in my last patch. Sorry for the noise. Kind regards, Christian 0001-lisp-ob-C.el-Support-dub-in-ob-D.patch Description: Binary data

[PATCH] Please add support for dlangs packagemanager to ob-C.el

Thanks a lot for you feedbacks! I rebased my change now, and I hope my changed commit message now conforms more the the projects standard. I will send in another patchset including some unittests, if I can get them to work locally at my machine. Thanks in advance, Christian

Re: Please add support for dlangs packagemanager to ob-C.el

Thanks Christian. Your TINYCHANGE fits into the 15 lines limit. I will review it. As Bastien said, we follow as much as we can a predefined format for commit messages: https://orgmode.org/worg/org-contribute.html#commit-messages You may also

Re: Please add support for dlangs packagemanager to ob-C.el

Hi Christian, thanks for the patch (you forgot to advertize it by adding [PATCH] in the subject.) Christian Köstlin writes: > Please see the patch comment. I reworked my original patch to fit > into the TINYPATCH category. I'm CC'ing Thierry as the maintainer of ob-C.el. The commit message

Please add support for dlangs packagemanager to ob-C.el

Please see the patch comment. I reworked my original patch to fit into the TINYPATCH category. Kind regards, Christian 0001-lisp-ob-C.el-Support-dub-dependencies-for-dlang.patch Description: Binary data

Re: Re: Please add support for dlangs packagemanager to ob-C.el

Hi Thierry, thanks for your feedback and please let me know if I should change anything to fit better into the org-mode codebase. > Easily adding DLang dependencies while keeping a single code block seems > quite useful. > I will take a deeper look at your proposal. > Also, you marked your

Re: Please add support for dlangs packagemanager to ob-C.el

Thanks Christian for this contribution. Easily adding DLang dependencies while keeping a single code block seems quite useful. I will take a deeper look at your proposal. Also, you marked your patch as TINYCHANGE, which imply it is less than 15 lines long. However your patch is 24 lines long.

Please add support for dlangs packagemanager to ob-C.el

I Hope the patch already contains enough background information why its a nice feature to have in ob-C.el. Kind regards, Christian 0001-lisp-ob-C.el-Support-dub-dependencies-for-dlang.patch Description: Binary data