Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

Bastien Guerry writes: > Ihor Radchenko writes: > >> Bastien, may you please check FSF records? > > Done, and confirmed things are in order. Welcome! Recorded. https://git.sr.ht/~bzg/worg/commit/4760468a -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

Ihor Radchenko writes: > Bastien, may you please check FSF records? Done, and confirmed things are in order. Welcome! -- Bastien Guerry

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

Tim Ruffing writes: > On Tue, 2024-02-27 at 12:49 +, Ihor Radchenko wrote: >> However, your total contributions are now at the limit we can legally >> accept without FSF copyright assignment. >> Would you consider doing copyright paperwork as described in >>

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

On Tue, 2024-02-27 at 12:49 +, Ihor Radchenko wrote: > However, your total contributions are now at the limit we can legally > accept without FSF copyright assignment. > Would you consider doing copyright paperwork as described in > ? >

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

Tim Ruffing writes: > Hm, now that I think about it again, I'm not sure that defining a new > function is worth the hassle. There's nothing wrong with the current > function or the optional argument, in the sense that callers can simply > choose not to use the optional argument. > > If

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

On Wed, 2024-02-14 at 14:20 +, Ihor Radchenko wrote: > > > We can do this - I do not see any code in the wild using the optional > arguments. However, we should do it carefully - (1) Move the function > to > org-compat and mark obsolete, recommending a new function instead; > (2) > Create a

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

Tim Ruffing writes: >> Please do not remove arguments from the public functions. This may >> break >> code outside Org mode. >> > Hm, sure, I assumed it's okay for this niche thing. Can we deprecate > the argument somehow? We can do this - I do not see any code in the wild using the optional

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

Added a test. > Please do not remove arguments from the public functions. This may > break > code outside Org mode. > Hm, sure, I assumed it's okay for this niche thing. Can we deprecate the argument somehow? Best, Tim From b886446be8ea02f38d9be6cccf6899d6de396d06 Mon Sep 17 00:00:00 2001

Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number

Tim Ruffing writes: > The attached patch fixes the following bug: > > * Have a scheduled item that has also has a deadline with a cusom >prewarning cookie, e.g. <... -3d>. > * Set `org-agenda-skip-deadline-prewarning-if-scheduled' to 7 > > Then in the agenda, the item is shown already 7