Re: Please add support for dlangs packagemanager to ob-C.el

2022-10-28 Thread Ihor Radchenko
tbanelwebmin writes: > Your TINYCHANGE fits into the 15 lines limit. I will review it. > > As Bastien said, we follow as much as we can a predefined format for commit > messages: > https://orgmode.org/worg/org-contribute.html#commit-messages > > You may also look at past commit messages, for ins

Re: Please add support for dlangs packagemanager to ob-C.el

2022-09-29 Thread tbanelwebmin
Thanks Christian. Your TINYCHANGE fits into the 15 lines limit. I will review it. As Bastien said, we follow as much as we can a predefined format for commit messages: https://orgmode.org/worg/org-contribute.html#commit-messages You may also l

Re: Please add support for dlangs packagemanager to ob-C.el

2022-09-27 Thread Bastien
Hi Christian, thanks for the patch (you forgot to advertize it by adding [PATCH] in the subject.) Christian Köstlin writes: > Please see the patch comment. I reworked my original patch to fit > into the TINYPATCH category. I'm CC'ing Thierry as the maintainer of ob-C.el. The commit message sh

Re: Re: Please add support for dlangs packagemanager to ob-C.el

2022-03-13 Thread Christian Köstlin
Hi Thierry, thanks for your feedback and please let me know if I should change anything to fit better into the org-mode codebase. > Easily adding DLang dependencies while keeping a single code block seems > quite useful. > I will take a deeper look at your proposal. > Also, you marked your patc

Re: Please add support for dlangs packagemanager to ob-C.el

2022-03-10 Thread tbanelwebmin
Thanks Christian for this contribution. Easily adding DLang dependencies while keeping a single code block seems quite useful. I will take a deeper look at your proposal. Also, you marked your patch as TINYCHANGE, which imply it is less than 15 lines long. However your patch is 24 lines long. Thi