Re: [Emc-developers] github pull requests, automatic checks, and signed-off-by

2016-08-15 Thread Jeff Epler
On Mon, Aug 15, 2016 at 04:55:51PM -0500, Jeff Epler wrote: > so yeah that is a promising idea! Do the SOB check as a pre-build step, > and no need to run a service for that. Unfortunately, this doesn't seem to pan out. If travis-ci already built at some ref abc123 for a push, it won't build aga

Re: [Emc-developers] github pull requests, automatic checks, and signed-off-by

2016-08-15 Thread Jeff Epler
On Mon, Aug 15, 2016 at 03:27:11PM -0500, John Morris wrote: > > > On 08/15/2016 02:43 PM, Jeff Epler wrote: > > I have about an 80% solution to checking signed-off-by and showing it on > > github pull requests as an automated check. You can see a PR that > > satisfies our policy here in my pers

Re: [Emc-developers] github pull requests, automatic checks, and signed-off-by

2016-08-15 Thread Jeff Epler
On IRC, Chris Radek notes that this would also mean rewriting/reimplementing the current e-mail integration (emc-commit list), irc integration (kgb-linuxcnc), and buildbot integration. This is technically doable with github's webhooks, but needs additional developer time. Jeff --

Re: [Emc-developers] github pull requests, automatic checks, and signed-off-by

2016-08-15 Thread John Morris
On 08/15/2016 02:43 PM, Jeff Epler wrote: > I have about an 80% solution to checking signed-off-by and showing it on > github pull requests as an automated check. You can see a PR that > satisfies our policy here in my personal github fork: > > https://github.com/jepler/linuxcnc/pull/3 > > (

[Emc-developers] github pull requests, automatic checks, and signed-off-by

2016-08-15 Thread Jeff Epler
I have about an 80% solution to checking signed-off-by and showing it on github pull requests as an automated check. You can see a PR that satisfies our policy here in my personal github fork: https://github.com/jepler/linuxcnc/pull/3 (for some reason you have to be signed in on github to se