First of all, be patient with my english.
I would like to contribute a generic userspace "modbus to hal" component,
AKA mb2hal.
It is based on (totally rewritten) Les Newell's code
http://wiki.linuxcnc.org/cgi-bin/wiki.pl?ContributedComponents#Generic_compo
nent_with_support_for_multiple_clients_
On 11 October 2012 00:21, Victor Rocco wrote:
> I would like to know if it could be accepted as a contribution and how is
> the process of accepting it.
If there is a process, then I have never spotted it.
Ideally you would need to find someone with push-access to the
repository who also has a
On 10/11/2012 6:13 AM, andy pugh wrote:
> On 11 October 2012 00:21, Victor Rocco wrote:
>
>
>> I would like to know if it could be accepted as a contribution and how is
>> the process of accepting it.
>>
> If there is a process, then I have never spotted it.
>
> Ideally you would need to
>On 10/11/2012 6:13 AM, andy pugh wrote:
>> Ideally you would need to find someone with push-access to the
>> repository who also has a modbus drive, and the time to test your
>> component.
>>
>> Finding all three at the same time might be difficult.
>>
>> However, as your component is a standalone
Sounds good.
Dave
On 10/15/2012 7:19 PM, Victor Rocco wrote:
>> On 10/11/2012 6:13 AM, andy pugh wrote:
>>
>>> Ideally you would need to find someone with push-access to the
>>> repository who also has a modbus drive, and the time to test your
>>> component.
>>>
>>> Finding all three at the
>On 10/11/2012 6:13 AM, andy pugh wrote:
>> However, as your component is a standalone module then the chances of
>> it breaking anything else seem rather small. The only danger seems to
>> be that it might break the build system.
>> A resonable guide to the tests that you ought to run can be fou
On 18 October 2012 12:09, Victor Rocco wrote:
> I have problems with
> http://wiki.linuxcnc.org/cgi-bin/wiki.pl?PreparingContributions
> The last test "fakeroot debian/rules binary" fails. The problem is not with
> my code
> because i have tested it with "master" alone, in normal and simulator mo
Am 18.10.2012 um 13:09 schrieb Victor Rocco:
>> On 10/11/2012 6:13 AM, andy pugh wrote:
>>> However, as your component is a standalone module then the chances of
>>> it breaking anything else seem rather small. The only danger seems to
>>> be that it might break the build system.
>>> A resonabl
Am 18.10.2012 um 14:15 schrieb Michael Haberler:
>
>
> Actually I think the dpkg-shlibdeps should find gcode.so and be happy; I dont
> know why it doesnt.
>
> Looking at debian/rules.in I see:
> dh_shlibdeps -l debian/@MAIN_PACKAGE_NAME@/usr/lib
>
> probably adding the Python library p
I'll take a look at it. But as you noted, it's been on my list for years, so
don't nobody hold your breath. ;-)
--
Sebastian Kuzminsky
- Reply message -
From: "Michael Haberler"
Date: Thu, Oct 18, 2012 06:55
Subject: [Emc-developers] I would like to co
Any progress on this? I have found myself recommending it as a
solution to a problem on the forum twice now, so there is no doubt
that it is going to be useful if it works.
--
atp
If you can't fix it, you don't own it.
http://www.ifixit.com/Manifesto
-
On Wed, 2012-10-24 at 13:34 +0100, andy pugh wrote:
> Any progress on this? I have found myself recommending it as a
> solution to a problem on the forum twice now, so there is no doubt
> that it is going to be useful if it works.
I haven't followed this thread, but Modbus should be working for si
On 24 October 2012 16:09, Kirk Wallace wrote:
>> I have found myself recommending it as a
>> solution to a problem on the forum twice now,
> I haven't followed this thread, but Modbus should be working for single
> devices in a .comp or Classic Ladder.
Actually, one of the occasions I suggested
On Wed, 2012-10-24 at 16:19 +0100, andy pugh wrote:
> On 24 October 2012 16:09, Kirk Wallace wrote:
>
> >> I have found myself recommending it as a
> >> solution to a problem on the forum twice now,
>
> > I haven't followed this thread, but Modbus should be working for single
> > devices in a .c
On 24 October 2012 16:39, Kirk Wallace wrote:
> I like the e-mail list because the messages come over whether I
> want them or not.:)
I don't like forums, I too much prefer email lists for the same
reason. It take real effort to be sure you haven't missed anything in
the forums.
> It would be
Am 24.10.2012 um 17:50 schrieb andy pugh:
> On 24 October 2012 16:39, Kirk Wallace wrote:
>
>> I like the e-mail list because the messages come over whether I
>> want them or not.:)
>
> I don't like forums, I too much prefer email lists for the same
> reason. It take real effort to be sure you
-Mensaje original-
De: Sebastian Kuzminsky [mailto:s...@highlab.com]
Enviado el: Miércoles, 24 de Octubre de 2012 01:40 p.m.
Para: Michael Haberler; victor_ro...@hotmail.com
Asunto: Re: Fwd: [Emc-developers] I would like to contribute a "modbus to
hal" component, AKA mb2hal.
O
to contribute a "modbus to
> hal" component, AKA mb2hal.
>
> On 10/24/12 10:16 , Michael Haberler wrote:
>> Anfang der weitergeleiteten E-Mail:
>>
>>> Von: Victor Rocco
>>> Betreff: RE: [Emc-developers] I would like to contribute a "modbus to
&g
> -Mensaje original-
> De: Sebastian Kuzminsky [mailto:s...@highlab.com] Enviado el:
> Miércoles, 24 de Octubre de 2012 04:07 p.m.
> Para: EMC developers
> Asunto: Re: [Emc-developers] I would like to contribute a "modbus to hal"
component, AKA mb2hal.
>
>
I haven't been following this thread but I found a couple of bugs in
modbus.c some time back. I don't know if they are the same problems
Victor found.
Here is the patch for modbus.c:
From ebaefba238af22e4f30febc61175c7f9d3211cb4 Mon Sep 17 00:00:00 2001
From: Les Newell
Date: Mon, 13 Aug 2012
On 25 October 2012 11:42, Les Newell wrote:
> I haven't been following this thread but I found a couple of bugs in
> modbus.c some time back. I don't know if they are the same problems
Not only that, but the patch under discussion is your patch file.
--
atp
If you can't fix it, you don't own it
On Thu, 25 Oct 2012 13:03:49 +0100, andy pugh wrote:
> On 25 October 2012 11:42, Les Newell
> wrote:
>> I haven't been following this thread but I found a couple of bugs in
>> modbus.c some time back. I don't know if they are the same problems
>
> Not only that, but the patch under discussion is
-Mensaje original-
De: Les Newell [mailto:les.new...@fastmail.co.uk]
Enviado el: Jueves, 25 de Octubre de 2012 07:42 a.m.
Para: EMC developers
Asunto: Re: [Emc-developers] I would like to contribute a "modbus to hal"
component, AKA mb2hal.
> I haven't been following
On 25/10/2012 13:03, andy pugh wrote:
> Not only that, but the patch under discussion is your patch file.
Victor Rocco wrote
> Yes i have tried it in depth and have totally rewritten it to create mb2hal.
Oops. I really should have paid more attention. I feel a bit of a fool
now :-[
> - When th
On 10/25/12 04:09 , Victor Rocco wrote:
> I did the homework.
> There are only 4 programs that uses modbus communications: 1) classicladder
> 2) gs2_vfd 3) vfs11_vfd 4) mb2hal.
> 1) classicladder have their own implementation of modbus. So will NOT be
> affected by the patch.
> 2) gs2_vfd uses the
On Thu, 2012-10-25 at 09:41 -0600, Sebastian Kuzminsky wrote:
> On 10/25/12 04:09 , Victor Rocco wrote:
... snip
> > I am confident that you could apply the patch (0002-A-.) to master
> > WITHOUT problems.
> > Just to be sure, i will be glad if you do some test with your own GS2 drive.
> >
>
>
Am 25.10.2012 um 18:54 schrieb Kirk Wallace:
> On Thu, 2012-10-25 at 09:41 -0600, Sebastian Kuzminsky wrote:
>> On 10/25/12 04:09 , Victor Rocco wrote:
> ... snip
>>> I am confident that you could apply the patch (0002-A-.) to master
>>> WITHOUT problems.
>>> Just to be sure, i will be glad i
On Thu, 2012-10-25 at 19:49 +0200, Michael Haberler wrote:
... snip
> I think folks generally pin too high hopes as to the accuracy and
> timeliness of wiki entries - really it's just perceived as a
> distributed notepad, with no clear maintenance responsibility affixed
> to it. I doubt appeals tow
On 10/25/12 13:02 , Kirk Wallace wrote:
> Also, my understanding is that I or others in my situation don't have
> access to the manual system, which is most likely a good thing. That's
> how I see it from here.
The manual is tracked in git, which means everyone has access. git is
explicitly d
On Thu, 2012-10-25 at 13:16 -0600, Sebastian Kuzminsky wrote:
> On 10/25/12 13:02 , Kirk Wallace wrote:
> > Also, my understanding is that I or others in my situation don't have
> > access to the manual system, which is most likely a good thing. That's
> > how I see it from here.
>
> The manual
Hi Victor, I noticed that Clang caught a couple of issues in mb2hal.
Nothing big, two instances of dead initialization (so, a variable is
explicitly set at define-time, but then written to again before being read).
http://buildbot.linuxcnc.org/clang/master-rt/v2.6.0-pre0-3261-g360e465/report-Wi
> -Mensaje original-
> De: Sebastian Kuzminsky [mailto:s...@highlab.com]
> Enviado el: Sábado, 27 de Octubre de 2012 11:28 a.m.
> Para: EMC developers
> CC: Victor Rocco
> Asunto: Re: [Emc-developers] I would like to contribute a "modbus to hal"
component,
> -Mensaje original-
> De: Les Newell [mailto:les.new...@fastmail.co.uk]
> Enviado el: Jueves, 25 de Octubre de 2012 10:43 a.m.
> Para: EMC developers
> Asunto: Re: [Emc-developers] I would like to contribute a "modbus to hal"
component, AKA mb2hal.
>
>
>
On 10/27/2012 10:47 AM, Victor Rocco wrote:
> Attached is the patch.
That fixed it, thanks. Pushed to master.
--
Sebastian Kuzminsky
--
WINDOWS 8 is here.
Millions of people. Your app in 30 days.
Visit The Windows
I applied the modbus patch and removed the patch file from our repo.
This just went into master.
Thanks Les Newell and Victor Rocco for doing the work to improve modbus.
--
Sebastian Kuzminsky
--
Everyone hates slow
35 matches
Mail list logo
