Re: [Emc-developers] hal_vti strangeness

2008-11-15 Thread Sebastian Kuzminsky
Stephen Wille Padnos wrote: > Sebastian Kuzminsky wrote: > >> I'm going through the issues Coverity has found in our TRUNK, and while >> fixing a couple of bugs in hal_vti i noticed something strange. >> >> > Can you post the scan report somewhere? I'm curious to see what one > looks like, es

Re: [Emc-developers] hal_vti strangeness

2008-11-14 Thread Stephen Wille Padnos
Sebastian Kuzminsky wrote: >I'm going through the issues Coverity has found in our TRUNK, and while >fixing a couple of bugs in hal_vti i noticed something strange. > > Can you post the scan report somewhere? I'm curious to see what one looks like, especially on code I'm (marginally) familiar

Re: [Emc-developers] hal_vti strangeness

2008-11-14 Thread Eric H. Johnson
Sebastian, I wrote that code, or more correctly adapted a typical HAL driver written by Alex with the EMC1 VTI driver written by Paul. I do not recall why I needed, or thought I needed to put that in there. All it does is a test from the command line for the maximum number of axes. The base VTI bo

[Emc-developers] hal_vti strangeness

2008-11-14 Thread Sebastian Kuzminsky
I'm going through the issues Coverity has found in our TRUNK, and while fixing a couple of bugs in hal_vti i noticed something strange. hal_vti.h defines MAX_CHANS to be 4, and that's used a lot in hal_vti.c. But hal_vti.c defines MAX_CHAN (without the S) to be 8, and uses that in one place in