Re: [Engine-devel] Gerrit NEW Change Screen

2014-01-27 Thread Mike Kolesnik
- Original Message - - Original Message - From: Roy Golan rgo...@redhat.com To: Itamar Heim ih...@redhat.com, vdsm-de...@lists.fedorahosted.org, engine-devel engine-devel@ovirt.org Sent: Sunday, January 26, 2014 9:12:38 AM Subject: Re: [Engine-devel] Gerrit NEW

Re: [Engine-devel] Using config values

2013-12-01 Thread Mike Kolesnik
- Original Message - - Original Message - From: Mike Kolesnik mkole...@redhat.com To: Kanagaraj kmayi...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Sunday, December 1, 2013 8:08:42 AM Subject: Re: [Engine-devel] Using config values

Re: [Engine-devel] Using config values

2013-12-01 Thread Mike Kolesnik
Regards, Mike - Original Message - - Original Message - From: Mike Kolesnik mkole...@redhat.com To: Omer Frenkel ofren...@redhat.com Cc: Kanagaraj kmayi...@redhat.com, engine-devel engine-devel@ovirt.org Sent: Sunday, December 1, 2013 11:01:50 AM Subject

Re: [Engine-devel] Using config values

2013-11-30 Thread Mike Kolesnik
- Original Message - Hi All, Hi Kanagaraj, The are some issues arising in configurations whenever we move up on the versions(3.3 = 3.4), because of the way we store and interpret them. Whenever there is a new cluster level, you will need to add a new entry for all(most) of the

Re: [Engine-devel] Remove Comment column in main tabs

2013-11-27 Thread Mike Kolesnik
...@redhat.com Cc: engine-devel engine-devel@ovirt.org, Mike Kolesnik mkole...@redhat.com Sent: Wednesday, November 27, 2013 8:18:38 AM Subject: Re: [Engine-devel] Remove Comment column in main tabs That is a good point. I guess the question is if sorting will be necessary

Re: [Engine-devel] Remove Comment column in main tabs

2013-11-26 Thread Mike Kolesnik
- Original Message - Hi Malini, This could work but I am not a big fan of simply adding iconic columns preceding the name. This is actually a good example where 2 icon columns are already there and adding another column is making the primary column ( i.e the name column) not

[Engine-devel] Remove Comment column in main tabs

2013-11-25 Thread Mike Kolesnik
Hi, When the comment RFE was added (in 3.3), there was also a column added to many main tabs. I would like to propose to get rid of the column (which can only house one icon or no icon), and instead if there's a comment on an entity just display the icon with the tooltip adjacent to the

Re: [Engine-devel] Fwd: Custom properties per device + vNIC profile = not working ( 3.3)

2013-11-19 Thread Mike Kolesnik
- Original Message - On 11/11/2013 11:48 AM, Mike Kolesnik wrote: - Original Message - Hi Mike, - Original Message - From: Mike Kolesnik mkole...@redhat.com To: engine-devel engine-devel@ovirt.org Cc: Barak Azulay bazu...@redhat.com, Martin Perina mper

Re: [Engine-devel] Fwd: Custom properties per device + vNIC profile = not working ( 3.3)

2013-11-19 Thread Mike Kolesnik
- Original Message - On 11/20/2013 09:07 AM, Mike Kolesnik wrote: - Original Message - On 11/11/2013 11:48 AM, Mike Kolesnik wrote: - Original Message - Hi Mike, - Original Message - From: Mike Kolesnik mkole...@redhat.com To: engine-devel engine

Re: [Engine-devel] Fwd: Custom properties per device + vNIC profile = not working ( 3.3)

2013-11-19 Thread Mike Kolesnik
- Original Message - On 11/20/2013 09:31 AM, Mike Kolesnik wrote: - Original Message - On 11/20/2013 09:07 AM, Mike Kolesnik wrote: - Original Message - On 11/11/2013 11:48 AM, Mike Kolesnik wrote: - Original Message - Hi Mike, - Original

Re: [Engine-devel] Fwd: Custom properties per device + vNIC profile = not working ( 3.3)

2013-11-11 Thread Mike Kolesnik
- Original Message - Hi Mike, - Original Message - From: Mike Kolesnik mkole...@redhat.com To: engine-devel engine-devel@ovirt.org Cc: Barak Azulay bazu...@redhat.com, Martin Perina mper...@redhat.com, Livnat Peer lp...@redhat.com, Itamar Heim ih...@redhat.com Sent

[Engine-devel] Custom properties per device + vNIC profile = not working ( 3.3)

2013-11-10 Thread Mike Kolesnik
Hi, I came across a situation where I wanted to define custom properties on a vNIC profile sitting under a network in a 3.2 data center. From what I saw the configuration value for custom properties (CustomDeviceProperties) is split into 4, one per each version (3.0, 3.1, 3.2, 3.3). Since

Re: [Engine-devel] Usage of 'Comment' field in Cluster

2013-10-29 Thread Mike Kolesnik
- Original Message - Hi All, I see a new field in Cluster called 'Comment'. It is available in 'New/Edit Cluster' dialog as well as in the 'Clusters Tab'. The Comment column in the clusters table shows a 'note' icon when some comment is set for a cluster. I just want to

Re: [Engine-devel] oVirt3.3 - Glance and Neutron Integration

2013-09-30 Thread Mike Kolesnik
- Original Message - Hi Mike, Hi Udaya, Thank You for the quick update on this. Happy to help, responses inline. Is there any restriction on installing the Neutron server? Should that be installed in the oVirt Engine machine or on the machines which host the openstack services

Re: [Engine-devel] oVirt3.3 - Glance and Neutron Integration

2013-09-30 Thread Mike Kolesnik
- Original Message - Hi Mike, Hi Udaya, Please find attached the screenshots for, 1. yum provides ovirt-engine 2. /etc/yum.repos.d/ovirt.repo Please correct me if some settings has to be changed. As you can see the package you have installed is from ovirt-nightly repo. The

[Engine-devel] Join us in a deep dive into the oVirt-Neutron integration

2013-08-01 Thread Mike Kolesnik
, Mike - Original Message - The following is a new meeting request: Subject: Join us in a deep dive into the oVirt-Neutron integration Organizer:Mike Kolesnik mkole...@redhat.com Time: Wednesday, July 31, 2013, 4:00:00 PM - 5:00:00 PM GMT +02:00 Jerusalem Invitees

[Engine-devel] Join us in a deep dive into the oVirt-Neutron integration

2013-07-28 Thread Mike Kolesnik
:20130731T17 STATUS:CONFIRMED CLASS:PUBLIC X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY TRANSP:OPAQUE LAST-MODIFIED:20130728T144239Z DTSTAMP:20130728T144239Z SEQUENCE:0 DESCRIPTION:The following is a new meeting request:\n\nSubject: Join us in a deep dive into the oVirt-Neutron integration \nOrganizer: Mike

Re: [Engine-devel] Proposal for new commit msg design for engine commits

2013-07-11 Thread Mike Kolesnik
- Original Message - - Original Message - From: Itamar Heim ih...@redhat.com To: Eyal Edri ee...@redhat.com Cc: engine-devel engine-devel@ovirt.org, infra in...@ovirt.org Sent: Wednesday, July 10, 2013 10:37:03 PM Subject: Re: [Engine-devel] Proposal for new commit

Re: [Engine-devel] What type of DB inheritance to use?

2013-05-13 Thread Mike Kolesnik
- Original Message - - Original Message - From: Itamar Heim ih...@redhat.com To: Mike Kolesnik mkole...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Sunday, May 12, 2013 5:05:52 PM Subject: Re: [Engine-devel] What type of DB inheritance to use? On 05

Re: [Engine-devel] What type of DB inheritance to use?

2013-05-13 Thread Mike Kolesnik
- Original Message - On 05/13/2013 08:33 AM, Mike Kolesnik wrote: - Original Message - On 05/12/2013 04:31 PM, Mike Kolesnik wrote: - Original Message - On 05/12/2013 03:16 PM, Mike Kolesnik wrote: - Original Message - On 05/12/2013 12:42 PM, Mike

Re: [Engine-devel] What type of DB inheritance to use?

2013-05-13 Thread Mike Kolesnik
- Original Message - On 05/12/2013 04:31 PM, Mike Kolesnik wrote: - Original Message - On 05/12/2013 03:16 PM, Mike Kolesnik wrote: - Original Message - On 05/12/2013 12:42 PM, Mike Kolesnik wrote: Hi All, I would like to have your opinions on which

Re: [Engine-devel] What type of DB inheritance to use?

2013-05-13 Thread Mike Kolesnik
- Original Message - On 05/13/2013 10:42 AM, Oved Ourfalli wrote: IMO, the following fields will fit most providers, at least the ones we plan to support in the near future: * id * name * type * URL * requires_authentication (boolean) to support development/POC/testing...

Re: [Engine-devel] What type of DB inheritance to use?

2013-05-13 Thread Mike Kolesnik
- Original Message - On 05/13/2013 11:05 AM, Mike Kolesnik wrote: - Original Message - On 05/13/2013 10:42 AM, Oved Ourfalli wrote: IMO, the following fields will fit most providers, at least the ones we plan to support in the near future: * id * name * type * URL

[Engine-devel] What type of DB inheritance to use?

2013-05-12 Thread Mike Kolesnik
Hi All, I would like to have your opinions on which inheritance type to use in the DB. We are adding an external provider entity to the system which will be able to provide various resources (networks, hosts, etc). These providers will be distinguishable by type. The basic definition of a

Re: [Engine-devel] What type of DB inheritance to use?

2013-05-12 Thread Mike Kolesnik
- Original Message - On 05/12/2013 12:42 PM, Mike Kolesnik wrote: Hi All, I would like to have your opinions on which inheritance type to use in the DB. We are adding an external provider entity to the system which will be able to provide various resources (networks, hosts

Re: [Engine-devel] What type of DB inheritance to use?

2013-05-12 Thread Mike Kolesnik
- Original Message - On 05/12/2013 03:16 PM, Mike Kolesnik wrote: - Original Message - On 05/12/2013 12:42 PM, Mike Kolesnik wrote: Hi All, I would like to have your opinions on which inheritance type to use in the DB. We are adding an external provider entity

Re: [Engine-devel] Move SQL out of stored procedures

2013-03-27 Thread Mike Kolesnik
- Original Message - On 03/27/2013 01:36 PM, Mike Kolesnik wrote: - Original Message - Hello, according to my experiences Hibernate/JPA is the best solution for application which has to support multiple databases. +1 JPA would be much easier to maintain than

Re: [Engine-devel] Move SQL out of stored procedures

2013-03-27 Thread Mike Kolesnik
- Original Message - Hello, according to my experiences Hibernate/JPA is the best solution for application which has to support multiple databases. +1 JPA would be much easier to maintain than the current approach. In most cases the stored procedures we use are for CRUD

Re: [Engine-devel] FeatureSupported and compatibility versions

2013-03-18 Thread Mike Kolesnik
- Original Message - Hi all, The current mechanism in oVirt to check whether a feature is supported in a particular compatibility version is to use the FeatureSupported class. e.g. FeatureSupported.networkLinking(getVm().getVdsGroupCompatibilityVersion()) Checks whether the

[Engine-devel] Generic name is used message

2013-03-17 Thread Mike Kolesnik
Hi, Lately I had to add an error message that name is already used. I looked in the translations files and saw many messages for specific entity types in the system that looked much the same: VDS_TRY_CREATE_WITH_EXISTING_PARAMS=Cannot ${action} ${type}. Host with the same name already exists

[Engine-devel] Better testing for ValidationResults using ValidationResultMatchers

2013-03-17 Thread Mike Kolesnik
Hi, If you don't know what ValidationResult is, check out http://www.ovirt.org/ValidationResult In a gist, I added a new way to test this using JUnit's assertThat syntax: // Test that validation result is valid assertThat(someValidation(), isValid()); // Test that validation result is

Re: [Engine-devel] Engine - top 10 with patches with no activity for more than 30 days

2013-02-20 Thread Mike Kolesnik
- Original Message - thoughts on how to trim these? (in openstack gerrit they auto-abandon patches with no activity for a couple of weeks - author can revive them back when they are relevant) preferred_email | count --+--

[Engine-devel] Import/snapshots duplicate MAC support

2013-02-05 Thread Mike Kolesnik
Hi, The current situation dictates that if the configuration value AllowDuplicateMacAddresses is set to false (this is the default setting), then we block import or switching snapshots where a MAC address in one or more of the snapshot/ovf's virtual NICs is already used. Given that we

Re: [Engine-devel] Guid NGuid

2013-02-04 Thread Mike Kolesnik
- Original Message - - Original Message - From: Laszlo Hornyak lhorn...@redhat.com To: Michael Kublin mkub...@redhat.com Cc: engine-devel@ovirt.org Sent: Monday, February 4, 2013 9:56:28 AM Subject: Re: [Engine-devel] Guid NGuid - Original Message

Re: [Engine-devel] oVirt 3.2 test-day

2013-01-31 Thread Mike Kolesnik
Hi All, I tested some basic network functionality and discovered the following bugs (updated in the wiki): Bug 906289 - [oVirt-webadmin] [network] Non-VM networks shown as VM networks on cluster attachment dialog Bug 906291 - [oVirt-webadmin] [network] Non-VM networks not being detached from

Re: [Engine-devel] jpa annotations

2013-01-13 Thread Mike Kolesnik
- Original Message - - Original Message - From: Itamar Heim ih...@redhat.com To: Laszlo Hornyak lhorn...@redhat.com Cc: engine-devel engine-devel@ovirt.org Sent: Tuesday, December 18, 2012 11:52:39 PM Subject: Re: [Engine-devel] jpa annotations On 12/18/2012

[Engine-devel] Add FeatureSupported class

2013-01-02 Thread Mike Kolesnik
FeatureSupported class Date: Sun, 30 Dec 2012 09:40:19 -0500 From: mkole...@redhat.com Reply-To: engine-devel@ovirt.org To: undisclosed-recipients:; Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add FeatureSupported class

[Engine-devel] Fwd: Change in ovirt-engine[master]: engine: Add FeatureSupported class

2013-01-01 Thread Mike Kolesnik
2012 09:40:19 -0500 From: mkole...@redhat.com Reply-To: engine-devel@ovirt.org To: undisclosed-recipients:; Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add FeatureSupported class .. engine

Re: [Engine-devel] Network related hooks in vdsm

2012-10-16 Thread Mike Kolesnik
- Original Message - Hi everyone, As you know vdsm has hooks mechanism and we already support dozen of hooks for different needs. Now it's a network's time. We would like to get your comments regarding our proposition for network related hooks. In general we are planning to

Re: [Engine-devel] Network related hooks in vdsm

2012-10-16 Thread Mike Kolesnik
- Original Message - On 10/10/12 16:47, Igor Lvovsky wrote: Hi everyone, As you know vdsm has hooks mechanism and we already support dozen of hooks for different needs. Now it's a network's time. We would like to get your comments regarding our proposition for network

Re: [Engine-devel] Any way to break the dao_unit_tests up?

2012-08-21 Thread Mike Kolesnik
- Original Message - On Monday 20 August 2012 11:16 AM, Mike Kolesnik wrote: - Original Message - The DAO unit tests take twice as long as the rest of the test to run is there any way to break them up into two pieces? It will not be easy.. The way the tests

Re: [Engine-devel] Any way to break the dao_unit_tests up?

2012-08-19 Thread Mike Kolesnik
- Original Message - The DAO unit tests take twice as long as the rest of the test to run is there any way to break them up into two pieces? It will not be easy.. The way the tests are built today is with DB-unit. DB-unit allows to have an XML file with predefined data (called

Re: [Engine-devel] Please review: Sync Networks enhancement

2012-07-15 Thread Mike Kolesnik
- Original Message - - Original Message - From: Mike Kolesnik mkole...@redhat.com To: engine-devel engine-devel@ovirt.org Sent: Wednesday, July 11, 2012 4:57:42 AM Subject: [Engine-devel] Please review: Sync Networks enhancement http://www.ovirt.org/wiki

Re: [Engine-devel] Please review: Sync Networks enhancement

2012-07-15 Thread Mike Kolesnik
to. Mike - can you please add that to the wiki. Yes, added in the Engine section. Thanks, Livnat - Original Message - - Original Message - - Original Message - From: Mike Kolesnik mkole...@redhat.com To: engine-devel engine-devel@ovirt.org

Re: [Engine-devel] Fwd: Problem in REST API handling/displaying of logical networks

2012-07-05 Thread Mike Kolesnik
On 07/05/2012 12:19 PM, Livnat Peer wrote: I'll give you one scenario and I'm sure there are lot more: delete all unused networks not strong enough use case in my opinion i do see sense in this, and based on my experience of closing ~5 bugs on this for SD and explaining like

[Engine-devel] Fwd: Problem in REST API handling/displaying of logical networks

2012-07-02 Thread Mike Kolesnik
Hi All, I would like to hear opinions about a behaviour that I think is problematic in REST API handling of logical networks. -- Intro -- Today in the REST API we are exposing two collections for logical network related entities. First is a top level collection which is out of any

Re: [Engine-devel] Vm nic active boolean should be converted to status/state=active

2012-06-14 Thread Mike Kolesnik
Hi, I believe we should save the REST API behavior and keep using status object instead of activetrue/active for vm nics. We should use: status stateactivestate /status Active is a binary state, why would we need a multi-state representation for it? Many rest frameworks works

Re: [Engine-devel] Forking unit tests

2012-06-13 Thread Mike Kolesnik
Hi guys, If you're using settings.xml as published in Building the oVirt Engine page, you'd see we're forking for every test, in every subproject. This behaviour was introduced to handle memory leaks in PowerMock we use in some subprojects, but is redundant in others. Over the past

Re: [Engine-devel] REST-API: Exposing correlation-ID

2012-05-06 Thread Mike Kolesnik
On 05/06/2012 10:03 AM, Ori Liel wrote: Still need to decide about this: 1) what's the name you'd give this parameter? job-id? batch-id? flow-id? command-id? correlation-id??? job-id will confuse us with engine's job-id which is a single command today. correleation-id is pretty long

Re: [Engine-devel] [Jenkins] ovirt-engine fails due to last commit

2012-04-19 Thread Mike Kolesnik
On 04/19/2012 01:36 PM, Itamar Heim wrote: On 04/19/2012 01:44 PM, Juan Hernandez wrote: On 04/19/2012 12:42 PM, Eyal Edri wrote: commit b9a6f23be188e2bf4d56f8b548db1b2536372385 - core: Add methods missing from PGHack (detail / gitweb) That is my fault. I introduced a change for Java

Re: [Engine-devel] How to utilize Jenkins to do your dirty (build) work for you...

2012-03-27 Thread Mike Kolesnik
On 03/26/2012 04:08 PM, Mike Kolesnik wrote: Hi, -- Intro -- When working on your local GIT repo you probably do a lot of: mvn clean install Additionally, if you're working on oVirt-engine you might be doing some of: mvn test -Penable-dao-tests mvn

[Engine-devel] How to utilize Jenkins to do your dirty (build) work for you...

2012-03-26 Thread Mike Kolesnik
Hi, -- Intro -- When working on your local GIT repo you probably do a lot of: mvn clean install Additionally, if you're working on oVirt-engine you might be doing some of: mvn test -Penable-dao-tests mvn install -Pgwt-admin etc.. This, of course, might take your

Re: [Engine-devel] Forward comp[atibility of OVF

2012-03-22 Thread Mike Kolesnik
On 22/03/12 11:04, Mike Kolesnik wrote: Hi, I wanted to know if we want to support forward compatibility of OVF format, which is used for export/import of VMs/VM Templates. For example, I create a VM in a 3.1 system, export it to an export Domain. Should I be able to import

Re: [Engine-devel] [backend] a little confusion about the quartz jobs

2012-02-14 Thread Mike Kolesnik
hi, I was playing with the quartz jobs in the backend and I thought this is an area where some simplification and/or cleanup would be useful. - SchedulerUtil interface would be nice to hide quartz from the rest of the code, but it very rarely used, the clients are bound to it's single

Re: [Engine-devel] Simplifying our POJOs

2012-02-06 Thread Mike Kolesnik
Zaslavsky wrote: On 02/01/2012 08:59 AM, Livnat Peer wrote: On 01/02/12 08:03, Mike Kolesnik wrote: - Original Message - On 01/31/2012 12:45 PM, Doron Fediuck wrote: On 31/01/12 12:39, Livnat Peer wrote: On 31/01/12 12:02, Mike Kolesnik wrote: Hi, Today many

Re: [Engine-devel] Simplifying our POJOs

2012-01-31 Thread Mike Kolesnik
- Original Message - On 31/01/12 12:39, Livnat Peer wrote: On 31/01/12 12:02, Mike Kolesnik wrote: Hi, Today many POJO http://en.wikipedia.org/wiki/Plain_Old_Java_Objects are used throughout the system to convey data: * Parameters - To send data to commands

Re: [Engine-devel] Shared disk / Floating disk import/export (was: Re: move disk command)

2012-01-18 Thread Mike Kolesnik
- Original Message - - Original Message - - Original Message - From: Ayal Baron aba...@redhat.com To: Omer Frenkel ofren...@redhat.com Cc: engine-devel@ovirt.org, Jon Choate jcho...@redhat.com, Maor mlipc...@redhat.com Sent: Wednesday, January