Re: [Enigmail] [PATCH] javascript cleanup

2013-01-19 Thread Daniel Kahn Gillmor
On 01/17/2013 04:42 PM, Daniel Kahn Gillmor wrote: > this patch should offer no significant surprises, as it just cleans up > some cruft that has drifted into the javascript over the years i didn't see any followup on this patch -- is there a problem with it? I think doing this sort of lint-y clea

Re: [Enigmail] [PATCH] javascript cleanup

2013-01-19 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 19.01.13 19:19, Daniel Kahn Gillmor wrote: > On 01/17/2013 04:42 PM, Daniel Kahn Gillmor wrote: >> this patch should offer no significant surprises, as it just >> cleans up some cruft that has drifted into the javascript over >> the years > > i d

Re: [Enigmail] [PATCH] javascript cleanup

2013-01-19 Thread Daniel Kahn Gillmor
On 01/19/2013 01:30 PM, Patrick Brunschwig wrote: > your mails very often end up in the spam folder of my provider (i.e. > sorted out before they are downloaded from Thunderbird), with "sender > address does not exist". This just happened with your patch mail. How weird. When i checked this morn

Re: [Enigmail] [PATCH] javascript cleanup

2013-01-20 Thread Daniel Kahn Gillmor
On 01/20/2013 09:56 AM, Patrick Brunschwig wrote: > I'm fine with your patch except for the following: > "use strict;" and > "use strict"; > > are not the same. According to Mozilla documentation, the latter > shouldn't do anything at all. Here's the documentation i've read: https://developer

Re: [Enigmail] [PATCH] javascript cleanup

2013-01-20 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 20.01.13 16:58, Daniel Kahn Gillmor wrote: > On 01/20/2013 09:56 AM, Patrick Brunschwig wrote: >> I'm fine with your patch except for the following: "use strict;" >> and "use strict"; >> >> are not the same. According to Mozilla documentation, th

Re: [Enigmail] [PATCH] javascript cleanup

2013-01-20 Thread Daniel Kahn Gillmor
On 01/20/2013 11:21 AM, Patrick Brunschwig wrote: > On 20.01.13 16:58, Daniel Kahn Gillmor wrote: > >> fwiw, 'use strict'; appears 6 times in enigmail, while 'use >> strict;' appears twice: > > Ah, sorry. You're right - my memory played tricks with me ;-) I guess i had the advantage of complete i

Re: [Enigmail] [PATCH] javascript cleanup

2013-01-20 Thread Patrick Brunschwig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 20.01.13 17:30, Daniel Kahn Gillmor wrote: > On 01/20/2013 11:21 AM, Patrick Brunschwig wrote: >> On 20.01.13 16:58, Daniel Kahn Gillmor wrote: >> >>> fwiw, 'use strict'; appears 6 times in enigmail, while 'use >>> strict;' appears twice: >> >>