Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Mike McCormack
On 08/27/2010 01:37 PM, Carsten Haitzler (The Rasterman) wrote: >> The pre-alpha excuse won't last for much longer. > > we're not pre-alpha anymore. we WERE and your issue is that your pre-alpha > build edje files didn't work with alpha. :) perfectly reasonable for that to > happen as the DEFINIT

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread The Rasterman
On Fri, 27 Aug 2010 12:21:53 +0900 Mike McCormack said: > On 08/27/2010 11:07 AM, Carsten Haitzler (The Rasterman) wrote: > > > already did that. :) as such though... "you used pre-alpha software... you > > were warned". your edj files were built from PRE alpha software. don't > > forget that. w

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Mike McCormack
On 08/27/2010 11:07 AM, Carsten Haitzler (The Rasterman) wrote: > already did that. :) as such though... "you used pre-alpha software... you > were > warned". your edj files were built from PRE alpha software. don't forget that. > we didn't not advertise, maintain or pretend to support any form o

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread The Rasterman
On Fri, 27 Aug 2010 10:07:07 +0900 Mike McCormack said: already did that. :) as such though... "you used pre-alpha software... you were warned". your edj files were built from PRE alpha software. don't forget that. we didn't not advertise, maintain or pretend to support any form of compatibility

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Mike McCormack
Guys, just one request: If you change the format of .edj again, please add a version number to the binary format so that you can still parse the old format, and build backwards compatibility into the code. The previous change of format screwed everything up royally, from me personally restart

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Lucas De Marchi
On Thu, Aug 26, 2010 at 7:16 PM, Albin Tonnerre wrote: > On Fri, 27 Aug 2010 00:08 +0200, Vincent Torri wrote : >> >> >> On Thu, 26 Aug 2010, Michael Jennings wrote: >> >> > No, that's the whole point.  Every instance that was patched needs to >> > be examined and probably fixed.  Reverting it doe

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Lucas De Marchi
On Thu, Aug 26, 2010 at 6:14 PM, Vincent Torri wrote: > > > > On Thu, 26 Aug 2010, Enlightenment SVN wrote: > >> Log: >>  Apply double_condition_check.cocci > > I do not agree at all with that patch. It is hiding potential problems. > The double condition check is in most case a copy/paste error t

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Tom Haste
*HUGE SNIP* I really don't want to increase the complexity of using > edje file for such a small win. > -- > Cedric BAIL > This is what I wanted to hear. Simple as possible! :D The edj file should be theme data and not translation data. Granted they are similar, but by adding this to more that a

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Michael Jennings
On Friday, 27 August 2010, at 00:08:15 (+0200), Vincent Torri wrote: > that patch is NOT good, hence it should not be in. A mail showing > where the problems are, without modifying the code in svn is far way > better than committing something wrong. The patch is an improvement. (Wrong and redund

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Albin Tonnerre
On Fri, 27 Aug 2010 00:08 +0200, Vincent Torri wrote : > > > On Thu, 26 Aug 2010, Michael Jennings wrote: > > > No, that's the whole point. Every instance that was patched needs to > > be examined and probably fixed. Reverting it doesn't accomplish > > anything either. > > that patch is NOT g

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Vincent Torri
On Thu, 26 Aug 2010, Michael Jennings wrote: > On Thursday, 26 August 2010, at 23:14:23 (+0200), > Vincent Torri wrote: > >> I do not agree at all with that patch. It is hiding potential problems. >> The double condition check is in most case a copy/paste error that needs >> fixing instead of re

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Michael Jennings
On Thursday, 26 August 2010, at 23:14:23 (+0200), Vincent Torri wrote: > I do not agree at all with that patch. It is hiding potential problems. > The double condition check is in most case a copy/paste error that needs > fixing instead of removal. > > Please revert it. No, that's the whole po

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Vincent Torri
On Thu, 26 Aug 2010, Enlightenment SVN wrote: > Log: > Apply double_condition_check.cocci I do not agree at all with that patch. It is hiding potential problems. The double condition check is in most case a copy/paste error that needs fixing instead of removal. Please revert it. Vincent

Re: [E-devel] E SVN: lucas IN trunk: E16/e/src PROTO/eon/src/lib/layout ecore/src/lib/ecore_win32 ecore/src/lib/ecore_wince edje/src/lib evas/src/lib/cache exalt/src/lib

2010-08-26 Thread Lucas De Marchi
Let's go to enlightenment-devel mainling list. On Thu, Aug 26, 2010 at 5:45 PM, Enlightenment SVN wrote: > Log: >  Apply double_condition_check.cocci > >  The offending projects were: > >   E16/e/src/backgrounds.c                 |   10 -- >   PROTO/eon/src/lib/layout/eon_stack.c    |    

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Cedric BAIL
On Thu, Aug 26, 2010 at 5:00 PM, Tom Hacohen wrote: > On Thu, 2010-08-26 at 16:32 +0200, Cedric BAIL wrote: >> Nothing prevent you to ship Edje file with a limited set of >> translations. They will be in separated eet section. So you can >> remove/add/modify them at your convenience. The problem o

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Cedric BAIL
On Thu, Aug 26, 2010 at 5:01 PM, Tom Haste wrote: > I for one wont be supporting any languages other than english in my > themes, as to include more languages would mean me having to write > them myself, or get people to send me patches which would add to more > work for a themer to do... That wor

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Tom Haste
I for one wont be supporting any languages other than english in my themes, as to include more languages would mean me having to write them myself, or get people to send me patches which would add to more work for a themer to do... That work would then get duplicated across themers and every single

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Tom Hacohen
On Thu, 2010-08-26 at 16:32 +0200, Cedric BAIL wrote: > Nothing prevent you to ship Edje file with a limited set of > translations. They will be in separated eet section. So you can > remove/add/modify them at your convenience. The problem of shipping > Edje file with separate translation, cause is

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Cedric BAIL
On Thu, Aug 26, 2010 at 4:06 PM, Tom Hacohen wrote: > I found out today that there's a plan to put translations for strings > inside edj's inside the edj's themselves - this is *BAD*. > > Here are my two main issues with this solution: > 1. There are at least 80 common languages around the world t

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Tom Hacohen
On Thu, 2010-08-26 at 16:20 +0200, Leif Middelschulte wrote: > Hi Tom, > > I'm not an expert on this, so please correct me if I understood stuff wrong. > > I think the reason for this is that with different languages often a > different culture comes along with different user interface > expectat

Re: [E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Leif Middelschulte
Hi Tom, I'm not an expert on this, so please correct me if I understood stuff wrong. I think the reason for this is that with different languages often a different culture comes along with different user interface expectations. This might lead to the point where you'd like to have a complete diff

[E-devel] Edje translations - Why they shouldn't be inside .edj's

2010-08-26 Thread Tom Hacohen
Hey all, I found out today that there's a plan to put translations for strings inside edj's inside the edj's themselves - this is *BAD*. Here are my two main issues with this solution: 1. There are at least 80 common languages around the world this means that each edj will now include 79 useless