Re: [E-devel] E SVN: mike_m trunk/e/src/modules/conf_randr

Yes good to see he's alive :) Daniel Juyung Seo (SeoZ) On Tue, Oct 2, 2012 at 9:38 PM, Christopher Michael wrote: > On 02/10/12 13:14, Mike McCormack wrote: >> On 10/02/2012 09:26 PM, Christopher Michael wrote: >> >>> A little premature wrt adding the UNUSED here because they are soon to >>> be

Re: [E-devel] E SVN: stefan trunk/elementary/src/lib

Good catch but it's not needed. EINA_INLIST_FOREACH_SAFE assign the proper value or NULL to itc anyway. Did you have any problem with that? Daniel Juyung Seo (SeoZ) On Tue, Oct 2, 2012 at 9:53 PM, Enlightenment SVN wrote: > Log: > elementary/genlist: Init itc to NULL before using it. > > Author:

Re: [E-devel] E SVN: stefan trunk/elementary/src/lib

Hello. On 03/10/12 09:32, Daniel Juyung Seo wrote: > Good catch but it's not needed. > EINA_INLIST_FOREACH_SAFE assign the proper value or NULL to itc anyway. > Did you have any problem with that? No actually problem. Just spotted it and thought it might be better to be on the safe side, but tha

[E-devel] efbb build failures

Hi, it seems that efbb has some dependencies and requirements which are not tested in configure. For now I can tell that python 2.6 is not new enough so CentOS 6 build fails with: ... Creating level ../../data/levels/level03.cfg... Creating level ../../data/levels/level00.cfg... Creating level

Re: [E-devel] E SVN: stefan trunk/SCRIPTS/coccinelle

Cool stuff, thanks for updating this. Just one thing I noticed while playing around with it. On 10/03/2012 09:45 AM, Enlightenment SVN wrote: > Modified: trunk/SCRIPTS/coccinelle/spatchall.sh > === > --- trunk/SCRIPTS/coccinelle/spatc

Re: [E-devel] E SVN: stefan trunk/SCRIPTS/coccinelle

Hello. On 03/10/12 10:52, Daniel Willmann wrote: > Cool stuff, thanks for updating this. > Just one thing I noticed while playing around with it. > > On 10/03/2012 09:45 AM, Enlightenment SVN wrote: >> Modified: trunk/SCRIPTS/coccinelle/spatchall.sh >> =

Re: [E-devel] E SVN: stefan trunk/elementary/src/lib

Ok. Just curious :) And yes it is a good practice. Thanks. Daniel Juyung Seo (SeoZ) On Wed, Oct 3, 2012 at 6:28 PM, Stefan Schmidt wrote: > Hello. > > On 03/10/12 09:32, Daniel Juyung Seo wrote: >> Good catch but it's not needed. >> EINA_INLIST_FOREACH_SAFE assign the proper value or NULL to itc

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

Bad commit. At least if EVAS_MAGIC_SOMETHING variable is set we should bitch so we can debug these errors On Wednesday, October 3, 2012, Enlightenment SVN wrote: > Log: > probably the best commit I'll ever make: evas_object_del() now takes NULL > parameter without bitching > > > Author: di

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

I agree with Gustavo. This is as obviously an error case, and errors should be printed as such. It's not a convenience like making free check for NULL, as deleting objects has more meaning than just freeing memory. I think one of the best improvements I've ever did to Evas was turning magic/nul

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

passing NULL to a free function is not an error case. if it were, then free(NULL) would crash. On Wed, Oct 3, 2012 at 12:59 PM, Tom Hacohen wrote: > I agree with Gustavo. This is as obviously an error case, and errors > should be printed as such. It's not a convenience like making free check > fo

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

I said it's *not* like the free case... On 03/10/12 14:05, Michael Blumenkrantz wrote: > passing NULL to a free function is not an error case. if it were, then > free(NULL) would crash. > > On Wed, Oct 3, 2012 at 12:59 PM, Tom Hacohen wrote: > >> I agree with Gustavo. This is as obviously an error

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

I know what evas_objec_free() does, and it is not like free, even if the object is actually freed, because there's a graphical representation to the object, and it's an object on screen (in most cases). So just having a pointer that may be NULL and deleting it just in case is way less common th

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

No, that's not following my logic. We need to make the common case super awesome, and the less common case awesome, and I think the common case is not deleting NULL objects, but just managing them properly. Therefore lets make the common case (NULL deletion is unwanted) super awesome and the le

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

Hm.. ? In most cases you build a UI, use it, and then delete it at the hand, i.e manage the UI properly. If the state in your application requires for an object to be deleted, it's deleted. Having an object pointer that may point to some random object that may be deleted is not the common case.

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

On Wed, Oct 3, 2012 at 3:01 PM, Tom Hacohen wrote: > Hm.. ? In most cases you build a UI, use it, and then delete it at the > hand, i.e manage the UI properly. If the state in your application requires > for an object to be deleted, it's deleted. Having an object pointer that > may point to some

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

On 03/10/12 16:05, Michael Blumenkrantz wrote: > > > On Wed, Oct 3, 2012 at 3:01 PM, Tom Hacohen > wrote: > > Hm.. ? In most cases you build a UI, use it, and then delete it at > the hand, i.e manage the UI properly. If the state in your > application re

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

On Wed, Oct 3, 2012 at 3:12 PM, Tom Hacohen wrote: > On 03/10/12 16:05, Michael Blumenkrantz wrote: > >> >> >> On Wed, Oct 3, 2012 at 3:01 PM, Tom Hacohen > > wrote: >> >> Hm.. ? In most cases you build a UI, use it, and then delete it at >> the hand, i.e m

Re: [E-devel] E SVN: discomfitor IN trunk/evas: . src/lib/canvas

On 03/10/12 16:15, Michael Blumenkrantz wrote: > how? what errors? if you're deleting a null pointer, it's almost > certainly because you already nulled the input and thus are managing > your objects properly, which is what you're claiming people would be > missing with this behavior. It just mean

[E-devel] [Patch] [Ecore] Allow to send SelectionNotify event if there is no data from XGetWindowProperty.

Dear EFL developers, I have posted this patch some time ago but I didn't receive any feedback on it apart of WebKit related discussion with Gustavo. The issue I want to fix is that elementary clipboard does not return paste callback if selection does not contain any data. Currently when

[E-devel] [PATCH][Eina] Fix minor issues spotted by cppcheck

Hi list Here are three patches for Eina: 01 Removes some unused variables. 02 Fixes bad format strings in *printf() calls. 03 Fixes typo and removes redundant duplicate code. -- Igor Index: src/examples/eina_array_01.c === --

[E-devel] [PATCHES] Allocation bugs in ecore, eio, elmdentica

Hello, please see attached some issues that were highlighted by coccinelle. Sent in individual patches for the different libraries. Vtorrified except for elmdentica where nobody seems to care. All bugs suffer from memory corruption. * ecore_x - The type used for calloc is wrong (and smaller than

Re: [E-devel] E SVN: etrunko trunk/ecore/src/lib/ecore_evas

On 03/10/2012 04:30 PM, Enlightenment SVN wrote: > Log: > Ecore_Evas: Cleanup unused function prototypes > >Signed-off-by: Eduardo Lima (Etrunko) > > > > Author: etrunko > Date: 2012-10-03 09:30:37 -0700 (Wed, 03 Oct 2012) > New Revision: 77374 > Trac: http://trac.enlight

Re: [E-devel] E SVN: etrunko trunk/ecore/src/lib/ecore_evas

On 03/10/2012 05:39 PM, Christopher Michael wrote: > On 03/10/2012 04:30 PM, Enlightenment SVN wrote: >> Log: >> Ecore_Evas: Cleanup unused function prototypes >> >> Signed-off-by: Eduardo Lima (Etrunko) >> >> >> >> Author: etrunko >> Date: 2012-10-03 09:30:37 -0700 (Wed, 03 Oct

Re: [E-devel] [PATCHES] Allocation bugs in ecore, eio, elmdentica

All patches are Reviewed-by: Igor Murzov I have just prepared the very same patch for Eio, but you were faster submitting it :) -- Igor > Hello, > > please see attached some issues that were highlighted by coccinelle. > Sent in individual patches for the different libraries. Vtorrified > exce

Re: [E-devel] E SVN: stefan trunk/PROTO/elocation/src/lib

In your case its unnecessary this line: if (strcmp(bus, GEOCLUE_DBUS_NAME) != 0) Only do that if you use the same callback to multiple bus names. On Wed, Oct 3, 2012 at 12:03 PM, Enlightenment SVN wrote: > Log: > PROTO/elocation: Use edbus infra to keep track of name owner changes > > Author:

Re: [E-devel] efbb build failures

On Wed, Oct 3, 2012 at 6:30 AM, Tomas Cech wrote: > Hi, > > it seems that efbb has some dependencies and requirements which are > not tested in configure. > > For now I can tell that python 2.6 is not new enough so CentOS 6 build > fails with: I've changed the script a bit and now it should works

[E-devel] [PATCH][Elementary] Fix issues discovered by cppcheck

Some more patches here. This time it's five patches for Elementary: 01 Removes unused variable. 02 Fixes bad format strings in *printf() calls. 03 Simplifies code and removes redundant duplicated code. 04 Fixes copy&paste error and possible invalid memory access. 05 Require Ecore >= 1.7.

Re: [E-devel] [PATCH][Eina] Fix minor issues spotted by cppcheck

Hi, On Thu, Oct 4, 2012 at 12:37 AM, Igor Murzov wrote: > Here are three patches for Eina: > > 01 Removes some unused variables. > 02 Fixes bad format strings in *printf() calls. > 03 Fixes typo and removes redundant duplicate code. Thanks in svn. -- Cedric BAIL -

Re: [E-devel] [PATCHES] Allocation bugs in ecore, eio, elmdentica

Hello, On Thu, Oct 4, 2012 at 12:59 AM, Daniel Willmann wrote: > please see attached some issues that were highlighted by coccinelle. > Sent in individual patches for the different libraries. Vtorrified > except for elmdentica where nobody seems to care. > > All bugs suffer from memory corruption

Re: [E-devel] [PATCH][Elementary] Fix issues discovered by cppcheck

Yop, On Thu, Oct 4, 2012 at 8:08 AM, Igor Murzov wrote: > Some more patches here. This time it's five patches for Elementary: > > 01 Removes unused variable. > 02 Fixes bad format strings in *printf() calls. > 03 Simplifies code and removes redundant duplicated code. > 04 Fixes copy&paste

Re: [E-devel] [PATCH][Elementary] Fix issues discovered by cppcheck

Oops I was reviewing this (and interrupted by someone else) Thanks for the patch and review :) Daniel Juyung Seo (SeoZ) On Thu, Oct 4, 2012 at 11:50 AM, Cedric BAIL wrote: > Yop, > > On Thu, Oct 4, 2012 at 8:08 AM, Igor Murzov wrote: >> Some more patches here. This time it's five patches for El

Re: [E-devel] [PATCHES] Allocation bugs in ecore, eio, elmdentica

On 03/10/12 16:59, Daniel Willmann wrote: > Hello, > > please see attached some issues that were highlighted by coccinelle. > Sent in individual patches for the different libraries. Vtorrified > except for elmdentica where nobody seems to care. > > All bugs suffer from memory corruption. > > * ecor

[E-devel] [patch][elementary] conformant - use layout focus next, direction

dear all, hello. um.. there would be a reason to not use focus next and direction stuff.. please let me know why the conform does not use those.. if there is no reason, please keep the patch. thanks. cordially, shinwoo kim. conform.use.focuschain.diff Description: Binary data --