Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Sebastian Dransfeld
On 10/06/2012 11:05 PM, Igor Murzov wrote: >> #3 is definitely correct. > > Then could you simplify this part, so that it doesn't look > like bad copy&paste? I don't think it looks like bad copy and paste. Think of it as mode being a primary action, and detail a subsidiary. Then it is nice to nes

Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Igor Murzov
> #3 is definitely correct. Then could you simplify this part, so that it doesn't look like bad copy&paste? -- Igor > Den 6. okt. 2012 kl. 21:14 skrev Igor Murzov : > > > Hi list. > > > > There are several suspicious code snippets in E, that > > look much like copy&paste errors, but I don't k

Re: [E-devel] E SVN: billiob trunk/terminology/src/bin

2012-10-06 Thread Boris Faure
On 12-10-06 22:46, Michaël Bouchaud wrote: > Please add parenthesis :) done ;) sorry. -- Boris Faure Pointer Arithmetician -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app

Re: [E-devel] E SVN: billiob trunk/terminology/src/bin

2012-10-06 Thread Michaël Bouchaud
Please add parenthesis :) 2012/10/6 Enlightenment SVN > Log: > terminology: fix vim issue > > Author: billiob > Date: 2012-10-06 13:23:20 -0700 (Sat, 06 Oct 2012) > New Revision: 77549 > Trac: http://trac.enlightenment.org/e/changeset/77549 > > Modified: > trunk/terminolo

Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Sebastian Dransfeld
#3 is definitely correct. S. Den 6. okt. 2012 kl. 21:14 skrev Igor Murzov : > Hi list. > > There are several suspicious code snippets in E, that > look much like copy&paste errors, but I don't know how > to properly fix those errors. Maybe someone experienced > could look into these. > > #1: s

[E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Igor Murzov
Hi list. There are several suspicious code snippets in E, that look much like copy&paste errors, but I don't know how to properly fix those errors. Maybe someone experienced could look into these. #1: src/bin/e_backlight.c#n496 if ((e_config->backlight

Re: [E-devel] [ecore] Recursive rm

2012-10-06 Thread rustyBSD
Le 06/10/2012 14:03, Vincent Torri a écrit : >> Hi, >> > I looked at the ecore_file_recursive_rm() function >> > (in ecore/src/lib/ecore_file/), and I wonder why this >> > is so ugly/complicated. >> > >> > We are doing a readlink() and two stat(). Why not simply >> > do a lstat() ? > note that lsta

Re: [E-devel] [ecore] Recursive rm

2012-10-06 Thread Vincent Torri
On Sat, Oct 6, 2012 at 1:21 PM, rustyBSD wrote: > Hi, > I looked at the ecore_file_recursive_rm() function > (in ecore/src/lib/ecore_file/), and I wonder why this > is so ugly/complicated. > > We are doing a readlink() and two stat(). Why not simply > do a lstat() ? note that lstat does not exist

[E-devel] [ecore] Recursive rm

2012-10-06 Thread rustyBSD
Hi, I looked at the ecore_file_recursive_rm() function (in ecore/src/lib/ecore_file/), and I wonder why this is so ugly/complicated. We are doing a readlink() and two stat(). Why not simply do a lstat() ? It takes less memory and it's simplier. Here is a patch. Am I wrong ? (And readlink() is s

Re: [E-devel] regarding notification

2012-10-06 Thread Michael Blumenkrantz
On Sat, 06 Oct 2012 12:05:52 +0200 Massimo Maiurana wrote: > can somebody explain what the option "Ignore replace ID" of the notification > module actually does? > notifications contain an identifier which allows the display system to replace notifications with the same ID. for example, if an a

[E-devel] regarding notification

2012-10-06 Thread Massimo Maiurana
can somebody explain what the option "Ignore replace ID" of the notification module actually does? -- Massimo Maiurana GPG keyID #7044D601 La fede e' credere in cio' che sai non essere vero [Mark Twain] signature.asc Description: OpenPGP digital signatur

Re: [E-devel] icons in menu and everything

2012-10-06 Thread Sebastian Dransfeld
On 10/05/2012 10:30 PM, Tomas Cech wrote: > Hi again, > > I have found that most of the problem was wrong installation. Now it > passed most of test and two remaining failures seems to be more > relevant. The tests hasn't been updated in a while, so it might be changes in efreet which triggers th