Re: [E-devel] Patch Review: Improving Community Interaction

2018-05-24 Thread Hermet Park
I agree on it. Anyone can see and try to review patches but I believe the point must be "lack of willing of review". :) EFL should appoint the REAL maintainer and REAL reviewers per project/module in order to make people have a responsibility for review. We could list up maintainers and reviewers

Re: [E-devel] Build systems

2018-05-24 Thread Felipe Magno de Almeida
On Thu, May 24, 2018 at 6:54 PM, William L. Thomson Jr. wrote: > To toss another out there, also Gradle, seems it maybe more robust in > ways than Bazel or Buck. > https://docs.gradle.org/current/userguide/native_software.html > > It is also 100% Java. All you need is a JDK, or maybe just a JRE if

Re: [E-devel] Build systems

2018-05-24 Thread William L. Thomson Jr.
On Thu, 24 May 2018 22:00:31 +0200 Marcel Hollerbach wrote: > Hello, > > i took a look at bazel quite a while ago, buck was new to me. > A few more arguements that are better in meson: Both are still new to me. No experience with either. Buck supports more languages, but the syntax and aspects

Re: [E-devel] Build systems

2018-05-24 Thread William L. Thomson Jr.
To toss another out there, also Gradle, seems it maybe more robust in ways than Bazel or Buck. https://docs.gradle.org/current/userguide/native_software.html It is also 100% Java. All you need is a JDK, or maybe just a JRE if not building a Java project. Still a JDK is less at times than installin

Re: [E-devel] Build systems

2018-05-24 Thread Marcel Hollerbach
Hello, i took a look at bazel quite a while ago, buck was new to me. A few more arguements that are better in meson: i) both lack the support of native dependencies, there is no direct easy way for using pkg-config to generate library objects and get the correct include directories etc. In mes

[E-devel] Build systems

2018-05-24 Thread William L. Thomson Jr.
This came up on Netbeans Development list. I find it interesting as everyone is on the Meson bandwagon. Except Google and Facebook. If you look at the number of forks, stars, etc. It seems they have a bit more interest. Interestingly both are in Java and not Python. If you see the speed of say Grad

Re: [E-devel] Heads up on upcoming 1.21 stabilization phase

2018-05-24 Thread William L. Thomson Jr.
On Thu, 24 May 2018 12:29:21 -0400 Mike Blumenkrantz wrote: > > To restate and completely define every term used: my proposal is that > every patch submitted during a release cycle must be reviewed prior > to the release deployment. The intention maybe more clear to say View and Comment or Ackno

Re: [E-devel] Heads up on upcoming 1.21 stabilization phase

2018-05-24 Thread Mike Blumenkrantz
Thanks for your reply, I think you've raised some good points. I will attempt to address them below, in full. I suppose I could have been more clear in defining what "review" means, but this confusion seems to (in my mind) largely be the result of not having a patch review culture or mindset withi

Re: [E-devel] Status of eflete and enventor

2018-05-24 Thread William L. Thomson Jr.
On Thu, 24 May 2018 19:37:46 +0900 Hermet Park wrote: > At least, I have a plan to fix Enventor to be buildable and repackage > it working on the next EFL version. Great, thank you! -- William L. Thomson Jr. pgpaMXEPSFH0t.pgp Description: OpenPGP digital signature ---

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: path get actually allocate memory and can't be pure.

2018-05-24 Thread Gustavo Sverzut Barbieri
ohh... then my mind tricked me, and I didn't notice the lack of "const" in there. I was remembering it as "const char *" return, that would be stored in a global until it finishes... if you need to free, then sure, PURE is wrong :-) On Thu, May 24, 2018 at 11:21 AM, Marcel Hollerbach wrote: > H

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: path get actually allocate memory and can't be pure.

2018-05-24 Thread Marcel Hollerbach
Hello, this is not correct. It returns a different pointer on each call. The content behind the pointer is the same, correct. The pointer is NOT. Your example is missing one thing, you are not using the value, think of a case where you give the returned value to a function that calls free. The

Re: [E-devel] Heads up on upcoming 1.21 stabilization phase

2018-05-24 Thread Stefan Schmidt
Hello. On 24.05.2018 15:37, Mike Blumenkrantz wrote: > I think this argument of not having enough time to review before a release > is a bit questionable. If we lack the resources to perform at least a > cursory review of incoming patches before a release, how can we possibly > have the capability

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: path get actually allocate memory and can't be pure.

2018-05-24 Thread Gustavo Sverzut Barbieri
I disagree with that signature. it does a malloc to populate a cache, which is later used... then *all calls returns the same, given the same parameters* (pure). the cache is only cleared on eina shutdown, which is unlikely to affect use cases (would break "while (1) { eina_init(); eina_module_sy

Re: [E-devel] Heads up on upcoming 1.21 stabilization phase

2018-05-24 Thread Mike Blumenkrantz
I think this argument of not having enough time to review before a release is a bit questionable. If we lack the resources to perform at least a cursory review of incoming patches before a release, how can we possibly have the capability as a project to even execute a quality release? Is the claim

Re: [E-devel] Patch Review: Improving Community Interaction

2018-05-24 Thread Mike Blumenkrantz
By majority vote, those with commit access are now added to cc for all efl patch submissions. On Tue, May 1, 2018 at 3:31 PM Mike Blumenkrantz < michael.blumenkra...@gmail.com> wrote: > Something which has been brought up time and again is that the process for > submitting and getting a patch rev

Re: [E-devel] Status of eflete and enventor

2018-05-24 Thread Hermet Park
At least, I have a plan to fix Enventor to be buildable and repackage it working on the next EFL version. On Fri, May 18, 2018 at 5:37 AM, William L. Thomson Jr. < wlt...@obsidian-studios.com> wrote: > Checking on the status of eflete and enventor, presently cannot build > either against 1.20.7.