I think this argument of not having enough time to review before a release is a bit questionable. If we lack the resources to perform at least a cursory review of incoming patches before a release, how can we possibly have the capability as a project to even execute a quality release? Is the claim then that we are instead using these resources to review patches which have reached the repo without review?
Getting into the habit of, at minimum, glancing at patches and determining if it's something worthwhile for the current release cycle (e.g., a bug fix) seems like it would be beneficial overall. On Wed, May 23, 2018 at 2:07 AM Stefan Schmidt <[email protected]> wrote: > Hello. > > On 17.05.2018 18:47, Mike Blumenkrantz wrote: > > I think we should make it a policy going forward that the stabilization > > period cannot begin until all pending patch submissions have been > reviewed. > > There are still a ton of patches out there which haven't been looked at, > > and "I didn't feel like reviewing patches" should never be a reason why > > patches don't make it into a release. > > > > This doesn't mean that all patches need to be merged, but patches > submitted > > during a release cycle should at least be reviewed during that cycle. > > My take on this is that we should aim for encouraging people to look at > patches and do reviews. This encouragement should not come by a policy > forcing them to do it. > > And if we want to go back to time based releases this would not fly. > Holding up the release for patches to be reviewed is basically the same > as holding it up for a feature to be merged. Both require developer time > that might or might not be available at the time for the release. > > regards > Stefan Schmidt > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
