Hi,
I was cleaning up my computer yesterday when I stumbled upon
some diffs. It seems that I forgot to send them, so I rebased
them and here they are.
1. Just an uninitialized variable
2. Since sysctl() returns -1 when failing, we should check
for 0
Ok/Comments?
diff --git
Hi,
EFL now requires valgrind. Valgrind doesn't exist on OpenBSD, and
is experimental on FreeBSD and NetBSD. Is that really necessary?
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8
Hi,
here is a small patch for the shot module.
1) 'fsize' should be long, and doesn't need to be global (as 'fdata' ?)
2) At l.475, we leak 'fd'
3) Error dialogs' titles should be simplified
4) Also added some strerror(errno) in error messages...
Tested on OpenBSD.
Ok/Comments ?
Index:
Hum, I've made a mistake in e_fm_op.c with lseek(), I inverted
the two last arguments. However it's not harmful, as SEEK_SET=0.
Index: e_fm_op.c
===
--- e_fm_op.c (révision 81690)
+++ e_fm_op.c (copie de travail)
@@ -1752,7 +1752,7
Hi,
same patch as before: removed useless nullchecks and
switched some free()'s to E_FREE().
Index: src/modules/conf_randr/e_smart_monitor.c
===
--- src/modules/conf_randr/e_smart_monitor.c (révision 81560)
+++
Le 21/12/2012 22:32, Michael Blumenkrantz a écrit :
On Fri, 21 Dec 2012 22:17:32 +0100
Maxime Villard rusty...@gmx.fr wrote:
Hi,
same patch as before: removed useless nullchecks and
switched some free()'s to E_FREE().
Hi,
I've committed your patch, but you really need to compile test
Hi,
here is a patch.
1. free() already null-checks the passed argument, so it is not
necessary to do 'if(x) free(x)'.
2. Moved some '{free(x); x = NULL}' to E_FREE.
3. In e_start_main.c, 'buf' is allocated with the size of the
two arguments + '=', so we don't need to check for lenght;
Le 18/12/2012 00:15, Vincent Torri a écrit :
On Mon, Dec 17, 2012 at 5:14 PM, Maxime Villard rusty...@gmx.fr wrote:
Le 17/12/2012 01:10, Carsten Haitzler (The Rasterman) a écrit :
the reasons are many but here are some:
1. devs are almost all on linux... so guess what? they support the os
Le 18/12/2012 17:21, Vincent Torri a écrit :
As far as I'm concerned, I already sent a lot of patches to support
BSD's.
I'm busy the week, but free the week-end. The w-e, I send patches and
I have to wait, wait, wait, ... and to resend a mail two weeks later
only to know if someone
Le 18/12/2012 17:51, Vincent Torri a écrit :
Yes I know, and the last time I tried to compile branches/ I got a
mega-bug with ecore. No error message, just garbage characters.
during compilation ?
Vincent
yes, i'll retry soon
Le 17/12/2012 01:10, Carsten Haitzler (The Rasterman) a écrit :
the reasons are many but here are some:
1. devs are almost all on linux... so guess what? they support the os they
work
on.
2. frankly linux has much more momentum than the bsd's (excluding osx as you
say) and that lead as i
Hi,
== efl/src/modules/ecore_evas/engines/buffer/ecore_evas_extn.c ==
OpenBSD doesn't have shm_open(), just shmget(). As ecore_evas_extn.c
doesn't seem to be used, I commented all the file and it works, but
it would be better if someone adds #elif HAVE_SHMGET or replaces
shm_open() by shmget(),
noticed, but I sent a patch before your answer.
Message original
Sujet: Re: [E-devel] [e] [patch] Leak (was FreeBSD patch)
Date : Sat, 15 Dec 2012 08:43:03 +0100
De : Maxime Villard rusty...@gmx.fr
Répondre à : Enlightenment developer list
enlightenment-devel@lists.sourceforge.net
A little patch to fix a possible warning - and overflow.
'buf' is PATH_MAX, but PATH_MAX is not necessary 1024. If
PATH_MAX 1024 - overflow.
Also, fgets() fills the buffer and nullterminate it, so we
don't need to buff[0] = '\0'.
--- e_acpi.c 2012-12-15 12:54:15.107749981 +0100
+++ e_acpi.c
== e_init_main.c l.331 ==
fprintf(stderr, screen region fill\n, w, h);
Hum, what is that supposed to write ?
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices
Just a patch to avoid using strdupa(), which doesn't exist
on BSD's.
By the way, 'buf' - and 'trash_dir' now - should be PATH_MAX
instead, no ?
--- e_fm/e_fm_ipc.c Sat Dec 15 22:24:51 2012
+++ e_fm/e_fm_ipc.c Sat Dec 15 22:21:50 2012
@@ -2,7 +2,6 @@
#include config.h
#endif
-
#ifndef
Le 14/12/2012 20:49, dieter roelants a écrit :
hi,
I get:
e_fm_ipc.c: In function '_e_fm_ipc_cb_fop_trash_idler':
e_fm_ipc.c:1270:4: warning: implicit declaration of function 'strdupa'
followed by a link error later on, when building e 0.17.0-lucky on
NetBSD. That is because strdupa is
Le 14/12/2012 06:29, Carsten Haitzler (The Rasterman) a écrit :
i put in just fixed for the FILE * leak here on error -
the rest i kept.
Why ?
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Last commit in e_fm_op.c from raster:
wtf? thats like double-free land.. why strdupa at all? nuts! remove
strdupa's and make code consistent with neighbouring code.
WTF? WTF we need to free lnk_path because _E_FM_OP_ERROR_SEND_WORK()
exits the function. The code with strdupa was good.
Le 15/12/2012 08:19, Maxime Villard a écrit :
Le 14/12/2012 06:29, Carsten Haitzler (The Rasterman) a écrit :
i put in just fixed for the FILE * leak here on error -
the rest i kept.
Why ?
I would also move some {free(x); x = null} to E_FREE.
Patch joined.
--- tempget.c 2012-12-15 08:37
Hum, I sent it two weeks ago
I. Removed useless 'buf[sizeof(buf) - 1] = 0;', fgets()
already does that
II. Ensure file descriptors are closed before 'goto error'
III.We don't need to nullcheck before freeing a buf, as it's
already done by free()
--- tempget.c 2012-12-01
21 matches
Mail list logo
