Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-15 Thread The Rasterman
On Sat, 6 Oct 2012 23:14:43 +0400 Igor Murzov said: > Hi list. > > There are several suspicious code snippets in E, that > look much like copy&paste errors, but I don't know how > to properly fix those errors. Maybe someone experienced > could look into these. > > #1: src/bin/e_backlight.c#n496

Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Sebastian Dransfeld
On 10/06/2012 11:05 PM, Igor Murzov wrote: >> #3 is definitely correct. > > Then could you simplify this part, so that it doesn't look > like bad copy&paste? I don't think it looks like bad copy and paste. Think of it as mode being a primary action, and detail a subsidiary. Then it is nice to nes

Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Igor Murzov
> #3 is definitely correct. Then could you simplify this part, so that it doesn't look like bad copy&paste? -- Igor > Den 6. okt. 2012 kl. 21:14 skrev Igor Murzov : > > > Hi list. > > > > There are several suspicious code snippets in E, that > > look much like copy&paste errors, but I don't k

Re: [E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Sebastian Dransfeld
#3 is definitely correct. S. Den 6. okt. 2012 kl. 21:14 skrev Igor Murzov : > Hi list. > > There are several suspicious code snippets in E, that > look much like copy&paste errors, but I don't know how > to properly fix those errors. Maybe someone experienced > could look into these. > > #1: s

[E-devel] [NO PATCH][Enlightement] Issues discovered by cppcheck

2012-10-06 Thread Igor Murzov
Hi list. There are several suspicious code snippets in E, that look much like copy&paste errors, but I don't know how to properly fix those errors. Maybe someone experienced could look into these. #1: src/bin/e_backlight.c#n496 if ((e_config->backlight