[E-devel] [PATCH] Shot module

2012-12-25 Thread Maxime Villard
Hi, here is a small patch for the shot module. 1) 'fsize' should be long, and doesn't need to be global (as 'fdata' ?) 2) At l.475, we leak 'fd' 3) Error dialogs' titles should be simplified 4) Also added some strerror(errno) in error messages... Tested on OpenBSD. Ok/Comments ? Index:

Re: [E-devel] [PATCH] Shot module

2012-12-25 Thread Igor Murzov
On Tue, 25 Dec 2012 17:27:11 +0100 Maxime Villard rusty...@gmx.fr wrote: Hi, here is a small patch for the shot module. 1) 'fsize' should be long, and doesn't need to be global (as 'fdata' ?) Yeah. All those static variables look weird. 2) At l.475, we leak 'fd' 3) Error dialogs'