Previous seconds value for a day was 84600 (23:30) instead of 86400 (24:00).
The commit fixes it using constants.
---
src/bin/test_calendar.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/src/bin/test_calendar.c b/src/bin/test_cal
Hello.
The change summary is a bit weak. Its not really a typo fix but a fix
for the wrong numbers of seconds a day. I changed it to:
test_calendar: Fix number of seconds per day.
Hope you don't mind.
On 09/30/2013 11:39 AM, Mariusz Bialonczyk wrote:
> Previous seconds value for a day was 84600
Thanks Mariusz Bialonczyk for your patch.
As Stefan mentioned it's not a typo fix. Thanks Stefan for the fix.
Btw Mariusz, can you raise a patch with phabricator + arcanist next time?
https://phab.enlightenment.org/w/arcanist/
It's easy and quick to submit a patch than writing an email.
You can ge
On 09/30/2013 02:10 PM, Daniel Juyung Seo wrote:
> Thanks Mariusz Bialonczyk for your patch.
> As Stefan mentioned it's not a typo fix. Thanks Stefan for the fix.
>
> Btw Mariusz, can you raise a patch with phabricator + arcanist next time?
> https://phab.enlightenment.org/w/arcanist/
It was me w
I agree. Arcanist is awful, and I definitely prefer to just get patches by
mail since it saves me a considerable amount of time.
On Mon, Sep 30, 2013 at 2:19 PM, Stefan Schmidt wrote:
> On 09/30/2013 02:10 PM, Daniel Juyung Seo wrote:
> > Thanks Mariusz Bialonczyk for your patch.
> > As Stefan m
Well this might be a personal preference.
I am used to accept new things very well and easily.
But I also agree with the fact that there is a high starting curve such as
installing this and that.
However once people do the initial setup, they will find it's super great
and easy.
Just see how peop
On 09/30/2013 02:30 PM, Stefan Schmidt wrote:
> Hello.
>
> The change summary is a bit weak. Its not really a typo fix but a fix
> for the wrong numbers of seconds a day. I changed it to:
>
> test_calendar: Fix number of seconds per day.
>
> Hope you don't mind.
of course :)
thanks!
regards,
-
On 09/30/2013 04:33 PM, Daniel Juyung Seo wrote:
> I just like arcanist :)
> You can keep using ml. I don't care. I just wanted him to know what efl's
> contribution process is.
got it!
maybe i'll give it a try next time, thanks :)
regards,
--
Mariusz Białończyk | xmpp/e-mail: ma...@skyboo.net
h
