Hi,
On Wed, Jan 30, 2013 at 04:17:51AM +, Bora Hwang wrote:
> Dear all,
>
> In elc_ctxpopup.c, there's something wrong when calculating the position of
> arrow.
> According to the previous code, arrow cannot be shown in the right position
> when it should not be displayed in the middle of th
mail.com>
Date : 2013-01-30 23:47 (GMT+09:00)
Title : Re: [E-devel] [Patch] fixed Ctxpopup _arrow_update
Hi Bora,
Hyoyoung made a good comment.
Please split the formatting fix and other patches.
Actually this is not a formatting fix. It was wrong.
Please refer the following l
sts.sourceforge.net>;
Cc:
Sent: 2013-01-31 (목) 11:43:38
Subject: Re: [E-devel] [Patch] fixed Ctxpopup _arrow_update
Oh, I'm terribly sorry :(
I thought I did it right, so didn't check the patch file.
Now, this is the correct revised version.
Thank you :-)
--- Origina
Oh, I'm terribly sorry :(
I thought I did it right, so didn't check the patch file.
Now, this is the correct revised version.
Thank you :-)
--- Original Message ---
Sender : Daniel Juyung Seo
Date : 2013-01-30 23:47 (GMT+09:00)
Title : Re: [E-devel] [Patch] fixed Ctxpopup _ar
Hi Bora,
Hyoyoung made a good comment.
Please split the formatting fix and other patches.
Actually this is not a formatting fix. It was wrong.
Please refer the following links:
http://trac.enlightenment.org/e/wiki/PatchReview
http://trac.enlightenment.org/e/wiki/ECoding
Can you resend your patch?
Hello, your patch is nice to apply. but indent isn't
why you change indent heavily? i think it's better to customize your editor.
On Wed, Jan 30, 2013 at 1:17 PM, Bora Hwang wrote:
> Dear all,
>
> In elc_ctxpopup.c, there's something wrong when calculating the position
> of arrow.
> According t
Dear all,
In elc_ctxpopup.c, there's something wrong when calculating the position of
arrow.
According to the previous code, arrow cannot be shown in the right position
when it should not be displayed in the middle of the ctxpopup.
After the value and condition of the calculation are changed,
u
