Message ---
Sender : Daniel Juyung Seoseojuyu...@gmail.com
Date : May 27, 2012 05:40 (GMT+09:00)
Title : Re: [E-devel] [Patch] [elm_entry] New APIs for user style
great as your first patch! and code looks good to me too. but i have two
comments.
1. add const to the parameter
as Daniel's comment.
Please review it.
Thanks Regards,
Thiep Ha
--- Original Message ---
Sender : Daniel Juyung Seoseojuyu...@gmail.com
Date : May 27, 2012 05:40 (GMT+09:00)
Title : Re: [E-devel] [Patch] [elm_entry] New APIs for user style
great as your first patch! and code looks good
great as your first patch! and code looks good to me too. but i have two
comments.
1. add const to the parameter of elm_entry_text_style_user_peek.
2. add example for pop and keep to test_entry_style_user.
and here is a tip for thiep.
http://trac.enlightenment.org/e/wiki/PatchReview
thanks.
On
On Thu, 24 May 2012 09:12:45 + (GMT) thiep ha thiep...@samsung.com said:
looks good with 1 exception. missing as part of the patch a patch to the
Changelog file and adding yourself to AUTHORS. can you add those into your
patch and re-send?
Hello,
As we known that, the user style is a
Hello,
As we known that, the user style is a convenience way which helps users to
work with style without the need of new edc file. It means that users can set
their own style (e.g. font, font_size, color) without making new edc file.
Currently, in Elementary Entry, there is no APIs supporting
